)]}'
{"tempest/api/image/v1/test_images.py":[{"author":{"_account_id":7148,"name":"Zhu Zhu","email":"bjzzu.zz@gmail.com","username":"zhuzhubj"},"change_message_id":"cae37f4a08c55c8680470c8271995b6e23179988","unresolved":false,"context_lines":[{"line_number":256,"context_line":""},{"line_number":257,"context_line":"    @attr(type\u003d\u0027gate\u0027)"},{"line_number":258,"context_line":"    def test_delete_image(self):"},{"line_number":259,"context_line":"        resp, image \u003d self.client.create_image(\u0027test\u0027, \u0027bare\u0027, \u0027raw\u0027)"},{"line_number":260,"context_line":"        resp1, body \u003d self.client.delete_image(image[\u0027id\u0027])"},{"line_number":261,"context_line":"        self.assertEqual(200, resp1.status)"},{"line_number":262,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAS3%2F%2Fl%2Bg%3D","line":259,"updated":"2013-09-24 07:59:00.000000000","message":"Add assert for the image creation success?","commit_id":"1c794e0e6828508cc17196c624f97400c1332d36"},{"author":{"_account_id":6981,"name":"Yang Yu","email":"yangyu@vmware.com","username":"yuyangbj"},"change_message_id":"8a116e53146d92f473cc664fba82b80e030cf250","unresolved":false,"context_lines":[{"line_number":256,"context_line":""},{"line_number":257,"context_line":"    @attr(type\u003d\u0027gate\u0027)"},{"line_number":258,"context_line":"    def test_delete_image(self):"},{"line_number":259,"context_line":"        resp, image \u003d self.client.create_image(\u0027test\u0027, \u0027bare\u0027, \u0027raw\u0027)"},{"line_number":260,"context_line":"        resp1, body \u003d self.client.delete_image(image[\u0027id\u0027])"},{"line_number":261,"context_line":"        self.assertEqual(200, resp1.status)"},{"line_number":262,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAS3%2F%2FeMc%3D","line":259,"in_reply_to":"AAAAS3%2F%2Fl%2Bg%3D","updated":"2013-09-26 06:58:45.000000000","message":"Actually, I do not care the creation is success or not. I just need to created a deleted image.","commit_id":"1c794e0e6828508cc17196c624f97400c1332d36"},{"author":{"_account_id":7148,"name":"Zhu Zhu","email":"bjzzu.zz@gmail.com","username":"zhuzhubj"},"change_message_id":"cae37f4a08c55c8680470c8271995b6e23179988","unresolved":false,"context_lines":[{"line_number":257,"context_line":"    @attr(type\u003d\u0027gate\u0027)"},{"line_number":258,"context_line":"    def test_delete_image(self):"},{"line_number":259,"context_line":"        resp, image \u003d self.client.create_image(\u0027test\u0027, \u0027bare\u0027, \u0027raw\u0027)"},{"line_number":260,"context_line":"        resp1, body \u003d self.client.delete_image(image[\u0027id\u0027])"},{"line_number":261,"context_line":"        self.assertEqual(200, resp1.status)"},{"line_number":262,"context_line":""},{"line_number":263,"context_line":"    @attr(type\u003d\u0027gate\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAS3%2F%2Fl%2Bc%3D","line":260,"updated":"2013-09-24 07:59:00.000000000","message":"you can still use resp. resp1 is not descriptive","commit_id":"1c794e0e6828508cc17196c624f97400c1332d36"},{"author":{"_account_id":7139,"name":"Zhi Kun Liu","username":"zhikunliu","inactive":true},"change_message_id":"2fed8cb947607c4a7db6aefb3f199ff305c195ca","unresolved":false,"context_lines":[{"line_number":258,"context_line":"    def test_delete_image(self):"},{"line_number":259,"context_line":"        resp, image \u003d self.client.create_image(\u0027test\u0027, \u0027bare\u0027, \u0027raw\u0027)"},{"line_number":260,"context_line":"        resp1, body \u003d self.client.delete_image(image[\u0027id\u0027])"},{"line_number":261,"context_line":"        self.assertEqual(200, resp1.status)"},{"line_number":262,"context_line":""},{"line_number":263,"context_line":"    @attr(type\u003d\u0027gate\u0027)"},{"line_number":264,"context_line":"    def test_delete_non_existing_image(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAS3%2F%2Flno%3D","line":261,"updated":"2013-09-24 09:42:52.000000000","message":"check return code is not enough, should also verify the image was deleted","commit_id":"1c794e0e6828508cc17196c624f97400c1332d36"},{"author":{"_account_id":7148,"name":"Zhu Zhu","email":"bjzzu.zz@gmail.com","username":"zhuzhubj"},"change_message_id":"cae37f4a08c55c8680470c8271995b6e23179988","unresolved":false,"context_lines":[{"line_number":263,"context_line":"    @attr(type\u003d\u0027gate\u0027)"},{"line_number":264,"context_line":"    def test_delete_non_existing_image(self):"},{"line_number":265,"context_line":"        image_id \u003d 111"},{"line_number":266,"context_line":"        resp, body \u003d self.client.delete_image(image_id)"},{"line_number":267,"context_line":"        self.assertEqual(404, resp.status)"},{"line_number":268,"context_line":""},{"line_number":269,"context_line":"    @attr(type\u003d\u0027gate\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAS3%2F%2Fl98%3D","line":266,"updated":"2013-09-24 07:59:00.000000000","message":"Use assertRaises instead","commit_id":"1c794e0e6828508cc17196c624f97400c1332d36"},{"author":{"_account_id":7148,"name":"Zhu Zhu","email":"bjzzu.zz@gmail.com","username":"zhuzhubj"},"change_message_id":"cae37f4a08c55c8680470c8271995b6e23179988","unresolved":false,"context_lines":[{"line_number":268,"context_line":""},{"line_number":269,"context_line":"    @attr(type\u003d\u0027gate\u0027)"},{"line_number":270,"context_line":"    def test_delete_protected_image(self):"},{"line_number":271,"context_line":"        location\u003d\u0027http://example.com/someimage.iso\u0027"},{"line_number":272,"context_line":"        resp, image \u003d self.client.create_image(name\u003d\u0027test\u0027,"},{"line_number":273,"context_line":"                                               container_format\u003d\u0027bare\u0027,"},{"line_number":274,"context_line":"                                               disk_format\u003d\u0027raw\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAS3%2F%2Fl%2BA%3D","line":271,"updated":"2013-09-24 07:59:00.000000000","message":"is location required here? In the above there is only three arguments?","commit_id":"1c794e0e6828508cc17196c624f97400c1332d36"},{"author":{"_account_id":6981,"name":"Yang Yu","email":"yangyu@vmware.com","username":"yuyangbj"},"change_message_id":"8a116e53146d92f473cc664fba82b80e030cf250","unresolved":false,"context_lines":[{"line_number":268,"context_line":""},{"line_number":269,"context_line":"    @attr(type\u003d\u0027gate\u0027)"},{"line_number":270,"context_line":"    def test_delete_protected_image(self):"},{"line_number":271,"context_line":"        location\u003d\u0027http://example.com/someimage.iso\u0027"},{"line_number":272,"context_line":"        resp, image \u003d self.client.create_image(name\u003d\u0027test\u0027,"},{"line_number":273,"context_line":"                                               container_format\u003d\u0027bare\u0027,"},{"line_number":274,"context_line":"                                               disk_format\u003d\u0027raw\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAS3%2F%2FeHU%3D","line":271,"in_reply_to":"AAAAS3%2F%2Fl%2BA%3D","updated":"2013-09-26 06:58:45.000000000","message":"Yes, I need location to create an active image.","commit_id":"1c794e0e6828508cc17196c624f97400c1332d36"},{"author":{"_account_id":7148,"name":"Zhu Zhu","email":"bjzzu.zz@gmail.com","username":"zhuzhubj"},"change_message_id":"cae37f4a08c55c8680470c8271995b6e23179988","unresolved":false,"context_lines":[{"line_number":274,"context_line":"                                               disk_format\u003d\u0027raw\u0027,"},{"line_number":275,"context_line":"                                               is_public\u003dTrue,"},{"line_number":276,"context_line":"                                               location\u003dlocation)"},{"line_number":277,"context_line":"        self.assertEqual(image[\u0027status\u0027], \u0027active\u0027)"},{"line_number":278,"context_line":""},{"line_number":279,"context_line":"        image_id \u003d image.get(\u0027id\u0027)"},{"line_number":280,"context_line":"        resp1, image1 \u003d self.client.update_image(image_id,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAS3%2F%2Fl%2BM%3D","line":277,"updated":"2013-09-24 07:59:00.000000000","message":"Use UpperCase \u0027ACTIVE\u0027 instead.","commit_id":"1c794e0e6828508cc17196c624f97400c1332d36"},{"author":{"_account_id":6981,"name":"Yang Yu","email":"yangyu@vmware.com","username":"yuyangbj"},"change_message_id":"8a116e53146d92f473cc664fba82b80e030cf250","unresolved":false,"context_lines":[{"line_number":274,"context_line":"                                               disk_format\u003d\u0027raw\u0027,"},{"line_number":275,"context_line":"                                               is_public\u003dTrue,"},{"line_number":276,"context_line":"                                               location\u003dlocation)"},{"line_number":277,"context_line":"        self.assertEqual(image[\u0027status\u0027], \u0027active\u0027)"},{"line_number":278,"context_line":""},{"line_number":279,"context_line":"        image_id \u003d image.get(\u0027id\u0027)"},{"line_number":280,"context_line":"        resp1, image1 \u003d self.client.update_image(image_id,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAS3%2F%2FeHE%3D","line":277,"in_reply_to":"AAAAS3%2F%2Fl%2BM%3D","updated":"2013-09-26 06:58:45.000000000","message":"no, in glance all image status is lowercase.","commit_id":"1c794e0e6828508cc17196c624f97400c1332d36"},{"author":{"_account_id":7148,"name":"Zhu Zhu","email":"bjzzu.zz@gmail.com","username":"zhuzhubj"},"change_message_id":"cae37f4a08c55c8680470c8271995b6e23179988","unresolved":false,"context_lines":[{"line_number":279,"context_line":"        image_id \u003d image.get(\u0027id\u0027)"},{"line_number":280,"context_line":"        resp1, image1 \u003d self.client.update_image(image_id,"},{"line_number":281,"context_line":"                                                 protected\u003dTrue)"},{"line_number":282,"context_line":"        self.assertTrue(image1.get(\u0027protected\u0027))"},{"line_number":283,"context_line":""},{"line_number":284,"context_line":"        resp2, body \u003d self.client.delete_image(image_id)"},{"line_number":285,"context_line":"        self.assertEqual(403, resp2.status)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAS3%2F%2Fl%2BQ%3D","line":282,"updated":"2013-09-24 07:59:00.000000000","message":"Consider assertIsNotNone","commit_id":"1c794e0e6828508cc17196c624f97400c1332d36"},{"author":{"_account_id":6981,"name":"Yang Yu","email":"yangyu@vmware.com","username":"yuyangbj"},"change_message_id":"8a116e53146d92f473cc664fba82b80e030cf250","unresolved":false,"context_lines":[{"line_number":279,"context_line":"        image_id \u003d image.get(\u0027id\u0027)"},{"line_number":280,"context_line":"        resp1, image1 \u003d self.client.update_image(image_id,"},{"line_number":281,"context_line":"                                                 protected\u003dTrue)"},{"line_number":282,"context_line":"        self.assertTrue(image1.get(\u0027protected\u0027))"},{"line_number":283,"context_line":""},{"line_number":284,"context_line":"        resp2, body \u003d self.client.delete_image(image_id)"},{"line_number":285,"context_line":"        self.assertEqual(403, resp2.status)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAS3%2F%2FeG0%3D","line":282,"in_reply_to":"AAAAS3%2F%2Fl%2BQ%3D","updated":"2013-09-26 06:58:45.000000000","message":"The property protected is boolean.","commit_id":"1c794e0e6828508cc17196c624f97400c1332d36"},{"author":{"_account_id":7148,"name":"Zhu Zhu","email":"bjzzu.zz@gmail.com","username":"zhuzhubj"},"change_message_id":"cae37f4a08c55c8680470c8271995b6e23179988","unresolved":false,"context_lines":[{"line_number":281,"context_line":"                                                 protected\u003dTrue)"},{"line_number":282,"context_line":"        self.assertTrue(image1.get(\u0027protected\u0027))"},{"line_number":283,"context_line":""},{"line_number":284,"context_line":"        resp2, body \u003d self.client.delete_image(image_id)"},{"line_number":285,"context_line":"        self.assertEqual(403, resp2.status)"},{"line_number":286,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAS3%2F%2Fl%2BU%3D","line":284,"updated":"2013-09-24 07:59:00.000000000","message":"If exception throw when do delete, the next line will not be touched. why not just assertRaises exceptions.Unauthorized()?","commit_id":"1c794e0e6828508cc17196c624f97400c1332d36"},{"author":{"_account_id":7139,"name":"Zhi Kun Liu","username":"zhikunliu","inactive":true},"change_message_id":"7f9487b7f3790651a8dd20ceed33ddb70814cc99","unresolved":false,"context_lines":[{"line_number":276,"context_line":"                                               disk_format\u003d\u0027raw\u0027,"},{"line_number":277,"context_line":"                                               is_public\u003dTrue,"},{"line_number":278,"context_line":"                                               location\u003dlocation)"},{"line_number":279,"context_line":"        self.assertEqual(image[\u0027status\u0027], \u0027active\u0027)"},{"line_number":280,"context_line":""},{"line_number":281,"context_line":"        image_id \u003d image.get(\u0027id\u0027)"},{"line_number":282,"context_line":"        resp1, image1 \u003d self.client.update_image(image_id,"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAS3%2F%2FYz0%3D","line":279,"updated":"2013-09-27 17:06:55.000000000","message":"the image\u0027s status maybe not \u0027active\u0027 right away.  it will raise if image is in the middle status, e.g. \u0027saving\u0027..  using self.wait_for_image_status(id, \u0027active\u0027) is better.","commit_id":"071d29990ad9553728d476be311f9814d350d1f2"},{"author":{"_account_id":7139,"name":"Zhi Kun Liu","username":"zhikunliu","inactive":true},"change_message_id":"7f9487b7f3790651a8dd20ceed33ddb70814cc99","unresolved":false,"context_lines":[{"line_number":281,"context_line":"        image_id \u003d image.get(\u0027id\u0027)"},{"line_number":282,"context_line":"        resp1, image1 \u003d self.client.update_image(image_id,"},{"line_number":283,"context_line":"                                                 protected\u003dTrue)"},{"line_number":284,"context_line":"        self.assertTrue(image1.get(\u0027protected\u0027))"},{"line_number":285,"context_line":"        self.assertRaises(exceptions.Unauthorized,"},{"line_number":286,"context_line":"                          self.client.delete_image, image_id)"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAS3%2F%2FY3o%3D","line":284,"updated":"2013-09-27 17:06:55.000000000","message":"this is difficult to debug. assertTrue has a \u0027msg\u0027 argument. it provides a message when expr is false. it is better to add a description \"image\u0027s protected\" using \u0027msg\u0027 parameter.","commit_id":"071d29990ad9553728d476be311f9814d350d1f2"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"65bce7c6c92cc785b65fdc8b346ec3eb628450e2","unresolved":false,"context_lines":[{"line_number":21,"context_line":"from tempest import exceptions"},{"line_number":22,"context_line":"from tempest.test import attr"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"import uuid"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"class CreateRegisterImagesTest(base.BaseV1ImageTest):"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAS3%2F%2FS7M%3D","line":24,"updated":"2013-09-30 20:39:06.000000000","message":"uuid is part of python stdlib so this goes in the same import block as stringio.","commit_id":"b7fed5c2e2f29bc472907c308ae4b52a4e38c226"},{"author":{"_account_id":6981,"name":"Yang Yu","email":"yangyu@vmware.com","username":"yuyangbj"},"change_message_id":"58f90f61be93b62d6ddd9a425cd57b3cdd855a28","unresolved":false,"context_lines":[{"line_number":21,"context_line":"from tempest import exceptions"},{"line_number":22,"context_line":"from tempest.test import attr"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"import uuid"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"class CreateRegisterImagesTest(base.BaseV1ImageTest):"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAATH%2F%2F2CQ%3D","line":24,"in_reply_to":"AAAAS3%2F%2FS7M%3D","updated":"2013-10-09 04:03:30.000000000","message":"I tested, uuid is not a module in StringIO.","commit_id":"b7fed5c2e2f29bc472907c308ae4b52a4e38c226"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"65bce7c6c92cc785b65fdc8b346ec3eb628450e2","unresolved":false,"context_lines":[{"line_number":261,"context_line":"        resp, image \u003d self.client.create_image(\u0027test\u0027, \u0027bare\u0027, \u0027raw\u0027)"},{"line_number":262,"context_line":"        self.assertEqual(resp.status, 201)"},{"line_number":263,"context_line":"        self.client.delete_image(image[\u0027id\u0027])"},{"line_number":264,"context_line":"        resp, images \u003d self.client.image_list()"},{"line_number":265,"context_line":"        self.assertEqual(resp.status, 200)"},{"line_number":266,"context_line":"        self.assertNotIn(image[\u0027id\u0027], images)"},{"line_number":267,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAS3%2F%2FSYE%3D","line":264,"updated":"2013-09-30 20:39:06.000000000","message":"delete is an async operation so this test has a race condition between delete and list. There is no guarantee that the image will be removed from the list by the time you call list here. Add a wait_for_image_status() call here to ensure the delete has been processed (although in that case this is a bit redundant because wait_for_status just does a bunch of gets until it gets a 404)","commit_id":"b7fed5c2e2f29bc472907c308ae4b52a4e38c226"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"94467cfac8c0a23137ca31055291b7a4910709c0","unresolved":false,"context_lines":[{"line_number":21,"context_line":"from tempest import exceptions"},{"line_number":22,"context_line":"from tempest.test import attr"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"import uuid"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"class CreateRegisterImagesTest(base.BaseV1ImageTest):"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAATH%2F%2FzaY%3D","line":24,"updated":"2013-10-09 15:53:44.000000000","message":"I wasn\u0027t saying that this included in the cStringIO library. I was saying that this is grouped incorrectly. It belongs in the same import group as cStringIO because they are both part of python stdlib. See: http://docs.openstack.org/developer/hacking/#imports\n\nPlease fix this.","commit_id":"76cec8829eb436f4e90cdeeb7232a5bb71b7bc2e"},{"author":{"_account_id":7139,"name":"Zhi Kun Liu","username":"zhikunliu","inactive":true},"change_message_id":"9b464b2acf0c02ab809f5ce0407d9b593f78eb50","unresolved":false,"context_lines":[{"line_number":283,"context_line":"        self.client.wait_for_image_status(image_id, \u0027active\u0027)"},{"line_number":284,"context_line":""},{"line_number":285,"context_line":"        resp, image \u003d self.client.update_image(image_id,"},{"line_number":286,"context_line":"                                               protected\u003dTrue)"},{"line_number":287,"context_line":"        self.assertTrue(image.get(\u0027protected\u0027),"},{"line_number":288,"context_line":"                        \u0027The image is not updated to protected status.\u0027)"},{"line_number":289,"context_line":"        self.assertRaises(exceptions.Unauthorized,"}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAATH%2F%2FodU%3D","line":286,"updated":"2013-10-12 03:02:44.000000000","message":"After testing, this test image is not cleaned up, right? It\u0027s better to use addCleanup to restore the protected to false and delete it.","commit_id":"c170474c86066006e96f139eb2b03d80e940a240"},{"author":{"_account_id":5586,"name":"Ivan-Zhu","email":"zhubo198511@gmail.com","username":"ivan-zhu"},"change_message_id":"fc36654801622c840ee7476b9ba41dd41197ccfc","unresolved":false,"context_lines":[{"line_number":272,"context_line":"                          self.client.delete_image, str(uuid.uuid4()))"},{"line_number":273,"context_line":""},{"line_number":274,"context_line":"    @attr(type\u003d[\u0027negative\u0027, \u0027gate\u0027])"},{"line_number":275,"context_line":"    def test_delete_protected_image(self):"},{"line_number":276,"context_line":"        location \u003d \u0027http://example.com/someimage.iso\u0027"},{"line_number":277,"context_line":"        resp, image \u003d self.client.create_image(name\u003d\u0027test\u0027,"},{"line_number":278,"context_line":"                                               container_format\u003d\u0027bare\u0027,"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAATH%2F%2FoGc%3D","line":275,"updated":"2013-10-12 06:36:21.000000000","message":"if a comment can be added here, will be better.","commit_id":"ac9d299383fb1648593099e5bc16dc0221ad3aea"},{"author":{"_account_id":5586,"name":"Ivan-Zhu","email":"zhubo198511@gmail.com","username":"ivan-zhu"},"change_message_id":"fc36654801622c840ee7476b9ba41dd41197ccfc","unresolved":false,"context_lines":[{"line_number":290,"context_line":"                          self.client.delete_image, image_id)"},{"line_number":291,"context_line":"        # In order to clean up the created image"},{"line_number":292,"context_line":"        resp, image \u003d self.client.update_image(image_id,"},{"line_number":293,"context_line":"                                               protected\u003dFalse)"},{"line_number":294,"context_line":"        self.addCleanup(self.client.delete_image, image_id)"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAATH%2F%2FoF8%3D","line":293,"updated":"2013-10-12 06:36:21.000000000","message":"we should also use addCleanup for restoring the image to \"protected\u003dFalse\".\n\nshould be the following:\n\nself.addCleanup(self.client.delete_image, image_id)\n\nself.addCleanup(self.client.update_image, image_id, protected\u003dFalse)","commit_id":"ac9d299383fb1648593099e5bc16dc0221ad3aea"},{"author":{"_account_id":5586,"name":"Ivan-Zhu","email":"zhubo198511@gmail.com","username":"ivan-zhu"},"change_message_id":"fc36654801622c840ee7476b9ba41dd41197ccfc","unresolved":false,"context_lines":[{"line_number":291,"context_line":"        # In order to clean up the created image"},{"line_number":292,"context_line":"        resp, image \u003d self.client.update_image(image_id,"},{"line_number":293,"context_line":"                                               protected\u003dFalse)"},{"line_number":294,"context_line":"        self.addCleanup(self.client.delete_image, image_id)"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAATH%2F%2FoGU%3D","line":294,"updated":"2013-10-12 06:36:21.000000000","message":"This should be put after create image. in the line:282.","commit_id":"ac9d299383fb1648593099e5bc16dc0221ad3aea"}],"tempest/services/image/v1/json/image_client.py":[{"author":{"_account_id":5586,"name":"Ivan-Zhu","email":"zhubo198511@gmail.com","username":"ivan-zhu"},"change_message_id":"946f17868d6d766fc2058568668b27ce14f7def2","unresolved":false,"context_lines":[{"line_number":173,"context_line":""},{"line_number":174,"context_line":"        data \u003d None"},{"line_number":175,"context_line":"        if \u0027data\u0027 in kwargs:"},{"line_number":176,"context_line":"            data \u003d kwargs[\u0027data\u0027]"},{"line_number":177,"context_line":"            if data is not None:"},{"line_number":178,"context_line":"                return self._update_with_data(image_id, headers, data)"},{"line_number":179,"context_line":""}],"source_content_type":"text/x-python","patch_set":17,"id":"AAAATH%2F%2FOyY%3D","line":176,"updated":"2013-10-20 14:29:58.000000000","message":"data \u003d kwargs.get(\"data\", None)  or data \u003d kwargs.get(\"data\") will be better","commit_id":"9edf2356f8686836f18188ca50b28c3e2d93845a"},{"author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"change_message_id":"f6017e51b4b85b6fc50bee3baea6a4f4c4bd2925","unresolved":false,"context_lines":[{"line_number":163,"context_line":"        if container_format is not None:"},{"line_number":164,"context_line":"            params[\u0027container_format\u0027] \u003d container_format"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"        for option in [\u0027is_public\u0027, \u0027location\u0027, \u0027properties\u0027,"},{"line_number":167,"context_line":"                       \u0027copy_from\u0027, \u0027min_ram\u0027, \u0027size\u0027, \u0027checksum\u0027,"},{"line_number":168,"context_line":"                       \u0027protected\u0027]:"},{"line_number":169,"context_line":"            if option in kwargs:"}],"source_content_type":"text/x-python","patch_set":21,"id":"AAAATn%2F%2FP3M%3D","line":166,"updated":"2013-11-12 09:55:23.000000000","message":"This change seams to be an unrelated change and not mentioned in the commit message.","commit_id":"0b3db872d1d71e359ca97cdbead1a46f46ff1b6c"}]}