)]}'
{"tempest/scenario/manager.py":[{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"249202f9eaf6d0e619b21b7b00261dbb3155879d","unresolved":false,"context_lines":[{"line_number":249,"context_line":"            display_name\u003dname,"},{"line_number":250,"context_line":"            description\u003ddescription,"},{"line_number":251,"context_line":"            metadata\u003dmetadata)[\u0027snapshot\u0027]"},{"line_number":252,"context_line":"        self.addCleanup("},{"line_number":253,"context_line":"            self.snapshots_client.wait_for_resource_deletion, snapshot[\u0027id\u0027])"},{"line_number":254,"context_line":"        self.addCleanup(self.snapshots_client.delete_snapshot, snapshot[\u0027id\u0027])"},{"line_number":255,"context_line":"        waiters.wait_for_volume_resource_status(self.snapshots_client,"},{"line_number":256,"context_line":"                                                snapshot[\u0027id\u0027], \u0027available\u0027)"},{"line_number":257,"context_line":"        return snapshot"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f1d235d_e5bd3602","line":254,"range":{"start_line":252,"start_character":8,"end_line":254,"end_character":78},"updated":"2017-07-07 02:47:35.000000000","message":"I\u0027m wondering whether it\u0027s useful to include test_utils.call_and_ignore_notfound_exc here because most helpers in this class use it.","commit_id":"231bbf3a7404226310367ef7b4396d17243f970c"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"ba70615a279de6c332b0b8a5693d00c8c5b71cd4","unresolved":false,"context_lines":[{"line_number":249,"context_line":"            display_name\u003dname,"},{"line_number":250,"context_line":"            description\u003ddescription,"},{"line_number":251,"context_line":"            metadata\u003dmetadata)[\u0027snapshot\u0027]"},{"line_number":252,"context_line":"        self.addCleanup("},{"line_number":253,"context_line":"            self.snapshots_client.wait_for_resource_deletion, snapshot[\u0027id\u0027])"},{"line_number":254,"context_line":"        self.addCleanup(self.snapshots_client.delete_snapshot, snapshot[\u0027id\u0027])"},{"line_number":255,"context_line":"        waiters.wait_for_volume_resource_status(self.snapshots_client,"},{"line_number":256,"context_line":"                                                snapshot[\u0027id\u0027], \u0027available\u0027)"},{"line_number":257,"context_line":"        return snapshot"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f1d235d_21909795","line":254,"range":{"start_line":252,"start_character":8,"end_line":254,"end_character":78},"in_reply_to":"3f1d235d_e5bd3602","updated":"2017-07-09 05:52:15.000000000","message":"I don\u0027t think it\u0027s useful in this case. \nIt\u0027s useful when the resource is created by the classmethod, however, the cleanup should be in the test case level so in this case we need this helper to ignore 404 error otherwise the resource_cleanup classmethod will try to delete a resource the already deleted.","commit_id":"231bbf3a7404226310367ef7b4396d17243f970c"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"249202f9eaf6d0e619b21b7b00261dbb3155879d","unresolved":false,"context_lines":[{"line_number":253,"context_line":"            self.snapshots_client.wait_for_resource_deletion, snapshot[\u0027id\u0027])"},{"line_number":254,"context_line":"        self.addCleanup(self.snapshots_client.delete_snapshot, snapshot[\u0027id\u0027])"},{"line_number":255,"context_line":"        waiters.wait_for_volume_resource_status(self.snapshots_client,"},{"line_number":256,"context_line":"                                                snapshot[\u0027id\u0027], \u0027available\u0027)"},{"line_number":257,"context_line":"        return snapshot"},{"line_number":258,"context_line":""},{"line_number":259,"context_line":"    def create_volume_type(self, client\u003dNone, name\u003dNone, backend_name\u003dNone):"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f1d235d_05715276","line":256,"updated":"2017-07-07 02:47:35.000000000","message":"You removed ``self.assertEqual(name, snapshot[\u0027name\u0027])`` which was included in the other 2 you removed.","commit_id":"231bbf3a7404226310367ef7b4396d17243f970c"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"ba70615a279de6c332b0b8a5693d00c8c5b71cd4","unresolved":false,"context_lines":[{"line_number":253,"context_line":"            self.snapshots_client.wait_for_resource_deletion, snapshot[\u0027id\u0027])"},{"line_number":254,"context_line":"        self.addCleanup(self.snapshots_client.delete_snapshot, snapshot[\u0027id\u0027])"},{"line_number":255,"context_line":"        waiters.wait_for_volume_resource_status(self.snapshots_client,"},{"line_number":256,"context_line":"                                                snapshot[\u0027id\u0027], \u0027available\u0027)"},{"line_number":257,"context_line":"        return snapshot"},{"line_number":258,"context_line":""},{"line_number":259,"context_line":"    def create_volume_type(self, client\u003dNone, name\u003dNone, backend_name\u003dNone):"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f1d235d_e1e73f46","line":256,"in_reply_to":"3f1d235d_05715276","updated":"2017-07-09 05:52:15.000000000","message":"It\u0027s unnecessary check, there is other test that check all the parameters include name parameter.","commit_id":"231bbf3a7404226310367ef7b4396d17243f970c"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"815e5a4eb8342e3532f246d8c8976f3b2bdea655","unresolved":false,"context_lines":[{"line_number":252,"context_line":"                        snapshot[\u0027id\u0027])"},{"line_number":253,"context_line":"        self.addCleanup(self.snapshots_client.delete_snapshot, snapshot[\u0027id\u0027])"},{"line_number":254,"context_line":"        waiters.wait_for_volume_resource_status(self.snapshots_client,"},{"line_number":255,"context_line":"                                                snapshot[\u0027id\u0027], \u0027available\u0027)"},{"line_number":256,"context_line":"        return snapshot"},{"line_number":257,"context_line":""},{"line_number":258,"context_line":"    def create_volume_type(self, client\u003dNone, name\u003dNone, backend_name\u003dNone):"}],"source_content_type":"text/x-python","patch_set":3,"id":"1f1a1f67_e78f2521","line":255,"range":{"start_line":255,"start_character":65,"end_line":255,"end_character":74},"updated":"2017-07-13 21:33:13.000000000","message":"test_stamp_pattern\u0027s one was waiting for available of the volume also, isn\u0027t it necessary here?","commit_id":"73ed1f35205466a2a2ef910239ce91117043b769"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"bf9f20d07b5a598204c3edcac460d6365a0835df","unresolved":false,"context_lines":[{"line_number":252,"context_line":"                        snapshot[\u0027id\u0027])"},{"line_number":253,"context_line":"        self.addCleanup(self.snapshots_client.delete_snapshot, snapshot[\u0027id\u0027])"},{"line_number":254,"context_line":"        waiters.wait_for_volume_resource_status(self.snapshots_client,"},{"line_number":255,"context_line":"                                                snapshot[\u0027id\u0027], \u0027available\u0027)"},{"line_number":256,"context_line":"        return snapshot"},{"line_number":257,"context_line":""},{"line_number":258,"context_line":"    def create_volume_type(self, client\u003dNone, name\u003dNone, backend_name\u003dNone):"}],"source_content_type":"text/x-python","patch_set":3,"id":"1f1a1f67_6c412da9","line":255,"range":{"start_line":255,"start_character":65,"end_line":255,"end_character":74},"in_reply_to":"1f1a1f67_a3068a1b","updated":"2017-07-19 02:15:06.000000000","message":"OK, I got it. Thanks for your explanation.","commit_id":"73ed1f35205466a2a2ef910239ce91117043b769"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"4ff75b7ce57275d66be88cf59790d5d2b7f0ddd1","unresolved":false,"context_lines":[{"line_number":252,"context_line":"                        snapshot[\u0027id\u0027])"},{"line_number":253,"context_line":"        self.addCleanup(self.snapshots_client.delete_snapshot, snapshot[\u0027id\u0027])"},{"line_number":254,"context_line":"        waiters.wait_for_volume_resource_status(self.snapshots_client,"},{"line_number":255,"context_line":"                                                snapshot[\u0027id\u0027], \u0027available\u0027)"},{"line_number":256,"context_line":"        return snapshot"},{"line_number":257,"context_line":""},{"line_number":258,"context_line":"    def create_volume_type(self, client\u003dNone, name\u003dNone, backend_name\u003dNone):"}],"source_content_type":"text/x-python","patch_set":3,"id":"1f1a1f67_a3068a1b","line":255,"range":{"start_line":255,"start_character":65,"end_line":255,"end_character":74},"in_reply_to":"1f1a1f67_e78f2521","updated":"2017-07-16 07:25:10.000000000","message":"It\u0027s redundant, volume status doesn\u0027t change while snapshot creation procedure.","commit_id":"73ed1f35205466a2a2ef910239ce91117043b769"}],"tempest/scenario/test_stamp_pattern.py":[{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"249202f9eaf6d0e619b21b7b00261dbb3155879d","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        self.addCleanup(self.snapshots_client.wait_for_resource_deletion,"},{"line_number":65,"context_line":"                        snapshot[\u0027id\u0027])"},{"line_number":66,"context_line":"        self.addCleanup(self.snapshots_client.delete_snapshot, snapshot[\u0027id\u0027])"},{"line_number":67,"context_line":"        waiters.wait_for_volume_resource_status(self.volumes_client,"},{"line_number":68,"context_line":"                                                volume[\u0027id\u0027], \u0027available\u0027)"},{"line_number":69,"context_line":"        waiters.wait_for_volume_resource_status(self.snapshots_client,"},{"line_number":70,"context_line":"                                                snapshot[\u0027id\u0027], \u0027available\u0027)"},{"line_number":71,"context_line":"        self.assertEqual(snapshot_name, snapshot[\u0027name\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f1d235d_25fb2ec1","side":"PARENT","line":68,"range":{"start_line":67,"start_character":8,"end_line":68,"end_character":74},"updated":"2017-07-07 02:47:35.000000000","message":"Looks like this is already done in self.create_volume() so probably not needed.","commit_id":"1f6c8d4da6c8d45947dab7a2796ced300eaefe63"}]}