)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"a67a33d9400d70b44d558bf4e97e36df2c0a3a29","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"3f1d235d_be15244b","line":10,"updated":"2017-07-06 15:04:34.000000000","message":"Include this below to track this in the blueprint:\n\nPartially Implements: blueprint tempest-lib-missing-test-coverage","commit_id":"1dfa8f9c2332b3b406c05e171b6ef2d021c3c8ab"}],"tempest/tests/lib/services/volume/v2/test_volumes_client.py":[{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"a67a33d9400d70b44d558bf4e97e36df2c0a3a29","unresolved":false,"context_lines":[{"line_number":26,"context_line":"        self.client \u003d volumes_client.VolumesClient(fake_auth,"},{"line_number":27,"context_line":"                                                   \u0027volume\u0027,"},{"line_number":28,"context_line":"                                                   \u0027regionOne\u0027)"},{"line_number":29,"context_line":"    # retype_volume"},{"line_number":30,"context_line":"    def test_retype_volume(self, bytes_body\u003dFalse):"},{"line_number":31,"context_line":"        kwargs \u003d {"},{"line_number":32,"context_line":"            \u0027attachment_id\u0027: \u00276980e295-920f-412e-b189-05c50d605acd\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f1d235d_7e0b0c29","line":29,"range":{"start_line":29,"start_character":4,"end_line":29,"end_character":19},"updated":"2017-07-06 15:04:34.000000000","message":"Can remove this.","commit_id":"1dfa8f9c2332b3b406c05e171b6ef2d021c3c8ab"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"a67a33d9400d70b44d558bf4e97e36df2c0a3a29","unresolved":false,"context_lines":[{"line_number":28,"context_line":"                                                   \u0027regionOne\u0027)"},{"line_number":29,"context_line":"    # retype_volume"},{"line_number":30,"context_line":"    def test_retype_volume(self, bytes_body\u003dFalse):"},{"line_number":31,"context_line":"        kwargs \u003d {"},{"line_number":32,"context_line":"            \u0027attachment_id\u0027: \u00276980e295-920f-412e-b189-05c50d605acd\u0027,"},{"line_number":33,"context_line":"            \u0027connector\u0027: {"},{"line_number":34,"context_line":"                \u0027initiator\u0027: \u0027iqn.2017-04.org.fake:01\u0027"},{"line_number":35,"context_line":"            }"},{"line_number":36,"context_line":"        }"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"        self.check_service_client_function("},{"line_number":39,"context_line":"            self.client.retype_volume,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f1d235d_398b6e68","line":36,"range":{"start_line":31,"start_character":8,"end_line":36,"end_character":9},"updated":"2017-07-06 15:04:34.000000000","message":"These are incorrect. Look at the request body example here: https://developer.openstack.org/api-ref/block-storage/v3/index.html?expanded\u003dretype-a-volume-detail#retype-a-volume\n\n{\n    \"os-retype\": {\n        \"new_type\": \"dedup-tier-replicaton\",\n        \"migration_policy\": \"never\"\n    }\n}\n\nHowever, if you look at retype_volume in Tempest\u0027s v2 volumes_client, you\u0027ll see that it does this:\n\n    post_body \u003d json.dumps({\u0027os-retype\u0027: kwargs})\n\nSo you only need to pass:\n\nkwargs \u003d {\n    \"new_type\": \"dedup-tier-replication\",\n    \"migration_policy\": \"never\"\n}","commit_id":"1dfa8f9c2332b3b406c05e171b6ef2d021c3c8ab"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"a67a33d9400d70b44d558bf4e97e36df2c0a3a29","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        self.check_service_client_function("},{"line_number":39,"context_line":"            self.client.retype_volume,"},{"line_number":40,"context_line":"            \u0027tempest.lib.common.rest_client.RestClient.post\u0027,"},{"line_number":41,"context_line":"            \u0027test_retyped_volume\u0027,"},{"line_number":42,"context_line":"            to_utf\u003dbytes_body,"},{"line_number":43,"context_line":"            status\u003d202,"},{"line_number":44,"context_line":"            volume_id\u003d\"a3be971b-8de5-4bdf-bdb8-3d8eb0fb69f8\","}],"source_content_type":"text/x-python","patch_set":1,"id":"3f1d235d_996cc2ce","line":41,"range":{"start_line":41,"start_character":12,"end_line":41,"end_character":33},"updated":"2017-07-06 15:04:34.000000000","message":"I don\u0027t think this returns a response body according to the API docs: https://developer.openstack.org/api-ref/block-storage/v3/index.html?expanded\u003dretype-a-volume-detail#retype-a-volume\n\nYou can confirm by manually running \"cinder --debug retype\" from the CLI and checking what the response body is. Besides that, this response body would be a dictionary, not a string.","commit_id":"1dfa8f9c2332b3b406c05e171b6ef2d021c3c8ab"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"a67a33d9400d70b44d558bf4e97e36df2c0a3a29","unresolved":false,"context_lines":[{"line_number":51,"context_line":"    def test_retype_volume_with_bytes_body(self):"},{"line_number":52,"context_line":"        self._test_retype_volume(bytes_body\u003dTrue)"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    # force_detach_volume"},{"line_number":55,"context_line":"    def _test_force_detach_volume(self, bytes_body\u003dFalse):"},{"line_number":56,"context_line":"        kwargs \u003d {"},{"line_number":57,"context_line":"            \u0027attachment_id\u0027: \u00276980e295-920f-412e-b189-05c50d605acd\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f1d235d_9e102859","line":54,"range":{"start_line":54,"start_character":4,"end_line":54,"end_character":25},"updated":"2017-07-06 15:04:34.000000000","message":"Can remove this.","commit_id":"1dfa8f9c2332b3b406c05e171b6ef2d021c3c8ab"}]}
