)]}'
{"tempest/api/orchestration/base.py":[{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"2a0433bbb87e7766c71dd62cb5c85e0c828385cb","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        resp, networks \u003d cls.network_client.list_networks()"},{"line_number":51,"context_line":"        for net in networks[\u0027networks\u0027]:"},{"line_number":52,"context_line":"            if net[\u0027name\u0027] \u003d\u003d cls.compute_cfg.fixed_network_name:"},{"line_number":53,"context_line":"                return net"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    @classmethod"},{"line_number":56,"context_line":"    def _get_identity_admin_client(cls):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAS3%2F%2Fhf0%3D","line":53,"updated":"2013-09-25 09:11:54.000000000","message":"should one raise if the network is not found or arbitrarily return the last network?","commit_id":"a44ca037d7add0015c92055e23da6615de135055"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"f37bfdfa5ff7c3516a8a4fe525f1a6754d5b21ee","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        resp, networks \u003d cls.network_client.list_networks()"},{"line_number":51,"context_line":"        for net in networks[\u0027networks\u0027]:"},{"line_number":52,"context_line":"            if net[\u0027name\u0027] \u003d\u003d cls.compute_cfg.fixed_network_name:"},{"line_number":53,"context_line":"                return net"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    @classmethod"},{"line_number":56,"context_line":"    def _get_identity_admin_client(cls):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAS3%2F%2Feuk%3D","line":53,"in_reply_to":"AAAAS3%2F%2Fhf0%3D","updated":"2013-09-26 01:00:00.000000000","message":"I assume the test would fail in some way which makes it obvious that the test environment is misconfigured.","commit_id":"a44ca037d7add0015c92055e23da6615de135055"}],"tempest/api/orchestration/stacks/test_non_empty_stack.py":[{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"2a0433bbb87e7766c71dd62cb5c85e0c828385cb","unresolved":false,"context_lines":[{"line_number":81,"context_line":"                        cls._create_keypair()[\u0027name\u0027])"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"        # create the stack"},{"line_number":84,"context_line":"        subnet \u003d cls._get_default_network()[\u0027subnets\u0027][0]"},{"line_number":85,"context_line":"        cls.stack_identifier \u003d cls.create_stack("},{"line_number":86,"context_line":"            cls.stack_name,"},{"line_number":87,"context_line":"            cls.template,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAS3%2F%2FhfU%3D","line":84,"updated":"2013-09-25 09:11:54.000000000","message":"In theory, if neutron is being used, there could be a network without a subnet.\nIf by construction this does not happen or this test is not meant to be ran with neutron, then this piece of code is safe.\nOtherwise one should either raise or create a subnet if it does not exist","commit_id":"a44ca037d7add0015c92055e23da6615de135055"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"f37bfdfa5ff7c3516a8a4fe525f1a6754d5b21ee","unresolved":false,"context_lines":[{"line_number":81,"context_line":"                        cls._create_keypair()[\u0027name\u0027])"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"        # create the stack"},{"line_number":84,"context_line":"        subnet \u003d cls._get_default_network()[\u0027subnets\u0027][0]"},{"line_number":85,"context_line":"        cls.stack_identifier \u003d cls.create_stack("},{"line_number":86,"context_line":"            cls.stack_name,"},{"line_number":87,"context_line":"            cls.template,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAS3%2F%2Feuo%3D","line":84,"in_reply_to":"AAAAS3%2F%2FhfU%3D","updated":"2013-09-26 01:00:00.000000000","message":"This test is only meant to be run with neutron. An assumption is made that the configured network has a subnet - as devstack currently does. I think it is fair to say that some neutron configuration is required for non-devstack tempest runs.","commit_id":"a44ca037d7add0015c92055e23da6615de135055"}],"tempest/scenario/manager.py":[{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"2a0433bbb87e7766c71dd62cb5c85e0c828385cb","unresolved":false,"context_lines":[{"line_number":651,"context_line":"        return rand_name(cls.__name__ + \u0027-\u0027)"},{"line_number":652,"context_line":""},{"line_number":653,"context_line":"    @classmethod"},{"line_number":654,"context_line":"    def _get_default_network(cls):"},{"line_number":655,"context_line":"        networks \u003d cls.network_client.list_networks()"},{"line_number":656,"context_line":"        for net in networks[\u0027networks\u0027]:"},{"line_number":657,"context_line":"            if net[\u0027name\u0027] \u003d\u003d cls.config.compute.fixed_network_name:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAS3%2F%2FheI%3D","line":654,"updated":"2013-09-25 09:11:54.000000000","message":"is there a way to avoid duplication of this method, which is already in api/base.py\n\nMaybe a utility functions module?\nThis just a question as I\u0027m still understanding how tempest is organized.","commit_id":"a44ca037d7add0015c92055e23da6615de135055"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"f37bfdfa5ff7c3516a8a4fe525f1a6754d5b21ee","unresolved":false,"context_lines":[{"line_number":651,"context_line":"        return rand_name(cls.__name__ + \u0027-\u0027)"},{"line_number":652,"context_line":""},{"line_number":653,"context_line":"    @classmethod"},{"line_number":654,"context_line":"    def _get_default_network(cls):"},{"line_number":655,"context_line":"        networks \u003d cls.network_client.list_networks()"},{"line_number":656,"context_line":"        for net in networks[\u0027networks\u0027]:"},{"line_number":657,"context_line":"            if net[\u0027name\u0027] \u003d\u003d cls.config.compute.fixed_network_name:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAS3%2F%2Fevc%3D","line":654,"in_reply_to":"AAAAS3%2F%2FheI%3D","updated":"2013-09-26 01:00:00.000000000","message":"One uses the tempest client and one uses python-heatclient, so I\u0027m not that keen to attempt any code reuse here.","commit_id":"a44ca037d7add0015c92055e23da6615de135055"}]}