)]}'
{"tempest/clients.py":[{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"dbbde8fb07e35bae579f7cc9b2cb1d2e7befd40d","unresolved":false,"context_lines":[{"line_number":246,"context_line":"            self.volumes_extension_client \u003d self.volume_v1.ExtensionsClient()"},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"            # Set default client for users that don\u0027t need explicit version"},{"line_number":249,"context_line":"            self.volumes_client_latest \u003d self.volumes_client"},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"        if CONF.volume_feature_enabled.api_v2:"},{"line_number":252,"context_line":"            self.backups_v2_client \u003d self.volume_v2.BackupsClient()"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f1d235d_5e76c940","line":249,"range":{"start_line":249,"start_character":17,"end_line":249,"end_character":38},"updated":"2017-07-10 02:01:18.000000000","message":"I\u0027d rather use \"self.volumes_client\" for the name of default volumes client","commit_id":"edb1459bab6de1543b456dc26ddc73539ed1b600"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"91988856f53c9c11782b9f3629bd827b2dc493c2","unresolved":false,"context_lines":[{"line_number":246,"context_line":"            self.volumes_extension_client \u003d self.volume_v1.ExtensionsClient()"},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"            # Set default client for users that don\u0027t need explicit version"},{"line_number":249,"context_line":"            self.volumes_client_latest \u003d self.volumes_client"},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"        if CONF.volume_feature_enabled.api_v2:"},{"line_number":252,"context_line":"            self.backups_v2_client \u003d self.volume_v2.BackupsClient()"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f1a1f67_275b222f","line":249,"range":{"start_line":249,"start_character":0,"end_line":249,"end_character":60},"updated":"2017-07-12 09:37:46.000000000","message":"Since we removed the v1 tests from Tempest I\u0027m not sure we want to support running scenario and other non-volume tests  through volume-v1 moving forward.","commit_id":"edb1459bab6de1543b456dc26ddc73539ed1b600"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"02baa6e57e017393a0ba5e2592fefbff2871362a","unresolved":false,"context_lines":[{"line_number":246,"context_line":"            self.volumes_extension_client \u003d self.volume_v1.ExtensionsClient()"},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"            # Set default client for users that don\u0027t need explicit version"},{"line_number":249,"context_line":"            self.volumes_client_latest \u003d self.volumes_client"},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"        if CONF.volume_feature_enabled.api_v2:"},{"line_number":252,"context_line":"            self.backups_v2_client \u003d self.volume_v2.BackupsClient()"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f1d235d_ca09e931","line":249,"range":{"start_line":249,"start_character":17,"end_line":249,"end_character":38},"in_reply_to":"3f1d235d_5e76c940","updated":"2017-07-10 13:01:16.000000000","message":"Yes, that was my oroginal preference as well. But since that variable name was already used here, and is used for other variable names throughout, it made it very difficult to determine what was being intended for v1 and what was not. I think adding the _latest to the ended at least makes it clear from the name that the version you can expect it to be can be different.","commit_id":"edb1459bab6de1543b456dc26ddc73539ed1b600"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"969f7a737641ed6ae318b235cb0f12d8e26a3464","unresolved":false,"context_lines":[{"line_number":246,"context_line":"            self.volumes_extension_client \u003d self.volume_v1.ExtensionsClient()"},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"            # Set default client for users that don\u0027t need explicit version"},{"line_number":249,"context_line":"            self.volumes_client_latest \u003d self.volumes_client"},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"        if CONF.volume_feature_enabled.api_v2:"},{"line_number":252,"context_line":"            self.backups_v2_client \u003d self.volume_v2.BackupsClient()"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f1d235d_4f87f562","line":249,"range":{"start_line":249,"start_character":17,"end_line":249,"end_character":38},"in_reply_to":"3f1d235d_ca09e931","updated":"2017-07-11 18:04:00.000000000","message":"I think the latest suffix is actually a good choice, one this is an incremental so we\u0027re not going back and dealing with collisions elsewhere, but also the real advantage of this is... well; we want the latest so that\u0027s what we\u0027re asking for and it\u0027s very clear that\u0027s what it is, no?","commit_id":"edb1459bab6de1543b456dc26ddc73539ed1b600"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"dbbde8fb07e35bae579f7cc9b2cb1d2e7befd40d","unresolved":false,"context_lines":[{"line_number":248,"context_line":"            # Set default client for users that don\u0027t need explicit version"},{"line_number":249,"context_line":"            self.volumes_client_latest \u003d self.volumes_client"},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"        if CONF.volume_feature_enabled.api_v2:"},{"line_number":252,"context_line":"            self.backups_v2_client \u003d self.volume_v2.BackupsClient()"},{"line_number":253,"context_line":"            self.encryption_types_v2_client \u003d \\"},{"line_number":254,"context_line":"                self.volume_v2.EncryptionTypesClient()"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f1d235d_be383d3d","line":251,"range":{"start_line":251,"start_character":7,"end_line":251,"end_character":46},"updated":"2017-07-10 02:01:18.000000000","message":"with this, if CONF.volue_feature_enabled.api_v2 is False, then it will go wrong in such places:\nhttps://github.com/openstack/tempest/blob/86c8c9ececc98028dd6c582890687c32291e716f/tempest/api/volume/base.py#L253","commit_id":"edb1459bab6de1543b456dc26ddc73539ed1b600"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"02baa6e57e017393a0ba5e2592fefbff2871362a","unresolved":false,"context_lines":[{"line_number":248,"context_line":"            # Set default client for users that don\u0027t need explicit version"},{"line_number":249,"context_line":"            self.volumes_client_latest \u003d self.volumes_client"},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"        if CONF.volume_feature_enabled.api_v2:"},{"line_number":252,"context_line":"            self.backups_v2_client \u003d self.volume_v2.BackupsClient()"},{"line_number":253,"context_line":"            self.encryption_types_v2_client \u003d \\"},{"line_number":254,"context_line":"                self.volume_v2.EncryptionTypesClient()"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f1d235d_4d7a9388","line":251,"range":{"start_line":251,"start_character":7,"end_line":251,"end_character":46},"in_reply_to":"3f1d235d_be383d3d","updated":"2017-07-10 13:01:16.000000000","message":"Yes, there is definitely more work to be done to support the v3 API. That test is for v2 [1], so this part is OK. But I\u0027ve opened a bug to track adding support for v3 [2].\n\n[1] https://github.com/openstack/tempest/blob/86c8c9ececc98028dd6c582890687c32291e716f/tempest/api/volume/base.py#L33\n[2] https://bugs.launchpad.net/tempest/+bug/1703364","commit_id":"edb1459bab6de1543b456dc26ddc73539ed1b600"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"91988856f53c9c11782b9f3629bd827b2dc493c2","unresolved":false,"context_lines":[{"line_number":288,"context_line":"            self.volumes_v3_client \u003d self.volume_v3.VolumesClient()"},{"line_number":289,"context_line":""},{"line_number":290,"context_line":"            # Set default client for users that don\u0027t need explicit version"},{"line_number":291,"context_line":"            self.volumes_client_latest \u003d self.volumes_v3_client"},{"line_number":292,"context_line":""},{"line_number":293,"context_line":"    def _set_object_storage_clients(self):"},{"line_number":294,"context_line":"        # NOTE(andreaf) Load configuration from config. Once object storage"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f1a1f67_270d6237","line":291,"range":{"start_line":291,"start_character":17,"end_line":291,"end_character":38},"updated":"2017-07-12 09:37:46.000000000","message":"I think the logic should be to select the preferred client, not necessary the latest. Is v3 ready to be the only version tested in the integration gate? We should be able to select which version we want to test without the need of disabling an API version completely.","commit_id":"edb1459bab6de1543b456dc26ddc73539ed1b600"}]}