)]}'
{"tempest/api/network/test_rbac_policies.py":[{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"14fc1b07c02b3987dcc99c708c1159313dec52c8","unresolved":false,"context_lines":[{"line_number":101,"context_line":"        updated_rbac_policy \u003d self.rbac_policies_client.update_rbac_policy("},{"line_number":102,"context_line":"            retrieved_rbac_policy[\u0027id\u0027], target_tenant\u003dself.alt_target_tenant)["},{"line_number":103,"context_line":"            \u0027rbac_policy\u0027]"},{"line_number":104,"context_line":"        self.assertEqual(self.alt_target_tenant, updated_rbac_policy["},{"line_number":105,"context_line":"            \u0027target_tenant\u0027])"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"        # Validate that deleting an RBAC policy works."},{"line_number":108,"context_line":"        self.rbac_policies_client.delete_rbac_policy(updated_rbac_policy[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f436f4f_f302430b","line":105,"range":{"start_line":104,"start_character":0,"end_line":105,"end_character":29},"updated":"2017-08-10 06:30:13.000000000","message":"if we update target_tenant, do we need to check project_id and tenant_id in show_rbac_policy change accordingly?","commit_id":"d984cb8caa43172824488f254b8f1d11be85c6ad"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"58362e40a163e4dcf4f7a68da6c4ab8dbd375004","unresolved":false,"context_lines":[{"line_number":101,"context_line":"        updated_rbac_policy \u003d self.rbac_policies_client.update_rbac_policy("},{"line_number":102,"context_line":"            retrieved_rbac_policy[\u0027id\u0027], target_tenant\u003dself.alt_target_tenant)["},{"line_number":103,"context_line":"            \u0027rbac_policy\u0027]"},{"line_number":104,"context_line":"        self.assertEqual(self.alt_target_tenant, updated_rbac_policy["},{"line_number":105,"context_line":"            \u0027target_tenant\u0027])"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"        # Validate that deleting an RBAC policy works."},{"line_number":108,"context_line":"        self.rbac_policies_client.delete_rbac_policy(updated_rbac_policy[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f436f4f_2596f840","line":105,"range":{"start_line":104,"start_character":0,"end_line":105,"end_character":29},"in_reply_to":"9f436f4f_f302430b","updated":"2017-08-13 17:05:57.000000000","message":"No, because the \"target_tenant\" is the tenant under which the RBAC policy will be enforced. The project_id (tenant_id) for the RBAC policy is the project_id under which the policy was created.\n\nAdding clarification via NOTE in next PS.\n\nhttps://developer.openstack.org/api-ref/networking/v2/?expanded\u003dcreate-rbac-policy-detail#create-rbac-policy","commit_id":"d984cb8caa43172824488f254b8f1d11be85c6ad"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"4713eee596d4a51d0be8d95b09c4a2e667945e94","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"class RBACPoliciesTest(base.BaseNetworkTest):"},{"line_number":24,"context_line":"    \"\"\"Tests the following operations in the tags API:"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"        Create an RBAC policy."},{"line_number":27,"context_line":"        Update an RBAC policy."}],"source_content_type":"text/x-python","patch_set":9,"id":"df7087c5_71712a44","line":24,"range":{"start_line":24,"start_character":45,"end_line":24,"end_character":49},"updated":"2018-03-23 03:19:35.000000000","message":"?","commit_id":"97c2e0a7ac522ada9af3198a63741c4486f6bebb"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"4713eee596d4a51d0be8d95b09c4a2e667945e94","unresolved":false,"context_lines":[{"line_number":23,"context_line":"class RBACPoliciesTest(base.BaseNetworkTest):"},{"line_number":24,"context_line":"    \"\"\"Tests the following operations in the tags API:"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"        Create an RBAC policy."},{"line_number":27,"context_line":"        Update an RBAC policy."},{"line_number":28,"context_line":"        Show an RBAC policy."},{"line_number":29,"context_line":"        Delete an RBAC policy."}],"source_content_type":"text/x-python","patch_set":9,"id":"df7087c5_71704a09","line":26,"range":{"start_line":26,"start_character":15,"end_line":26,"end_character":22},"updated":"2018-03-23 03:19:35.000000000","message":"I wonder why \"an RBAC\" :) the same in api ref","commit_id":"97c2e0a7ac522ada9af3198a63741c4486f6bebb"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"78ba157ab188e1f6b68c15c86fb84cc5bb33bc8a","unresolved":false,"context_lines":[{"line_number":23,"context_line":"class RBACPoliciesTest(base.BaseNetworkTest):"},{"line_number":24,"context_line":"    \"\"\"Tests the following operations in the tags API:"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"        Create an RBAC policy."},{"line_number":27,"context_line":"        Update an RBAC policy."},{"line_number":28,"context_line":"        Show an RBAC policy."},{"line_number":29,"context_line":"        Delete an RBAC policy."}],"source_content_type":"text/x-python","patch_set":9,"id":"bf659307_10343cfb","line":26,"range":{"start_line":26,"start_character":15,"end_line":26,"end_character":22},"in_reply_to":"bf659307_0cb0ae42","updated":"2018-04-02 00:59:47.000000000","message":"got it, thanks:)","commit_id":"97c2e0a7ac522ada9af3198a63741c4486f6bebb"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"8ccd55ede9d8b44dc6fae9bc810e38a1222a5765","unresolved":false,"context_lines":[{"line_number":23,"context_line":"class RBACPoliciesTest(base.BaseNetworkTest):"},{"line_number":24,"context_line":"    \"\"\"Tests the following operations in the tags API:"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"        Create an RBAC policy."},{"line_number":27,"context_line":"        Update an RBAC policy."},{"line_number":28,"context_line":"        Show an RBAC policy."},{"line_number":29,"context_line":"        Delete an RBAC policy."}],"source_content_type":"text/x-python","patch_set":9,"id":"bf659307_0cb0ae42","line":26,"range":{"start_line":26,"start_character":15,"end_line":26,"end_character":22},"in_reply_to":"df7087c5_71704a09","updated":"2018-03-31 23:16:14.000000000","message":"The rule for using \"an\" is actually dependent on the sound of the word after it. For example, \"an hour\" or \"an honor\". In this case, it\u0027s \"an RBAC\" because that\u0027s pronounced \"Are-BAC\". But not even many English speakers are familiar with this rule.\n\nI will go ahead and change it to be consistent with API ref.","commit_id":"97c2e0a7ac522ada9af3198a63741c4486f6bebb"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"4713eee596d4a51d0be8d95b09c4a2e667945e94","unresolved":false,"context_lines":[{"line_number":103,"context_line":"            \u0027rbac_policy\u0027]"},{"line_number":104,"context_line":"        self.assertEqual(self.alt_target_tenant, updated_rbac_policy["},{"line_number":105,"context_line":"            \u0027target_tenant\u0027])"},{"line_number":106,"context_line":"        # NOTE: The RBAC policy\u0027s project_id/tenant_id should still be"},{"line_number":107,"context_line":"        # ``self.target_tenant`` because that is the tenant under which the"},{"line_number":108,"context_line":"        # policy was created. The target_tenant specifies the tenant under"},{"line_number":109,"context_line":"        # which the RBAC policy will be enforced."},{"line_number":110,"context_line":"        for attr in [\u0027project_id\u0027, \u0027tenant_id\u0027]:"},{"line_number":111,"context_line":"            self.assertEqual(self.target_tenant, updated_rbac_policy[attr])"},{"line_number":112,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"df7087c5_8c13815c","line":109,"range":{"start_line":106,"start_character":0,"end_line":109,"end_character":49},"updated":"2018-03-23 03:19:35.000000000","message":"This behaviour seems a bit hard to understand.\nHow can we know that the policy is enforced on alt_tenant?(except the response of update_rbac_policy)","commit_id":"97c2e0a7ac522ada9af3198a63741c4486f6bebb"}]}