)]}'
{"tempest/api/compute/admin/test_servers.py":[{"author":{"_account_id":7872,"name":"Marc Koderer","email":"marc@koderer.com","username":"mkoderer"},"change_message_id":"85af8d969071ec63f0a97482cd5f26a87063dbb0","unresolved":false,"context_lines":[{"line_number":129,"context_line":"        for key in basic_attrs:"},{"line_number":130,"context_line":"            self.assertIn(key, str(diagnostic.keys()))"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"    @attr(type\u003d\u0027gate\u0027)"},{"line_number":133,"context_line":"    def test_get_server_diagnostics_by_non_admin(self):"},{"line_number":134,"context_line":"        # Non-admin user can not view server diagnostics according to policy"},{"line_number":135,"context_line":"        self.assertRaises(exceptions.Unauthorized,"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAS3%2F%2FXRE%3D","line":132,"updated":"2013-09-28 06:57:29.000000000","message":"Could you add the \"negative\" type here?","commit_id":"76d932a8bd10050b4917bffdb8a40f7f8907550d"},{"author":{"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},"change_message_id":"0c64b99c268dc6fddcb05b2addad5aa186861a06","unresolved":false,"context_lines":[{"line_number":170,"context_line":"                       \u0027tx_packets\u0027, \u0027tx_errors\u0027, \u0027tx_drop\u0027,"},{"line_number":171,"context_line":"                       \u0027read_req\u0027, \u0027write_req\u0027, \u0027cpu\u0027, \u0027memory\u0027]"},{"line_number":172,"context_line":"        for key in basic_attrs:"},{"line_number":173,"context_line":"            self.assertIn(key, str(diagnostic.keys()))"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"    @attr(type\u003d[\u0027negative\u0027, \u0027gate\u0027])"},{"line_number":176,"context_line":"    def test_get_server_diagnostics_by_non_admin(self):"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAATH%2F%2F%2FPQ%3D","line":173,"updated":"2013-10-06 14:54:43.000000000","message":"why not directly use assertIn(key, diagnostic.keys())?","commit_id":"da0708587432e47f85241201968e6402190f0c5d"},{"author":{"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},"change_message_id":"1599baf8aaff7bdbf4356542c064d3ee6f3a8bf1","unresolved":false,"context_lines":[{"line_number":170,"context_line":"                       \u0027tx_packets\u0027, \u0027tx_errors\u0027, \u0027tx_drop\u0027,"},{"line_number":171,"context_line":"                       \u0027read_req\u0027, \u0027write_req\u0027, \u0027cpu\u0027, \u0027memory\u0027]"},{"line_number":172,"context_line":"        for key in basic_attrs:"},{"line_number":173,"context_line":"            self.assertIn(key, str(diagnostic.keys()))"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"    @attr(type\u003d[\u0027negative\u0027, \u0027gate\u0027])"},{"line_number":176,"context_line":"    def test_get_server_diagnostics_by_non_admin(self):"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAATH%2F%2F%2FNc%3D","line":173,"in_reply_to":"AAAATH%2F%2F%2FOM%3D","updated":"2013-10-06 16:01:58.000000000","message":"zhu, Thanks for your explanation!","commit_id":"da0708587432e47f85241201968e6402190f0c5d"},{"author":{"_account_id":7148,"name":"Zhu Zhu","email":"bjzzu.zz@gmail.com","username":"zhuzhubj"},"change_message_id":"e2a32c1a924442654adc7f89767e89c43680b3fc","unresolved":false,"context_lines":[{"line_number":170,"context_line":"                       \u0027tx_packets\u0027, \u0027tx_errors\u0027, \u0027tx_drop\u0027,"},{"line_number":171,"context_line":"                       \u0027read_req\u0027, \u0027write_req\u0027, \u0027cpu\u0027, \u0027memory\u0027]"},{"line_number":172,"context_line":"        for key in basic_attrs:"},{"line_number":173,"context_line":"            self.assertIn(key, str(diagnostic.keys()))"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"    @attr(type\u003d[\u0027negative\u0027, \u0027gate\u0027])"},{"line_number":176,"context_line":"    def test_get_server_diagnostics_by_non_admin(self):"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAATH%2F%2F%2FOM%3D","line":173,"in_reply_to":"AAAATH%2F%2F%2FPQ%3D","updated":"2013-10-06 15:43:30.000000000","message":"hello, it is not suitable to use assertIn that way here, the reason is that the api return value is something like tapxxx_tx_packages, only with suffix with \u0027tx_packets\u0027.  assertIn(key, diagnostic.keys()) will fail the case since it is strictly comparation.","commit_id":"da0708587432e47f85241201968e6402190f0c5d"}]}