)]}'
{"tempest/scenario/test_volume_backup_restore.py":[{"author":{"_account_id":18600,"name":"Ferenc Horváth","email":"hferenc@inf.u-szeged.hu","username":"hferenc"},"change_message_id":"7dd078846bd98cb72515e65554bf69a47da0872d","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    def skip_checks(cls):"},{"line_number":42,"context_line":"        super(TestVolumeBackupRestore, cls).skip_checks()"},{"line_number":43,"context_line":"        if not CONF.volume_feature_enabled.backup:"},{"line_number":44,"context_line":"            raise cls.skipException(\u0027Backup is not enable.\u0027)"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    @decorators.idempotent_id(\u00272ce5e55c-4085-43c1-98c6-582525334ad7\u0027)"},{"line_number":47,"context_line":"    @test.services(\u0027compute\u0027, \u0027volume\u0027, \u0027image\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f1d235d_e947e8bb","line":44,"range":{"start_line":44,"start_character":51,"end_line":44,"end_character":57},"updated":"2017-07-11 14:20:58.000000000","message":"enabled","commit_id":"2cddbfba2c20db476784f7142ab55d31792faed3"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"0322e73b6e97fac7a99c951342f211023fc5f3f7","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    def skip_checks(cls):"},{"line_number":42,"context_line":"        super(TestVolumeBackupRestore, cls).skip_checks()"},{"line_number":43,"context_line":"        if not CONF.volume_feature_enabled.backup:"},{"line_number":44,"context_line":"            raise cls.skipException(\u0027Backup is not enable.\u0027)"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    @decorators.idempotent_id(\u00272ce5e55c-4085-43c1-98c6-582525334ad7\u0027)"},{"line_number":47,"context_line":"    @test.services(\u0027compute\u0027, \u0027volume\u0027, \u0027image\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f1d235d_a67d841d","line":44,"range":{"start_line":44,"start_character":51,"end_line":44,"end_character":57},"in_reply_to":"3f1d235d_e947e8bb","updated":"2017-07-12 05:11:30.000000000","message":"Thanks, done","commit_id":"2cddbfba2c20db476784f7142ab55d31792faed3"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"9838d44652c37713adb2312d4eafe5bd209137f9","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    def test_volume_backup_restore(self):"},{"line_number":49,"context_line":"        # Create volume from image"},{"line_number":50,"context_line":"        img_uuid \u003d CONF.compute.image_ref"},{"line_number":51,"context_line":"        volume \u003d self.create_volume(imageRef\u003dimg_uuid)"},{"line_number":52,"context_line":"        volume_details \u003d self.volumes_client.show_volume("},{"line_number":53,"context_line":"            volume[\u0027id\u0027])[\u0027volume\u0027]"},{"line_number":54,"context_line":"        self.assertEqual(\u0027true\u0027, volume_details[\u0027bootable\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f1a1f67_597de3e5","line":51,"range":{"start_line":51,"start_character":8,"end_line":51,"end_character":54},"updated":"2017-07-12 09:15:46.000000000","message":"to put it directly:\nvolume \u003d self.create_volume(imageRef\u003dCONF.compute.image_ref)","commit_id":"27a184c70d0044b4b437dcb45da113692b73d7d1"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"4ea73bf6675652ed6e7b464a49e7903b4d1d4643","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    def test_volume_backup_restore(self):"},{"line_number":49,"context_line":"        # Create volume from image"},{"line_number":50,"context_line":"        img_uuid \u003d CONF.compute.image_ref"},{"line_number":51,"context_line":"        volume \u003d self.create_volume(imageRef\u003dimg_uuid)"},{"line_number":52,"context_line":"        volume_details \u003d self.volumes_client.show_volume("},{"line_number":53,"context_line":"            volume[\u0027id\u0027])[\u0027volume\u0027]"},{"line_number":54,"context_line":"        self.assertEqual(\u0027true\u0027, volume_details[\u0027bootable\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f1a1f67_1ca2b49b","line":51,"range":{"start_line":51,"start_character":8,"end_line":51,"end_character":54},"in_reply_to":"1f1a1f67_597de3e5","updated":"2017-07-12 11:54:07.000000000","message":"Done","commit_id":"27a184c70d0044b4b437dcb45da113692b73d7d1"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"9838d44652c37713adb2312d4eafe5bd209137f9","unresolved":false,"context_lines":[{"line_number":84,"context_line":"        floating_ip \u003d self.create_floating_ip(server)"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"        # Check server connectivity"},{"line_number":87,"context_line":"        self.check_vm_connectivity(floating_ip[\u0027ip\u0027],"},{"line_number":88,"context_line":"                                   username\u003dCONF.validation.image_ssh_user,"},{"line_number":89,"context_line":"                                   private_key\u003dkeypair[\u0027private_key\u0027],"},{"line_number":90,"context_line":"                                   should_connect\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f1a1f67_f93dcf2c","line":87,"range":{"start_line":87,"start_character":13,"end_line":87,"end_character":34},"updated":"2017-07-12 09:15:46.000000000","message":"if you want to \"verifies content preservation after backup\", maybe it\u0027s better to create_timestamp\nbefore backup and get_timestamp after restore","commit_id":"27a184c70d0044b4b437dcb45da113692b73d7d1"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"4ea73bf6675652ed6e7b464a49e7903b4d1d4643","unresolved":false,"context_lines":[{"line_number":84,"context_line":"        floating_ip \u003d self.create_floating_ip(server)"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"        # Check server connectivity"},{"line_number":87,"context_line":"        self.check_vm_connectivity(floating_ip[\u0027ip\u0027],"},{"line_number":88,"context_line":"                                   username\u003dCONF.validation.image_ssh_user,"},{"line_number":89,"context_line":"                                   private_key\u003dkeypair[\u0027private_key\u0027],"},{"line_number":90,"context_line":"                                   should_connect\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f1a1f67_3c3fb0d7","line":87,"range":{"start_line":87,"start_character":13,"end_line":87,"end_character":34},"in_reply_to":"1f1a1f67_f93dcf2c","updated":"2017-07-12 11:54:07.000000000","message":"Yes I think it\u0027s better.\nThanks","commit_id":"27a184c70d0044b4b437dcb45da113692b73d7d1"},{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"bf4c117f28a08748966c6b6d5a16322e35f6e552","unresolved":false,"context_lines":[{"line_number":72,"context_line":"            private_key\u003dkeypair[\u0027private_key\u0027])"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        # Create a backup for the attached volume"},{"line_number":75,"context_line":"        backup \u003d self.create_backup(volume_id\u003dvolume[\u0027id\u0027], force\u003dTrue)"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"        # Detach the volume"},{"line_number":78,"context_line":"        self.nova_volume_detach(server, volume)"}],"source_content_type":"text/x-python","patch_set":4,"id":"1f1a1f67_5c3a1f98","line":75,"updated":"2017-07-14 05:17:09.000000000","message":"I\u0027m actually not sure that using \u0027force\u003dTrue\u0027 is a normal operation? I feel volume_detach -\u003e create_backup is a normal and robust way.","commit_id":"66b62155c87fa7fe0f6652635ddcdddd295b3503"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"86b870914c700b4c608a4b0976dfdc8b4866ea6b","unresolved":false,"context_lines":[{"line_number":72,"context_line":"            private_key\u003dkeypair[\u0027private_key\u0027])"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        # Create a backup for the attached volume"},{"line_number":75,"context_line":"        backup \u003d self.create_backup(volume_id\u003dvolume[\u0027id\u0027], force\u003dTrue)"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"        # Detach the volume"},{"line_number":78,"context_line":"        self.nova_volume_detach(server, volume)"}],"source_content_type":"text/x-python","patch_set":4,"id":"1f1a1f67_a3a20afb","line":75,"in_reply_to":"1f1a1f67_5c3a1f98","updated":"2017-07-16 07:56:41.000000000","message":"Hi Masayuki,\n\nI think we should test it with \u0027force\u003dTrue\u0027 since it\u0027s a valid option and possible use in some cases. We should also test the scenario you have described.","commit_id":"66b62155c87fa7fe0f6652635ddcdddd295b3503"}]}