)]}'
{"tempest/api/compute/servers/test_create_server.py":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"0328f81cef853b04bc8f21294cea28323f5c1e32","unresolved":false,"context_lines":[{"line_number":73,"context_line":"        self.assertEqual(self.server[\u0027accessIPv6\u0027],"},{"line_number":74,"context_line":"                         str(netaddr.IPAddress(self.accessIPv6)))"},{"line_number":75,"context_line":"        self.assertEqual(self.name, self.server[\u0027name\u0027])"},{"line_number":76,"context_line":"        self.assertEqual(self.image_ref, self.server[\u0027image\u0027][\u0027id\u0027])"},{"line_number":77,"context_line":"        self.assertEqual(self.flavor_ref, self.server[\u0027flavor\u0027][\u0027id\u0027])"},{"line_number":78,"context_line":"        self.assertEqual(self.meta, self.server[\u0027metadata\u0027])"},{"line_number":79,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1f1a1f67_8a14fb4f","line":76,"updated":"2017-07-13 19:37:26.000000000","message":"http://logs.openstack.org/96/483296/2/check/gate-tempest-dsvm-neutron-full-ubuntu-xenial/21da85c/logs/tempest.txt.gz#_2017-07-13_14_32_47_792\n\n \"image\": \"\",\n\nSo this assertEqual should be switched on each condition like\n\n if self.volume_backed:\n     self.assertEqual(\"\", self.server[\u0027image\u0027])\n else:\n     self.assertEqual(self.image_ref, self.server[\u0027image\u0027][\u0027id\u0027])","commit_id":"36b0b110da13253c54b3c506d9a022bd9932689a"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"ebc1e0cbcf44113bce3f08b036d387441ee3891e","unresolved":false,"context_lines":[{"line_number":75,"context_line":"        self.assertEqual(self.name, self.server[\u0027name\u0027])"},{"line_number":76,"context_line":"        self.assertEqual(self.image_ref, self.server[\u0027image\u0027][\u0027id\u0027])"},{"line_number":77,"context_line":"        if self.volume_backed:"},{"line_number":78,"context_line":"            self.assertEqual(\"\", self.server[\u0027image\u0027])"},{"line_number":79,"context_line":"        else:"},{"line_number":80,"context_line":"            self.assertEqual(self.image_ref, self.server[\u0027image\u0027][\u0027id\u0027])"},{"line_number":81,"context_line":"        self.assertEqual(self.flavor_ref, self.server[\u0027flavor\u0027][\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":4,"id":"1f1a1f67_4e84aeb1","line":78,"range":{"start_line":78,"start_character":12,"end_line":78,"end_character":54},"updated":"2017-07-14 01:34:17.000000000","message":"the schema shows image can be null,\n{\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]} \nso how about self.assertFalse(self.server[\u0027image\u0027])?","commit_id":"de31b78ac122d6e95295d7d800cecfcf171cfb78"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"c9da9d7f6d257292b21a95d1b0cc111ea1cc34ec","unresolved":false,"context_lines":[{"line_number":75,"context_line":"        self.assertEqual(self.name, self.server[\u0027name\u0027])"},{"line_number":76,"context_line":"        self.assertEqual(self.image_ref, self.server[\u0027image\u0027][\u0027id\u0027])"},{"line_number":77,"context_line":"        if self.volume_backed:"},{"line_number":78,"context_line":"            self.assertEqual(\"\", self.server[\u0027image\u0027])"},{"line_number":79,"context_line":"        else:"},{"line_number":80,"context_line":"            self.assertEqual(self.image_ref, self.server[\u0027image\u0027][\u0027id\u0027])"},{"line_number":81,"context_line":"        self.assertEqual(self.flavor_ref, self.server[\u0027flavor\u0027][\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":4,"id":"1f1a1f67_a577ce02","line":78,"range":{"start_line":78,"start_character":12,"end_line":78,"end_character":54},"in_reply_to":"1f1a1f67_4e84aeb1","updated":"2017-07-14 13:56:11.000000000","message":"Thanks - I\u0027m not sure if the API will be returning null here, but assuming the schema is correct I agree","commit_id":"de31b78ac122d6e95295d7d800cecfcf171cfb78"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"126a7adac1f465a247dc25473623cd093a2e78c3","unresolved":false,"context_lines":[{"line_number":74,"context_line":"                         str(netaddr.IPAddress(self.accessIPv6)))"},{"line_number":75,"context_line":"        self.assertEqual(self.name, self.server[\u0027name\u0027])"},{"line_number":76,"context_line":"        if self.volume_backed:"},{"line_number":77,"context_line":"            # Accept empty string or None"},{"line_number":78,"context_line":"            self.assertFalse(self.server[\u0027image\u0027])"},{"line_number":79,"context_line":"        else:"},{"line_number":80,"context_line":"            self.assertEqual(self.image_ref, self.server[\u0027image\u0027][\u0027id\u0027])"},{"line_number":81,"context_line":"        self.assertEqual(self.flavor_ref, self.server[\u0027flavor\u0027][\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":7,"id":"1f1a1f67_0ceab9d6","line":78,"range":{"start_line":77,"start_character":12,"end_line":78,"end_character":50},"updated":"2017-07-19 02:05:42.000000000","message":"The Nova API returns an empty string only in this case like\nhttps://github.com/openstack/nova/blob/master/nova/api/openstack/compute/servers.py#L852\n\nSo we need to check the empty string for stable API.","commit_id":"6c3139d88d2b24742cb07f03de5f84ba84ac7d33"},{"author":{"_account_id":23081,"name":"Jeremy Zhang","email":"zhangjun_inspur@163.com","username":"jeremy.zhang"},"change_message_id":"70bfe1c9258ba2d8f132ac9b9a58879ca4d67fd0","unresolved":false,"context_lines":[{"line_number":160,"context_line":"            raise cls.skipException(msg)"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"class ServersTesBootFromVolume(ServersTestJSON):"},{"line_number":164,"context_line":"    \"\"\"Run the `ServersTestJSON` tests with a volume backed VM\"\"\""},{"line_number":165,"context_line":"    volume_backed \u003d True"},{"line_number":166,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"1f1a1f67_11019b38","line":163,"range":{"start_line":163,"start_character":13,"end_line":163,"end_character":16},"updated":"2017-07-19 14:47:44.000000000","message":"The class name should be ServersTestBootFromVolume, :)","commit_id":"02033d84beeb0656ab914c1cf25c9a465103ce79"}],"tempest/lib/api_schema/response/compute/v2_26/servers.py":[{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"e9e36b69fceefbeeea0f7736aa02209dcadc134d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2016 IBM Corp."},{"line_number":2,"context_line":"# Copyright 2017 AT\u0026T Corp."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":6,"id":"1f1a1f67_59d1b522","side":"PARENT","line":1,"updated":"2017-07-18 07:02:03.000000000","message":"Why did you remove this? I think this removing is not related to this patch.","commit_id":"d69d1b552ba08ac1637b8589eb73eb108aa2e1d5"}]}