)]}'
{"tempest/common/dynamic_creds.py":[{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"ceef01cac31ec99cbeb87e75f540e27d3a889e36","unresolved":false,"context_lines":[{"line_number":128,"context_line":"        \"\"\""},{"line_number":129,"context_line":"        os \u003d clients.ServiceClients(self.default_admin_creds,"},{"line_number":130,"context_line":"                                    self.identity_uri)"},{"line_number":131,"context_line":"        params \u003d {\u0027endpoint_type\u0027: endpoint_type}"},{"line_number":132,"context_line":"        if self.identity_version \u003d\u003d \u0027v2\u0027:"},{"line_number":133,"context_line":"            return (os.identity_v2.IdentityClient(**params),"},{"line_number":134,"context_line":"                    os.identity_v2.TenantsClient(**params),"}],"source_content_type":"text/x-python","patch_set":7,"id":"1f1a1f67_c46335b1","line":131,"updated":"2017-07-20 16:53:13.000000000","message":"So my only concern is the default value here. endpoint_type is defaulting to admin here, and in the v3 case this probably should be public. For v2 admin is definitely the correct default (because admin is a separate api service)\n\nI worry that for people using this module as a lib interface and wanting v3 only this will become a potential problem, especially if there is no admin endpoint exposed.","commit_id":"2a8eefd72c83f5c9ddf420cdefa8d94373c75ef1"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"c659fbfaa9ced981eae0846ca03b86a197b45f8b","unresolved":false,"context_lines":[{"line_number":70,"context_line":"        :param project_network_mask_bits: The network mask bits to use for"},{"line_number":71,"context_line":"                                          created project networks"},{"line_number":72,"context_line":"        :param public_network_id: The id for the public network to use"},{"line_number":73,"context_line":"        :param identity_admin_endpoint_type: The endpoint type for identity"},{"line_number":74,"context_line":"                                             admin clients. Defaults to public."},{"line_number":75,"context_line":"        :param identity_uri: Identity URI of the target cloud"},{"line_number":76,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":8,"id":"1f1a1f67_eb0cb595","line":73,"updated":"2017-07-20 22:46:56.000000000","message":"I feel like we might want to explain a bit more here, but I guess this is good enough. We can fix this in the lib docs after the migration.","commit_id":"dcd9100d03ddadf931cf18e8701911440a40cf21"}]}