)]}'
{"tempest/api/network/test_networks.py":[{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"d1ef7e10edf7843414858f92b7cd9f146c4ab8fb","unresolved":false,"context_lines":[{"line_number":377,"context_line":"        \"\"\"Verifies user can see external networks but not subnets.\"\"\""},{"line_number":378,"context_line":"        body \u003d self.networks_client.list_networks(**{\u0027router:external\u0027: True,"},{"line_number":379,"context_line":"                                                     \u0027shared\u0027: False})"},{"line_number":380,"context_line":"        networks \u003d [network[\u0027id\u0027] for network in body[\u0027networks\u0027]]"},{"line_number":381,"context_line":"        if len(networks) \u003d\u003d 0:"},{"line_number":382,"context_line":"            raise lib_exc.InvalidConfiguration("},{"line_number":383,"context_line":"                \"This test requires that public network %s is configured as \""},{"line_number":384,"context_line":"                \"external and not shared.\""}],"source_content_type":"text/x-python","patch_set":2,"id":"df3967d1_44621ab0","line":381,"range":{"start_line":380,"start_character":43,"end_line":381,"end_character":30},"updated":"2017-08-03 09:07:31.000000000","message":"nit:\n   if not networks:","commit_id":"b4eb152a0c575b69dc9e99632d610012bf632fb5"},{"author":{"_account_id":23709,"name":"Duc Truong","email":"dkt26111@gmail.com","username":"dtruong"},"change_message_id":"c9caf6b6839e632e08679db446e6f1229d43040c","unresolved":false,"context_lines":[{"line_number":377,"context_line":"        \"\"\"Verifies user can see external networks but not subnets.\"\"\""},{"line_number":378,"context_line":"        body \u003d self.networks_client.list_networks(**{\u0027router:external\u0027: True,"},{"line_number":379,"context_line":"                                                     \u0027shared\u0027: False})"},{"line_number":380,"context_line":"        networks \u003d [network[\u0027id\u0027] for network in body[\u0027networks\u0027]]"},{"line_number":381,"context_line":"        if len(networks) \u003d\u003d 0:"},{"line_number":382,"context_line":"            raise lib_exc.InvalidConfiguration("},{"line_number":383,"context_line":"                \"This test requires that public network %s is configured as \""},{"line_number":384,"context_line":"                \"external and not shared.\""}],"source_content_type":"text/x-python","patch_set":2,"id":"df3967d1_6ec72198","line":381,"range":{"start_line":380,"start_character":43,"end_line":381,"end_character":30},"in_reply_to":"df3967d1_44621ab0","updated":"2017-08-03 23:22:04.000000000","message":"Done","commit_id":"b4eb152a0c575b69dc9e99632d610012bf632fb5"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"d1ef7e10edf7843414858f92b7cd9f146c4ab8fb","unresolved":false,"context_lines":[{"line_number":379,"context_line":"                                                     \u0027shared\u0027: False})"},{"line_number":380,"context_line":"        networks \u003d [network[\u0027id\u0027] for network in body[\u0027networks\u0027]]"},{"line_number":381,"context_line":"        if len(networks) \u003d\u003d 0:"},{"line_number":382,"context_line":"            raise lib_exc.InvalidConfiguration("},{"line_number":383,"context_line":"                \"This test requires that public network %s is configured as \""},{"line_number":384,"context_line":"                \"external and not shared.\""},{"line_number":385,"context_line":"                % CONF.network.public_network_id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"df3967d1_a4f786d3","line":382,"range":{"start_line":382,"start_character":26,"end_line":382,"end_character":46},"updated":"2017-08-03 09:07:31.000000000","message":"So do you think to configure an external network as shared is some kind of misconfiguration?","commit_id":"b4eb152a0c575b69dc9e99632d610012bf632fb5"},{"author":{"_account_id":23709,"name":"Duc Truong","email":"dkt26111@gmail.com","username":"dtruong"},"change_message_id":"c9caf6b6839e632e08679db446e6f1229d43040c","unresolved":false,"context_lines":[{"line_number":379,"context_line":"                                                     \u0027shared\u0027: False})"},{"line_number":380,"context_line":"        networks \u003d [network[\u0027id\u0027] for network in body[\u0027networks\u0027]]"},{"line_number":381,"context_line":"        if len(networks) \u003d\u003d 0:"},{"line_number":382,"context_line":"            raise lib_exc.InvalidConfiguration("},{"line_number":383,"context_line":"                \"This test requires that public network %s is configured as \""},{"line_number":384,"context_line":"                \"external and not shared.\""},{"line_number":385,"context_line":"                % CONF.network.public_network_id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"df3967d1_4e49fd2e","line":382,"range":{"start_line":382,"start_character":26,"end_line":382,"end_character":46},"in_reply_to":"df3967d1_a4f786d3","updated":"2017-08-03 23:22:04.000000000","message":"Yes, it is a misconfiguration of tempest.  If their public network is both external and shared, the user should disable this test case by removing the extension \u0027external-net\u0027 in tempest.conf or change the public network.","commit_id":"b4eb152a0c575b69dc9e99632d610012bf632fb5"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"4003b01e21fec06afe9bc2bef5f2e9eb2b995ce1","unresolved":false,"context_lines":[{"line_number":379,"context_line":"                                                     \u0027shared\u0027: False})"},{"line_number":380,"context_line":"        networks \u003d [network[\u0027id\u0027] for network in body[\u0027networks\u0027]]"},{"line_number":381,"context_line":"        if not networks:"},{"line_number":382,"context_line":"            raise lib_exc.InvalidConfiguration("},{"line_number":383,"context_line":"                \"This test requires that public network %s is configured as \""},{"line_number":384,"context_line":"                \"external and not shared.\""},{"line_number":385,"context_line":"                % CONF.network.public_network_id)"}],"source_content_type":"text/x-python","patch_set":4,"id":"7f287b81_29462f7e","line":382,"updated":"2017-08-23 17:26:16.000000000","message":"I don\u0027t think you want to fail in this case. This setup may be as intended by the cloud operator.\n\nI would say, if the network is shared, we should validate that subnets are seen; if it\u0027s not, that it\u0027s not seen. But not fail in any of those cases.","commit_id":"08c11f3cfed73e02db9e4af2efb7033c5e1bacb1"},{"author":{"_account_id":23709,"name":"Duc Truong","email":"dkt26111@gmail.com","username":"dtruong"},"change_message_id":"6b1c9febb925d45f3c2db504d25916565544f7d8","unresolved":false,"context_lines":[{"line_number":379,"context_line":"                                                     \u0027shared\u0027: False})"},{"line_number":380,"context_line":"        networks \u003d [network[\u0027id\u0027] for network in body[\u0027networks\u0027]]"},{"line_number":381,"context_line":"        if not networks:"},{"line_number":382,"context_line":"            raise lib_exc.InvalidConfiguration("},{"line_number":383,"context_line":"                \"This test requires that public network %s is configured as \""},{"line_number":384,"context_line":"                \"external and not shared.\""},{"line_number":385,"context_line":"                % CONF.network.public_network_id)"}],"source_content_type":"text/x-python","patch_set":4,"id":"7f287b81_fdf21e06","line":382,"in_reply_to":"7f287b81_29462f7e","updated":"2017-08-23 21:52:43.000000000","message":"Done","commit_id":"08c11f3cfed73e02db9e4af2efb7033c5e1bacb1"}]}