)]}'
{"tempest/common/isolated_creds.py":[{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"0927cfbc07a078b7b17caeb2cec51445a13741dc","unresolved":false,"context_lines":[{"line_number":93,"context_line":"            tenants \u003d self.identity_admin_client.tenants.list()"},{"line_number":94,"context_line":"            for ten in tenants:"},{"line_number":95,"context_line":"                if ten[\u0027name\u0027] \u003d\u003d name:"},{"line_number":96,"context_line":"                    return ten"},{"line_number":97,"context_line":"            raise exceptions.NotFound(\u0027No such tenant\u0027)"},{"line_number":98,"context_line":"        return tenant"},{"line_number":99,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAS3%2F%2Fbgw%3D","line":96,"updated":"2013-09-26 19:32:06.000000000","message":"why not just add a break that\u0027s all that is missing here.","commit_id":"03681d663dec0c49b2cae07d71a4fdc8924b70c4"},{"author":{"_account_id":8641,"name":"DennyZhang","email":"filebat.mark@gmail.com","username":"dennyzhang"},"change_message_id":"f921dfe3489ac5de6b8f785108ceefcec70c7795","unresolved":false,"context_lines":[{"line_number":93,"context_line":"            tenants \u003d self.identity_admin_client.tenants.list()"},{"line_number":94,"context_line":"            for ten in tenants:"},{"line_number":95,"context_line":"                if ten[\u0027name\u0027] \u003d\u003d name:"},{"line_number":96,"context_line":"                    return ten"},{"line_number":97,"context_line":"            raise exceptions.NotFound(\u0027No such tenant\u0027)"},{"line_number":98,"context_line":"        return tenant"},{"line_number":99,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAS3%2F%2FbfM%3D","line":96,"in_reply_to":"AAAAS3%2F%2Fbgw%3D","updated":"2013-09-26 19:41:17.000000000","message":"OK. For the suggested change, we may need several more code lines to do this.","commit_id":"03681d663dec0c49b2cae07d71a4fdc8924b70c4"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"5eeb3ff838486cbbfae0630bfbea4a26d6ff40db","unresolved":false,"context_lines":[{"line_number":90,"context_line":"        if self.tempest_client:"},{"line_number":91,"context_line":"            resp, tenant \u003d self.identity_admin_client.get_tenant_by_name(name)"},{"line_number":92,"context_line":"        else:"},{"line_number":93,"context_line":"            tenant \u003d None"},{"line_number":94,"context_line":"            tenants \u003d self.identity_admin_client.tenants.list()"},{"line_number":95,"context_line":"            for ten in tenants:"},{"line_number":96,"context_line":"                if ten[\u0027name\u0027] \u003d\u003d name:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAS3%2F%2FbeA%3D","line":93,"updated":"2013-09-26 19:47:59.000000000","message":"This isn\u0027t needed because you don\u0027t need the new if below.","commit_id":"46b445494c2d46de63d77977e435abf09cea37ee"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"5eeb3ff838486cbbfae0630bfbea4a26d6ff40db","unresolved":false,"context_lines":[{"line_number":96,"context_line":"                if ten[\u0027name\u0027] \u003d\u003d name:"},{"line_number":97,"context_line":"                    tenant \u003d ten"},{"line_number":98,"context_line":"                    break"},{"line_number":99,"context_line":"            if tenant is None:"},{"line_number":100,"context_line":"                raise exceptions.NotFound(\u0027No such tenant\u0027)"},{"line_number":101,"context_line":"        return tenant"},{"line_number":102,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAS3%2F%2FbeU%3D","line":99,"updated":"2013-09-26 19:47:59.000000000","message":"This isn\u0027t needed. The break above breaks out of the for loop, not the if block. (http://docs.python.org/2/tutorial/controlflow.html#break-and-continue-statements-and-else-clauses-on-loops) So if tenant is never set we raise the exception if it is set we break out of the for loop and return it.","commit_id":"46b445494c2d46de63d77977e435abf09cea37ee"},{"author":{"_account_id":8641,"name":"DennyZhang","email":"filebat.mark@gmail.com","username":"dennyzhang"},"change_message_id":"10c581d29771c2233be2a06f0a3cd46708b3efeb","unresolved":false,"context_lines":[{"line_number":96,"context_line":"                if ten[\u0027name\u0027] \u003d\u003d name:"},{"line_number":97,"context_line":"                    tenant \u003d ten"},{"line_number":98,"context_line":"                    break"},{"line_number":99,"context_line":"            if tenant is None:"},{"line_number":100,"context_line":"                raise exceptions.NotFound(\u0027No such tenant\u0027)"},{"line_number":101,"context_line":"        return tenant"},{"line_number":102,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAS3%2F%2Fbcs%3D","line":99,"in_reply_to":"AAAAS3%2F%2FbeU%3D","updated":"2013-09-26 20:06:15.000000000","message":"The clause of \"for...else... \" is very funcy. Haven\u0027t heard of this before, thanks.","commit_id":"46b445494c2d46de63d77977e435abf09cea37ee"}]}