)]}'
{"tempest/services/object_storage/bulk_middleware_client.py":[{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"65c6b1fbee53c570d43e902fe0771b54564805d0","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":"        if headers is None:"},{"line_number":45,"context_line":"            headers \u003d {}"},{"line_number":46,"context_line":"        resp, body \u003d self.delete(url, headers, data)"},{"line_number":47,"context_line":"        self.expected_success(200, resp.status)"},{"line_number":48,"context_line":"        return rest_client.ResponseBodyData(resp, body)"},{"line_number":49,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"ff346bd7_f72ff6f3","line":46,"range":{"start_line":46,"start_character":21,"end_line":46,"end_character":52},"updated":"2017-07-24 09:07:34.000000000","message":"This change seems unrelated, and I don\u0027t see the need for it. Since both headers and body are optional parameters, it is actually better not to rely on the order.","commit_id":"609298cce7c4878420a844de21158b9b5e7ca8fe"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"850f6566f750e796fdcac9b183aedac962d3f5ae","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":"        if headers is None:"},{"line_number":45,"context_line":"            headers \u003d {}"},{"line_number":46,"context_line":"        resp, body \u003d self.delete(url, headers, data)"},{"line_number":47,"context_line":"        self.expected_success(200, resp.status)"},{"line_number":48,"context_line":"        return rest_client.ResponseBodyData(resp, body)"},{"line_number":49,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"ff346bd7_5780028c","line":46,"range":{"start_line":46,"start_character":21,"end_line":46,"end_character":52},"in_reply_to":"ff346bd7_f72ff6f3","updated":"2017-07-24 09:12:45.000000000","message":"yea it does not matter but i modified it for consistency to other method of calling base methods.","commit_id":"609298cce7c4878420a844de21158b9b5e7ca8fe"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"65c6b1fbee53c570d43e902fe0771b54564805d0","unresolved":false,"context_lines":[{"line_number":57,"context_line":""},{"line_number":58,"context_line":"        if headers is None:"},{"line_number":59,"context_line":"            headers \u003d {}"},{"line_number":60,"context_line":"        resp, body \u003d self.post(url, data, headers)"},{"line_number":61,"context_line":"        self.expected_success([200, 204], resp.status)"},{"line_number":62,"context_line":"        return rest_client.ResponseBodyData(resp, body)"}],"source_content_type":"text/x-python","patch_set":3,"id":"ff346bd7_d782b2c8","line":60,"range":{"start_line":60,"start_character":21,"end_line":60,"end_character":50},"updated":"2017-07-24 09:07:34.000000000","message":"Ditto. data is mandatory here, but headers is not.","commit_id":"609298cce7c4878420a844de21158b9b5e7ca8fe"}],"tempest/tests/services/object_storage/test_bulk_middleware_client.py":[{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"a403380016a5937dff1b267089d868ca5ff8c3a1","unresolved":false,"context_lines":[{"line_number":56,"context_line":"            {},"},{"line_number":57,"context_line":"            mock_args\u003d[url, data, {}],"},{"line_number":58,"context_line":"            resp_as_string\u003dTrue,"},{"line_number":59,"context_line":"            data\u003ddata)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f1a1f67_ddfe5f6a","line":59,"updated":"2017-07-20 21:12:10.000000000","message":"status\u003d[200, 204] should be included.\n\nhttps://github.com/openstack/tempest/blob/724c86b02df46371210b2480a5c36afc47e19798/tempest/services/object_storage/bulk_middleware_client.py#L61","commit_id":"9837bea7fe06ec0989609457961917f2d1bc2b25"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"9e24f8af925f846b4c4c66650500b7eb101c8a59","unresolved":false,"context_lines":[{"line_number":56,"context_line":"            {},"},{"line_number":57,"context_line":"            mock_args\u003d[url, data, {}],"},{"line_number":58,"context_line":"            resp_as_string\u003dTrue,"},{"line_number":59,"context_line":"            data\u003ddata)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f1a1f67_80a19b98","line":59,"in_reply_to":"1f1a1f67_ddfe5f6a","updated":"2017-07-21 01:42:00.000000000","message":"yea, thanks. it does not work as list as of now. let\u0027s test with both possible code as returned by swift.","commit_id":"9837bea7fe06ec0989609457961917f2d1bc2b25"}]}
