)]}'
{"tempest/cmd/verify_tempest_config.py":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"0874e730f53e9a0d7be1c8dfbda2ec125c36d8a8","unresolved":false,"context_lines":[{"line_number":84,"context_line":"        try:"},{"line_number":85,"context_line":"            versions \u003d os.image_v2.VersionsClient().list_versions()[\u0027versions\u0027]"},{"line_number":86,"context_line":"            versions \u003d [x[\u0027id\u0027] for x in versions]"},{"line_number":87,"context_line":"        except lib_exc.NotFound:"},{"line_number":88,"context_line":"            msg \u003d (\u0027Glance is available in the catalog, but no known version, \u0027"},{"line_number":89,"context_line":"                   \u0027(v1.x or v2.x) of Glance could be found\u0027)"},{"line_number":90,"context_line":"            LOG.exception(msg)"},{"line_number":91,"context_line":"            raise"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    if CONF.image_feature_enabled.api_v1 !\u003d contains_version(\u0027v1.\u0027, versions):"},{"line_number":94,"context_line":"        print_and_or_update(\u0027api_v1\u0027, \u0027image-feature-enabled\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff346bd7_16094a2b","line":91,"range":{"start_line":87,"start_character":0,"end_line":91,"end_character":17},"updated":"2017-07-24 18:06:11.000000000","message":"I think we don\u0027t need to handle this NotFound case here.\nI could not image the situation unknown version of Glance like this msg and it would be enough to output raw exception without this error handling.","commit_id":"67beea65528feb16d3a94d16a4d25a3f911fc651"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"ecfe6a3a8a8a737f5cba8f8521fc4b37dcbd77ea","unresolved":false,"context_lines":[{"line_number":79,"context_line":"        # If not found, we use v2. The assumption is that either v1 or v2"},{"line_number":80,"context_line":"        # are available, since glance is marked as available in the catalog."},{"line_number":81,"context_line":"        # If not, the cloud catalog is broken, and there\u0027s no point trying"},{"line_number":82,"context_line":"        # to configure Tempest for a broken cloud."},{"line_number":83,"context_line":"        versions \u003d os.image_v2.VersionsClient().list_versions()[\u0027versions\u0027]"},{"line_number":84,"context_line":"        versions \u003d [x[\u0027id\u0027] for x in versions]"},{"line_number":85,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"df3967d1_9019ed89","line":82,"updated":"2017-07-28 22:56:41.000000000","message":"Well in the case where we\u0027re running tempest that\u0027s true. But for verifying the config we should handle this case and say CONF.service_available.glance should be set False","commit_id":"0e77d5a01859c98f444aecc4a2229e434d63308d"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"160dc3e670468752ccb59603e9b81d814c2160ee","unresolved":false,"context_lines":[{"line_number":79,"context_line":"        # If not found, we use v2. The assumption is that either v1 or v2"},{"line_number":80,"context_line":"        # are available, since glance is marked as available in the catalog."},{"line_number":81,"context_line":"        # If not, the cloud catalog is broken, and there\u0027s no point trying"},{"line_number":82,"context_line":"        # to configure Tempest for a broken cloud."},{"line_number":83,"context_line":"        versions \u003d os.image_v2.VersionsClient().list_versions()[\u0027versions\u0027]"},{"line_number":84,"context_line":"        versions \u003d [x[\u0027id\u0027] for x in versions]"},{"line_number":85,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"df3967d1_c89fbcb2","line":82,"in_reply_to":"df3967d1_9019ed89","updated":"2017-07-30 15:02:50.000000000","message":"Heh, this was my initial approach, so I\u0027ll put it back now.\n\nOne thing that\u0027s not clear to me though is way glance was treated differently from other services to begin with. The approach for other services is to remove the version from the path and do a GET. Wouldn\u0027t this work for glance as well?","commit_id":"0e77d5a01859c98f444aecc4a2229e434d63308d"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"a92c540ea073687b520a811c32ccbcaf73f31ae3","unresolved":false,"context_lines":[{"line_number":85,"context_line":"        except lib_exc.NotFound:"},{"line_number":86,"context_line":"            msg \u003d (\u0027Glance is available in the catalog, but no known version, \u0027"},{"line_number":87,"context_line":"                   \u0027(v1.x or v2.x) of Glance could be found, so Glance should \u0027"},{"line_number":88,"context_line":"                   \u0027be configured as not available\u0027)"},{"line_number":89,"context_line":"            LOG.exception(msg)"},{"line_number":90,"context_line":"            raise"},{"line_number":91,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"df3967d1_4ca11346","line":88,"updated":"2017-08-03 15:59:42.000000000","message":"This is closer, but it\u0027s still not correct because it\u0027s a fatal error. My earlier point was if we ever reach the case where glance is enabled but v1 and v2 are not avaailble that isn\u0027t a fatal condition. It\u0027s something that verify-tempest-config should reflect in the output, because glance is misconfigured on the cloud. This should remove the glance entry from the services list in main(). We definitely should still log an error or warning (except for maybe without the last sentence, because that\u0027ll be in the console output) because this is a very bizarre situation, but we shouldn\u0027t use LOG.exception or raise here.","commit_id":"c90a750971a81e69f88d077d195833011ef60afe"}]}