)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"32c7bd2907e0f1c2275cd767b3eeaebb52703817","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Adding testcase for dhcp agent scheduler"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Testcase for dhcp agent scheduler were missing."},{"line_number":10,"context_line":"At first stage api test to List DHCP agents hosting network is added."},{"line_number":11,"context_line":"part of blueprint: dhcp-agent-scheduler-api-testcases"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ide000eb7cc91186144ccae45938031d61063913f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"AAAATn%2F%2Fqq4%3D","line":10,"updated":"2013-10-30 16:53:34.000000000","message":"honestly, it is probably my fault but, what is this really testing or listing? the network serviced by a dhcp agent? the dhcp agents hosted on a particular network?","commit_id":"d7354a82ebc5129925b2947fe59aca378f47494c"}],"tempest/api/network/base.py":[{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"9428f01d34ec5647bd319a15ba6c5aabb73703a6","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        cls.network_cfg \u003d os.config.network"},{"line_number":53,"context_line":"        if not cls.config.service_available.neutron:"},{"line_number":54,"context_line":"            raise cls.skipException(\"Neutron support is required\")"},{"line_number":55,"context_line":"        cls.network_cfg \u003d os.config.network"},{"line_number":56,"context_line":"        cls.client \u003d os.network_client"},{"line_number":57,"context_line":"        cls.networks \u003d []"},{"line_number":58,"context_line":"        cls.subnets \u003d []"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAS3%2F%2FGA0%3D","line":55,"updated":"2013-10-04 14:44:57.000000000","message":"this appears a couple of lines upper already","commit_id":"634b73b3f7659afc48a35e14c5c64c09c6e86bb4"},{"author":{"_account_id":8205,"name":"Mh Raies","email":"raiesmh08@gmail.com","username":"raiesmh08"},"change_message_id":"5c84f02dcb56e0d422bdf566b19860967bf11d15","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        cls.network_cfg \u003d os.config.network"},{"line_number":53,"context_line":"        if not cls.config.service_available.neutron:"},{"line_number":54,"context_line":"            raise cls.skipException(\"Neutron support is required\")"},{"line_number":55,"context_line":"        cls.network_cfg \u003d os.config.network"},{"line_number":56,"context_line":"        cls.client \u003d os.network_client"},{"line_number":57,"context_line":"        cls.networks \u003d []"},{"line_number":58,"context_line":"        cls.subnets \u003d []"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAS3%2F%2FFfU%3D","line":55,"in_reply_to":"AAAAS3%2F%2FGA0%3D","updated":"2013-10-04 16:41:50.000000000","message":"Done","commit_id":"634b73b3f7659afc48a35e14c5c64c09c6e86bb4"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"02c8408e37e9422e08fd2346520ff26a3c07a0c4","unresolved":false,"context_lines":[{"line_number":259,"context_line":"    @classmethod"},{"line_number":260,"context_line":"    def setUpClass(cls):"},{"line_number":261,"context_line":"        super(BaseNetworkAdminTest, cls).setUpClass()"},{"line_number":262,"context_line":"        cls.adm_user \u003d cls.config.identity.admin_username"},{"line_number":263,"context_line":"        cls.adm_pass \u003d cls.config.identity.admin_password"},{"line_number":264,"context_line":"        cls.adm_tenant \u003d cls.config.identity.admin_tenant_name"},{"line_number":265,"context_line":"        if not all((cls.adm_user, cls.adm_pass, cls.adm_tenant)):"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATH%2F%2FLjE%3D","line":262,"updated":"2013-10-21 21:03:51.000000000","message":"While it\u0027s not needed now for the test you\u0027re adding here you should add isolated credential usage if tenant_isolation is turned on. This might be a requirement for future admin tests, and it\u0027ll be good to be consistent. \n\nI actually need to add this for the non-admin case above, I didn\u0027t realize it wasn\u0027t already there.","commit_id":"d7354a82ebc5129925b2947fe59aca378f47494c"}],"tempest/api/network/test_dhcp_agent_scheduler.py":[{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"9428f01d34ec5647bd319a15ba6c5aabb73703a6","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    \"\"\""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    @classmethod"},{"line_number":33,"context_line":"    def setUpClass(cls):"},{"line_number":34,"context_line":"        super(DhcpAgentSchedulerTest, cls).setUpClass()"},{"line_number":35,"context_line":"        cls.network_cfg \u003d cls.network_cfg"},{"line_number":36,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAS3%2F%2FGAs%3D","line":33,"updated":"2013-10-04 14:44:57.000000000","message":"you don\u0027t seem to need any setUpClass at all","commit_id":"634b73b3f7659afc48a35e14c5c64c09c6e86bb4"},{"author":{"_account_id":8205,"name":"Mh Raies","email":"raiesmh08@gmail.com","username":"raiesmh08"},"change_message_id":"5c84f02dcb56e0d422bdf566b19860967bf11d15","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    \"\"\""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    @classmethod"},{"line_number":33,"context_line":"    def setUpClass(cls):"},{"line_number":34,"context_line":"        super(DhcpAgentSchedulerTest, cls).setUpClass()"},{"line_number":35,"context_line":"        cls.network_cfg \u003d cls.network_cfg"},{"line_number":36,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAS3%2F%2FFfY%3D","line":33,"in_reply_to":"AAAAS3%2F%2FGAs%3D","updated":"2013-10-04 16:41:50.000000000","message":"Done","commit_id":"634b73b3f7659afc48a35e14c5c64c09c6e86bb4"}],"tempest/services/network/json/network_client.py":[{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"9428f01d34ec5647bd319a15ba6c5aabb73703a6","unresolved":false,"context_lines":[{"line_number":601,"context_line":"        body \u003d json.loads(body)"},{"line_number":602,"context_line":"        return resp, body"},{"line_number":603,"context_line":""},{"line_number":604,"context_line":"    def list_dhcp_agents_hosting_network(self, net_id):"},{"line_number":605,"context_line":"        uri \u003d \u0027%s/networks/%s/dhcp-agents\u0027 % (self.uri_prefix, net_id)"},{"line_number":606,"context_line":"        resp, body \u003d self.get(uri, self.headers)"},{"line_number":607,"context_line":"        body \u003d json.loads(body)"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAS3%2F%2FGAE%3D","line":604,"updated":"2013-10-04 14:44:57.000000000","message":"All these methods are valuable but I think the idea is to add these only together with tests using them so this is the only method you can keep here for now","commit_id":"634b73b3f7659afc48a35e14c5c64c09c6e86bb4"},{"author":{"_account_id":8205,"name":"Mh Raies","email":"raiesmh08@gmail.com","username":"raiesmh08"},"change_message_id":"5c84f02dcb56e0d422bdf566b19860967bf11d15","unresolved":false,"context_lines":[{"line_number":601,"context_line":"        body \u003d json.loads(body)"},{"line_number":602,"context_line":"        return resp, body"},{"line_number":603,"context_line":""},{"line_number":604,"context_line":"    def list_dhcp_agents_hosting_network(self, net_id):"},{"line_number":605,"context_line":"        uri \u003d \u0027%s/networks/%s/dhcp-agents\u0027 % (self.uri_prefix, net_id)"},{"line_number":606,"context_line":"        resp, body \u003d self.get(uri, self.headers)"},{"line_number":607,"context_line":"        body \u003d json.loads(body)"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAS3%2F%2FFfg%3D","line":604,"in_reply_to":"AAAAS3%2F%2FGAE%3D","updated":"2013-10-04 16:41:50.000000000","message":"In further patches I will implement testcases related to these methods also. So I think these are valid here.","commit_id":"634b73b3f7659afc48a35e14c5c64c09c6e86bb4"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"6d188bee6628c894a243a836f47338b10569f0f6","unresolved":false,"context_lines":[{"line_number":607,"context_line":"        body \u003d json.loads(body)"},{"line_number":608,"context_line":"        return resp, body"},{"line_number":609,"context_line":""},{"line_number":610,"context_line":"    def list_networks_hosted_by_one_dhcp_agent(self, agent_id):"},{"line_number":611,"context_line":"        uri \u003d \u0027%s/agents/%s/dhcp-networks\u0027 % (self.uri_prefix, agent_id)"},{"line_number":612,"context_line":"        resp, body \u003d self.get(uri, self.headers)"},{"line_number":613,"context_line":"        body \u003d json.loads(body)"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAATH%2F%2F9%2BU%3D","line":610,"updated":"2013-10-07 10:31:31.000000000","message":"please tie this together with some tests or strip it from this patchset and later submit it with another submission together with the tests","commit_id":"e680baa35edea7f132e53d512062f2cddc74ab3f"},{"author":{"_account_id":8205,"name":"Mh Raies","email":"raiesmh08@gmail.com","username":"raiesmh08"},"change_message_id":"055c76efd43e429917ef370ff3273b4879b95f09","unresolved":false,"context_lines":[{"line_number":607,"context_line":"        body \u003d json.loads(body)"},{"line_number":608,"context_line":"        return resp, body"},{"line_number":609,"context_line":""},{"line_number":610,"context_line":"    def list_networks_hosted_by_one_dhcp_agent(self, agent_id):"},{"line_number":611,"context_line":"        uri \u003d \u0027%s/agents/%s/dhcp-networks\u0027 % (self.uri_prefix, agent_id)"},{"line_number":612,"context_line":"        resp, body \u003d self.get(uri, self.headers)"},{"line_number":613,"context_line":"        body \u003d json.loads(body)"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAATH%2F%2FTBg%3D","line":610,"in_reply_to":"AAAATH%2F%2F9%2BU%3D","updated":"2013-10-18 07:08:25.000000000","message":"Done","commit_id":"e680baa35edea7f132e53d512062f2cddc74ab3f"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"6d188bee6628c894a243a836f47338b10569f0f6","unresolved":false,"context_lines":[{"line_number":613,"context_line":"        body \u003d json.loads(body)"},{"line_number":614,"context_line":"        return resp, body"},{"line_number":615,"context_line":""},{"line_number":616,"context_line":"    def schedule_network_to_dhcp_agent(self, agent_id, net_id):"},{"line_number":617,"context_line":"        uri \u003d \u0027%s/agents/%s/dhcp-networks\u0027 % (self.uri_prefix, agent_id)"},{"line_number":618,"context_line":"        post_body \u003d {\u0027network_id\u0027: net_id}"},{"line_number":619,"context_line":"        body \u003d json.dumps(post_body)"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAATH%2F%2F9%2BQ%3D","line":616,"updated":"2013-10-07 10:31:31.000000000","message":"tests missing","commit_id":"e680baa35edea7f132e53d512062f2cddc74ab3f"},{"author":{"_account_id":8205,"name":"Mh Raies","email":"raiesmh08@gmail.com","username":"raiesmh08"},"change_message_id":"055c76efd43e429917ef370ff3273b4879b95f09","unresolved":false,"context_lines":[{"line_number":613,"context_line":"        body \u003d json.loads(body)"},{"line_number":614,"context_line":"        return resp, body"},{"line_number":615,"context_line":""},{"line_number":616,"context_line":"    def schedule_network_to_dhcp_agent(self, agent_id, net_id):"},{"line_number":617,"context_line":"        uri \u003d \u0027%s/agents/%s/dhcp-networks\u0027 % (self.uri_prefix, agent_id)"},{"line_number":618,"context_line":"        post_body \u003d {\u0027network_id\u0027: net_id}"},{"line_number":619,"context_line":"        body \u003d json.dumps(post_body)"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAATH%2F%2FTBc%3D","line":616,"in_reply_to":"AAAATH%2F%2F9%2BQ%3D","updated":"2013-10-18 07:08:25.000000000","message":"Done","commit_id":"e680baa35edea7f132e53d512062f2cddc74ab3f"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"6d188bee6628c894a243a836f47338b10569f0f6","unresolved":false,"context_lines":[{"line_number":622,"context_line":"        return resp, body"},{"line_number":623,"context_line":""},{"line_number":624,"context_line":"    def remove_network_from_dhcp_agent(self, agent_id, net_id):"},{"line_number":625,"context_line":"        uri \u003d \u0027%s/agents/%s/dhcp-networks/%s\u0027 % (self.uri_prefix,"},{"line_number":626,"context_line":"                                                 agent_id, net_id)"},{"line_number":627,"context_line":"        resp, body \u003d self.delete(uri, self.headers)"},{"line_number":628,"context_line":"        return resp, body"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAATH%2F%2F9%2BM%3D","line":625,"updated":"2013-10-07 10:31:31.000000000","message":"tests missing","commit_id":"e680baa35edea7f132e53d512062f2cddc74ab3f"},{"author":{"_account_id":8205,"name":"Mh Raies","email":"raiesmh08@gmail.com","username":"raiesmh08"},"change_message_id":"055c76efd43e429917ef370ff3273b4879b95f09","unresolved":false,"context_lines":[{"line_number":622,"context_line":"        return resp, body"},{"line_number":623,"context_line":""},{"line_number":624,"context_line":"    def remove_network_from_dhcp_agent(self, agent_id, net_id):"},{"line_number":625,"context_line":"        uri \u003d \u0027%s/agents/%s/dhcp-networks/%s\u0027 % (self.uri_prefix,"},{"line_number":626,"context_line":"                                                 agent_id, net_id)"},{"line_number":627,"context_line":"        resp, body \u003d self.delete(uri, self.headers)"},{"line_number":628,"context_line":"        return resp, body"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAATH%2F%2FTBU%3D","line":625,"in_reply_to":"AAAATH%2F%2F9%2BM%3D","updated":"2013-10-18 07:08:25.000000000","message":"Done","commit_id":"e680baa35edea7f132e53d512062f2cddc74ab3f"}]}