)]}'
{"releasenotes/notes/fix-remoteclient-default-ssh-shell-prologue-WHATNUMBERSHOULDGOHERE.yaml":[{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"f703b718f0ea70acd2d17cd43952f1ce4029dbe3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"9f436f4f_a9c67548","updated":"2017-08-22 02:35:11.000000000","message":"You need to use reno to generate a release note. Here\u0027s the user-guide https://docs.openstack.org/reno/latest/user/usage.html","commit_id":"1c4c2687e9e5a7d8f454bb48de39b38da5ca9c39"},{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"f703b718f0ea70acd2d17cd43952f1ce4029dbe3","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |\r"},{"line_number":4,"context_line":"    Fix RemoteClient default ssh_shell_prologue: Bug#1707478\r"},{"line_number":5,"context_line":"\r"},{"line_number":6,"context_line":"    The default ssh_shell_proloque has been modified from\r"},{"line_number":7,"context_line":"    specifying erroneous PATH\u003d$$PATH:/sbin to PATH\u003d$PATH:/sbin."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"9f436f4f_89c5f13e","line":6,"updated":"2017-08-22 02:35:11.000000000","message":"It seems like there are some carriage returns(0d). Could you check your git config and/or editor\u0027s setting?","commit_id":"1c4c2687e9e5a7d8f454bb48de39b38da5ca9c39"}],"tempest/lib/common/utils/linux/remote_client.py":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"06722687735c8753e571ac9cf89e2f1b7d6aed9c","unresolved":false,"context_lines":[{"line_number":67,"context_line":"    def __init__(self, ip_address, username, password\u003dNone, pkey\u003dNone,"},{"line_number":68,"context_line":"                 server\u003dNone, servers_client\u003dNone, ssh_timeout\u003d300,"},{"line_number":69,"context_line":"                 connect_timeout\u003d60, console_output_enabled\u003dTrue,"},{"line_number":70,"context_line":"                 ssh_shell_prologue\u003d\"set -eu -o pipefail; PATH\u003d$PATH:/sbin;\","},{"line_number":71,"context_line":"                 ping_count\u003d1, ping_size\u003d56):"},{"line_number":72,"context_line":"        \"\"\"Executes commands in a VM over ssh"},{"line_number":73,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"bf3e73b7_cc18e0d4","line":70,"range":{"start_line":70,"start_character":36,"end_line":70,"end_character":76},"updated":"2017-08-07 18:32:14.000000000","message":"This seems a valid change which is the same as the original code of I7693911e6b883a21baafe6f804564754ebaea5e0\n\n      def exec_command(self, cmd):\n +        # Shell options below add more clearness on failures,\n +        # path is extended for some non-cirros guest oses (centos7)\n +        cmd \u003d \"set -eu -o pipefail; PATH\u003d$PATH:/sbin; \" + cmd\n          return self.ssh_client.exec_command(cmd)\n\nAnd current config value which contains double $s seems right because of I669dd4386ffb539dad88a9487bef6c172b5d65fa which adds double $s intentionally.\n\nSo LGTM","commit_id":"b330b1971d1f8b45397342e68559da4d49b6acb4"}]}