)]}'
{"tempest/api/identity/admin/v3/test_roles.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"42110c0010e541ada6999f921dbccce6d65327f6","unresolved":false,"context_lines":[{"line_number":100,"context_line":"            self.project[\u0027id\u0027], self.user_body[\u0027id\u0027])[\u0027roles\u0027]"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"        self.assertEqual(1, len(roles))"},{"line_number":103,"context_line":"        self.assertEqual(self.role[\u0027id\u0027], roles[0][\u0027id\u0027])"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"        self.roles_client.check_user_role_existence_on_project("},{"line_number":106,"context_line":"            self.project[\u0027id\u0027], self.user_body[\u0027id\u0027], self.role[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"df3967d1_b250390c","line":103,"range":{"start_line":103,"start_character":8,"end_line":103,"end_character":57},"updated":"2017-08-02 06:32:51.000000000","message":"it is not always necessary that assigned role will be first in list. we should check assertIn here instead of assertEqual.","commit_id":"628642b8b8fd5e0af7c4e221d15d7e2e432ef31c"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"65ea26c88cf00c3f660e0df04bf94bbd262dde40","unresolved":false,"context_lines":[{"line_number":100,"context_line":"            self.project[\u0027id\u0027], self.user_body[\u0027id\u0027])[\u0027roles\u0027]"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"        self.assertEqual(1, len(roles))"},{"line_number":103,"context_line":"        self.assertEqual(self.role[\u0027id\u0027], roles[0][\u0027id\u0027])"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"        self.roles_client.check_user_role_existence_on_project("},{"line_number":106,"context_line":"            self.project[\u0027id\u0027], self.user_body[\u0027id\u0027], self.role[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"df3967d1_38bd24d8","line":103,"range":{"start_line":103,"start_character":8,"end_line":103,"end_character":57},"in_reply_to":"df3967d1_919e3352","updated":"2017-08-02 09:14:44.000000000","message":"yea you are right. i missed the len check","commit_id":"628642b8b8fd5e0af7c4e221d15d7e2e432ef31c"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"0231383f88190e5f75f1c7c1816743c3818a3f8d","unresolved":false,"context_lines":[{"line_number":100,"context_line":"            self.project[\u0027id\u0027], self.user_body[\u0027id\u0027])[\u0027roles\u0027]"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"        self.assertEqual(1, len(roles))"},{"line_number":103,"context_line":"        self.assertEqual(self.role[\u0027id\u0027], roles[0][\u0027id\u0027])"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"        self.roles_client.check_user_role_existence_on_project("},{"line_number":106,"context_line":"            self.project[\u0027id\u0027], self.user_body[\u0027id\u0027], self.role[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"df3967d1_919e3352","line":103,"range":{"start_line":103,"start_character":8,"end_line":103,"end_character":57},"in_reply_to":"df3967d1_b250390c","updated":"2017-08-02 06:39:14.000000000","message":"Thanks gmann, here the lenth of roles is 1, so we can use assertEqual. \nAnd if we use assertIn, we will have more complicated code, something like:\nself.assertIn(self.role[\u0027id\u0027], [role[\u0027id\u0027] for role in roles])","commit_id":"628642b8b8fd5e0af7c4e221d15d7e2e432ef31c"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"42110c0010e541ada6999f921dbccce6d65327f6","unresolved":false,"context_lines":[{"line_number":117,"context_line":"            self.domain[\u0027id\u0027], self.user_body[\u0027id\u0027])[\u0027roles\u0027]"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"        self.assertEqual(1, len(roles))"},{"line_number":120,"context_line":"        self.assertEqual(self.role[\u0027id\u0027], roles[0][\u0027id\u0027])"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"        self.roles_client.check_user_role_existence_on_domain("},{"line_number":123,"context_line":"            self.domain[\u0027id\u0027], self.user_body[\u0027id\u0027], self.role[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"df3967d1_124b8559","line":120,"range":{"start_line":120,"start_character":7,"end_line":120,"end_character":57},"updated":"2017-08-02 06:32:51.000000000","message":"ditto","commit_id":"628642b8b8fd5e0af7c4e221d15d7e2e432ef31c"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"42110c0010e541ada6999f921dbccce6d65327f6","unresolved":false,"context_lines":[{"line_number":135,"context_line":"            self.project[\u0027id\u0027], self.group_body[\u0027id\u0027])[\u0027roles\u0027]"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"        self.assertEqual(1, len(roles))"},{"line_number":138,"context_line":"        self.assertEqual(self.role[\u0027id\u0027], roles[0][\u0027id\u0027])"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"        # Add user to group, and insure user has role on project"},{"line_number":141,"context_line":"        self.groups_client.add_group_user(self.group_body[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"df3967d1_f245a144","line":138,"range":{"start_line":138,"start_character":0,"end_line":138,"end_character":57},"updated":"2017-08-02 06:32:51.000000000","message":"ditto","commit_id":"628642b8b8fd5e0af7c4e221d15d7e2e432ef31c"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"42110c0010e541ada6999f921dbccce6d65327f6","unresolved":false,"context_lines":[{"line_number":167,"context_line":"            self.domain[\u0027id\u0027], self.group_body[\u0027id\u0027])[\u0027roles\u0027]"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"        self.assertEqual(1, len(roles))"},{"line_number":170,"context_line":"        self.assertEqual(self.role[\u0027id\u0027], roles[0][\u0027id\u0027])"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"        self.roles_client.check_role_from_group_on_domain_existence("},{"line_number":173,"context_line":"            self.domain[\u0027id\u0027], self.group_body[\u0027id\u0027], self.role[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"df3967d1_b2795994","line":170,"range":{"start_line":170,"start_character":0,"end_line":170,"end_character":57},"updated":"2017-08-02 06:32:51.000000000","message":"ditto","commit_id":"628642b8b8fd5e0af7c4e221d15d7e2e432ef31c"}]}