)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10608,"name":"Matthew Edmonds","email":"edmondsw@us.ibm.com","username":"edmondsw"},"change_message_id":"96b0a2638027ca35efccaa77a90cdd061e025991","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fix identity tests when domain specific drivers and LDAP are enabled"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This updates users and groups identity tests to check the"},{"line_number":10,"context_line":"existance of LDAP domain specific drivers and, therefore,"},{"line_number":11,"context_line":"the existance of users and groups on different domain drivers."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This adds a new feature flag to be used when LDAP domain specific"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9f436f4f_8a8b3666","line":10,"range":{"start_line":10,"start_character":13,"end_line":10,"end_character":41},"updated":"2017-08-15 18:56:02.000000000","message":"does LDAP really have anything to do with this? I thought the changes here had everything to do with domain-specific drivers, whether or not any of those drivers were LDAP.","commit_id":"104e4a9a139b853c2049cfd1d8d7f2f3ed895f5a"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"e5481c3fab6e2320efe173aff38a3cca99984593","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fix identity tests when domain specific drivers and LDAP are enabled"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This updates users and groups identity tests to check the"},{"line_number":10,"context_line":"existance of LDAP domain specific drivers and, therefore,"},{"line_number":11,"context_line":"the existance of users and groups on different domain drivers."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This adds a new feature flag to be used when LDAP domain specific"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9f436f4f_c93f0b85","line":10,"range":{"start_line":10,"start_character":13,"end_line":10,"end_character":41},"in_reply_to":"9f436f4f_8a8b3666","updated":"2017-08-15 20:27:05.000000000","message":"the plugin is mixed, and the only way of setting up LDAP backend is with domain specific drivers so I think it is fine.","commit_id":"104e4a9a139b853c2049cfd1d8d7f2f3ed895f5a"},{"author":{"_account_id":25651,"name":"Leticia Wanderley","email":"leticiafwanderley@gmail.com","username":"lwanderley"},"change_message_id":"9ba67ff8fd8b51a1ad0d24cfc4fba012211df726","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fix identity tests when domain specific drivers and LDAP are enabled"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This updates users and groups identity tests to check the"},{"line_number":10,"context_line":"existance of LDAP domain specific drivers and, therefore,"},{"line_number":11,"context_line":"the existance of users and groups on different domain drivers."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This adds a new feature flag to be used when LDAP domain specific"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9f436f4f_8dcd79b8","line":10,"range":{"start_line":10,"start_character":13,"end_line":10,"end_character":41},"in_reply_to":"9f436f4f_9c9dad0b","updated":"2017-08-16 15:00:27.000000000","message":"Done","commit_id":"104e4a9a139b853c2049cfd1d8d7f2f3ed895f5a"},{"author":{"_account_id":25651,"name":"Leticia Wanderley","email":"leticiafwanderley@gmail.com","username":"lwanderley"},"change_message_id":"b4701347c4d7db49c6d486dc5ddfd7c26bbbecb9","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fix identity tests when domain specific drivers and LDAP are enabled"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This updates users and groups identity tests to check the"},{"line_number":10,"context_line":"existance of LDAP domain specific drivers and, therefore,"},{"line_number":11,"context_line":"the existance of users and groups on different domain drivers."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This adds a new feature flag to be used when LDAP domain specific"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9f436f4f_07f72a5b","line":10,"range":{"start_line":10,"start_character":13,"end_line":10,"end_character":41},"in_reply_to":"9f436f4f_9c9dad0b","updated":"2017-08-16 14:20:13.000000000","message":"I think that makes a lot of sense, I\u0027ll rename it now and update the commit message. Thanks for the review.","commit_id":"104e4a9a139b853c2049cfd1d8d7f2f3ed895f5a"},{"author":{"_account_id":10608,"name":"Matthew Edmonds","email":"edmondsw@us.ibm.com","username":"edmondsw"},"change_message_id":"f4c9d26b171c8d24be99824ff208c6251af29706","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fix identity tests when domain specific drivers and LDAP are enabled"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This updates users and groups identity tests to check the"},{"line_number":10,"context_line":"existance of LDAP domain specific drivers and, therefore,"},{"line_number":11,"context_line":"the existance of users and groups on different domain drivers."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This adds a new feature flag to be used when LDAP domain specific"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9f436f4f_cfca6b9f","line":10,"range":{"start_line":10,"start_character":13,"end_line":10,"end_character":41},"in_reply_to":"9f436f4f_c93f0b85","updated":"2017-08-15 22:03:05.000000000","message":"I\u0027m not sure that\u0027s true, but regardless, I\u0027m looking at it from the opposite direction... isn\u0027t this needed for configs with domain-specific drivers without LDAP?","commit_id":"104e4a9a139b853c2049cfd1d8d7f2f3ed895f5a"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"4daade02d846495e7ed9058989bb6d1abfd722cd","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fix identity tests when domain specific drivers and LDAP are enabled"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This updates users and groups identity tests to check the"},{"line_number":10,"context_line":"existance of LDAP domain specific drivers and, therefore,"},{"line_number":11,"context_line":"the existance of users and groups on different domain drivers."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This adds a new feature flag to be used when LDAP domain specific"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9f436f4f_fcb83911","line":10,"range":{"start_line":10,"start_character":13,"end_line":10,"end_character":41},"in_reply_to":"9f436f4f_cfca6b9f","updated":"2017-08-16 13:28:29.000000000","message":"but we don\u0027t have a `domain specific drivers` only plugin, we have it as a result from the LDAP plugin install. But I get your point, maybe change to \"LDAP plugin that uses domain specific drivers\".","commit_id":"104e4a9a139b853c2049cfd1d8d7f2f3ed895f5a"},{"author":{"_account_id":10608,"name":"Matthew Edmonds","email":"edmondsw@us.ibm.com","username":"edmondsw"},"change_message_id":"389b6e494ced0ea485ca4bc03b10adca10cb54c9","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fix identity tests when domain specific drivers and LDAP are enabled"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This updates users and groups identity tests to check the"},{"line_number":10,"context_line":"existance of LDAP domain specific drivers and, therefore,"},{"line_number":11,"context_line":"the existance of users and groups on different domain drivers."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This adds a new feature flag to be used when LDAP domain specific"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9f436f4f_9c9dad0b","line":10,"range":{"start_line":10,"start_character":13,"end_line":10,"end_character":41},"in_reply_to":"9f436f4f_fcb83911","updated":"2017-08-16 13:49:19.000000000","message":"Could we rename the tempest conf option from ldap_enabled to domain_specific_identity_enabled? And then of course devstack can set this when it has ldap enabled, but it could also be set in other cases in future.","commit_id":"104e4a9a139b853c2049cfd1d8d7f2f3ed895f5a"},{"author":{"_account_id":25651,"name":"Leticia Wanderley","email":"leticiafwanderley@gmail.com","username":"lwanderley"},"change_message_id":"9ba67ff8fd8b51a1ad0d24cfc4fba012211df726","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fix identity tests when domain specific drivers and LDAP are enabled"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This updates users and groups identity tests to check the"},{"line_number":10,"context_line":"existance of LDAP domain specific drivers and, therefore,"},{"line_number":11,"context_line":"the existance of users and groups on different domain drivers."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This adds a new feature flag to be used when LDAP domain specific"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9f436f4f_4dc3118a","line":10,"range":{"start_line":10,"start_character":13,"end_line":10,"end_character":41},"in_reply_to":"9f436f4f_fcb83911","updated":"2017-08-16 15:00:27.000000000","message":"Done","commit_id":"104e4a9a139b853c2049cfd1d8d7f2f3ed895f5a"},{"author":{"_account_id":10608,"name":"Matthew Edmonds","email":"edmondsw@us.ibm.com","username":"edmondsw"},"change_message_id":"50037e626d45bed68fbd70234ec7bf1d2333412b","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix identity tests when domain specific drivers are enabled"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This updates users and groups identity tests to check the existance"},{"line_number":10,"context_line":"of domain specific drivers and, therefore, the existance of users"},{"line_number":11,"context_line":"and groups on different domain drivers."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"9f436f4f_a8f14b03","line":9,"range":{"start_line":9,"start_character":58,"end_line":9,"end_character":67},"updated":"2017-08-16 15:31:00.000000000","message":"existence*","commit_id":"35892206c5ce071586286c104da612a27d91ed5a"},{"author":{"_account_id":25651,"name":"Leticia Wanderley","email":"leticiafwanderley@gmail.com","username":"lwanderley"},"change_message_id":"006d27c8477fc0725a276500bdd70fa8279241e6","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix identity tests when domain specific drivers are enabled"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This updates users and groups identity tests to check the existance"},{"line_number":10,"context_line":"of domain specific drivers and, therefore, the existance of users"},{"line_number":11,"context_line":"and groups on different domain drivers."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"9f436f4f_468bebc1","line":9,"range":{"start_line":9,"start_character":58,"end_line":9,"end_character":67},"in_reply_to":"9f436f4f_a8f14b03","updated":"2017-08-16 20:55:42.000000000","message":"Done","commit_id":"35892206c5ce071586286c104da612a27d91ed5a"},{"author":{"_account_id":10608,"name":"Matthew Edmonds","email":"edmondsw@us.ibm.com","username":"edmondsw"},"change_message_id":"50037e626d45bed68fbd70234ec7bf1d2333412b","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fix identity tests when domain specific drivers are enabled"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This updates users and groups identity tests to check the existance"},{"line_number":10,"context_line":"of domain specific drivers and, therefore, the existance of users"},{"line_number":11,"context_line":"and groups on different domain drivers."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This adds a new feature flag to be used when domain specific drivers"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"9f436f4f_88f447f2","line":10,"range":{"start_line":10,"start_character":47,"end_line":10,"end_character":56},"updated":"2017-08-16 15:31:00.000000000","message":"ditto","commit_id":"35892206c5ce071586286c104da612a27d91ed5a"},{"author":{"_account_id":25651,"name":"Leticia Wanderley","email":"leticiafwanderley@gmail.com","username":"lwanderley"},"change_message_id":"006d27c8477fc0725a276500bdd70fa8279241e6","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fix identity tests when domain specific drivers are enabled"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This updates users and groups identity tests to check the existance"},{"line_number":10,"context_line":"of domain specific drivers and, therefore, the existance of users"},{"line_number":11,"context_line":"and groups on different domain drivers."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This adds a new feature flag to be used when domain specific drivers"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"9f436f4f_2686a7ba","line":10,"range":{"start_line":10,"start_character":47,"end_line":10,"end_character":56},"in_reply_to":"9f436f4f_88f447f2","updated":"2017-08-16 20:55:42.000000000","message":"Done","commit_id":"35892206c5ce071586286c104da612a27d91ed5a"}],"releasenotes/notes/identity-tests-domain-drivers-76235f6672221e45.yaml":[{"author":{"_account_id":10608,"name":"Matthew Edmonds","email":"edmondsw@us.ibm.com","username":"edmondsw"},"change_message_id":"fe0e6fbedff533e8e3ea2ddc40b1aa232c536aff","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    When dealing with specific domain drivers, a flag on user"},{"line_number":5,"context_line":"    and groups identity tests allows the retrieval of objects"},{"line_number":6,"context_line":"    from multiple domains."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9f436f4f_c570f042","line":4,"updated":"2017-08-16 21:24:37.000000000","message":"you\u0027d better indicate what that flag is, and what conf group it goes into.","commit_id":"f0c1ac677222f05193be275f58c5f15d3a0cd4c4"},{"author":{"_account_id":10608,"name":"Matthew Edmonds","email":"edmondsw@us.ibm.com","username":"edmondsw"},"change_message_id":"82a4c5168c8d50ef3380d8f6177e42c13e670e9d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    When dealing with specific domain drivers,"},{"line_number":5,"context_line":"    the flag ``domain_specific_drivers``, from "}],"source_content_type":"text/x-yaml","patch_set":8,"id":"9f436f4f_e3451a17","line":2,"updated":"2017-08-17 14:45:50.000000000","message":"I think this should probably be \"features\". We\u0027re adding something new here. And that\u0027s what has been done with other new conf options if you look at some of the existing release notes.","commit_id":"2c4a649fee7f66905cefa2b1bc2e59e053fa2dcf"},{"author":{"_account_id":25651,"name":"Leticia Wanderley","email":"leticiafwanderley@gmail.com","username":"lwanderley"},"change_message_id":"c24b193cca50b42fc83c312412fd6707a860c6c1","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    When dealing with specific domain drivers,"},{"line_number":5,"context_line":"    the flag ``domain_specific_drivers``, from "}],"source_content_type":"text/x-yaml","patch_set":8,"id":"9f436f4f_c91fd5b5","line":2,"in_reply_to":"9f436f4f_e3451a17","updated":"2017-08-17 16:24:37.000000000","message":"Done","commit_id":"2c4a649fee7f66905cefa2b1bc2e59e053fa2dcf"},{"author":{"_account_id":10608,"name":"Matthew Edmonds","email":"edmondsw@us.ibm.com","username":"edmondsw"},"change_message_id":"82a4c5168c8d50ef3380d8f6177e42c13e670e9d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    When dealing with specific domain drivers,"},{"line_number":5,"context_line":"    the flag ``domain_specific_drivers``, from "},{"line_number":6,"context_line":"    ``identity_feature_enabled`` conf group,"},{"line_number":7,"context_line":"    on user and groups identity tests allows the retrieval of"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"9f436f4f_e31cfa14","line":4,"updated":"2017-08-17 14:45:50.000000000","message":"This is kinda hard to read... how about something like:\n\nA new boolean config option ``domain_specific_drivers`` is added to the section ``identity-feature-enabled``. This option must be enabled when testing an environment that is configured to use domain-specific identity drivers.","commit_id":"2c4a649fee7f66905cefa2b1bc2e59e053fa2dcf"},{"author":{"_account_id":25651,"name":"Leticia Wanderley","email":"leticiafwanderley@gmail.com","username":"lwanderley"},"change_message_id":"c24b193cca50b42fc83c312412fd6707a860c6c1","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    When dealing with specific domain drivers,"},{"line_number":5,"context_line":"    the flag ``domain_specific_drivers``, from "},{"line_number":6,"context_line":"    ``identity_feature_enabled`` conf group,"},{"line_number":7,"context_line":"    on user and groups identity tests allows the retrieval of"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"9f436f4f_69f34975","line":4,"in_reply_to":"9f436f4f_e31cfa14","updated":"2017-08-17 16:24:37.000000000","message":"Done\nThanks for the comment.\nI also added a line about the tests that are changed on this release note.","commit_id":"2c4a649fee7f66905cefa2b1bc2e59e053fa2dcf"},{"author":{"_account_id":10608,"name":"Matthew Edmonds","email":"edmondsw@us.ibm.com","username":"edmondsw"},"change_message_id":"82a4c5168c8d50ef3380d8f6177e42c13e670e9d","unresolved":false,"context_lines":[{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    When dealing with specific domain drivers,"},{"line_number":5,"context_line":"    the flag ``domain_specific_drivers``, from "},{"line_number":6,"context_line":"    ``identity_feature_enabled`` conf group,"},{"line_number":7,"context_line":"    on user and groups identity tests allows the retrieval of"},{"line_number":8,"context_line":"    objects from multiple domains."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"9f436f4f_e3c07a7f","line":5,"range":{"start_line":5,"start_character":42,"end_line":5,"end_character":47},"updated":"2017-08-17 14:45:50.000000000","message":"can\u0027t end the line with a space","commit_id":"2c4a649fee7f66905cefa2b1bc2e59e053fa2dcf"},{"author":{"_account_id":25651,"name":"Leticia Wanderley","email":"leticiafwanderley@gmail.com","username":"lwanderley"},"change_message_id":"c24b193cca50b42fc83c312412fd6707a860c6c1","unresolved":false,"context_lines":[{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    When dealing with specific domain drivers,"},{"line_number":5,"context_line":"    the flag ``domain_specific_drivers``, from "},{"line_number":6,"context_line":"    ``identity_feature_enabled`` conf group,"},{"line_number":7,"context_line":"    on user and groups identity tests allows the retrieval of"},{"line_number":8,"context_line":"    objects from multiple domains."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"9f436f4f_a91c91c1","line":5,"range":{"start_line":5,"start_character":42,"end_line":5,"end_character":47},"in_reply_to":"9f436f4f_e3c07a7f","updated":"2017-08-17 16:24:37.000000000","message":"Done","commit_id":"2c4a649fee7f66905cefa2b1bc2e59e053fa2dcf"},{"author":{"_account_id":10608,"name":"Matthew Edmonds","email":"edmondsw@us.ibm.com","username":"edmondsw"},"change_message_id":"5426ff351d6379b06d299828390b21113da94014","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    is added to the section ``identity-feature-enabled``."},{"line_number":6,"context_line":"    This option must be enabled when testing an environment that"},{"line_number":7,"context_line":"    is configured to use domain-specific identity drivers."},{"line_number":8,"context_line":"    When enable, the identity users and groups tests will execute"},{"line_number":9,"context_line":"    retrieving objects from specified domains."}],"source_content_type":"text/x-yaml","patch_set":9,"id":"9f436f4f_0402643f","line":8,"range":{"start_line":8,"start_character":9,"end_line":8,"end_character":15},"updated":"2017-08-17 17:01:27.000000000","message":"enabled* ... but I would just drop these two lines. I don\u0027t think they\u0027re quite right (the tests will execute regardless, they just wouldn\u0027t work) or necessary.","commit_id":"19e5bdc3e78583949d9711aa79edd1cf4c887073"}],"tempest/api/identity/admin/v3/test_groups.py":[{"author":{"_account_id":23630,"name":"Tovin Seven","email":"tovin07@gmail.com","username":"tovin07"},"change_message_id":"713e05900cb628e612cbf57a313f1f9155565821","unresolved":false,"context_lines":[{"line_number":136,"context_line":"        body \u003d self.groups_client.list_groups()[\u0027groups\u0027]"},{"line_number":137,"context_line":"        if CONF.identity_feature_enabled.ldap_enabled:"},{"line_number":138,"context_line":"            body \u003d self.groups_client.list_groups("},{"line_number":139,"context_line":"                **{\u0027domain_id\u0027: self.domain[\u0027id\u0027]})[\u0027groups\u0027]"},{"line_number":140,"context_line":"        for g in body:"},{"line_number":141,"context_line":"            fetched_ids.append(g[\u0027id\u0027])"},{"line_number":142,"context_line":"        missing_groups \u003d [g for g in group_ids if g not in fetched_ids]"}],"source_content_type":"text/x-python","patch_set":1,"id":"df3967d1_8502206e","line":139,"range":{"start_line":139,"start_character":16,"end_line":139,"end_character":50},"updated":"2017-08-04 04:16:23.000000000","message":"domain_id\u003dself.domain[\u0027id\u0027]","commit_id":"f2bdc16bbb363bede2f4feb01a90cc2c3353f3e4"},{"author":{"_account_id":25651,"name":"Leticia Wanderley","email":"leticiafwanderley@gmail.com","username":"lwanderley"},"change_message_id":"f0b3f6a46b866f76201e14a9dcf8af9dc3a17e64","unresolved":false,"context_lines":[{"line_number":136,"context_line":"        body \u003d self.groups_client.list_groups()[\u0027groups\u0027]"},{"line_number":137,"context_line":"        if CONF.identity_feature_enabled.ldap_enabled:"},{"line_number":138,"context_line":"            body \u003d self.groups_client.list_groups("},{"line_number":139,"context_line":"                **{\u0027domain_id\u0027: self.domain[\u0027id\u0027]})[\u0027groups\u0027]"},{"line_number":140,"context_line":"        for g in body:"},{"line_number":141,"context_line":"            fetched_ids.append(g[\u0027id\u0027])"},{"line_number":142,"context_line":"        missing_groups \u003d [g for g in group_ids if g not in fetched_ids]"}],"source_content_type":"text/x-python","patch_set":1,"id":"df3967d1_edde653c","line":139,"range":{"start_line":139,"start_character":16,"end_line":139,"end_character":50},"in_reply_to":"df3967d1_8502206e","updated":"2017-08-04 14:08:05.000000000","message":"Done","commit_id":"f2bdc16bbb363bede2f4feb01a90cc2c3353f3e4"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"ac13ae77d17833779f4afe0c1219000785d7298a","unresolved":false,"context_lines":[{"line_number":133,"context_line":"            self.addCleanup(self.groups_client.delete_group, group[\u0027id\u0027])"},{"line_number":134,"context_line":"            group_ids.append(group[\u0027id\u0027])"},{"line_number":135,"context_line":"        # List and Verify Groups"},{"line_number":136,"context_line":"        body \u003d self.groups_client.list_groups()[\u0027groups\u0027]"},{"line_number":137,"context_line":"        if CONF.identity_feature_enabled.ldap_enabled:"},{"line_number":138,"context_line":"            body \u003d self.groups_client.list_groups("},{"line_number":139,"context_line":"                domain_id\u003dself.domain[\u0027id\u0027])[\u0027groups\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"df3967d1_768da130","line":136,"updated":"2017-08-04 17:39:12.000000000","message":"don\u0027t do the work twice, fetch the groups list in one condition or another","commit_id":"77232b6ac6b328cb909480a20903d963e7399ac0"},{"author":{"_account_id":25651,"name":"Leticia Wanderley","email":"leticiafwanderley@gmail.com","username":"lwanderley"},"change_message_id":"bc33e2e9c7b830f1598d103ac4ab79182d403465","unresolved":false,"context_lines":[{"line_number":133,"context_line":"            self.addCleanup(self.groups_client.delete_group, group[\u0027id\u0027])"},{"line_number":134,"context_line":"            group_ids.append(group[\u0027id\u0027])"},{"line_number":135,"context_line":"        # List and Verify Groups"},{"line_number":136,"context_line":"        body \u003d self.groups_client.list_groups()[\u0027groups\u0027]"},{"line_number":137,"context_line":"        if CONF.identity_feature_enabled.ldap_enabled:"},{"line_number":138,"context_line":"            body \u003d self.groups_client.list_groups("},{"line_number":139,"context_line":"                domain_id\u003dself.domain[\u0027id\u0027])[\u0027groups\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"df3967d1_cc015a3a","line":136,"in_reply_to":"df3967d1_768da130","updated":"2017-08-04 19:16:38.000000000","message":"Done","commit_id":"77232b6ac6b328cb909480a20903d963e7399ac0"},{"author":{"_account_id":10608,"name":"Matthew Edmonds","email":"edmondsw@us.ibm.com","username":"edmondsw"},"change_message_id":"50037e626d45bed68fbd70234ec7bf1d2333412b","unresolved":false,"context_lines":[{"line_number":136,"context_line":"        # When domain specific drivers are enabled the operations"},{"line_number":137,"context_line":"        # of listing all users and listing all groups are not supported,"},{"line_number":138,"context_line":"        # they need a domain filter to be specified"},{"line_number":139,"context_line":"        if CONF.identity_feature_enabled.domain_specific_drivers_enabled:"},{"line_number":140,"context_line":"            body \u003d self.groups_client.list_groups("},{"line_number":141,"context_line":"                domain_id\u003dself.domain[\u0027id\u0027])[\u0027groups\u0027]"},{"line_number":142,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f436f4f_48953f86","line":139,"updated":"2017-08-16 15:31:00.000000000","message":"sorry, this was my suggestion but I just realized that we don\u0027t need the \"_enabled\" on the end... that will come from the CONF group name (identity_feature_enabled) so repeating it is redundant (and makes the name longer than it needs to be). I.e., this should be:\n\nCONF.identity_feature_enabled.domain_specific_drivers","commit_id":"35892206c5ce071586286c104da612a27d91ed5a"},{"author":{"_account_id":25651,"name":"Leticia Wanderley","email":"leticiafwanderley@gmail.com","username":"lwanderley"},"change_message_id":"006d27c8477fc0725a276500bdd70fa8279241e6","unresolved":false,"context_lines":[{"line_number":136,"context_line":"        # When domain specific drivers are enabled the operations"},{"line_number":137,"context_line":"        # of listing all users and listing all groups are not supported,"},{"line_number":138,"context_line":"        # they need a domain filter to be specified"},{"line_number":139,"context_line":"        if CONF.identity_feature_enabled.domain_specific_drivers_enabled:"},{"line_number":140,"context_line":"            body \u003d self.groups_client.list_groups("},{"line_number":141,"context_line":"                domain_id\u003dself.domain[\u0027id\u0027])[\u0027groups\u0027]"},{"line_number":142,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f436f4f_a6ccd734","line":139,"in_reply_to":"9f436f4f_48953f86","updated":"2017-08-16 20:55:42.000000000","message":"Done","commit_id":"35892206c5ce071586286c104da612a27d91ed5a"}],"tempest/api/identity/admin/v3/test_list_users.py":[{"author":{"_account_id":23630,"name":"Tovin Seven","email":"tovin07@gmail.com","username":"tovin07"},"change_message_id":"713e05900cb628e612cbf57a313f1f9155565821","unresolved":false,"context_lines":[{"line_number":97,"context_line":"        body \u003d self.users_client.list_users()[\u0027users\u0027]"},{"line_number":98,"context_line":"        if CONF.identity_feature_enabled.ldap_enabled:"},{"line_number":99,"context_line":"            body_enabled_user \u003d self.users_client.list_users("},{"line_number":100,"context_line":"                **{\u0027domain_id\u0027:"},{"line_number":101,"context_line":"                    self.domain_enabled_user[\u0027domain_id\u0027]})[\u0027users\u0027]"},{"line_number":102,"context_line":"            body_non_enabled_user \u003d self.users_client.list_users("},{"line_number":103,"context_line":"                **{\u0027domain_id\u0027:"},{"line_number":104,"context_line":"                    self.non_domain_enabled_user[\u0027domain_id\u0027]})[\u0027users\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"df3967d1_45f8b879","line":101,"range":{"start_line":100,"start_character":16,"end_line":101,"end_character":58},"updated":"2017-08-04 04:16:23.000000000","message":"ditto","commit_id":"f2bdc16bbb363bede2f4feb01a90cc2c3353f3e4"},{"author":{"_account_id":25651,"name":"Leticia Wanderley","email":"leticiafwanderley@gmail.com","username":"lwanderley"},"change_message_id":"f0b3f6a46b866f76201e14a9dcf8af9dc3a17e64","unresolved":false,"context_lines":[{"line_number":97,"context_line":"        body \u003d self.users_client.list_users()[\u0027users\u0027]"},{"line_number":98,"context_line":"        if CONF.identity_feature_enabled.ldap_enabled:"},{"line_number":99,"context_line":"            body_enabled_user \u003d self.users_client.list_users("},{"line_number":100,"context_line":"                **{\u0027domain_id\u0027:"},{"line_number":101,"context_line":"                    self.domain_enabled_user[\u0027domain_id\u0027]})[\u0027users\u0027]"},{"line_number":102,"context_line":"            body_non_enabled_user \u003d self.users_client.list_users("},{"line_number":103,"context_line":"                **{\u0027domain_id\u0027:"},{"line_number":104,"context_line":"                    self.non_domain_enabled_user[\u0027domain_id\u0027]})[\u0027users\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"df3967d1_2dc22d5a","line":101,"range":{"start_line":100,"start_character":16,"end_line":101,"end_character":58},"in_reply_to":"df3967d1_45f8b879","updated":"2017-08-04 14:08:05.000000000","message":"Done","commit_id":"f2bdc16bbb363bede2f4feb01a90cc2c3353f3e4"},{"author":{"_account_id":23630,"name":"Tovin Seven","email":"tovin07@gmail.com","username":"tovin07"},"change_message_id":"713e05900cb628e612cbf57a313f1f9155565821","unresolved":false,"context_lines":[{"line_number":100,"context_line":"                **{\u0027domain_id\u0027:"},{"line_number":101,"context_line":"                    self.domain_enabled_user[\u0027domain_id\u0027]})[\u0027users\u0027]"},{"line_number":102,"context_line":"            body_non_enabled_user \u003d self.users_client.list_users("},{"line_number":103,"context_line":"                **{\u0027domain_id\u0027:"},{"line_number":104,"context_line":"                    self.non_domain_enabled_user[\u0027domain_id\u0027]})[\u0027users\u0027]"},{"line_number":105,"context_line":"            body \u003d (body_enabled_user + body_non_enabled_user)"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"        fetched_ids \u003d [u[\u0027id\u0027] for u in body]"}],"source_content_type":"text/x-python","patch_set":1,"id":"df3967d1_25f13496","line":104,"range":{"start_line":103,"start_character":16,"end_line":104,"end_character":62},"updated":"2017-08-04 04:16:23.000000000","message":"ditto","commit_id":"f2bdc16bbb363bede2f4feb01a90cc2c3353f3e4"},{"author":{"_account_id":25651,"name":"Leticia Wanderley","email":"leticiafwanderley@gmail.com","username":"lwanderley"},"change_message_id":"f0b3f6a46b866f76201e14a9dcf8af9dc3a17e64","unresolved":false,"context_lines":[{"line_number":100,"context_line":"                **{\u0027domain_id\u0027:"},{"line_number":101,"context_line":"                    self.domain_enabled_user[\u0027domain_id\u0027]})[\u0027users\u0027]"},{"line_number":102,"context_line":"            body_non_enabled_user \u003d self.users_client.list_users("},{"line_number":103,"context_line":"                **{\u0027domain_id\u0027:"},{"line_number":104,"context_line":"                    self.non_domain_enabled_user[\u0027domain_id\u0027]})[\u0027users\u0027]"},{"line_number":105,"context_line":"            body \u003d (body_enabled_user + body_non_enabled_user)"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"        fetched_ids \u003d [u[\u0027id\u0027] for u in body]"}],"source_content_type":"text/x-python","patch_set":1,"id":"df3967d1_0db529ee","line":104,"range":{"start_line":103,"start_character":16,"end_line":104,"end_character":62},"in_reply_to":"df3967d1_25f13496","updated":"2017-08-04 14:08:05.000000000","message":"Done","commit_id":"f2bdc16bbb363bede2f4feb01a90cc2c3353f3e4"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"ac13ae77d17833779f4afe0c1219000785d7298a","unresolved":false,"context_lines":[{"line_number":85,"context_line":"    def test_list_users_with_name(self):"},{"line_number":86,"context_line":"        # List users with name"},{"line_number":87,"context_line":"        params \u003d {\u0027name\u0027: self.domain_enabled_user[\u0027name\u0027]}"},{"line_number":88,"context_line":"        if CONF.identity_feature_enabled.ldap_enabled:"},{"line_number":89,"context_line":"            params[\u0027domain_id\u0027] \u003d self.domain_enabled_user[\u0027domain_id\u0027]"},{"line_number":90,"context_line":"        self._list_users_with_params(params, \u0027name\u0027,"},{"line_number":91,"context_line":"                                     self.domain_enabled_user,"}],"source_content_type":"text/x-python","patch_set":2,"id":"df3967d1_7692414e","line":88,"updated":"2017-08-04 17:39:12.000000000","message":"add a comment here to explain why is this needed","commit_id":"77232b6ac6b328cb909480a20903d963e7399ac0"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"ac13ae77d17833779f4afe0c1219000785d7298a","unresolved":false,"context_lines":[{"line_number":95,"context_line":"    def test_list_users(self):"},{"line_number":96,"context_line":"        # List users"},{"line_number":97,"context_line":"        body \u003d self.users_client.list_users()[\u0027users\u0027]"},{"line_number":98,"context_line":"        if CONF.identity_feature_enabled.ldap_enabled:"},{"line_number":99,"context_line":"            body_enabled_user \u003d self.users_client.list_users("},{"line_number":100,"context_line":"                domain_id\u003dself.domain_enabled_user[\u0027domain_id\u0027])[\u0027users\u0027]"},{"line_number":101,"context_line":"            body_non_enabled_user \u003d self.users_client.list_users("}],"source_content_type":"text/x-python","patch_set":2,"id":"df3967d1_36983968","line":98,"updated":"2017-08-04 17:39:12.000000000","message":"same comment as in the groups tests","commit_id":"77232b6ac6b328cb909480a20903d963e7399ac0"},{"author":{"_account_id":25651,"name":"Leticia Wanderley","email":"leticiafwanderley@gmail.com","username":"lwanderley"},"change_message_id":"bc33e2e9c7b830f1598d103ac4ab79182d403465","unresolved":false,"context_lines":[{"line_number":95,"context_line":"    def test_list_users(self):"},{"line_number":96,"context_line":"        # List users"},{"line_number":97,"context_line":"        body \u003d self.users_client.list_users()[\u0027users\u0027]"},{"line_number":98,"context_line":"        if CONF.identity_feature_enabled.ldap_enabled:"},{"line_number":99,"context_line":"            body_enabled_user \u003d self.users_client.list_users("},{"line_number":100,"context_line":"                domain_id\u003dself.domain_enabled_user[\u0027domain_id\u0027])[\u0027users\u0027]"},{"line_number":101,"context_line":"            body_non_enabled_user \u003d self.users_client.list_users("}],"source_content_type":"text/x-python","patch_set":2,"id":"df3967d1_cc86fab9","line":98,"in_reply_to":"df3967d1_36983968","updated":"2017-08-04 19:16:38.000000000","message":"Done","commit_id":"77232b6ac6b328cb909480a20903d963e7399ac0"},{"author":{"_account_id":10608,"name":"Matthew Edmonds","email":"edmondsw@us.ibm.com","username":"edmondsw"},"change_message_id":"96b0a2638027ca35efccaa77a90cdd061e025991","unresolved":false,"context_lines":[{"line_number":85,"context_line":"    def test_list_users_with_name(self):"},{"line_number":86,"context_line":"        # List users with name"},{"line_number":87,"context_line":"        params \u003d {\u0027name\u0027: self.domain_enabled_user[\u0027name\u0027]}"},{"line_number":88,"context_line":"        # When LDAP is enabled alongside domain specific drivers the operations"},{"line_number":89,"context_line":"        # of listing all users and listing all groups are not supported,"},{"line_number":90,"context_line":"        # they need a domain filter to be specified"},{"line_number":91,"context_line":"        if CONF.identity_feature_enabled.ldap_enabled:"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f436f4f_ca3edeb6","line":88,"updated":"2017-08-15 18:56:02.000000000","message":"seems odd to have the comment here but not in the other places we\u0027re adding similar code.","commit_id":"104e4a9a139b853c2049cfd1d8d7f2f3ed895f5a"},{"author":{"_account_id":25651,"name":"Leticia Wanderley","email":"leticiafwanderley@gmail.com","username":"lwanderley"},"change_message_id":"9ba67ff8fd8b51a1ad0d24cfc4fba012211df726","unresolved":false,"context_lines":[{"line_number":85,"context_line":"    def test_list_users_with_name(self):"},{"line_number":86,"context_line":"        # List users with name"},{"line_number":87,"context_line":"        params \u003d {\u0027name\u0027: self.domain_enabled_user[\u0027name\u0027]}"},{"line_number":88,"context_line":"        # When LDAP is enabled alongside domain specific drivers the operations"},{"line_number":89,"context_line":"        # of listing all users and listing all groups are not supported,"},{"line_number":90,"context_line":"        # they need a domain filter to be specified"},{"line_number":91,"context_line":"        if CONF.identity_feature_enabled.ldap_enabled:"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f436f4f_4ddaf177","line":88,"in_reply_to":"9f436f4f_ca3edeb6","updated":"2017-08-16 15:00:27.000000000","message":"Done","commit_id":"104e4a9a139b853c2049cfd1d8d7f2f3ed895f5a"}],"tempest/config.py":[{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"ac13ae77d17833779f4afe0c1219000785d7298a","unresolved":false,"context_lines":[{"line_number":236,"context_line":"                                  \"which are not supported anymore\"),"},{"line_number":237,"context_line":"    cfg.BoolOpt(\u0027ldap_enabled\u0027,"},{"line_number":238,"context_line":"                default\u003dFalse,"},{"line_number":239,"context_line":"                help\u003d\u0027Are domain specific drivers enabled and is one of them \u0027"},{"line_number":240,"context_line":"                \u0027LDAP?\u0027),"},{"line_number":241,"context_line":"    cfg.BoolOpt(\u0027security_compliance\u0027,"},{"line_number":242,"context_line":"                default\u003dFalse,"},{"line_number":243,"context_line":"                help\u003d\u0027Does the environment have the security compliance \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"df3967d1_96a6c5aa","line":240,"range":{"start_line":239,"start_character":21,"end_line":240,"end_character":23},"updated":"2017-08-04 17:39:12.000000000","message":"maybe: Is LDAP plugin enabled alongside domain specific drivers?","commit_id":"77232b6ac6b328cb909480a20903d963e7399ac0"},{"author":{"_account_id":25651,"name":"Leticia Wanderley","email":"leticiafwanderley@gmail.com","username":"lwanderley"},"change_message_id":"bc33e2e9c7b830f1598d103ac4ab79182d403465","unresolved":false,"context_lines":[{"line_number":236,"context_line":"                                  \"which are not supported anymore\"),"},{"line_number":237,"context_line":"    cfg.BoolOpt(\u0027ldap_enabled\u0027,"},{"line_number":238,"context_line":"                default\u003dFalse,"},{"line_number":239,"context_line":"                help\u003d\u0027Are domain specific drivers enabled and is one of them \u0027"},{"line_number":240,"context_line":"                \u0027LDAP?\u0027),"},{"line_number":241,"context_line":"    cfg.BoolOpt(\u0027security_compliance\u0027,"},{"line_number":242,"context_line":"                default\u003dFalse,"},{"line_number":243,"context_line":"                help\u003d\u0027Does the environment have the security compliance \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"df3967d1_2cd0e6c8","line":240,"range":{"start_line":239,"start_character":21,"end_line":240,"end_character":23},"in_reply_to":"df3967d1_96a6c5aa","updated":"2017-08-04 19:16:38.000000000","message":"Done","commit_id":"77232b6ac6b328cb909480a20903d963e7399ac0"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"85054a45cf2bdbb64c739e1c13ca375a40632ec1","unresolved":false,"context_lines":[{"line_number":236,"context_line":"                                  \"which are not supported anymore\"),"},{"line_number":237,"context_line":"    cfg.BoolOpt(\u0027domain_specific_drivers\u0027,"},{"line_number":238,"context_line":"                default\u003dFalse,"},{"line_number":239,"context_line":"                help\u003d\u0027Are domain specific drivers enabled?\u0027),"},{"line_number":240,"context_line":"    cfg.BoolOpt(\u0027security_compliance\u0027,"},{"line_number":241,"context_line":"                default\u003dFalse,"},{"line_number":242,"context_line":"                help\u003d\u0027Does the environment have the security compliance \u0027"}],"source_content_type":"text/x-python","patch_set":10,"id":"9f436f4f_534a2f27","line":239,"range":{"start_line":239,"start_character":21,"end_line":239,"end_character":59},"updated":"2017-08-21 08:29:00.000000000","message":"will it be more clear to put:\n\u0027Are domain specific drivers enabled? This configuration value should \u0027\n\u0027be same as [identity]-\u003edomain_specific_drivers_enabled in keystone.conf\u0027","commit_id":"395e725452abf5fadf7742150862f71b999761e7"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"2214684e66ad8c0384e6e8e751c7f59f64243347","unresolved":false,"context_lines":[{"line_number":238,"context_line":"                default\u003dFalse,"},{"line_number":239,"context_line":"                help\u003d\u0027Are domain specific drivers enabled? \u0027"},{"line_number":240,"context_line":"                     \u0027This configuration value should be same as \u0027"},{"line_number":241,"context_line":"                     \u0027[identity]-\u003edomain_specific_drivers_enabled \u0027"},{"line_number":242,"context_line":"                     \u0027in keystone.conf.\u0027),"},{"line_number":243,"context_line":"    cfg.BoolOpt(\u0027security_compliance\u0027,"},{"line_number":244,"context_line":"                default\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":11,"id":"7f287b81_57f38674","line":241,"range":{"start_line":241,"start_character":34,"end_line":241,"end_character":65},"updated":"2017-08-31 18:04:57.000000000","message":"This config value is changed in devstack like\n\nlib/keystone\n 223     # Rewrite stock ``keystone.conf``\n 224     if is_service_enabled ldap; then\n 225         iniset $KEYSTONE_CONF identity domain_config_dir \"$KEYSTONE_CONF_DIR/domains\"\n 226         iniset $KEYSTONE_CONF identity domain_specific_drivers_enabled \"True\"\n 227     fi\n\nSo we might need to add tempest part also into the above block after this patch.","commit_id":"9cafd3d045b6253a6821e38857ebfd9f3675aeda"}]}