)]}'
{"tempest/test.py":[{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"4f94d4f8a64c0af8f15dc95476faae4174e23b38","unresolved":false,"context_lines":[{"line_number":382,"context_line":"            cls.validation_resources \u003d vresources.create_validation_resources("},{"line_number":383,"context_line":"                cls.os_primary, cls.validation_resources,"},{"line_number":384,"context_line":"                use_neutron\u003dCONF.service_available.neutron,"},{"line_number":385,"context_line":"                ethertype\u003d\u0027IPv\u0027 + str(CONF.validation.ip_version_for_ssh),"},{"line_number":386,"context_line":"                floating_network_id\u003dCONF.network.public_network_id,"},{"line_number":387,"context_line":"                floating_network_name\u003dCONF.network.floating_network_name)"},{"line_number":388,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f436f4f_eb48bf87","line":385,"range":{"start_line":385,"start_character":16,"end_line":385,"end_character":73},"updated":"2017-08-14 01:52:35.000000000","message":"the original code is:\n    ethertype \u003d \u0027IPv4\u0027\n    if CONF.validation.ip_version_for_ssh \u003d\u003d 6:\n        ethertype \u003d \u0027IPv6\u0027\nso it will not cause error when there is misconfiguration in tempest.conf, such as\nip_version_for_ssh \u003d\n\nthe new code will not tolerate any misconfiguration, how do you think about it?","commit_id":"d7faa36cd16ad9ebb0e053a5b06c782be4aa5a5f"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"bb2474809d6fb7547e64b60aed101482236a0ac3","unresolved":false,"context_lines":[{"line_number":382,"context_line":"            cls.validation_resources \u003d vresources.create_validation_resources("},{"line_number":383,"context_line":"                cls.os_primary, cls.validation_resources,"},{"line_number":384,"context_line":"                use_neutron\u003dCONF.service_available.neutron,"},{"line_number":385,"context_line":"                ethertype\u003d\u0027IPv\u0027 + str(CONF.validation.ip_version_for_ssh),"},{"line_number":386,"context_line":"                floating_network_id\u003dCONF.network.public_network_id,"},{"line_number":387,"context_line":"                floating_network_name\u003dCONF.network.floating_network_name)"},{"line_number":388,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f436f4f_0c1ad86d","line":385,"range":{"start_line":385,"start_character":16,"end_line":385,"end_character":73},"in_reply_to":"9f436f4f_133d63c3","updated":"2017-08-15 06:34:10.000000000","message":"yeah, sounds fine","commit_id":"d7faa36cd16ad9ebb0e053a5b06c782be4aa5a5f"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"899475b93434f36ad09da94f1aeccff4b3ab6d4a","unresolved":false,"context_lines":[{"line_number":382,"context_line":"            cls.validation_resources \u003d vresources.create_validation_resources("},{"line_number":383,"context_line":"                cls.os_primary, cls.validation_resources,"},{"line_number":384,"context_line":"                use_neutron\u003dCONF.service_available.neutron,"},{"line_number":385,"context_line":"                ethertype\u003d\u0027IPv\u0027 + str(CONF.validation.ip_version_for_ssh),"},{"line_number":386,"context_line":"                floating_network_id\u003dCONF.network.public_network_id,"},{"line_number":387,"context_line":"                floating_network_name\u003dCONF.network.floating_network_name)"},{"line_number":388,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f436f4f_a94d1ac5","line":385,"range":{"start_line":385,"start_character":16,"end_line":385,"end_character":73},"in_reply_to":"9f436f4f_29feca6a","updated":"2017-08-14 08:37:34.000000000","message":"I am not object to detecting the misconfiguration, but if we directly use CONF.validation.ip_version_for_ssh, the error message may not be friendly:)","commit_id":"d7faa36cd16ad9ebb0e053a5b06c782be4aa5a5f"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"d9bc78cd534f60b315f7b9a219603e5f756630c6","unresolved":false,"context_lines":[{"line_number":382,"context_line":"            cls.validation_resources \u003d vresources.create_validation_resources("},{"line_number":383,"context_line":"                cls.os_primary, cls.validation_resources,"},{"line_number":384,"context_line":"                use_neutron\u003dCONF.service_available.neutron,"},{"line_number":385,"context_line":"                ethertype\u003d\u0027IPv\u0027 + str(CONF.validation.ip_version_for_ssh),"},{"line_number":386,"context_line":"                floating_network_id\u003dCONF.network.public_network_id,"},{"line_number":387,"context_line":"                floating_network_name\u003dCONF.network.floating_network_name)"},{"line_number":388,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f436f4f_133d63c3","line":385,"range":{"start_line":385,"start_character":16,"end_line":385,"end_character":73},"in_reply_to":"9f436f4f_84eebdb1","updated":"2017-08-15 06:23:40.000000000","message":"So I guess an InvalidConfiguration exception would be easier to read.","commit_id":"d7faa36cd16ad9ebb0e053a5b06c782be4aa5a5f"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"29e3cc017c0067eb8bfd3103b61107cbc23d412f","unresolved":false,"context_lines":[{"line_number":382,"context_line":"            cls.validation_resources \u003d vresources.create_validation_resources("},{"line_number":383,"context_line":"                cls.os_primary, cls.validation_resources,"},{"line_number":384,"context_line":"                use_neutron\u003dCONF.service_available.neutron,"},{"line_number":385,"context_line":"                ethertype\u003d\u0027IPv\u0027 + str(CONF.validation.ip_version_for_ssh),"},{"line_number":386,"context_line":"                floating_network_id\u003dCONF.network.public_network_id,"},{"line_number":387,"context_line":"                floating_network_name\u003dCONF.network.floating_network_name)"},{"line_number":388,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f436f4f_84eebdb1","line":385,"range":{"start_line":385,"start_character":16,"end_line":385,"end_character":73},"in_reply_to":"9f436f4f_a94d1ac5","updated":"2017-08-14 09:18:57.000000000","message":"It will be what neutron returns. If nova is used this setting is ignore so I don\u0027t want to do more checks here. I could catch the error in the validation resources module and return a specific error message.","commit_id":"d7faa36cd16ad9ebb0e053a5b06c782be4aa5a5f"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"4f603fbeb99b58850788e2c8593505f546d66105","unresolved":false,"context_lines":[{"line_number":382,"context_line":"            cls.validation_resources \u003d vresources.create_validation_resources("},{"line_number":383,"context_line":"                cls.os_primary, cls.validation_resources,"},{"line_number":384,"context_line":"                use_neutron\u003dCONF.service_available.neutron,"},{"line_number":385,"context_line":"                ethertype\u003d\u0027IPv\u0027 + str(CONF.validation.ip_version_for_ssh),"},{"line_number":386,"context_line":"                floating_network_id\u003dCONF.network.public_network_id,"},{"line_number":387,"context_line":"                floating_network_name\u003dCONF.network.floating_network_name)"},{"line_number":388,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f436f4f_29feca6a","line":385,"range":{"start_line":385,"start_character":16,"end_line":385,"end_character":73},"in_reply_to":"9f436f4f_eb48bf87","updated":"2017-08-14 08:31:38.000000000","message":"I think it\u0027s better to detect a misconfiguration rather than silently ignore it?\nThe default value for the config option is 4, so unless someone sets this option it will work. And if they set it wrong they probably are better of knowing about the issue.","commit_id":"d7faa36cd16ad9ebb0e053a5b06c782be4aa5a5f"}]}