)]}'
{"tempest/api/compute/volumes/test_attach_volume.py":[{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"01e9504d21cce1f2ad16c3b869b7b8137ebf6b2b","unresolved":false,"context_lines":[{"line_number":117,"context_line":"        volume_1st \u003d self.create_volume()"},{"line_number":118,"context_line":"        attachment_1st \u003d self.attach_volume(server, volume_1st,"},{"line_number":119,"context_line":"                                            device\u003d(\u0027/dev/%s\u0027 % self.device))"},{"line_number":120,"context_line":"        waiters.wait_for_volume_resource_status("},{"line_number":121,"context_line":"            self.volumes_client, attachment_1st[\u0027volumeId\u0027], \u0027in-use\u0027)"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"        body \u003d self.servers_client.list_volume_attachments("},{"line_number":124,"context_line":"            server[\u0027id\u0027])[\u0027volumeAttachments\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f436f4f_fd49d38a","line":121,"range":{"start_line":120,"start_character":0,"end_line":121,"end_character":70},"updated":"2017-08-11 00:55:16.000000000","message":"this is not needed because in attach_volume there already does wait_for_volume_resource_status","commit_id":"4872fe6cea5cff08c5122ada07d9e7530333e9bc"},{"author":{"_account_id":17386,"name":"Steve Noyes","email":"steve.noyes@oracle.com","username":"ssn1ssn"},"change_message_id":"a0c5a4f2e0fa17a29f7144d93cbb7b6c5530eccf","unresolved":false,"context_lines":[{"line_number":117,"context_line":"        volume_1st \u003d self.create_volume()"},{"line_number":118,"context_line":"        attachment_1st \u003d self.attach_volume(server, volume_1st,"},{"line_number":119,"context_line":"                                            device\u003d(\u0027/dev/%s\u0027 % self.device))"},{"line_number":120,"context_line":"        waiters.wait_for_volume_resource_status("},{"line_number":121,"context_line":"            self.volumes_client, attachment_1st[\u0027volumeId\u0027], \u0027in-use\u0027)"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"        body \u003d self.servers_client.list_volume_attachments("},{"line_number":124,"context_line":"            server[\u0027id\u0027])[\u0027volumeAttachments\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f436f4f_344be359","line":121,"range":{"start_line":120,"start_character":0,"end_line":121,"end_character":70},"in_reply_to":"9f436f4f_fd49d38a","updated":"2017-08-11 13:39:52.000000000","message":"Done","commit_id":"4872fe6cea5cff08c5122ada07d9e7530333e9bc"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"01e9504d21cce1f2ad16c3b869b7b8137ebf6b2b","unresolved":false,"context_lines":[{"line_number":136,"context_line":"        # attach one more volume to server"},{"line_number":137,"context_line":"        volume_2nd \u003d self.create_volume()"},{"line_number":138,"context_line":"        attachment_2nd \u003d self.attach_volume(server, volume_2nd)"},{"line_number":139,"context_line":"        waiters.wait_for_volume_resource_status("},{"line_number":140,"context_line":"            self.volumes_client, attachment_2nd[\u0027volumeId\u0027], \u0027in-use\u0027)"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"        body \u003d self.servers_client.list_volume_attachments("},{"line_number":143,"context_line":"            server[\u0027id\u0027])[\u0027volumeAttachments\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f436f4f_dd604f04","line":140,"range":{"start_line":139,"start_character":0,"end_line":140,"end_character":70},"updated":"2017-08-11 00:55:16.000000000","message":"ditto","commit_id":"4872fe6cea5cff08c5122ada07d9e7530333e9bc"},{"author":{"_account_id":17386,"name":"Steve Noyes","email":"steve.noyes@oracle.com","username":"ssn1ssn"},"change_message_id":"a0c5a4f2e0fa17a29f7144d93cbb7b6c5530eccf","unresolved":false,"context_lines":[{"line_number":136,"context_line":"        # attach one more volume to server"},{"line_number":137,"context_line":"        volume_2nd \u003d self.create_volume()"},{"line_number":138,"context_line":"        attachment_2nd \u003d self.attach_volume(server, volume_2nd)"},{"line_number":139,"context_line":"        waiters.wait_for_volume_resource_status("},{"line_number":140,"context_line":"            self.volumes_client, attachment_2nd[\u0027volumeId\u0027], \u0027in-use\u0027)"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"        body \u003d self.servers_client.list_volume_attachments("},{"line_number":143,"context_line":"            server[\u0027id\u0027])[\u0027volumeAttachments\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f436f4f_543c27be","line":140,"range":{"start_line":139,"start_character":0,"end_line":140,"end_character":70},"in_reply_to":"9f436f4f_dd604f04","updated":"2017-08-11 13:39:52.000000000","message":"Done","commit_id":"4872fe6cea5cff08c5122ada07d9e7530333e9bc"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"01e9504d21cce1f2ad16c3b869b7b8137ebf6b2b","unresolved":false,"context_lines":[{"line_number":149,"context_line":"            self.assertEqual(server[\u0027id\u0027], body[\u0027serverId\u0027])"},{"line_number":150,"context_line":"            self.assertEqual(attachment[\u0027volumeId\u0027], body[\u0027volumeId\u0027])"},{"line_number":151,"context_line":"            self.assertEqual(attachment[\u0027id\u0027], body[\u0027id\u0027])"},{"line_number":152,"context_line":"            self.servers_client.detach_volume(server[\u0027id\u0027],"},{"line_number":153,"context_line":"                                              attachment[\u0027volumeId\u0027])"},{"line_number":154,"context_line":"            waiters.wait_for_volume_resource_status("},{"line_number":155,"context_line":"                self.volumes_client, attachment[\u0027volumeId\u0027], \u0027available\u0027)"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"class AttachVolumeShelveTestJSON(AttachVolumeTestJSON):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f436f4f_5d321f12","line":155,"range":{"start_line":152,"start_character":0,"end_line":155,"end_character":73},"updated":"2017-08-11 00:55:16.000000000","message":"so I want to know why detach will fail?","commit_id":"4872fe6cea5cff08c5122ada07d9e7530333e9bc"},{"author":{"_account_id":17386,"name":"Steve Noyes","email":"steve.noyes@oracle.com","username":"ssn1ssn"},"change_message_id":"a0c5a4f2e0fa17a29f7144d93cbb7b6c5530eccf","unresolved":false,"context_lines":[{"line_number":149,"context_line":"            self.assertEqual(server[\u0027id\u0027], body[\u0027serverId\u0027])"},{"line_number":150,"context_line":"            self.assertEqual(attachment[\u0027volumeId\u0027], body[\u0027volumeId\u0027])"},{"line_number":151,"context_line":"            self.assertEqual(attachment[\u0027id\u0027], body[\u0027id\u0027])"},{"line_number":152,"context_line":"            self.servers_client.detach_volume(server[\u0027id\u0027],"},{"line_number":153,"context_line":"                                              attachment[\u0027volumeId\u0027])"},{"line_number":154,"context_line":"            waiters.wait_for_volume_resource_status("},{"line_number":155,"context_line":"                self.volumes_client, attachment[\u0027volumeId\u0027], \u0027available\u0027)"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"class AttachVolumeShelveTestJSON(AttachVolumeTestJSON):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f436f4f_b457d302","line":155,"range":{"start_line":152,"start_character":0,"end_line":155,"end_character":73},"in_reply_to":"9f436f4f_5d321f12","updated":"2017-08-11 13:39:52.000000000","message":"we were seeing detach failures in the log while testing https://review.openstack.org/#/c/330285/. The test was passing but the log was full of iscsid errors.","commit_id":"4872fe6cea5cff08c5122ada07d9e7530333e9bc"},{"author":{"_account_id":17386,"name":"Steve Noyes","email":"steve.noyes@oracle.com","username":"ssn1ssn"},"change_message_id":"324ef092da004be99aac6332b732875b06df0e98","unresolved":false,"context_lines":[{"line_number":149,"context_line":"            self.assertEqual(server[\u0027id\u0027], body[\u0027serverId\u0027])"},{"line_number":150,"context_line":"            self.assertEqual(attachment[\u0027volumeId\u0027], body[\u0027volumeId\u0027])"},{"line_number":151,"context_line":"            self.assertEqual(attachment[\u0027id\u0027], body[\u0027id\u0027])"},{"line_number":152,"context_line":"            self.servers_client.detach_volume(server[\u0027id\u0027],"},{"line_number":153,"context_line":"                                              attachment[\u0027volumeId\u0027])"},{"line_number":154,"context_line":"            waiters.wait_for_volume_resource_status("},{"line_number":155,"context_line":"                self.volumes_client, attachment[\u0027volumeId\u0027], \u0027available\u0027)"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"class AttachVolumeShelveTestJSON(AttachVolumeTestJSON):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f436f4f_f48afb18","line":155,"range":{"start_line":152,"start_character":0,"end_line":155,"end_character":73},"in_reply_to":"9f436f4f_b457d302","updated":"2017-08-11 13:50:33.000000000","message":"some more detail... In tempest/api/compute/base \u003e attach_volume, it tells cleanup to specifically ignore errors:\n\n       # Ignore 404s on detach in case the server is deleted or the volume\n        # is already detached.\n\nSo any detach issues in this test will be ignored if we let cleanup do the detaching.","commit_id":"4872fe6cea5cff08c5122ada07d9e7530333e9bc"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"d85778b46b463e880eae46b6a3eb7a15cba107e5","unresolved":false,"context_lines":[{"line_number":149,"context_line":"            self.assertEqual(server[\u0027id\u0027], body[\u0027serverId\u0027])"},{"line_number":150,"context_line":"            self.assertEqual(attachment[\u0027volumeId\u0027], body[\u0027volumeId\u0027])"},{"line_number":151,"context_line":"            self.assertEqual(attachment[\u0027id\u0027], body[\u0027id\u0027])"},{"line_number":152,"context_line":"            self.servers_client.detach_volume(server[\u0027id\u0027],"},{"line_number":153,"context_line":"                                              attachment[\u0027volumeId\u0027])"},{"line_number":154,"context_line":"            waiters.wait_for_volume_resource_status("},{"line_number":155,"context_line":"                self.volumes_client, attachment[\u0027volumeId\u0027], \u0027available\u0027)"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"class AttachVolumeShelveTestJSON(AttachVolumeTestJSON):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f436f4f_c47cc520","line":155,"range":{"start_line":152,"start_character":0,"end_line":155,"end_character":73},"in_reply_to":"9f436f4f_f48afb18","updated":"2017-08-14 09:16:50.000000000","message":"1. \"The test was passing but the log was full of iscsid errors.\", how did you see the log if the testcase passed?\n2. \"# Ignore 404s on detach\", it only ignores 404 NotFound, but will not ignore other exceptions\n3. we test detach-volume in test_attach_detach_volume, so generally speaking, we needn\u0027t test detach-volume in all\n   testcases. (if there is something wrong with detach-volume, we will know it from test_attach_detach_volume, and we\n   may not want many other testcases also fail because of it.)\n\nso, if test_attach_detach_volume fails, I don\u0027t think it\u0027s necessary for test_list_get_volume_attachments to also fail\nbecause of same reason.","commit_id":"4872fe6cea5cff08c5122ada07d9e7530333e9bc"}]}