)]}'
{"tempest/tests/cmd/test_run.py":[{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"334f2898bfc61d64be19ba0496f3a97a1b70e571","unresolved":false,"context_lines":[{"line_number":72,"context_line":"                         self.run_cmd._build_regex(args))"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    def test__build_whitelist_file(self):"},{"line_number":75,"context_line":"        # Ignores the Resource warnings in py34+ generated by os-testr"},{"line_number":76,"context_line":"        with warnings.catch_warnings():"},{"line_number":77,"context_line":"            warnings.simplefilter(\"ignore\")"},{"line_number":78,"context_line":"            args \u003d mock.Mock(spec\u003dargparse.Namespace)"},{"line_number":79,"context_line":"            setattr(args, \u0027smoke\u0027, False)"},{"line_number":80,"context_line":"            setattr(args, \u0027regex\u0027, None)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f436f4f_2703f244","line":77,"range":{"start_line":75,"start_character":0,"end_line":77,"end_character":43},"updated":"2017-08-20 17:58:22.000000000","message":"I\u0027m not sure we want to bake into tempest ignores for os-testr warnings.\nWe should fix them instead on os-testr side.\nThis will catch any warning, not only os-testr related ones.","commit_id":"1419d24fa20c82d1c44fc9e4af8a8f6224898096"},{"author":{"_account_id":26484,"name":"Divyansh Acharya","email":"divyansh.acharya7@gmail.com","username":"divi7727"},"change_message_id":"745399a1d8edbfe4952e464e21085667843d21be","unresolved":false,"context_lines":[{"line_number":72,"context_line":"                         self.run_cmd._build_regex(args))"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    def test__build_whitelist_file(self):"},{"line_number":75,"context_line":"        # Ignores the Resource warnings in py34+ generated by os-testr"},{"line_number":76,"context_line":"        with warnings.catch_warnings():"},{"line_number":77,"context_line":"            warnings.simplefilter(\"ignore\")"},{"line_number":78,"context_line":"            args \u003d mock.Mock(spec\u003dargparse.Namespace)"},{"line_number":79,"context_line":"            setattr(args, \u0027smoke\u0027, False)"},{"line_number":80,"context_line":"            setattr(args, \u0027regex\u0027, None)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f436f4f_ad190189","line":77,"range":{"start_line":75,"start_character":0,"end_line":77,"end_character":43},"in_reply_to":"9f436f4f_2703f244","updated":"2017-08-20 23:07:23.000000000","message":"https://review.openstack.org/#/c/494697/\nI made this change in to fix the warnings. The warnings are caused because of outdated code in os-testr. Once that change gets approved I\u0027ll remove the \u0027ignore warnings\u0027 part of the code and but without ignoring the warnings these perfectly fine tests were failing in tox py35.","commit_id":"1419d24fa20c82d1c44fc9e4af8a8f6224898096"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"d45c3cfebeb95c62210375f52bcf4a50b54c2453","unresolved":false,"context_lines":[{"line_number":71,"context_line":"                         self.run_cmd._build_regex(args))"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    def test__build_whitelist_file(self):"},{"line_number":74,"context_line":"            args \u003d mock.Mock(spec\u003dargparse.Namespace)"},{"line_number":75,"context_line":"            setattr(args, \u0027smoke\u0027, False)"},{"line_number":76,"context_line":"            setattr(args, \u0027regex\u0027, None)"},{"line_number":77,"context_line":"            self.tests \u003d tempfile.NamedTemporaryFile("}],"source_content_type":"text/x-python","patch_set":2,"id":"7f287b81_4014814e","line":74,"updated":"2017-08-24 22:56:26.000000000","message":"Indentation should be 4 spaces.","commit_id":"2d9c8e9b9c9cda682a09b465719bb74663c6eea0"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"d45c3cfebeb95c62210375f52bcf4a50b54c2453","unresolved":false,"context_lines":[{"line_number":78,"context_line":"                prefix\u003d\u0027whitelist\u0027, delete\u003dFalse)"},{"line_number":79,"context_line":"            self.tests.write(b\"volume \\n compute\")"},{"line_number":80,"context_line":"            self.tests.close()"},{"line_number":81,"context_line":"            setattr(args, \u0027whitelist_file\u0027, self.tests.name)"},{"line_number":82,"context_line":"            setattr(args, \u0027blacklist_file\u0027, None)"},{"line_number":83,"context_line":"            self.assertEqual(\"volume|compute\","},{"line_number":84,"context_line":"                             self.run_cmd._build_regex(args))"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f287b81_a002050a","line":81,"updated":"2017-08-24 22:56:26.000000000","message":"nit: I think it makes sense to put lines 75,76,81,82 together as they do a common setup.","commit_id":"2d9c8e9b9c9cda682a09b465719bb74663c6eea0"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"d45c3cfebeb95c62210375f52bcf4a50b54c2453","unresolved":false,"context_lines":[{"line_number":93,"context_line":"            self.tests.write(b\"volume \\n compute\")"},{"line_number":94,"context_line":"            self.tests.close()"},{"line_number":95,"context_line":"            setattr(args, \u0027whitelist_file\u0027, None)"},{"line_number":96,"context_line":"            setattr(args, \u0027blacklist_file\u0027, self.tests.name)"},{"line_number":97,"context_line":"            self.assertEqual(\"^((?!compute|volume).)*$\","},{"line_number":98,"context_line":"                             self.run_cmd._build_regex(args))"},{"line_number":99,"context_line":"            os.unlink(self.tests.name)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f287b81_4a001f02","line":96,"updated":"2017-08-24 22:56:26.000000000","message":"Ditto","commit_id":"2d9c8e9b9c9cda682a09b465719bb74663c6eea0"}]}