)]}'
{"tempest/api/volume/admin/test_groups.py":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"bb6587970eb359847118ec8f250ae1cfe8e769f7","unresolved":false,"context_lines":[{"line_number":346,"context_line":"                        group[\u0027id\u0027], \u0027available\u0027)"},{"line_number":347,"context_line":"        for status in [\u0027creating\u0027, \u0027available\u0027, \u0027error\u0027]:"},{"line_number":348,"context_line":"            self.admin_groups_client.reset_group_status(group[\u0027id\u0027], status)"},{"line_number":349,"context_line":"            group_get \u003d self.groups_client.show_group(group[\u0027id\u0027])[\u0027group\u0027]"},{"line_number":350,"context_line":"            self.assertEqual(status, group_get[\u0027status\u0027])"}],"source_content_type":"text/x-python","patch_set":4,"id":"7f287b81_34a0c6f4","line":350,"range":{"start_line":349,"start_character":0,"end_line":350,"end_character":57},"updated":"2017-08-23 17:31:26.000000000","message":"The test itself seems to succeed like\n\nhttp://logs.openstack.org/13/495513/4/check/gate-tempest-dsvm-neutron-full-ubuntu-xenial/11e2f8e/logs/testr_results.html.gz\n\n pt258.1: tempest.api.volume.admin.test_groups.GroupsV320Test.test_reset_group_status[id-b20c696b-0cbc-49a5-8b3a-b1fb9338f45c]\n\nSo that is good.\nI have one question about this API and test.\n\nThis API returns HTTP 202(Accepted), that means we cannot say the operation is complete as the RFC\n\n 202 Accepted: The request has been accepted for processing, but the processing has not been completed.\n\nSo the above status verification can be unstable, that is my concern here.","commit_id":"f0154a94c123d16fd1152e2db8f6d1b7e367428c"},{"author":{"_account_id":23081,"name":"Jeremy Zhang","email":"zhangjun_inspur@163.com","username":"jeremy.zhang"},"change_message_id":"0ea1125984da5f3a6d9fb1dace9c8e4b660108de","unresolved":false,"context_lines":[{"line_number":346,"context_line":"                        group[\u0027id\u0027], \u0027available\u0027)"},{"line_number":347,"context_line":"        for status in [\u0027creating\u0027, \u0027available\u0027, \u0027error\u0027]:"},{"line_number":348,"context_line":"            self.admin_groups_client.reset_group_status(group[\u0027id\u0027], status)"},{"line_number":349,"context_line":"            group_get \u003d self.groups_client.show_group(group[\u0027id\u0027])[\u0027group\u0027]"},{"line_number":350,"context_line":"            self.assertEqual(status, group_get[\u0027status\u0027])"}],"source_content_type":"text/x-python","patch_set":4,"id":"7f287b81_9b520267","line":350,"range":{"start_line":349,"start_character":0,"end_line":350,"end_character":57},"in_reply_to":"7f287b81_34a0c6f4","updated":"2017-08-24 01:18:22.000000000","message":"@Ken\u0027ichi, thanks for your comments.\nI agree with your opinion, this API return HTTP 202 and is mainly a DB operation. Although the DB operation is not time-consuming and status of group will be changed quickly, it\u0027s still not unstable for verifying the status immediately after calling the API.\nI think use the waiters.wait_for_volume_resouce_status will be more suitable and stable.\nLooking forward your suggestions.","commit_id":"f0154a94c123d16fd1152e2db8f6d1b7e367428c"}]}