)]}'
{"tempest/api/compute/servers/test_virtual_interfaces.py":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"26d85587c94b5eeae8901255de47439223e6baf5","unresolved":false,"context_lines":[{"line_number":62,"context_line":"                                \u0027interfaces.\u0027)"},{"line_number":63,"context_line":"            for virt_iface in virt_ifaces[\u0027virtual_interfaces\u0027]:"},{"line_number":64,"context_line":"                mac_address \u003d virt_iface[\u0027mac_address\u0027]"},{"line_number":65,"context_line":"                self.assertTrue(netaddr.valid_mac(mac_address),"},{"line_number":66,"context_line":"                                \"Invalid mac address detected. mac address: %s\""},{"line_number":67,"context_line":"                                % mac_address)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f436f4f_821cb577","side":"PARENT","line":67,"range":{"start_line":65,"start_character":0,"end_line":67,"end_character":46},"updated":"2017-08-21 17:39:12.000000000","message":"The reason why we can remove here is the mac_address shema is\n\n 31 mac_address \u003d {\n 32     \u0027type\u0027: \u0027string\u0027,\n 33     \u0027pattern\u0027: \u0027(?:[a-f0-9]{2}:){5}[a-f0-9]{2}\u0027\n 34 }\n\nright?","commit_id":"e56964dfbe6bca0c3acee7891111d9e12d0cc4e2"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"b330888379e9952b3bc706a6c12f3b7773589d53","unresolved":false,"context_lines":[{"line_number":60,"context_line":"            self.assertNotEmpty(virt_ifaces[\u0027virtual_interfaces\u0027],"},{"line_number":61,"context_line":"                                \u0027Expected virtual interfaces, got 0 \u0027"},{"line_number":62,"context_line":"                                \u0027interfaces.\u0027)"},{"line_number":63,"context_line":"            for virt_iface in virt_ifaces[\u0027virtual_interfaces\u0027]:"},{"line_number":64,"context_line":"                mac_address \u003d virt_iface[\u0027mac_address\u0027]"},{"line_number":65,"context_line":"                self.assertTrue(netaddr.valid_mac(mac_address),"},{"line_number":66,"context_line":"                                \"Invalid mac address detected. mac address: %s\""},{"line_number":67,"context_line":"                                % mac_address)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f436f4f_a98f952c","side":"PARENT","line":67,"range":{"start_line":63,"start_character":0,"end_line":67,"end_character":46},"updated":"2017-08-22 02:32:34.000000000","message":"i prefer to have these check, there is no harm and not time consuming. schema regex can be week check than netaddr.valid_mac.","commit_id":"e56964dfbe6bca0c3acee7891111d9e12d0cc4e2"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"0c4f3ebe9e527ffcd48bbcf7787f47dccd8d7231","unresolved":false,"context_lines":[{"line_number":62,"context_line":"                                \u0027interfaces.\u0027)"},{"line_number":63,"context_line":"            for virt_iface in virt_ifaces[\u0027virtual_interfaces\u0027]:"},{"line_number":64,"context_line":"                mac_address \u003d virt_iface[\u0027mac_address\u0027]"},{"line_number":65,"context_line":"                self.assertTrue(netaddr.valid_mac(mac_address),"},{"line_number":66,"context_line":"                                \"Invalid mac address detected. mac address: %s\""},{"line_number":67,"context_line":"                                % mac_address)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f436f4f_062210a5","side":"PARENT","line":67,"range":{"start_line":65,"start_character":0,"end_line":67,"end_character":46},"in_reply_to":"9f436f4f_821cb577","updated":"2017-08-22 00:47:43.000000000","message":"yes:)","commit_id":"e56964dfbe6bca0c3acee7891111d9e12d0cc4e2"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"c5918d6ea1446378d1cdf936c8dc977029001d8c","unresolved":false,"context_lines":[{"line_number":60,"context_line":"            self.assertNotEmpty(virt_ifaces[\u0027virtual_interfaces\u0027],"},{"line_number":61,"context_line":"                                \u0027Expected virtual interfaces, got 0 \u0027"},{"line_number":62,"context_line":"                                \u0027interfaces.\u0027)"},{"line_number":63,"context_line":"            for virt_iface in virt_ifaces[\u0027virtual_interfaces\u0027]:"},{"line_number":64,"context_line":"                mac_address \u003d virt_iface[\u0027mac_address\u0027]"},{"line_number":65,"context_line":"                self.assertTrue(netaddr.valid_mac(mac_address),"},{"line_number":66,"context_line":"                                \"Invalid mac address detected. mac address: %s\""},{"line_number":67,"context_line":"                                % mac_address)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f436f4f_2c02930a","side":"PARENT","line":67,"range":{"start_line":63,"start_character":0,"end_line":67,"end_character":46},"in_reply_to":"9f436f4f_a98f952c","updated":"2017-08-22 03:05:58.000000000","message":"ok to keep it","commit_id":"e56964dfbe6bca0c3acee7891111d9e12d0cc4e2"}]}