)]}'
{"tempest/api/volume/admin/test_volumes_actions.py":[{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"563b4d479136200cce2aa3895b40433937039bc4","unresolved":false,"context_lines":[{"line_number":65,"context_line":""},{"line_number":66,"context_line":"        # Verify volume attachment"},{"line_number":67,"context_line":"        attachment \u003d self.volumes_client.show_volume("},{"line_number":68,"context_line":"            volume[\u0027id\u0027])[\u0027volume\u0027][\u0027attachments\u0027][0]"},{"line_number":69,"context_line":"        self.assertEqual(server[\u0027id\u0027], attachment[\u0027server_id\u0027])"},{"line_number":70,"context_line":"        self.assertEqual(volume[\u0027id\u0027], attachment[\u0027volume_id\u0027])"},{"line_number":71,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7f287b81_d794fdea","line":68,"updated":"2017-08-23 04:14:59.000000000","message":"Might be good to do a self.assertNotEmpty() before indexing [0].","commit_id":"1dae9a75bf60da20751ba3bbe7798466cca580fd"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"b791eb4d3904903eb1692c9d2076f2d02a07b91e","unresolved":false,"context_lines":[{"line_number":54,"context_line":"        volume \u003d self.create_volume()"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"        # Attach volume"},{"line_number":57,"context_line":"        self.volumes_client.attach_volume("},{"line_number":58,"context_line":"            volume[\u0027id\u0027], instance_uuid\u003dserver[\u0027id\u0027],"},{"line_number":59,"context_line":"            mountpoint\u003d\u0027/dev/%s\u0027 % CONF.compute.volume_device_name)"},{"line_number":60,"context_line":"        waiters.wait_for_volume_resource_status("},{"line_number":61,"context_line":"            self.volumes_client, volume[\u0027id\u0027], \u0027in-use\u0027)"},{"line_number":62,"context_line":"        self.addCleanup(waiters.wait_for_volume_resource_status,"},{"line_number":63,"context_line":"                        self.volumes_client, volume[\u0027id\u0027], \u0027available\u0027)"},{"line_number":64,"context_line":"        self.addCleanup(self.volumes_client.detach_volume, volume[\u0027id\u0027])"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"        # Verify volume attachment"},{"line_number":67,"context_line":"        attachments \u003d self.volumes_client.show_volume("}],"source_content_type":"text/x-python","patch_set":3,"id":"7f515b1d_b3ae0de5","line":64,"range":{"start_line":57,"start_character":0,"end_line":64,"end_character":72},"updated":"2017-09-25 09:41:45.000000000","message":"can be replaced by base.attach_volume?","commit_id":"626479eef8650419eb8ab3d1846db7b27ebfe438"},{"author":{"_account_id":23081,"name":"Jeremy Zhang","email":"zhangjun_inspur@163.com","username":"jeremy.zhang"},"change_message_id":"25951100f422223a9824a4a194156bf2c7f9411e","unresolved":false,"context_lines":[{"line_number":54,"context_line":"        volume \u003d self.create_volume()"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"        # Attach volume"},{"line_number":57,"context_line":"        self.volumes_client.attach_volume("},{"line_number":58,"context_line":"            volume[\u0027id\u0027], instance_uuid\u003dserver[\u0027id\u0027],"},{"line_number":59,"context_line":"            mountpoint\u003d\u0027/dev/%s\u0027 % CONF.compute.volume_device_name)"},{"line_number":60,"context_line":"        waiters.wait_for_volume_resource_status("},{"line_number":61,"context_line":"            self.volumes_client, volume[\u0027id\u0027], \u0027in-use\u0027)"},{"line_number":62,"context_line":"        self.addCleanup(waiters.wait_for_volume_resource_status,"},{"line_number":63,"context_line":"                        self.volumes_client, volume[\u0027id\u0027], \u0027available\u0027)"},{"line_number":64,"context_line":"        self.addCleanup(self.volumes_client.detach_volume, volume[\u0027id\u0027])"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"        # Verify volume attachment"},{"line_number":67,"context_line":"        attachments \u003d self.volumes_client.show_volume("}],"source_content_type":"text/x-python","patch_set":3,"id":"7f515b1d_bee7c212","line":64,"range":{"start_line":57,"start_character":0,"end_line":64,"end_character":72},"in_reply_to":"7f515b1d_b3ae0de5","updated":"2017-09-26 15:37:03.000000000","message":"I would like to have a try, :)","commit_id":"626479eef8650419eb8ab3d1846db7b27ebfe438"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"b791eb4d3904903eb1692c9d2076f2d02a07b91e","unresolved":false,"context_lines":[{"line_number":72,"context_line":""},{"line_number":73,"context_line":"        # Reset attach_status to \u0027detached\u0027"},{"line_number":74,"context_line":"        self.admin_volume_client.reset_volume_status("},{"line_number":75,"context_line":"            volume[\u0027id\u0027], attach_status\u003d\u0027detached\u0027)"},{"line_number":76,"context_line":"        attachments \u003d self.volumes_client.show_volume("},{"line_number":77,"context_line":"            volume[\u0027id\u0027])[\u0027volume\u0027][\u0027attachments\u0027]"},{"line_number":78,"context_line":"        self.assertEmpty(attachments)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7f515b1d_1365e1b5","line":75,"range":{"start_line":75,"start_character":26,"end_line":75,"end_character":49},"updated":"2017-09-25 09:41:45.000000000","message":"1.after doing this, what\u0027s the expected status of volume?\n2.will volumes_client.detach_volume perform as usual when volume\u0027s attach_status is detached?","commit_id":"626479eef8650419eb8ab3d1846db7b27ebfe438"},{"author":{"_account_id":23081,"name":"Jeremy Zhang","email":"zhangjun_inspur@163.com","username":"jeremy.zhang"},"change_message_id":"25951100f422223a9824a4a194156bf2c7f9411e","unresolved":false,"context_lines":[{"line_number":72,"context_line":""},{"line_number":73,"context_line":"        # Reset attach_status to \u0027detached\u0027"},{"line_number":74,"context_line":"        self.admin_volume_client.reset_volume_status("},{"line_number":75,"context_line":"            volume[\u0027id\u0027], attach_status\u003d\u0027detached\u0027)"},{"line_number":76,"context_line":"        attachments \u003d self.volumes_client.show_volume("},{"line_number":77,"context_line":"            volume[\u0027id\u0027])[\u0027volume\u0027][\u0027attachments\u0027]"},{"line_number":78,"context_line":"        self.assertEmpty(attachments)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7f515b1d_63a77151","line":75,"range":{"start_line":75,"start_character":26,"end_line":75,"end_character":49},"in_reply_to":"7f515b1d_1365e1b5","updated":"2017-09-26 15:37:03.000000000","message":"1. Resetting attach status of volume will not have effect on status of volume, it will keep the original.\n\n2. Yes, \u0027attached\u0027 volume will still be \u0027in-use\u0027 after resetting attach_status, but the attchments will be empty. The volumes_client.detach_volume will still perform as usual.","commit_id":"626479eef8650419eb8ab3d1846db7b27ebfe438"}]}