)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"60e25b71b13bb0c735ce4f3d9668b5a0688dce0b","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Remove build files before run tox doc builder"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This may cause build failed if the old build file still existed."},{"line_number":10,"context_line":"This patch is to remove build files before run tox releasenotes"},{"line_number":11,"context_line":"and docs builder."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7f287b81_fcec80f4","line":9,"updated":"2017-08-23 01:59:00.000000000","message":"I\u0027m actually unsure that the situation of that failure. Could you provide a specific case of failure?","commit_id":"0e0ba700d320e0870208099c3e00030d3e665551"},{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"121ebede265b3cb4e2a7019a180c42a21a96a9c2","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"TrivialFix for flake8 and docs build in tox.ini"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"1. exclude \"build,tools,dist\" in flake8 section."},{"line_number":10,"context_line":"2. to ensure the old files are not left over when running these"},{"line_number":11,"context_line":"   document builds."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7f287b81_d2788bf9","line":9,"updated":"2017-08-23 05:40:35.000000000","message":"Why should we exclude these directories? I think we should care about tools directory at least.","commit_id":"575c78cb8cc5545e399421f4c39cfef72c5a886e"},{"author":{"_account_id":25456,"name":"junboli","email":"junbo85.li@gmail.com","username":"junboli"},"change_message_id":"3abb9a5a27ff130d05e8c3e7f476137dcdf2b3b6","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"TrivialFix for flake8 and docs build in tox.ini"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"1. exclude \"build,tools,dist\" in flake8 section."},{"line_number":10,"context_line":"2. to ensure the old files are not left over when running these"},{"line_number":11,"context_line":"   document builds."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7f287b81_8db78487","line":9,"in_reply_to":"7f287b81_d2788bf9","updated":"2017-08-23 06:49:30.000000000","message":"--exclude is that we don\u0027t want to generate docs from these directories.\nIn this case, \"build\" is a generated doc file directory we need to exclude. \"dist\" is doubled, \"tools\" shoud not exclude here because there are docs inside.","commit_id":"575c78cb8cc5545e399421f4c39cfef72c5a886e"},{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"121ebede265b3cb4e2a7019a180c42a21a96a9c2","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"1. exclude \"build,tools,dist\" in flake8 section."},{"line_number":10,"context_line":"2. to ensure the old files are not left over when running these"},{"line_number":11,"context_line":"   document builds."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ia5590b7816b36351559c692eebfecb3c8e6fd1a3"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7f287b81_b27dffe8","line":11,"updated":"2017-08-23 05:40:35.000000000","message":"I think sphinx can generate documents even if the old files are left if the source documents are updated. So, could you give me the specific case of this problem?","commit_id":"575c78cb8cc5545e399421f4c39cfef72c5a886e"},{"author":{"_account_id":25456,"name":"junboli","email":"junbo85.li@gmail.com","username":"junboli"},"change_message_id":"3abb9a5a27ff130d05e8c3e7f476137dcdf2b3b6","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"1. exclude \"build,tools,dist\" in flake8 section."},{"line_number":10,"context_line":"2. to ensure the old files are not left over when running these"},{"line_number":11,"context_line":"   document builds."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ia5590b7816b36351559c692eebfecb3c8e6fd1a3"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7f287b81_0dab941d","line":11,"in_reply_to":"7f287b81_b27dffe8","updated":"2017-08-23 06:49:30.000000000","message":"If one or more files are depreciated, we ought to remove those, but we still keep those files with the new generated files, with this accumulate, it will cause some junk files, let people who read the docs confuse which files are updated files.\nActually, remove the old files before generate the new ones is the normal operation.","commit_id":"575c78cb8cc5545e399421f4c39cfef72c5a886e"}],"tox.ini":[{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"60e25b71b13bb0c735ce4f3d9668b5a0688dce0b","unresolved":false,"context_lines":[{"line_number":160,"context_line":"# E129 skipped because it is too limiting when combined with other rules"},{"line_number":161,"context_line":"ignore \u003d E125,E123,E129"},{"line_number":162,"context_line":"show-source \u003d True"},{"line_number":163,"context_line":"exclude \u003d .git,.venv,.tox,dist,doc,*egg,build,tools,dist"},{"line_number":164,"context_line":"enable-extensions \u003d H106,H203,H904"},{"line_number":165,"context_line":"import-order-style \u003d pep8"},{"line_number":166,"context_line":""}],"source_content_type":"text/x-properties","patch_set":1,"id":"7f287b81_dcbb04e3","line":163,"updated":"2017-08-23 01:59:00.000000000","message":"I think it\u0027s better to mention about this in the commit message.","commit_id":"0e0ba700d320e0870208099c3e00030d3e665551"},{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"121ebede265b3cb4e2a7019a180c42a21a96a9c2","unresolved":false,"context_lines":[{"line_number":160,"context_line":"# E129 skipped because it is too limiting when combined with other rules"},{"line_number":161,"context_line":"ignore \u003d E125,E123,E129"},{"line_number":162,"context_line":"show-source \u003d True"},{"line_number":163,"context_line":"exclude \u003d .git,.venv,.tox,dist,doc,*egg,build,tools,dist"},{"line_number":164,"context_line":"enable-extensions \u003d H106,H203,H904"},{"line_number":165,"context_line":"import-order-style \u003d pep8"},{"line_number":166,"context_line":""}],"source_content_type":"text/x-properties","patch_set":2,"id":"7f287b81_928203c8","line":163,"updated":"2017-08-23 05:40:35.000000000","message":"double dist... And why did you exclude tools directory, too? I think we should care about the files under tools directory.","commit_id":"575c78cb8cc5545e399421f4c39cfef72c5a886e"},{"author":{"_account_id":25456,"name":"junboli","email":"junbo85.li@gmail.com","username":"junboli"},"change_message_id":"3abb9a5a27ff130d05e8c3e7f476137dcdf2b3b6","unresolved":false,"context_lines":[{"line_number":160,"context_line":"# E129 skipped because it is too limiting when combined with other rules"},{"line_number":161,"context_line":"ignore \u003d E125,E123,E129"},{"line_number":162,"context_line":"show-source \u003d True"},{"line_number":163,"context_line":"exclude \u003d .git,.venv,.tox,dist,doc,*egg,build,tools,dist"},{"line_number":164,"context_line":"enable-extensions \u003d H106,H203,H904"},{"line_number":165,"context_line":"import-order-style \u003d pep8"},{"line_number":166,"context_line":""}],"source_content_type":"text/x-properties","patch_set":2,"id":"7f287b81_2d21b0b5","line":163,"in_reply_to":"7f287b81_928203c8","updated":"2017-08-23 06:49:30.000000000","message":"Yes, double dist, and tools should not exclude here, there are docs inside.","commit_id":"575c78cb8cc5545e399421f4c39cfef72c5a886e"}]}