)]}'
{"tools/check_logs.py":[{"author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"change_message_id":"f9552973b731f5fb0db6e71f77c55892ad8253ac","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"usage \u003d \"\"\""},{"line_number":27,"context_line":"Find non-white-listed log errors in OpenStack log files. Log files will be"},{"line_number":28,"context_line":"searched for ERROR or TRACE messages. If any error messages do not match any"},{"line_number":29,"context_line":"of the whitelist entries contained in whitelist.yaml, those messages will be"},{"line_number":30,"context_line":"printed to the console and failure will be returned."},{"line_number":31,"context_line":"\"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATH%2F%2F9kw%3D","line":28,"updated":"2013-10-07 13:11:56.000000000","message":"It should search for the CRITICAL messages as well.","commit_id":"4e45c06cae3bb5fe50aa875733620058de7f0854"},{"author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"change_message_id":"f9552973b731f5fb0db6e71f77c55892ad8253ac","unresolved":false,"context_lines":[{"line_number":34,"context_line":"parser.add_argument(\u0027-d\u0027, \u0027--directory\u0027,"},{"line_number":35,"context_line":"                    help\u003d\"Directory containing log files\")"},{"line_number":36,"context_line":"parser.add_argument(\u0027files\u0027, nargs\u003d\u0027*\u0027,"},{"line_number":37,"context_line":"                    help\u003d\"List of log files\")"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"if __name__ \u003d\u003d \"__main__\":"},{"line_number":40,"context_line":"    sys.exit(main(parser.parse_args()))"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATH%2F%2F9i4%3D","line":37,"updated":"2013-10-07 13:11:56.000000000","message":"What is the expected using of the directory ? Will it be concatenated with all path provided as files ?","commit_id":"4e45c06cae3bb5fe50aa875733620058de7f0854"},{"author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"change_message_id":"74246b7aaea549eaf4e2246dc99f8a5a5539190d","unresolved":false,"context_lines":[{"line_number":34,"context_line":"parser.add_argument(\u0027-d\u0027, \u0027--directory\u0027,"},{"line_number":35,"context_line":"                    help\u003d\"Directory containing log files\")"},{"line_number":36,"context_line":"parser.add_argument(\u0027files\u0027, nargs\u003d\u0027*\u0027,"},{"line_number":37,"context_line":"                    help\u003d\"List of log files\")"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"if __name__ \u003d\u003d \"__main__\":"},{"line_number":40,"context_line":"    sys.exit(main(parser.parse_args()))"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATH%2F%2F9N4%3D","line":37,"in_reply_to":"AAAATH%2F%2F9cs%3D","updated":"2013-10-07 14:17:29.000000000","message":"Giulio: I would drop -d If I need to choose. you can pass several MiB file list on the stack to the child process.\n\nThe shell has globbing capabilities.","commit_id":"4e45c06cae3bb5fe50aa875733620058de7f0854"},{"author":{"_account_id":1192,"name":"David Kranz","email":"dkranz@redhat.com","username":"david-kranz"},"change_message_id":"ae5c2d12a7092bd4b1f507eca60b476a47313e83","unresolved":false,"context_lines":[{"line_number":34,"context_line":"parser.add_argument(\u0027-d\u0027, \u0027--directory\u0027,"},{"line_number":35,"context_line":"                    help\u003d\"Directory containing log files\")"},{"line_number":36,"context_line":"parser.add_argument(\u0027files\u0027, nargs\u003d\u0027*\u0027,"},{"line_number":37,"context_line":"                    help\u003d\"List of log files\")"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"if __name__ \u003d\u003d \"__main__\":"},{"line_number":40,"context_line":"    sys.exit(main(parser.parse_args()))"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATH%2F%2F9VU%3D","line":37,"in_reply_to":"AAAATH%2F%2F9cs%3D","updated":"2013-10-07 14:09:34.000000000","message":"I don\u0027t want to over-engineer this and was planning to provide a -u option to point at a url.","commit_id":"4e45c06cae3bb5fe50aa875733620058de7f0854"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"25a82dda6e236175452cc2726cf2707c6770776e","unresolved":false,"context_lines":[{"line_number":34,"context_line":"parser.add_argument(\u0027-d\u0027, \u0027--directory\u0027,"},{"line_number":35,"context_line":"                    help\u003d\"Directory containing log files\")"},{"line_number":36,"context_line":"parser.add_argument(\u0027files\u0027, nargs\u003d\u0027*\u0027,"},{"line_number":37,"context_line":"                    help\u003d\"List of log files\")"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"if __name__ \u003d\u003d \"__main__\":"},{"line_number":40,"context_line":"    sys.exit(main(parser.parse_args()))"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATH%2F%2F9cs%3D","line":37,"in_reply_to":"AAAATH%2F%2F9i4%3D","updated":"2013-10-07 13:34:53.000000000","message":"I agree with afazekas on this making some confusion. I\u0027d make -d a required option (or the dir a required argument), drop the files argument and maybe allow with an option for some arbitrary inclusion regex so that people wanting to filter files could just pass their own regexp","commit_id":"4e45c06cae3bb5fe50aa875733620058de7f0854"},{"author":{"_account_id":1192,"name":"David Kranz","email":"dkranz@redhat.com","username":"david-kranz"},"change_message_id":"ae5c2d12a7092bd4b1f507eca60b476a47313e83","unresolved":false,"context_lines":[{"line_number":34,"context_line":"parser.add_argument(\u0027-d\u0027, \u0027--directory\u0027,"},{"line_number":35,"context_line":"                    help\u003d\"Directory containing log files\")"},{"line_number":36,"context_line":"parser.add_argument(\u0027files\u0027, nargs\u003d\u0027*\u0027,"},{"line_number":37,"context_line":"                    help\u003d\"List of log files\")"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"if __name__ \u003d\u003d \"__main__\":"},{"line_number":40,"context_line":"    sys.exit(main(parser.parse_args()))"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATH%2F%2F9WQ%3D","line":37,"in_reply_to":"AAAATH%2F%2F9i4%3D","updated":"2013-10-07 14:09:34.000000000","message":"In my current version it does not, but I don\u0027t really care either way.","commit_id":"4e45c06cae3bb5fe50aa875733620058de7f0854"}]}