)]}'
{"tempest/api/compute/servers/test_list_server_filters.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"ba80aa427aa107b2965d68a00f8479d0d6e033c9","unresolved":false,"context_lines":[{"line_number":58,"context_line":"            raise RuntimeError(\"Image %s (image_ref_alt) was not found!\" %"},{"line_number":59,"context_line":"                               cls.image_ref_alt)"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"        cls.s1_name \u003d rand_name(cls.__name__ + \"-instance\")"},{"line_number":62,"context_line":"        resp, cls.s1 \u003d cls.create_server(name\u003dcls.s1_name,"},{"line_number":63,"context_line":"                                         image_id\u003dcls.image_ref,"},{"line_number":64,"context_line":"                                         flavor\u003dcls.flavor_ref,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAS3%2F%2FE1o%3D","line":61,"updated":"2013-10-04 19:56:10.000000000","message":"Note: I was kind of on the fence about defining a variable for the name here versus just letting the BaseComputeTest.create_server method create it and then later getting the server instance (like used to happen on line 72) and pull the name from that in the tests.  If I did that, we wouldn\u0027t need the s*_name variables and we wouldn\u0027t have to call get_server in the filtered_by_ip tests since we\u0027d have the name/addresses values up front.  If there are opinions of doing it that way, I can certainly do that since I think both approaches would be OK (and would remove the need for rand_name calls in this code).","commit_id":"77bb72c1219abaff34539359259533168b3c88eb"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"9bd27cc3cb2336f3914ac586d0d5664bb335b4ca","unresolved":false,"context_lines":[{"line_number":179,"context_line":""},{"line_number":180,"context_line":"    @attr(type\u003d\u0027gate\u0027)"},{"line_number":181,"context_line":"    def test_list_servers_filtered_by_name_wildcard(self):"},{"line_number":182,"context_line":"        # List all servers that contains \u0027server\u0027 in name"},{"line_number":183,"context_line":"        params \u003d {\u0027name\u0027: \u0027server\u0027}"},{"line_number":184,"context_line":"        resp, body \u003d self.client.list_servers(params)"},{"line_number":185,"context_line":"        servers \u003d body[\u0027servers\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAS3%2F%2FEvo%3D","line":182,"updated":"2013-10-04 20:30:44.000000000","message":"Missed this one because I\u0027m testing against DB2 and we have to exclude that test on DB2 since it doesn\u0027t work (nova isn\u0027t supporting the regex filtering that DB2 needs yet).  Will clean this up.","commit_id":"77bb72c1219abaff34539359259533168b3c88eb"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"7e651cdd9cd5dcfa7a5f2bfd7822324eadf6e3fe","unresolved":false,"context_lines":[{"line_number":58,"context_line":"            raise RuntimeError(\"Image %s (image_ref_alt) was not found!\" %"},{"line_number":59,"context_line":"                               cls.image_ref_alt)"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"        cls.s1_name \u003d rand_name(cls.__name__ + \u0027-instance\u0027)"},{"line_number":62,"context_line":"        resp, cls.s1 \u003d cls.create_server(name\u003dcls.s1_name,"},{"line_number":63,"context_line":"                                         image_id\u003dcls.image_ref,"},{"line_number":64,"context_line":"                                         flavor\u003dcls.flavor_ref,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAS3%2F%2FEuw%3D","line":61,"updated":"2013-10-04 20:35:25.000000000","message":"Note: I was kind of on the fence about defining a variable for the name here versus just letting the BaseComputeTest.create_server method create it and then later getting the server instance (like used to happen on line 72) and pull the name from that in the tests. If I did that, we wouldn\u0027t need the s*_name variables and we wouldn\u0027t have to call get_server in the filtered_by_ip tests since we\u0027d have the name/addresses values up front. If there are opinions of doing it that way, I can certainly do that since I think both approaches would be OK (and would remove the need for rand_name calls in this code).","commit_id":"12c29e02920ec3d8d8fb4373bbed1d47da3a3cf3"}]}