)]}'
{"tempest/api/volume/admin/test_volume_retype_with_migration.py":[{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"a1220b4ea9ccee97adcd3a058238f8e176dbeef6","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        cls.src_vol_type \u003d cls.create_volume_type(extra_specs\u003dextra_specs_src)"},{"line_number":50,"context_line":"        cls.dst_vol_type \u003d cls.create_volume_type(extra_specs\u003dextra_specs_dst)"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    def _internal_volume_cleanup(self, vol):"},{"line_number":53,"context_line":"        # When retyping a volume, Cinder creates an internal volume in the"},{"line_number":54,"context_line":"        # target backend. The volume in the source backend is deleted after"},{"line_number":55,"context_line":"        # the migration, so we need to wait for Cinder delete this volume"}],"source_content_type":"text/x-python","patch_set":8,"id":"bf659307_f2e9e17f","line":52,"range":{"start_line":52,"start_character":8,"end_line":52,"end_character":32},"updated":"2018-04-11 01:34:48.000000000","message":"how about _wait_for_internal_volume_cleanup or _wait_for_internal_volume_disappear or something like these","commit_id":"538293ce06f334ae0fb4cb1afb23ba284e5abb7e"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"8ffe4b897e9a14d5c3c9ddf1527a19a3cc08de5e","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        cls.src_vol_type \u003d cls.create_volume_type(extra_specs\u003dextra_specs_src)"},{"line_number":50,"context_line":"        cls.dst_vol_type \u003d cls.create_volume_type(extra_specs\u003dextra_specs_dst)"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    def _internal_volume_cleanup(self, vol):"},{"line_number":53,"context_line":"        # When retyping a volume, Cinder creates an internal volume in the"},{"line_number":54,"context_line":"        # target backend. The volume in the source backend is deleted after"},{"line_number":55,"context_line":"        # the migration, so we need to wait for Cinder delete this volume"}],"source_content_type":"text/x-python","patch_set":8,"id":"bf659307_14346192","line":52,"range":{"start_line":52,"start_character":8,"end_line":52,"end_character":32},"in_reply_to":"bf659307_f2e9e17f","updated":"2018-04-11 10:03:32.000000000","message":"Done","commit_id":"538293ce06f334ae0fb4cb1afb23ba284e5abb7e"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"a1220b4ea9ccee97adcd3a058238f8e176dbeef6","unresolved":false,"context_lines":[{"line_number":71,"context_line":"                break"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    def _retype_volume(self, volume):"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"        keys_with_no_change \u003d (\u0027id\u0027, \u0027size\u0027, \u0027description\u0027, \u0027name\u0027, \u0027user_id\u0027,"},{"line_number":76,"context_line":"                               \u0027os-vol-tenant-attr:tenant_id\u0027)"},{"line_number":77,"context_line":"        keys_with_change \u003d (\u0027volume_type\u0027, \u0027os-vol-host-attr:host\u0027)"}],"source_content_type":"text/x-python","patch_set":8,"id":"bf659307_d2085d2e","line":74,"updated":"2018-04-11 01:34:48.000000000","message":"no need a blank line","commit_id":"538293ce06f334ae0fb4cb1afb23ba284e5abb7e"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"8ffe4b897e9a14d5c3c9ddf1527a19a3cc08de5e","unresolved":false,"context_lines":[{"line_number":71,"context_line":"                break"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    def _retype_volume(self, volume):"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"        keys_with_no_change \u003d (\u0027id\u0027, \u0027size\u0027, \u0027description\u0027, \u0027name\u0027, \u0027user_id\u0027,"},{"line_number":76,"context_line":"                               \u0027os-vol-tenant-attr:tenant_id\u0027)"},{"line_number":77,"context_line":"        keys_with_change \u003d (\u0027volume_type\u0027, \u0027os-vol-host-attr:host\u0027)"}],"source_content_type":"text/x-python","patch_set":8,"id":"bf659307_94f631d7","line":74,"in_reply_to":"bf659307_d2085d2e","updated":"2018-04-11 10:03:32.000000000","message":"Done","commit_id":"538293ce06f334ae0fb4cb1afb23ba284e5abb7e"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"a1220b4ea9ccee97adcd3a058238f8e176dbeef6","unresolved":false,"context_lines":[{"line_number":115,"context_line":"        snapshot \u003d self.create_snapshot(src_vol[\u0027id\u0027])"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"        # Create a volume from the snapshot"},{"line_number":118,"context_line":"        src_vol \u003d self.create_volume(volume_type\u003dself.src_vol_type[\u0027name\u0027],"},{"line_number":119,"context_line":"                                     snapshot_id\u003dsnapshot[\u0027id\u0027])"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"        # Delete the snapshot"}],"source_content_type":"text/x-python","patch_set":8,"id":"bf659307_5cdd2d6e","line":118,"range":{"start_line":118,"start_character":37,"end_line":118,"end_character":75},"updated":"2018-04-11 01:34:48.000000000","message":"I am curious what will happen if we don\u0027t specify this?","commit_id":"538293ce06f334ae0fb4cb1afb23ba284e5abb7e"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"8ffe4b897e9a14d5c3c9ddf1527a19a3cc08de5e","unresolved":false,"context_lines":[{"line_number":115,"context_line":"        snapshot \u003d self.create_snapshot(src_vol[\u0027id\u0027])"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"        # Create a volume from the snapshot"},{"line_number":118,"context_line":"        src_vol \u003d self.create_volume(volume_type\u003dself.src_vol_type[\u0027name\u0027],"},{"line_number":119,"context_line":"                                     snapshot_id\u003dsnapshot[\u0027id\u0027])"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"        # Delete the snapshot"}],"source_content_type":"text/x-python","patch_set":8,"id":"bf659307_94715179","line":118,"range":{"start_line":118,"start_character":37,"end_line":118,"end_character":75},"in_reply_to":"bf659307_5cdd2d6e","updated":"2018-04-11 10:03:32.000000000","message":"The volume type of the created volume(from the snapshot) will be as the volume type of the parent volume of the snapshot.\nBut I think just in case it\u0027s better to specify the volume type.","commit_id":"538293ce06f334ae0fb4cb1afb23ba284e5abb7e"}]}