)]}'
{"tempest/api/compute/servers/test_server_actions.py":[{"author":{"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},"change_message_id":"5f786e855d0cc0a3d92c87407560a20909c1bf70","unresolved":false,"context_lines":[{"line_number":301,"context_line":"                                               \u0027SHELVED\u0027)"},{"line_number":302,"context_line":"        resp, server \u003d self.client.unshelve_server(self.server_id)"},{"line_number":303,"context_line":"        self.assertEqual(202, resp.status)"},{"line_number":304,"context_line":"        self.client.wait_for_server_status(self.server_id, \u0027ACTIVE\u0027)"},{"line_number":305,"context_line":""},{"line_number":306,"context_line":"    @classmethod"},{"line_number":307,"context_line":"    def rebuild_servers(cls):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATH%2F%2F5uw%3D","line":304,"updated":"2013-10-08 09:48:36.000000000","message":"what would happen if it fails on this line?","commit_id":"bebe15eeae065d8906301a49879f20b199ae579e"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"75b8efe78f5cd0e06718ea8d2336da9ffe618698","unresolved":false,"context_lines":[{"line_number":301,"context_line":"                                               \u0027SHELVED\u0027)"},{"line_number":302,"context_line":"        resp, server \u003d self.client.unshelve_server(self.server_id)"},{"line_number":303,"context_line":"        self.assertEqual(202, resp.status)"},{"line_number":304,"context_line":"        self.client.wait_for_server_status(self.server_id, \u0027ACTIVE\u0027)"},{"line_number":305,"context_line":""},{"line_number":306,"context_line":"    @classmethod"},{"line_number":307,"context_line":"    def rebuild_servers(cls):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATH%2F%2F4lQ%3D","line":304,"in_reply_to":"AAAATH%2F%2F5uw%3D","updated":"2013-10-08 14:16:25.000000000","message":"if unshelve fails and server_status becomes error, this line causes the time out.","commit_id":"bebe15eeae065d8906301a49879f20b199ae579e"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"8a1c0b016b473d229a4a0b2a37031890ff67b03e","unresolved":false,"context_lines":[{"line_number":260,"context_line":"                                               \u0027SHELVED\u0027)"},{"line_number":261,"context_line":"        resp, server \u003d self.client.unshelve_server(self.server_id)"},{"line_number":262,"context_line":"        self.assertEqual(202, resp.status)"},{"line_number":263,"context_line":"        # self.client.wait_for_server_status(self.server_id, \u0027ACTIVE\u0027)"},{"line_number":264,"context_line":""},{"line_number":265,"context_line":"    @attr(type\u003d\u0027gate\u0027)"},{"line_number":266,"context_line":"    def test_stop_start_server(self):"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAATH%2F%2FTdY%3D","line":263,"updated":"2013-10-18 03:03:49.000000000","message":"commented for digging the reason of unshelve failure.","commit_id":"2b82e18fb5a565bb694de2f0f41ba21d113d60b8"},{"author":{"_account_id":5292,"name":"Christopher Yeoh","email":"cbkyeoh@gmail.com","username":"cyeoh-0"},"change_message_id":"e523a42f547b40467749656adab9d12ecb0146ad","unresolved":false,"context_lines":[{"line_number":250,"context_line":"        try:"},{"line_number":251,"context_line":"            # If the shelved_offload_time of nova configuration is 0(it"},{"line_number":252,"context_line":"            # is default value), the status of shelved server should be"},{"line_number":253,"context_line":"            # SHELVED_OFFLOADED."},{"line_number":254,"context_line":"            self.client.wait_for_server_status(self.server_id,"},{"line_number":255,"context_line":"                                               \u0027SHELVED_OFFLOADED\u0027)"},{"line_number":256,"context_line":"        except exceptions.TimeoutException:"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAATn%2F%2Fkog%3D","line":253,"updated":"2013-11-01 04:41:02.000000000","message":"I think perhaps that this should be a setting in the tempest configuration rather than trying to discover it by the behavior. That way it also tests Nova not obeying shelved_offload_time correctly.","commit_id":"452fdfedcd77a34be8c03c4c4107bcd32aea389f"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"a06397266d4233641f9ffdab015ae7bd02364635","unresolved":false,"context_lines":[{"line_number":250,"context_line":"        try:"},{"line_number":251,"context_line":"            # If the shelved_offload_time of nova configuration is 0(it"},{"line_number":252,"context_line":"            # is default value), the status of shelved server should be"},{"line_number":253,"context_line":"            # SHELVED_OFFLOADED."},{"line_number":254,"context_line":"            self.client.wait_for_server_status(self.server_id,"},{"line_number":255,"context_line":"                                               \u0027SHELVED_OFFLOADED\u0027)"},{"line_number":256,"context_line":"        except exceptions.TimeoutException:"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAATn%2F%2Fkf8%3D","line":253,"in_reply_to":"AAAATn%2F%2Fkog%3D","updated":"2013-11-01 05:44:59.000000000","message":"I see, will change here.","commit_id":"452fdfedcd77a34be8c03c4c4107bcd32aea389f"},{"author":{"_account_id":5586,"name":"Ivan-Zhu","email":"zhubo198511@gmail.com","username":"ivan-zhu"},"change_message_id":"3cf49898516d89faed892dad53798c50008c0022","unresolved":false,"context_lines":[{"line_number":254,"context_line":"                                               \u0027SHELVED_OFFLOADED\u0027)"},{"line_number":255,"context_line":"        else:"},{"line_number":256,"context_line":"            self.client.wait_for_server_status(self.server_id,"},{"line_number":257,"context_line":"                                               \u0027SHELVED\u0027)"},{"line_number":258,"context_line":"        resp, server \u003d self.client.unshelve_server(self.server_id)"},{"line_number":259,"context_line":"        self.assertEqual(202, resp.status)"},{"line_number":260,"context_line":"        self.client.wait_for_server_status(self.server_id, \u0027ACTIVE\u0027)"}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAATn%2F%2Fgas%3D","line":257,"updated":"2013-11-04 03:03:59.000000000","message":"If I remember correctly, the server  will reach the \"SHELVED\" status only if the server boot from volume or have a volume attached. \nBut here we use BaseComputeTest.rebuild_server() create the server, it just boot from an image. so It won\u0027t reach the status: \"SHELVED\", regardless of self.config.compute_feature_enabled.shelved_offload.\nIf I miss something, please correct me.","commit_id":"0ea30e6e5c483f329fec2846595361feaf71ef08"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"ffa0c47dcc91f7f3af34fd7a2fb463159edd3bea","unresolved":false,"context_lines":[{"line_number":254,"context_line":"                                               \u0027SHELVED_OFFLOADED\u0027)"},{"line_number":255,"context_line":"        else:"},{"line_number":256,"context_line":"            self.client.wait_for_server_status(self.server_id,"},{"line_number":257,"context_line":"                                               \u0027SHELVED\u0027)"},{"line_number":258,"context_line":"        resp, server \u003d self.client.unshelve_server(self.server_id)"},{"line_number":259,"context_line":"        self.assertEqual(202, resp.status)"},{"line_number":260,"context_line":"        self.client.wait_for_server_status(self.server_id, \u0027ACTIVE\u0027)"}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAATn%2F%2FUtk%3D","line":257,"in_reply_to":"AAAATn%2F%2Fgas%3D","updated":"2013-11-10 22:17:49.000000000","message":"Sorry for my late response.\n\nIf shelved_offload_time of nova.conf is 0, a vm status reaches \"SHELVE_OFFLOADED\":\n\nnova/compute/manager.py\n 3501         if CONF.shelved_offload_time \u003d\u003d 0:\n 3502             instance.task_state \u003d task_states.SHELVING_OFFLOADING\n 3503         instance.power_state \u003d current_power_state\n 3504         instance.save(expected_task_state\u003d[\n 3505                 task_states.SHELVING,\n 3506                 task_states.SHELVING_IMAGE_UPLOADING])\n 3507 \n 3508         if CONF.shelved_offload_time \u003d\u003d 0:\n 3509             self.shelve_offload_instance(context, instance)\n\nThis behavior does not depend on boot_from_volume. It depends on the configuration.","commit_id":"0ea30e6e5c483f329fec2846595361feaf71ef08"},{"author":{"_account_id":5292,"name":"Christopher Yeoh","email":"cbkyeoh@gmail.com","username":"cyeoh-0"},"change_message_id":"b6400d8ca0fee4fb30ad3f7e0974232c83f76323","unresolved":false,"context_lines":[{"line_number":249,"context_line":"        resp, server \u003d self.client.shelve_server(self.server_id)"},{"line_number":250,"context_line":"        self.assertEqual(202, resp.status)"},{"line_number":251,"context_line":""},{"line_number":252,"context_line":"        if self.config.compute_feature_enabled.shelved_offload:"},{"line_number":253,"context_line":"            self.client.wait_for_server_status(self.server_id,"},{"line_number":254,"context_line":"                                               \u0027SHELVED_OFFLOADED\u0027)"},{"line_number":255,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":17,"id":"AAAATn%2F%2FPHc%3D","line":252,"updated":"2013-11-12 13:44:19.000000000","message":"So I think that if the nova shelved_offload_time is greater than build_timeout for tempest then this test will erroneously fail as the server will be in SHELVED state rather than SHELVED_OFFLOADED.\n\nPerhaps rather than having a boolean value for shelved_offload it should mirror shelved_offload_time and then work out if its going to offload within the build timeout time. If build timeout is less than shelved_offload_time then its not going to offload before timing out, so we can only look for the SHELVED state\n\nWhich unfortunately doesn\u0027t solve the problem where shelved_offload_time  is about the same as build_timeout.If its close, it may offload in time, it may not and its not really a failure. I\u0027m not sure what we should do in this case as the test will be inherently unstable (maybe have to accept both).","commit_id":"3b530c9a9ebde61c9d92493fe84368828b984a5c"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"d6d2b64b086794e7dea5339d42818efa159a2986","unresolved":false,"context_lines":[{"line_number":249,"context_line":"        resp, server \u003d self.client.shelve_server(self.server_id)"},{"line_number":250,"context_line":"        self.assertEqual(202, resp.status)"},{"line_number":251,"context_line":""},{"line_number":252,"context_line":"        if self.config.compute_feature_enabled.shelved_offload:"},{"line_number":253,"context_line":"            self.client.wait_for_server_status(self.server_id,"},{"line_number":254,"context_line":"                                               \u0027SHELVED_OFFLOADED\u0027)"},{"line_number":255,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":17,"id":"AAAATn%2F%2FPEs%3D","line":252,"in_reply_to":"AAAATn%2F%2FPHc%3D","updated":"2013-11-12 13:54:48.000000000","message":"How about extending wait_for_server_status() by adding \"extra_timeout\" argument, and passing shelved_offload_time to wait_for_server_status()?","commit_id":"3b530c9a9ebde61c9d92493fe84368828b984a5c"}],"tempest/api/compute/servers/test_servers_negative.py":[{"author":{"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},"change_message_id":"5f786e855d0cc0a3d92c87407560a20909c1bf70","unresolved":false,"context_lines":[{"line_number":331,"context_line":"        # shelve a shelved server."},{"line_number":332,"context_line":"        resp, server \u003d self.create_server(wait_until\u003d\u0027ACTIVE\u0027)"},{"line_number":333,"context_line":"        self.server_id \u003d server[\u0027id\u0027]"},{"line_number":334,"context_line":"        self.client.shelve_server(self.server_id)"},{"line_number":335,"context_line":"        try:"},{"line_number":336,"context_line":"            # If the shelved_offload_time of nova configuration is 0(it"},{"line_number":337,"context_line":"            # is default value), the status of shelved server should be"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATH%2F%2F5u4%3D","line":334,"updated":"2013-10-08 09:48:36.000000000","message":"we should check the status code of responses first. The earlier a problem is detected the easier it is to debug, especially where there is complicated setup required.","commit_id":"bebe15eeae065d8906301a49879f20b199ae579e"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"75b8efe78f5cd0e06718ea8d2336da9ffe618698","unresolved":false,"context_lines":[{"line_number":331,"context_line":"        # shelve a shelved server."},{"line_number":332,"context_line":"        resp, server \u003d self.create_server(wait_until\u003d\u0027ACTIVE\u0027)"},{"line_number":333,"context_line":"        self.server_id \u003d server[\u0027id\u0027]"},{"line_number":334,"context_line":"        self.client.shelve_server(self.server_id)"},{"line_number":335,"context_line":"        try:"},{"line_number":336,"context_line":"            # If the shelved_offload_time of nova configuration is 0(it"},{"line_number":337,"context_line":"            # is default value), the status of shelved server should be"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATH%2F%2F4ko%3D","line":334,"in_reply_to":"AAAATH%2F%2F5u4%3D","updated":"2013-10-08 14:16:25.000000000","message":"Nice catch, thanks.\nwill fix here and the following also.","commit_id":"bebe15eeae065d8906301a49879f20b199ae579e"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"3e6aded58eb11a474102934ffcbb585e507ca5a6","unresolved":false,"context_lines":[{"line_number":371,"context_line":"    def test_shelve_shelved_server(self):"},{"line_number":372,"context_line":"        # shelve a shelved server."},{"line_number":373,"context_line":"        resp, server \u003d self.client.shelve_server(self.server_id)"},{"line_number":374,"context_line":"        self.assertEqual(202, resp.status)"},{"line_number":375,"context_line":"        try:"},{"line_number":376,"context_line":"            # If the shelved_offload_time of nova configuration is 0(it"},{"line_number":377,"context_line":"            # is default value), the status of shelved server should be"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATH%2F%2FTf8%3D","line":374,"updated":"2013-10-18 01:54:32.000000000","message":"We need self.addCleanup(self.client.unshelve_server, self.server_id) like Ie1b9dc62bad2bf7b8595da2c9d6f994c646a0025","commit_id":"cade3b2049003243a26b72d85eb109d4bd9e4374"}],"tempest/config.py":[{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"e5f5a359df561e0ce138988dac9f0cb175e4ddfe","unresolved":false,"context_lines":[{"line_number":231,"context_line":"    cfg.BoolOpt(\u0027shelved_offload\u0027,"},{"line_number":232,"context_line":"                default\u003dTrue,"},{"line_number":233,"context_line":"                help\u003d\"Does the test environment offloads a vm instance cache \""},{"line_number":234,"context_line":"                     \"when shelving a vm instance? \")"},{"line_number":235,"context_line":"]"},{"line_number":236,"context_line":""},{"line_number":237,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAATn%2F%2FkOw%3D","line":234,"updated":"2013-11-01 08:02:19.000000000","message":"There is a trailing space after \u0027instance?\u0027.","commit_id":"8e19726c0366c5bef20cd12bd8436335fbc1e84a"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"7999d4122a87bf981e0ac0962fc09990f79ce543","unresolved":false,"context_lines":[{"line_number":231,"context_line":"    cfg.BoolOpt(\u0027shelved_offload\u0027,"},{"line_number":232,"context_line":"                default\u003dTrue,"},{"line_number":233,"context_line":"                help\u003d\"Does the test environment offloads a vm instance cache \""},{"line_number":234,"context_line":"                     \"when shelving a vm instance? \")"},{"line_number":235,"context_line":"]"},{"line_number":236,"context_line":""},{"line_number":237,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAATn%2F%2FkOQ%3D","line":234,"in_reply_to":"AAAATn%2F%2FkOw%3D","updated":"2013-11-01 08:07:24.000000000","message":"nice catch, will fix it.","commit_id":"8e19726c0366c5bef20cd12bd8436335fbc1e84a"},{"author":{"_account_id":5586,"name":"Ivan-Zhu","email":"zhubo198511@gmail.com","username":"ivan-zhu"},"change_message_id":"3cf49898516d89faed892dad53798c50008c0022","unresolved":false,"context_lines":[{"line_number":231,"context_line":"    cfg.BoolOpt(\u0027shelved_offload\u0027,"},{"line_number":232,"context_line":"                default\u003dTrue,"},{"line_number":233,"context_line":"                help\u003d\"Does the test environment offloads a vm instance cache \""},{"line_number":234,"context_line":"                     \"when shelving a vm instance?\")"},{"line_number":235,"context_line":"]"},{"line_number":236,"context_line":""},{"line_number":237,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAATn%2F%2Fga0%3D","line":234,"updated":"2013-11-04 03:03:59.000000000","message":"A question: in which test environment, it will offloads a vm instance cache?","commit_id":"0ea30e6e5c483f329fec2846595361feaf71ef08"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"ffa0c47dcc91f7f3af34fd7a2fb463159edd3bea","unresolved":false,"context_lines":[{"line_number":231,"context_line":"    cfg.BoolOpt(\u0027shelved_offload\u0027,"},{"line_number":232,"context_line":"                default\u003dTrue,"},{"line_number":233,"context_line":"                help\u003d\"Does the test environment offloads a vm instance cache \""},{"line_number":234,"context_line":"                     \"when shelving a vm instance?\")"},{"line_number":235,"context_line":"]"},{"line_number":236,"context_line":""},{"line_number":237,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAATn%2F%2FUtg%3D","line":234,"in_reply_to":"AAAATn%2F%2Fga0%3D","updated":"2013-11-10 22:17:49.000000000","message":"If shelved_offload_time of nova.conf is 0, a vm instance cache would be offloaded.","commit_id":"0ea30e6e5c483f329fec2846595361feaf71ef08"}],"tempest/services/compute/json/servers_client.py":[{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"e5f5a359df561e0ce138988dac9f0cb175e4ddfe","unresolved":false,"context_lines":[{"line_number":329,"context_line":"        return self.action(server_id, \u0027lock\u0027, None, **kwargs)"},{"line_number":330,"context_line":""},{"line_number":331,"context_line":"    def unlock_server(self, server_id, **kwargs):"},{"line_number":332,"context_line":"        \"\"\"UNlocks the given server.\"\"\""},{"line_number":333,"context_line":"        return self.action(server_id, \u0027unlock\u0027, None, **kwargs)"},{"line_number":334,"context_line":""},{"line_number":335,"context_line":"    def suspend_server(self, server_id, **kwargs):"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAATn%2F%2FkPc%3D","line":332,"updated":"2013-11-01 08:02:19.000000000","message":"capital \"UN\" is only here. The others are \"Un-\"","commit_id":"8e19726c0366c5bef20cd12bd8436335fbc1e84a"}]}