)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":23709,"name":"Duc Truong","email":"dkt26111@gmail.com","username":"dtruong"},"change_message_id":"361aaa887bb48e9f0eefb697de11b2fc589d25c0","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2017-09-02 20:02:07 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"allow to config port bind:profile"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I9b562aaabf960d38f623d88e8b88619edbb70fe8"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7f287b81_05f9eb7e","line":8,"updated":"2017-09-05 17:13:11.000000000","message":"Please provide some explanation why this change is necessary","commit_id":"ee8f993a0dd9da95fb74058cde61719460965560"},{"author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"change_message_id":"424421e1542309e1ce938db4eeded2ce9184a7c6","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2017-09-02 20:02:07 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"allow to config port bind:profile"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I9b562aaabf960d38f623d88e8b88619edbb70fe8"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3f4b6375_3d1bca1b","line":8,"in_reply_to":"7f287b81_05f9eb7e","updated":"2017-11-01 23:30:57.000000000","message":"Done","commit_id":"ee8f993a0dd9da95fb74058cde61719460965560"}],"releasenotes/notes/add-port-profile-config-option-2610b2fa67027960.yaml":[{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"057033396379d969cbde64fd14cad6be3c5d3f35","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    able to test this we need profile capability support"},{"line_number":7,"context_line":"    in Tempest as well."},{"line_number":8,"context_line":"features:"},{"line_number":9,"context_line":"  - Adding ability to create Neutron port with binding-profile"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"3fa0c359_f11bb57d","line":9,"range":{"start_line":9,"start_character":4,"end_line":9,"end_character":62},"updated":"2018-02-24 03:16:47.000000000","message":"Better to mention in what section, what item is added in config file.\nThe content of tempest/releasenotes/notes/add-floating-ip-config-option-e5774bf77702ce9f.yaml is an sample.","commit_id":"b6cc9c26526add79c191fa12427aa937ffd4695d"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"e6ba8a446215690be5d8992ba357edc102b689d1","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    able to test this we need profile capability support"},{"line_number":7,"context_line":"    in Tempest as well."},{"line_number":8,"context_line":"features:"},{"line_number":9,"context_line":"  - A new config option in the network section to specify"},{"line_number":10,"context_line":"    capabilities of the port."},{"line_number":11,"context_line":"    default this is set to {}."}],"source_content_type":"text/x-yaml","patch_set":9,"id":"3fa0c359_68b24ce7","line":11,"range":{"start_line":9,"start_character":0,"end_line":11,"end_character":30},"updated":"2018-02-26 02:23:04.000000000","message":"How about:\n  - A new config option \u0027port_profile\u0027 is added to the section\n    \u0027network\u0027 to specify capabilities of the port.\n    By default this is set to {}.","commit_id":"a79262bfcd6db59dc5b614dcc83a752cb807c4cd"},{"author":{"_account_id":14807,"name":"Lenny","email":"lennyb@mellanox.com","username":"lennyb"},"change_message_id":"4dcf0a918b201fda0cf4ca95b4ac8faaef4e36fb","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    able to test this we need profile capability support"},{"line_number":7,"context_line":"    in Tempest as well."},{"line_number":8,"context_line":"features:"},{"line_number":9,"context_line":"  - A new config option in the network section to specify"},{"line_number":10,"context_line":"    capabilities of the port."},{"line_number":11,"context_line":"    default this is set to {}."}],"source_content_type":"text/x-yaml","patch_set":9,"id":"3fa0c359_fe2db28e","line":11,"range":{"start_line":9,"start_character":0,"end_line":11,"end_character":30},"in_reply_to":"3fa0c359_68b24ce7","updated":"2018-02-26 06:24:38.000000000","message":"Fixed.\nThanks a lot for a review.","commit_id":"a79262bfcd6db59dc5b614dcc83a752cb807c4cd"}],"tempest/config.py":[{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"9a8f6ca84e479226ad90b10af67e3e98d137aa4d","unresolved":false,"context_lines":[{"line_number":618,"context_line":"                     \" for subnet creation\"),"},{"line_number":619,"context_line":"    cfg.StrOpt(\u0027port_vnic_type\u0027,"},{"line_number":620,"context_line":"               choices\u003d[None, \u0027normal\u0027, \u0027direct\u0027, \u0027macvtap\u0027],"},{"line_number":621,"context_line":"               help\u003d\"vnic_type to use when Launching instances\""},{"line_number":622,"context_line":"                    \" with pre-configured ports.\""},{"line_number":623,"context_line":"                    \" Supported ports are:\""},{"line_number":624,"context_line":"                    \" [\u0027normal\u0027,\u0027direct\u0027,\u0027macvtap\u0027]\"),"}],"source_content_type":"text/x-python","patch_set":5,"id":"bf8cb3f7_4d09412f","line":621,"range":{"start_line":621,"start_character":43,"end_line":621,"end_character":44},"updated":"2017-12-25 08:10:13.000000000","message":"ditto","commit_id":"e0119f91b1a5c32e8e37e5956c7a78cd05cc8b48"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"9a8f6ca84e479226ad90b10af67e3e98d137aa4d","unresolved":false,"context_lines":[{"line_number":624,"context_line":"                    \" [\u0027normal\u0027,\u0027direct\u0027,\u0027macvtap\u0027]\"),"},{"line_number":625,"context_line":"    cfg.DictOpt(\u0027port_profile\u0027,"},{"line_number":626,"context_line":"                default\u003d{},"},{"line_number":627,"context_line":"                help\u003d\"port profile to use when Launching instances\""},{"line_number":628,"context_line":"                     \" with pre-configured ports.\"),"},{"line_number":629,"context_line":"    cfg.ListOpt(\u0027default_network\u0027,"},{"line_number":630,"context_line":"                default\u003d[\"1.0.0.0/16\", \"2.0.0.0/16\"],"}],"source_content_type":"text/x-python","patch_set":5,"id":"bf8cb3f7_6d14454f","line":627,"range":{"start_line":627,"start_character":47,"end_line":627,"end_character":48},"updated":"2017-12-25 08:10:13.000000000","message":"l","commit_id":"e0119f91b1a5c32e8e37e5956c7a78cd05cc8b48"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"a7c4c3deb5d9473f545080983d17a75784ae1fa8","unresolved":false,"context_lines":[{"line_number":622,"context_line":"                    \" with pre-configured ports.\""},{"line_number":623,"context_line":"                    \" Supported ports are:\""},{"line_number":624,"context_line":"                    \" [\u0027normal\u0027,\u0027direct\u0027,\u0027macvtap\u0027]\"),"},{"line_number":625,"context_line":"    cfg.DictOpt(\u0027port_profile\u0027,"},{"line_number":626,"context_line":"                default\u003d{},"},{"line_number":627,"context_line":"                help\u003d\"port profile to use when launching instances\""},{"line_number":628,"context_line":"                     \" with pre-configured ports.\"),"}],"source_content_type":"text/x-python","patch_set":6,"id":"9f91af0f_549c09bf","line":625,"range":{"start_line":625,"start_character":4,"end_line":625,"end_character":31},"updated":"2018-01-09 02:06:29.000000000","message":"better to add a reno file for this new option","commit_id":"ab430097d09193000cdc9ffbf130ad6e2b37e063"}],"tempest/scenario/manager.py":[{"author":{"_account_id":14807,"name":"Lenny","email":"lennyb@mellanox.com","username":"lennyb"},"change_message_id":"fd058b518c943cd96b86b047dc2f1e6ccc200f34","unresolved":false,"context_lines":[{"line_number":149,"context_line":"            ports \u003d []"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"            create_port_body \u003d {\u0027binding:vnic_type\u0027: vnic_type,"},{"line_number":152,"context_line":"                                \u0027binding:profile\u0027: profile,"},{"line_number":153,"context_line":"                                \u0027namestart\u0027: \u0027port-smoke\u0027}"},{"line_number":154,"context_line":"            if kwargs:"},{"line_number":155,"context_line":"                # Convert security group names to security group ids"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f2577a7_89d91123","line":152,"updated":"2017-09-18 13:44:52.000000000","message":"Don\u0027t you need to check that profile was set?","commit_id":"ee8f993a0dd9da95fb74058cde61719460965560"},{"author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"change_message_id":"424421e1542309e1ce938db4eeded2ce9184a7c6","unresolved":false,"context_lines":[{"line_number":149,"context_line":"            ports \u003d []"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"            create_port_body \u003d {\u0027binding:vnic_type\u0027: vnic_type,"},{"line_number":152,"context_line":"                                \u0027binding:profile\u0027: profile,"},{"line_number":153,"context_line":"                                \u0027namestart\u0027: \u0027port-smoke\u0027}"},{"line_number":154,"context_line":"            if kwargs:"},{"line_number":155,"context_line":"                # Convert security group names to security group ids"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f4b6375_5d1c4612","line":152,"in_reply_to":"5f2577a7_89d91123","updated":"2017-11-01 23:30:57.000000000","message":"no the default is {}","commit_id":"ee8f993a0dd9da95fb74058cde61719460965560"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"a7c4c3deb5d9473f545080983d17a75784ae1fa8","unresolved":false,"context_lines":[{"line_number":147,"context_line":"            ports \u003d []"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"            create_port_body \u003d {\u0027binding:vnic_type\u0027: vnic_type,"},{"line_number":150,"context_line":"                                \u0027binding:profile\u0027: profile}"},{"line_number":151,"context_line":"            if kwargs:"},{"line_number":152,"context_line":"                # Convert security group names to security group ids"},{"line_number":153,"context_line":"                # to pass to create_port"}],"source_content_type":"text/x-python","patch_set":6,"id":"9f91af0f_5438899e","line":150,"range":{"start_line":150,"start_character":32,"end_line":150,"end_character":58},"updated":"2018-01-09 02:06:29.000000000","message":"Is it ok to pass \"\u0027binding:profile\u0027: {}\" for all systems?\nIf yes then no problem.","commit_id":"ab430097d09193000cdc9ffbf130ad6e2b37e063"},{"author":{"_account_id":14807,"name":"Lenny","email":"lennyb@mellanox.com","username":"lennyb"},"change_message_id":"d549f5a2d411f523ae546801626d70ace4962c84","unresolved":false,"context_lines":[{"line_number":147,"context_line":"            ports \u003d []"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"            create_port_body \u003d {\u0027binding:vnic_type\u0027: vnic_type,"},{"line_number":150,"context_line":"                                \u0027binding:profile\u0027: profile}"},{"line_number":151,"context_line":"            if kwargs:"},{"line_number":152,"context_line":"                # Convert security group names to security group ids"},{"line_number":153,"context_line":"                # to pass to create_port"}],"source_content_type":"text/x-python","patch_set":6,"id":"7f96bb07_797cf5ea","line":150,"range":{"start_line":150,"start_character":32,"end_line":150,"end_character":58},"in_reply_to":"9f91af0f_5438899e","updated":"2018-01-14 12:45:26.000000000","message":"yes. All the systems will get empty dict","commit_id":"ab430097d09193000cdc9ffbf130ad6e2b37e063"},{"author":{"_account_id":25805,"name":"Yu Shengzuo","email":"yu.shengzuo@99cloud.net","username":"yuc"},"change_message_id":"7649aa1001d933f5ce5ad2b492dc658f1ff0dbb5","unresolved":false,"context_lines":[{"line_number":152,"context_line":"                # Convert security group names to security group ids"},{"line_number":153,"context_line":"                # to pass to create_port"},{"line_number":154,"context_line":"                if \u0027security_groups\u0027 in kwargs:"},{"line_number":155,"context_line":"                    security_groups \u003d \\"},{"line_number":156,"context_line":"                        clients.security_groups_client.list_security_groups("},{"line_number":157,"context_line":"                        ).get(\u0027security_groups\u0027)"},{"line_number":158,"context_line":"                    sec_dict \u003d dict([(s[\u0027name\u0027], s[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":6,"id":"bf8cb3f7_b76a7eb0","line":155,"range":{"start_line":155,"start_character":38,"end_line":155,"end_character":39},"updated":"2017-12-27 11:23:54.000000000","message":"Bad code-style\nbetter:\n     security_groups \u003d(\n        clients.security_groups_client.list_security_groups(","commit_id":"ab430097d09193000cdc9ffbf130ad6e2b37e063"},{"author":{"_account_id":14807,"name":"Lenny","email":"lennyb@mellanox.com","username":"lennyb"},"change_message_id":"457d887484072a194997495c292374d593af2494","unresolved":false,"context_lines":[{"line_number":152,"context_line":"                # Convert security group names to security group ids"},{"line_number":153,"context_line":"                # to pass to create_port"},{"line_number":154,"context_line":"                if \u0027security_groups\u0027 in kwargs:"},{"line_number":155,"context_line":"                    security_groups \u003d \\"},{"line_number":156,"context_line":"                        clients.security_groups_client.list_security_groups("},{"line_number":157,"context_line":"                        ).get(\u0027security_groups\u0027)"},{"line_number":158,"context_line":"                    sec_dict \u003d dict([(s[\u0027name\u0027], s[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":6,"id":"bf8cb3f7_da1de90f","line":155,"range":{"start_line":155,"start_character":38,"end_line":155,"end_character":39},"in_reply_to":"bf8cb3f7_b76a7eb0","updated":"2018-01-04 08:58:06.000000000","message":"this code is not related to the patch","commit_id":"ab430097d09193000cdc9ffbf130ad6e2b37e063"}]}