)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"baf827330887362884a597aca155d58a797882a3","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fixes test_network_basic_ops"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Removes the use of keypairs from the ssh test and replaces it with the use of a"},{"line_number":10,"context_line":"password"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I37fa3c729144f9a6d73cde06088142f1fb16467f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAATH%2F%2F2EY%3D","line":9,"updated":"2013-10-09 03:21:13.000000000","message":"you\u0027re not really removing the use of keypairs","commit_id":"9ffd6c4e926bcf693f289d180fb2336a655e1e89"}],"tempest/scenario/manager.py":[{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"baf827330887362884a597aca155d58a797882a3","unresolved":false,"context_lines":[{"line_number":622,"context_line":""},{"line_number":623,"context_line":"    def _is_reachable_via_ssh_password(self, ip_address, username, timeout):"},{"line_number":624,"context_line":"        ssh_client \u003d ssh.Client(ip_address, username,"},{"line_number":625,"context_line":"                                self.config.compute.image_ssh_password,"},{"line_number":626,"context_line":"                                timeout\u003dtimeout)"},{"line_number":627,"context_line":"        return ssh_client.test_connection_auth()"},{"line_number":628,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2F2EA%3D","line":625,"updated":"2013-10-09 03:21:13.000000000","message":"I can\u0027t see this in the config file","commit_id":"9ffd6c4e926bcf693f289d180fb2336a655e1e89"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"7759d1c8819ed789e294e4f32d5dd1690a530b5e","unresolved":false,"context_lines":[{"line_number":622,"context_line":""},{"line_number":623,"context_line":"    def _is_reachable_via_ssh_password(self, ip_address, username, timeout):"},{"line_number":624,"context_line":"        ssh_client \u003d ssh.Client(ip_address, username,"},{"line_number":625,"context_line":"                                self.config.compute.image_ssh_password,"},{"line_number":626,"context_line":"                                timeout\u003dtimeout)"},{"line_number":627,"context_line":"        return ssh_client.test_connection_auth()"},{"line_number":628,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2F13k%3D","line":625,"in_reply_to":"AAAATH%2F%2F18A%3D","updated":"2013-10-09 05:43:42.000000000","message":"indeed it\u0027s in the sample file too, I was looking into a branch, sorry about that","commit_id":"9ffd6c4e926bcf693f289d180fb2336a655e1e89"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"29edcaf64505a425c1cbb30f0d76da90ee1a1534","unresolved":false,"context_lines":[{"line_number":622,"context_line":""},{"line_number":623,"context_line":"    def _is_reachable_via_ssh_password(self, ip_address, username, timeout):"},{"line_number":624,"context_line":"        ssh_client \u003d ssh.Client(ip_address, username,"},{"line_number":625,"context_line":"                                self.config.compute.image_ssh_password,"},{"line_number":626,"context_line":"                                timeout\u003dtimeout)"},{"line_number":627,"context_line":"        return ssh_client.test_connection_auth()"},{"line_number":628,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2F18A%3D","line":625,"in_reply_to":"AAAATH%2F%2F2EA%3D","updated":"2013-10-09 04:26:52.000000000","message":"A quick grep shows it does appear in config.py, and has for some time.  It\u0027s also configured by devstack.","commit_id":"9ffd6c4e926bcf693f289d180fb2336a655e1e89"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"baf827330887362884a597aca155d58a797882a3","unresolved":false,"context_lines":[{"line_number":633,"context_line":"                                timeout\u003dtimeout)"},{"line_number":634,"context_line":"        return ssh_client.test_connection_auth()"},{"line_number":635,"context_line":""},{"line_number":636,"context_line":"    def _check_vm_connectivity(self, ip_address, username, private_key):"},{"line_number":637,"context_line":"        result_ping \u003d self._ping_ip_address(ip_address)"},{"line_number":638,"context_line":"        self.assertTrue("},{"line_number":639,"context_line":"            result_ping,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2F2D8%3D","line":636,"updated":"2013-10-09 03:21:13.000000000","message":"this will fail unless both _password and _keypair succeed","commit_id":"9ffd6c4e926bcf693f289d180fb2336a655e1e89"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"7759d1c8819ed789e294e4f32d5dd1690a530b5e","unresolved":false,"context_lines":[{"line_number":633,"context_line":"                                timeout\u003dtimeout)"},{"line_number":634,"context_line":"        return ssh_client.test_connection_auth()"},{"line_number":635,"context_line":""},{"line_number":636,"context_line":"    def _check_vm_connectivity(self, ip_address, username, private_key):"},{"line_number":637,"context_line":"        result_ping \u003d self._ping_ip_address(ip_address)"},{"line_number":638,"context_line":"        self.assertTrue("},{"line_number":639,"context_line":"            result_ping,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2F1yQ%3D","line":636,"in_reply_to":"AAAATH%2F%2F16k%3D","updated":"2013-10-09 05:43:42.000000000","message":"I see what you mean but this would also require the images to have some particular password set and I\u0027m not sure about the benefits.","commit_id":"9ffd6c4e926bcf693f289d180fb2336a655e1e89"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"29edcaf64505a425c1cbb30f0d76da90ee1a1534","unresolved":false,"context_lines":[{"line_number":633,"context_line":"                                timeout\u003dtimeout)"},{"line_number":634,"context_line":"        return ssh_client.test_connection_auth()"},{"line_number":635,"context_line":""},{"line_number":636,"context_line":"    def _check_vm_connectivity(self, ip_address, username, private_key):"},{"line_number":637,"context_line":"        result_ping \u003d self._ping_ip_address(ip_address)"},{"line_number":638,"context_line":"        self.assertTrue("},{"line_number":639,"context_line":"            result_ping,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2F16k%3D","line":636,"in_reply_to":"AAAATH%2F%2F2D8%3D","updated":"2013-10-09 04:26:52.000000000","message":"That\u0027s by design - the goal is to narrow the failure mode.  If password-based auth succeeds but key-based auth fails, the implication is that ip reuse is causing the wrong vm to be contacted.  If only key-based auth is tested, we can\u0027t determine whether a routing problem or ip reuse is the cause of a failure.","commit_id":"9ffd6c4e926bcf693f289d180fb2336a655e1e89"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"5fd141c1d19c6a6e371178508df99e2160b39554","unresolved":false,"context_lines":[{"line_number":620,"context_line":"        return tempest.test.call_until_true("},{"line_number":621,"context_line":"            ping, self.config.compute.ping_timeout, 1)"},{"line_number":622,"context_line":""},{"line_number":623,"context_line":"    def _is_reachable_via_ssh_password(self, ip_address, username, timeout):"},{"line_number":624,"context_line":"        ssh_client \u003d ssh.Client(ip_address, username,"},{"line_number":625,"context_line":"                                self.config.compute.image_ssh_password,"},{"line_number":626,"context_line":"                                timeout\u003dtimeout)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATH%2F%2FwKw%3D","line":623,"updated":"2013-10-10 10:38:40.000000000","message":"nit: with_password","commit_id":"a14485d78909e6681a600da66cd2a4d2a77de051"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"5fd141c1d19c6a6e371178508df99e2160b39554","unresolved":false,"context_lines":[{"line_number":626,"context_line":"                                timeout\u003dtimeout)"},{"line_number":627,"context_line":"        return ssh_client.test_connection_auth()"},{"line_number":628,"context_line":""},{"line_number":629,"context_line":"    def _is_reachable_via_ssh_keypair(self, ip_address, username, private_key,"},{"line_number":630,"context_line":"                                      timeout):"},{"line_number":631,"context_line":"        ssh_client \u003d ssh.Client(ip_address, username,"},{"line_number":632,"context_line":"                                pkey\u003dprivate_key,"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATH%2F%2FwKs%3D","line":629,"updated":"2013-10-10 10:38:40.000000000","message":"nit: with_key","commit_id":"a14485d78909e6681a600da66cd2a4d2a77de051"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"5fd141c1d19c6a6e371178508df99e2160b39554","unresolved":false,"context_lines":[{"line_number":638,"context_line":"        self.assertTrue("},{"line_number":639,"context_line":"            result_ping,"},{"line_number":640,"context_line":"            \"Timed out waiting for %s to become reachable\" % ip_address)"},{"line_number":641,"context_line":"        result_ssh \u003d self._is_reachable_via_ssh_password("},{"line_number":642,"context_line":"            ip_address, username, self.config.compute.ssh_timeout)"},{"line_number":643,"context_line":"        self.assertTrue("},{"line_number":644,"context_line":"            result_ssh,"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATH%2F%2FwJs%3D","line":641,"updated":"2013-10-10 10:38:40.000000000","message":"perhaps the ssh password check should be skipped if compute.image_ssh_password s not defined?","commit_id":"a14485d78909e6681a600da66cd2a4d2a77de051"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"1648541b69e4917b3abaa8d5ee188681f8d4643f","unresolved":false,"context_lines":[{"line_number":638,"context_line":"        self.assertTrue("},{"line_number":639,"context_line":"            result_ping,"},{"line_number":640,"context_line":"            \"Timed out waiting for %s to become reachable\" % ip_address)"},{"line_number":641,"context_line":"        result_ssh \u003d self._is_reachable_via_ssh_password("},{"line_number":642,"context_line":"            ip_address, username, self.config.compute.ssh_timeout)"},{"line_number":643,"context_line":"        self.assertTrue("},{"line_number":644,"context_line":"            result_ssh,"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATH%2F%2Fs40%3D","line":641,"in_reply_to":"AAAATH%2F%2FwJs%3D","updated":"2013-10-11 00:22:45.000000000","message":"+1","commit_id":"a14485d78909e6681a600da66cd2a4d2a77de051"}],"tempest/scenario/test_network_basic_ops.py":[{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"5fd141c1d19c6a6e371178508df99e2160b39554","unresolved":false,"context_lines":[{"line_number":17,"context_line":"#    under the License."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from tempest.api.network import common as net_common"},{"line_number":20,"context_line":"#from tempest.common import debug"},{"line_number":21,"context_line":"from tempest.common.utils.data_utils import rand_name"},{"line_number":22,"context_line":"from tempest import config"},{"line_number":23,"context_line":"from tempest.openstack.common import log as logging"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATH%2F%2FwJo%3D","line":20,"updated":"2013-10-10 10:38:40.000000000","message":"why?","commit_id":"a14485d78909e6681a600da66cd2a4d2a77de051"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"5fd141c1d19c6a6e371178508df99e2160b39554","unresolved":false,"context_lines":[{"line_number":254,"context_line":"                                                private_key)"},{"line_number":255,"context_line":"        except Exception as exc:"},{"line_number":256,"context_line":"            LOG.exception(exc)"},{"line_number":257,"context_line":"            #debug.log_ip_ns()"},{"line_number":258,"context_line":"            raise exc"},{"line_number":259,"context_line":""},{"line_number":260,"context_line":"    @attr(type\u003d\u0027smoke\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATH%2F%2FwJk%3D","line":257,"updated":"2013-10-10 10:38:40.000000000","message":"why?","commit_id":"a14485d78909e6681a600da66cd2a4d2a77de051"}]}