)]}'
{"tempest/common/validation_resources.py":[{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"aaccfc5a42bad0c913e7bc7beda7ac87be32eb43","unresolved":false,"context_lines":[{"line_number":117,"context_line":"                           \u0027First cleanup exception: %s\u0027)"},{"line_number":118,"context_line":"                    # The exceptions logging is already handled, so using"},{"line_number":119,"context_line":"                    # debug here just to provide more context"},{"line_number":120,"context_line":"                    LOG.debug(msg, sgc_exc, cleanup_exc)"},{"line_number":121,"context_line":"    LOG.debug(\"SSH Validation resource security group with tcp and icmp \""},{"line_number":122,"context_line":"              \"rules %s created\", sg_name)"},{"line_number":123,"context_line":"    return security_group"}],"source_content_type":"text/x-python","patch_set":3,"id":"7f287b81_079c2cbe","line":120,"updated":"2017-09-06 18:32:23.000000000","message":"Same as the other place","commit_id":"73d45473ebbb9ca03a5152e93c21d705af0268c4"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"0b4e7b31cd8b81204f3b01feba8d7396c53f31d5","unresolved":false,"context_lines":[{"line_number":117,"context_line":"                           \u0027First cleanup exception: %s\u0027)"},{"line_number":118,"context_line":"                    # The exceptions logging is already handled, so using"},{"line_number":119,"context_line":"                    # debug here just to provide more context"},{"line_number":120,"context_line":"                    LOG.debug(msg, sgc_exc, cleanup_exc)"},{"line_number":121,"context_line":"    LOG.debug(\"SSH Validation resource security group with tcp and icmp \""},{"line_number":122,"context_line":"              \"rules %s created\", sg_name)"},{"line_number":123,"context_line":"    return security_group"}],"source_content_type":"text/x-python","patch_set":3,"id":"7f287b81_cdd9a556","line":120,"in_reply_to":"7f287b81_079c2cbe","updated":"2017-09-06 19:42:36.000000000","message":"Done","commit_id":"73d45473ebbb9ca03a5152e93c21d705af0268c4"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"b0eb8225d5741a5d2059bd77d6433056051318c1","unresolved":false,"context_lines":[{"line_number":241,"context_line":"                           \u0027Provisioning exception: %s\\n\u0027"},{"line_number":242,"context_line":"                           \u0027First cleanup exception: %s\u0027)"},{"line_number":243,"context_line":"                    # The exceptions logging is already handled, so using"},{"line_number":244,"context_line":"                    # debug here just to provide more context"},{"line_number":245,"context_line":"                    LOG.debug(msg, prov_exc, cleanup_exc)"},{"line_number":246,"context_line":"    return validation_data"},{"line_number":247,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7f287b81_b3847ad4","line":244,"range":{"start_line":244,"start_character":22,"end_line":244,"end_character":27},"updated":"2017-09-06 20:49:09.000000000","message":"Given comment below, this comment no longer applies.","commit_id":"73d45473ebbb9ca03a5152e93c21d705af0268c4"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"aaccfc5a42bad0c913e7bc7beda7ac87be32eb43","unresolved":false,"context_lines":[{"line_number":242,"context_line":"                           \u0027First cleanup exception: %s\u0027)"},{"line_number":243,"context_line":"                    # The exceptions logging is already handled, so using"},{"line_number":244,"context_line":"                    # debug here just to provide more context"},{"line_number":245,"context_line":"                    LOG.debug(msg, prov_exc, cleanup_exc)"},{"line_number":246,"context_line":"    return validation_data"},{"line_number":247,"context_line":""},{"line_number":248,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7f287b81_e7a000f7","line":245,"updated":"2017-09-06 18:32:23.000000000","message":"You don\u0027t want to just do log exception here? Isn\u0027t this also an error condition? Just because it happens during our failure cleanup does that really change anything?","commit_id":"73d45473ebbb9ca03a5152e93c21d705af0268c4"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"0b4e7b31cd8b81204f3b01feba8d7396c53f31d5","unresolved":false,"context_lines":[{"line_number":242,"context_line":"                           \u0027First cleanup exception: %s\u0027)"},{"line_number":243,"context_line":"                    # The exceptions logging is already handled, so using"},{"line_number":244,"context_line":"                    # debug here just to provide more context"},{"line_number":245,"context_line":"                    LOG.debug(msg, prov_exc, cleanup_exc)"},{"line_number":246,"context_line":"    return validation_data"},{"line_number":247,"context_line":""},{"line_number":248,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7f287b81_adde593b","line":245,"in_reply_to":"7f287b81_e7a000f7","updated":"2017-09-06 19:42:36.000000000","message":"Done","commit_id":"73d45473ebbb9ca03a5152e93c21d705af0268c4"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"76d5926ea0e8b6365c0c022688e68918db762328","unresolved":false,"context_lines":[{"line_number":216,"context_line":"    except Exception as prov_exc:"},{"line_number":217,"context_line":"        # If something goes wrong, cleanup as much as possible before we"},{"line_number":218,"context_line":"        # re-raise the exception"},{"line_number":219,"context_line":"        if validation_data:"},{"line_number":220,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":221,"context_line":"                # Cleanup may fail as well"},{"line_number":222,"context_line":"                try:"}],"source_content_type":"text/x-python","patch_set":4,"id":"7f287b81_dba6f10f","line":219,"range":{"start_line":219,"start_character":8,"end_line":219,"end_character":27},"updated":"2017-09-07 07:42:52.000000000","message":"if exception was raised when provisioning first resource, then that exception won\u0027t be thrown out?","commit_id":"51754fbbeea8be3b5eb4c025d6acda81e652476a"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"264b877c897bc40991269c7f8b6b74ceb7caa242","unresolved":false,"context_lines":[{"line_number":216,"context_line":"    except Exception as prov_exc:"},{"line_number":217,"context_line":"        # If something goes wrong, cleanup as much as possible before we"},{"line_number":218,"context_line":"        # re-raise the exception"},{"line_number":219,"context_line":"        if validation_data:"},{"line_number":220,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":221,"context_line":"                # Cleanup may fail as well"},{"line_number":222,"context_line":"                try:"}],"source_content_type":"text/x-python","patch_set":4,"id":"7f287b81_160b2b24","line":219,"range":{"start_line":219,"start_character":8,"end_line":219,"end_character":27},"in_reply_to":"7f287b81_dba6f10f","updated":"2017-09-07 10:12:24.000000000","message":"good catch, thanks","commit_id":"51754fbbeea8be3b5eb4c025d6acda81e652476a"}],"tempest/lib/common/validation_resources.py":[{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"8fbeb957dad67e067f070fe9dad69bf534db068b","unresolved":false,"context_lines":[{"line_number":114,"context_line":"                           \u0027The cleanup was triggered by an exception during \u0027"},{"line_number":115,"context_line":"                           \u0027the provisioning of security group rules.\\n\u0027"},{"line_number":116,"context_line":"                           \u0027Provisioning exception: %s\\n\u0027"},{"line_number":117,"context_line":"                           \u0027First cleanup exception: %s\u0027)"},{"line_number":118,"context_line":"                    # The exceptions logging is already handled, so using"},{"line_number":119,"context_line":"                    # debug here just to provide more context"},{"line_number":120,"context_line":"                    LOG.debug(msg, sgc_exc, cleanup_exc)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f287b81_b16933bf","line":117,"updated":"2017-09-06 00:00:23.000000000","message":"nit: The use of \"First\" in this sentence is a little confusing, because I understand it to mean, \"The first exception that happened.\"","commit_id":"1e866ad832366d6eb33fa415a74e5e1f7fe74cc2"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"22380ec6ec6c38d61d065bf13759566b746e1fe5","unresolved":false,"context_lines":[{"line_number":183,"context_line":"    \"\"\""},{"line_number":184,"context_line":"    # Create and Return the validation resources required to validate a VM"},{"line_number":185,"context_line":"    validation_data \u003d {}"},{"line_number":186,"context_line":"    try:"},{"line_number":187,"context_line":"        if keypair:"},{"line_number":188,"context_line":"            keypair_name \u003d data_utils.rand_name(\u0027keypair\u0027)"},{"line_number":189,"context_line":"            validation_data.update("}],"source_content_type":"text/x-python","patch_set":2,"id":"7f287b81_075917fd","line":186,"range":{"start_line":186,"start_character":4,"end_line":186,"end_character":8},"updated":"2017-09-04 06:37:17.000000000","message":"it seems even if without this, resources already provisioned will be deleted in resource_cleanup?","commit_id":"1e866ad832366d6eb33fa415a74e5e1f7fe74cc2"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"d78256f597ff0ccfef4613cb3452f1905e6b03c3","unresolved":false,"context_lines":[{"line_number":183,"context_line":"    \"\"\""},{"line_number":184,"context_line":"    # Create and Return the validation resources required to validate a VM"},{"line_number":185,"context_line":"    validation_data \u003d {}"},{"line_number":186,"context_line":"    try:"},{"line_number":187,"context_line":"        if keypair:"},{"line_number":188,"context_line":"            keypair_name \u003d data_utils.rand_name(\u0027keypair\u0027)"},{"line_number":189,"context_line":"            validation_data.update("}],"source_content_type":"text/x-python","patch_set":2,"id":"7f287b81_b36ede93","line":186,"range":{"start_line":186,"start_character":4,"end_line":186,"end_character":8},"in_reply_to":"7f287b81_075917fd","updated":"2017-09-05 20:20:21.000000000","message":"no they won\u0027t - if there is an exception during the provisioning process validation_data is not returned and resource_cleanup won\u0027t have anything to cleanup","commit_id":"1e866ad832366d6eb33fa415a74e5e1f7fe74cc2"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"8fbeb957dad67e067f070fe9dad69bf534db068b","unresolved":false,"context_lines":[{"line_number":239,"context_line":"                           \u0027The cleanup was triggered by an exception during \u0027"},{"line_number":240,"context_line":"                           \u0027the provisioning step.\\n\u0027"},{"line_number":241,"context_line":"                           \u0027Provisioning exception: %s\\n\u0027"},{"line_number":242,"context_line":"                           \u0027First cleanup exception: %s\u0027)"},{"line_number":243,"context_line":"                    # The exceptions logging is already handled, so using"},{"line_number":244,"context_line":"                    # debug here just to provide more context"},{"line_number":245,"context_line":"                    LOG.debug(msg, prov_exc, cleanup_exc)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f287b81_119ec7b7","line":242,"updated":"2017-09-06 00:00:23.000000000","message":"See above.","commit_id":"1e866ad832366d6eb33fa415a74e5e1f7fe74cc2"}]}