)]}'
{"tools/check_newlines.sh":[{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"3cc459a858207cc2d48384a8b3b4ee09bd7de2ae","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"function exit_if {"},{"line_number":4,"context_line":"    cnt\u003d`echo -n \"$1\" | wc -l`"}],"source_content_type":"text/x-sh","patch_set":2,"id":"7f287b81_5b80e58b","line":1,"updated":"2017-09-06 08:45:13.000000000","message":"I think \"#!/usr/bin/env bash\" is safer here.\nAnd, how about adding Apache License here?","commit_id":"8d1b5e1fec647f4311ee93550c0990cec7e67391"},{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"3cc459a858207cc2d48384a8b3b4ee09bd7de2ae","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"function exit_if {"},{"line_number":4,"context_line":"    cnt\u003d`echo -n \"$1\" | wc -l`"},{"line_number":5,"context_line":"    echo -n \"[$cnt]\""},{"line_number":6,"context_line":"    if [ -n $cnt -a $cnt -ne 0 ]; then"},{"line_number":7,"context_line":"        echo -e \"\\n$2\\n$1\""}],"source_content_type":"text/x-sh","patch_set":2,"id":"7f287b81_3b7bd9be","line":4,"updated":"2017-09-06 08:45:13.000000000","message":"I think this cnt is zero when there\u0027s CRLF in only one file.","commit_id":"8d1b5e1fec647f4311ee93550c0990cec7e67391"},{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"3cc459a858207cc2d48384a8b3b4ee09bd7de2ae","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    echo -n \"[$cnt]\""},{"line_number":6,"context_line":"    if [ -n $cnt -a $cnt -ne 0 ]; then"},{"line_number":7,"context_line":"        echo -e \"\\n$2\\n$1\""},{"line_number":8,"context_line":"        exit 1"},{"line_number":9,"context_line":"    fi"},{"line_number":10,"context_line":"}"},{"line_number":11,"context_line":""}],"source_content_type":"text/x-sh","patch_set":2,"id":"7f287b81_1b4c9d9c","line":8,"updated":"2017-09-06 08:45:13.000000000","message":"I feel it better to just return here. Because I think we want to check all of the directories.","commit_id":"8d1b5e1fec647f4311ee93550c0990cec7e67391"},{"author":{"_account_id":16385,"name":"Kris Sterckx","email":"kris.sterckx@nuagenetworks.net","username":"KrisSterckx"},"change_message_id":"d816a0628fe2edcc10984474160417cb1d7a17fb","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    echo -n \"[$cnt]\""},{"line_number":6,"context_line":"    if [ -n $cnt -a $cnt -ne 0 ]; then"},{"line_number":7,"context_line":"        echo -e \"\\n$2\\n$1\""},{"line_number":8,"context_line":"        exit 1"},{"line_number":9,"context_line":"    fi"},{"line_number":10,"context_line":"}"},{"line_number":11,"context_line":""}],"source_content_type":"text/x-sh","patch_set":2,"id":"5f2577a7_cff60f64","line":8,"in_reply_to":"7f287b81_1b4c9d9c","updated":"2017-09-16 19:44:29.000000000","message":"All comments are addressed in patchset 3. Thanks for review!","commit_id":"8d1b5e1fec647f4311ee93550c0990cec7e67391"},{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"b46e104a626752f641e78d8960ec542994880e78","unresolved":false,"context_lines":[{"line_number":19,"context_line":"success\u003d1"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"for dir in . `find . -mindepth 1 -maxdepth 1  -type d -not -path \u0027*/\\.*\u0027`; do"},{"line_number":22,"context_line":"    echo -n $dir"},{"line_number":23,"context_line":"    depth\u003d\"\""},{"line_number":24,"context_line":"    if [ \"$dir\" \u003d\u003d \".\" ]; then"},{"line_number":25,"context_line":"        depth\u003d\"-maxdepth 1\""}],"source_content_type":"text/x-sh","patch_set":4,"id":"ff5d4b2f_93e0e698","line":22,"updated":"2017-09-19 06:47:08.000000000","message":"Do we really need to print each directories?","commit_id":"b66bf7d1b2aaa90412fa67724dd03df9d89059d6"},{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"b46e104a626752f641e78d8960ec542994880e78","unresolved":false,"context_lines":[{"line_number":29,"context_line":"        echo -e \"[ERROR]\\n$crlf\""},{"line_number":30,"context_line":"        success\u003d"},{"line_number":31,"context_line":"    else"},{"line_number":32,"context_line":"        echo -n \"[OK] \""},{"line_number":33,"context_line":"    fi"},{"line_number":34,"context_line":"done"},{"line_number":35,"context_line":""}],"source_content_type":"text/x-sh","patch_set":4,"id":"ff5d4b2f_73efb287","line":32,"updated":"2017-09-19 06:47:08.000000000","message":"If we don\u0027t need to print each succession, this can be removed.","commit_id":"b66bf7d1b2aaa90412fa67724dd03df9d89059d6"},{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"ca6f167e61bf7c0a8d9737ea104c6475639713a6","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"if [ ! \"$success\" ]; then"},{"line_number":34,"context_line":"    echo \"Exiting with error(s).\""},{"line_number":35,"context_line":"    exit -1"},{"line_number":36,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":6,"id":"bf57530f_174a9e7f","line":35,"updated":"2017-09-20 03:04:44.000000000","message":"This could be just \u00271\u0027 not \u0027-1\u0027. I feel -1(255) is a kind of special and just \u00271\u0027 is enough here. http://tldp.org/LDP/abs/html/exitcodes.html","commit_id":"943d0034be176b1207d48f0d83c9de0ea04884b4"},{"author":{"_account_id":16385,"name":"Kris Sterckx","email":"kris.sterckx@nuagenetworks.net","username":"KrisSterckx"},"change_message_id":"c9ea37497da1afeb34ac1003c1513453923f1fee","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"if [ ! \"$success\" ]; then"},{"line_number":34,"context_line":"    echo \"Exiting with error(s).\""},{"line_number":35,"context_line":"    exit -1"},{"line_number":36,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":6,"id":"bf57530f_5ecb8aa4","line":35,"in_reply_to":"bf57530f_174a9e7f","updated":"2017-09-20 08:58:39.000000000","message":"Thanks. Updated","commit_id":"943d0034be176b1207d48f0d83c9de0ea04884b4"}]}