)]}'
{"tempest/api/network/test_security_groups.py":[{"author":{"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},"change_message_id":"5feb54b89ed5c36e90a7e59143f90699478d922b","unresolved":false,"context_lines":[{"line_number":131,"context_line":""},{"line_number":132,"context_line":"    @attr(type\u003d[\u0027negative\u0027, \u0027smoke\u0027])"},{"line_number":133,"context_line":"    def test_create_sg_rules_with_non_existent_sg(self):"},{"line_number":134,"context_line":"        non_exist_id \u003d rand_name(\u0027secgroup-\u0027)"},{"line_number":135,"context_line":"        self.assertRaises(exceptions.NotFound,"},{"line_number":136,"context_line":"                          self.client.create_security_group_rule,"},{"line_number":137,"context_line":"                          non_exist_id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATH%2F%2F5y8%3D","line":134,"updated":"2013-10-08 09:29:17.000000000","message":"we could use the method below:\n\nimport uuid\n...\nnon_exist_id \u003d str(uuid.uuid4())","commit_id":"4bf344be3ed63e2fe00a011447eddcb6a1f79264"}],"tempest/api/network/test_security_groups_negative.py":[{"author":{"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},"change_message_id":"f3c99599b76675235e50c7e3e00246c1dd6fe4b8","unresolved":false,"context_lines":[{"line_number":49,"context_line":"    def test_create_sg_rules_with_non_existent_sg(self):"},{"line_number":50,"context_line":"        self.assertRaises(exceptions.NotFound,"},{"line_number":51,"context_line":"                          self.client.create_security_group_rule,"},{"line_number":52,"context_line":"                          str(uuid.uuid4()))"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"class NegativeSecGroupTestXML(NegativeSecGroupTest):"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATH%2F%2FNuo%3D","line":52,"updated":"2013-10-21 10:15:59.000000000","message":"maybe use:\nnon_existent_sg \u003d str(uuid.uuid4())\nis better for readability, right?","commit_id":"f004eb3ac96e1e1152dd86b074d67d7af9644510"},{"author":{"_account_id":8846,"name":"Hao Wang","display_name":"Hao Wang","email":"sxmatch1986@gmail.com","username":"sxmatch"},"change_message_id":"a10a3c7dea40aa35fbdf13aa6a8dcca4a6f02700","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        self.assertRaises(exceptions.NotFound,"},{"line_number":51,"context_line":"                          self.client.create_security_group_rule,"},{"line_number":52,"context_line":"                          str(uuid.uuid4()))"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"class NegativeSecGroupTestXML(NegativeSecGroupTest):"},{"line_number":56,"context_line":"    _interface \u003d \u0027xml\u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATH%2F%2FOJg%3D","line":53,"updated":"2013-10-21 06:26:05.000000000","message":"tests are good, maybe there is better more tests","commit_id":"f004eb3ac96e1e1152dd86b074d67d7af9644510"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"fb6989287f00e965027e0309f5d9b6d688b0e0c7","unresolved":false,"context_lines":[{"line_number":76,"context_line":"            self.assertIn(msg, str(ex))"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    @attr(type\u003d[\u0027negative\u0027, \u0027smoke\u0027])"},{"line_number":79,"context_line":"    def test_create_default_security_group(self):"},{"line_number":80,"context_line":"        name \u003d \u0027default\u0027"},{"line_number":81,"context_line":"        self.assertRaises(exceptions.Conflict,"},{"line_number":82,"context_line":"                          self.client.create_security_group,"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAATn%2F%2B75o%3D","line":79,"updated":"2013-11-18 11:49:23.000000000","message":"consider rename to test_create_additional_default_security_group_fails","commit_id":"fdb39da61acda07b3becd3ce2939538f870eefaa"},{"author":{"_account_id":8625,"name":"Anju Tiwari","username":"Anju5","inactive":true},"change_message_id":"f7aab1866c2876424ebd792b3456ac9121cba166","unresolved":false,"context_lines":[{"line_number":83,"context_line":"                          name)"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    @attr(type\u003d[\u0027negative\u0027, \u0027smoke\u0027])"},{"line_number":86,"context_line":"    def test_create_sg_rules_with_non_existent_sg(self):"},{"line_number":87,"context_line":"        non_existent_sg \u003d str(uuid.uuid4())"},{"line_number":88,"context_line":"        self.assertRaises(exceptions.NotFound,"},{"line_number":89,"context_line":"                          self.client.create_security_group_rule,"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAATn%2F%2B38A%3D","line":86,"updated":"2013-11-19 04:20:04.000000000","message":"Hii,\n\nI think you can add a comment here for defining what \"sg\" is ?\n\n# Create security group rules with not existing security group .","commit_id":"768c6186a05057b262969eaad2134cb033350e84"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"1bd9eb67ddcfe5121c2a5db853fde7b058b24ffd","unresolved":false,"context_lines":[{"line_number":75,"context_line":"                                   port_range_max\u003dpmax)"},{"line_number":76,"context_line":"            self.assertIn(msg, str(ex))"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    @attr(type\u003d[\u0027negative\u0027, \u0027smoke\u0027])"},{"line_number":79,"context_line":"    def test_create_additional_default_security_group_fails(self):"},{"line_number":80,"context_line":"        # Create security group named \u0027default\u0027, it should be failed."},{"line_number":81,"context_line":"        name \u003d \u0027default\u0027"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAATn%2F%2BXeg%3D","line":78,"updated":"2013-11-26 21:11:10.000000000","message":"Why don\u0027t you use \u0027gate\u0027 instead of \u0027smoke\u0027 like the other tests?","commit_id":"01b105376dc3ddcfe528f3bf22d89a3e82d5f4c1"},{"author":{"_account_id":1192,"name":"David Kranz","email":"dkranz@redhat.com","username":"david-kranz"},"change_message_id":"325742bf3249f1db8ab0f1c88b83295fd7af6dad","unresolved":false,"context_lines":[{"line_number":75,"context_line":"                                   port_range_max\u003dpmax)"},{"line_number":76,"context_line":"            self.assertIn(msg, str(ex))"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    @attr(type\u003d[\u0027negative\u0027, \u0027smoke\u0027])"},{"line_number":79,"context_line":"    def test_create_additional_default_security_group_fails(self):"},{"line_number":80,"context_line":"        # Create security group named \u0027default\u0027, it should be failed."},{"line_number":81,"context_line":"        name \u003d \u0027default\u0027"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAATn%2F90nw%3D","line":78,"in_reply_to":"AAAATn%2F%2BWUU%3D","updated":"2013-12-05 15:17:28.000000000","message":"Ken\u0027ichi you are right in principle. But this issue only exists temporarily until neutron is up-to-speed. The \u0027smoke\u0027 and \u0027gate\u0027 tags are pretty meaningless now because \u0027gate\u0027 is ignored, and \u0027smoke\u0027 is being used as whatever was there before plus anything new that involves neutron. Once neutron is running the full gate job, we should sanitize \u0027smoke\u0027 to mean what it should mean: a fast sanity check that can be run in situations where speed is more important than comprehensiveness.","commit_id":"01b105376dc3ddcfe528f3bf22d89a3e82d5f4c1"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"71d81deef70e37ec8c2aea110d24007592f2a309","unresolved":false,"context_lines":[{"line_number":75,"context_line":"                                   port_range_max\u003dpmax)"},{"line_number":76,"context_line":"            self.assertIn(msg, str(ex))"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    @attr(type\u003d[\u0027negative\u0027, \u0027smoke\u0027])"},{"line_number":79,"context_line":"    def test_create_additional_default_security_group_fails(self):"},{"line_number":80,"context_line":"        # Create security group named \u0027default\u0027, it should be failed."},{"line_number":81,"context_line":"        name \u003d \u0027default\u0027"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAATn%2F%2BWUU%3D","line":78,"in_reply_to":"AAAATn%2F%2BWYk%3D","updated":"2013-11-27 03:07:17.000000000","message":"Thanks for your explanation, but I\u0027m not sure that we should do this only for new tests.\nCould you wait for the other reviewer?","commit_id":"01b105376dc3ddcfe528f3bf22d89a3e82d5f4c1"},{"author":{"_account_id":8282,"name":"Dong Liu","email":"willowd878@gmail.com","username":"liudong"},"change_message_id":"5d252ad946d954891c866ea0a023ae2174d440b2","unresolved":false,"context_lines":[{"line_number":75,"context_line":"                                   port_range_max\u003dpmax)"},{"line_number":76,"context_line":"            self.assertIn(msg, str(ex))"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    @attr(type\u003d[\u0027negative\u0027, \u0027smoke\u0027])"},{"line_number":79,"context_line":"    def test_create_additional_default_security_group_fails(self):"},{"line_number":80,"context_line":"        # Create security group named \u0027default\u0027, it should be failed."},{"line_number":81,"context_line":"        name \u003d \u0027default\u0027"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAATn%2F%2BWYk%3D","line":78,"in_reply_to":"AAAATn%2F%2BXeg%3D","updated":"2013-11-27 02:49:27.000000000","message":"Hi Ken\u0027ichi, thanks for your review.\nIn https://review.openstack.org/#/c/54228/ patch set 6, afazekas said that we should use the \u0027smoke\u0027 on the security group related test cases.","commit_id":"01b105376dc3ddcfe528f3bf22d89a3e82d5f4c1"}]}