)]}'
{"tempest/api/compute/base.py":[{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"a9d8ed4bc2128e6a9e72ac309f35c03820431e89","unresolved":false,"context_lines":[{"line_number":346,"context_line":"        waiters.wait_for_server_status(cls.servers_client, server_id, \u0027ACTIVE\u0027)"},{"line_number":347,"context_line":""},{"line_number":348,"context_line":"    @classmethod"},{"line_number":349,"context_line":"    def delete_volume(cls, volume_id, volumes_client\u003dNone):"},{"line_number":350,"context_line":"        \"\"\"Deletes the given volume and waits for it to be gone.\"\"\""},{"line_number":351,"context_line":"        if not volumes_client:"},{"line_number":352,"context_line":"            volumes_client \u003d cls.volumes_client"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f2577a7_80093632","line":349,"updated":"2017-09-13 22:53:17.000000000","message":"I\u0027m actually not sure why you added the volumes_client parameter here.. Are you thinking to use it?","commit_id":"740ce6f005c151319dcf67a0ba0e0dab84819388"},{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"f6503e74da9b665b4ea9a19ffeacb60d4a40364e","unresolved":false,"context_lines":[{"line_number":346,"context_line":"        waiters.wait_for_server_status(cls.servers_client, server_id, \u0027ACTIVE\u0027)"},{"line_number":347,"context_line":""},{"line_number":348,"context_line":"    @classmethod"},{"line_number":349,"context_line":"    def delete_volume(cls, volume_id, volumes_client\u003dNone):"},{"line_number":350,"context_line":"        \"\"\"Deletes the given volume and waits for it to be gone.\"\"\""},{"line_number":351,"context_line":"        if not volumes_client:"},{"line_number":352,"context_line":"            volumes_client \u003d cls.volumes_client"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff5d4b2f_f372827c","line":349,"updated":"2017-09-19 06:23:45.000000000","message":"yeah, _delete_volume supports that. But only user is inside this method. So, I\u0027m not sure why we need this parameter if you don\u0027t have a particular reason. I think the number of parameters should be small as possible.","commit_id":"740ce6f005c151319dcf67a0ba0e0dab84819388"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"dacb0b7cb87e2aac6dbe84900129065c0d256512","unresolved":false,"context_lines":[{"line_number":346,"context_line":"        waiters.wait_for_server_status(cls.servers_client, server_id, \u0027ACTIVE\u0027)"},{"line_number":347,"context_line":""},{"line_number":348,"context_line":"    @classmethod"},{"line_number":349,"context_line":"    def delete_volume(cls, volume_id, volumes_client\u003dNone):"},{"line_number":350,"context_line":"        \"\"\"Deletes the given volume and waits for it to be gone.\"\"\""},{"line_number":351,"context_line":"        if not volumes_client:"},{"line_number":352,"context_line":"            volumes_client \u003d cls.volumes_client"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f2577a7_3172d612","line":349,"in_reply_to":"5f2577a7_80093632","updated":"2017-09-14 00:57:15.000000000","message":"because _delete_volume supports volumes_client, since I delete it I don\u0027t want to lose this support:)","commit_id":"740ce6f005c151319dcf67a0ba0e0dab84819388"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"5136e81841945195c9a504ba33b917ff7e596893","unresolved":false,"context_lines":[{"line_number":346,"context_line":"        waiters.wait_for_server_status(cls.servers_client, server_id, \u0027ACTIVE\u0027)"},{"line_number":347,"context_line":""},{"line_number":348,"context_line":"    @classmethod"},{"line_number":349,"context_line":"    def delete_volume(cls, volume_id, volumes_client\u003dNone):"},{"line_number":350,"context_line":"        \"\"\"Deletes the given volume and waits for it to be gone.\"\"\""},{"line_number":351,"context_line":"        if not volumes_client:"},{"line_number":352,"context_line":"            volumes_client \u003d cls.volumes_client"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff5d4b2f_9e310df0","line":349,"in_reply_to":"ff5d4b2f_f372827c","updated":"2017-09-19 07:03:04.000000000","message":"ok, I\u0027m fine to add it when needed in the future:)","commit_id":"740ce6f005c151319dcf67a0ba0e0dab84819388"}]}