)]}'
{"tempest/api/compute/base.py":[{"author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"change_message_id":"1da9d8be5a00c7a0c2405a828092b8f199302193","unresolved":false,"context_lines":[{"line_number":102,"context_line":"    @classmethod"},{"line_number":103,"context_line":"    def rebuild_servers(cls):"},{"line_number":104,"context_line":"        # Destroy any existing server and creates a new one"},{"line_number":105,"context_line":"        cls.clear_servers()"},{"line_number":106,"context_line":"        resp, server \u003d cls.create_server(wait_until\u003d\u0027ACTIVE\u0027)"},{"line_number":107,"context_line":"        cls.server_id \u003d server[\u0027id\u0027]"},{"line_number":108,"context_line":"        cls.password \u003d server[\u0027adminPass\u0027]"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAATH%2F%2Fm80%3D","line":105,"updated":"2013-10-13 04:31:57.000000000","message":"Enough to delete the \u0027server\u0027, deleting all servers is not required.","commit_id":"91827397b2b7c7a6b4d8c2d01d4ca9b129fd88a2"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"735f5cd4b63d0ab1a17702f9bbe2260a20f28412","unresolved":false,"context_lines":[{"line_number":102,"context_line":"    @classmethod"},{"line_number":103,"context_line":"    def rebuild_servers(cls):"},{"line_number":104,"context_line":"        # Destroy any existing server and creates a new one"},{"line_number":105,"context_line":"        cls.clear_servers()"},{"line_number":106,"context_line":"        resp, server \u003d cls.create_server(wait_until\u003d\u0027ACTIVE\u0027)"},{"line_number":107,"context_line":"        cls.server_id \u003d server[\u0027id\u0027]"},{"line_number":108,"context_line":"        cls.password \u003d server[\u0027adminPass\u0027]"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAATH%2F%2Fmn8%3D","line":105,"in_reply_to":"AAAATH%2F%2Fm80%3D","updated":"2013-10-13 13:01:52.000000000","message":"I see, will change here.","commit_id":"91827397b2b7c7a6b4d8c2d01d4ca9b129fd88a2"},{"author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"change_message_id":"1da9d8be5a00c7a0c2405a828092b8f199302193","unresolved":false,"context_lines":[{"line_number":103,"context_line":"    def rebuild_servers(cls):"},{"line_number":104,"context_line":"        # Destroy any existing server and creates a new one"},{"line_number":105,"context_line":"        cls.clear_servers()"},{"line_number":106,"context_line":"        resp, server \u003d cls.create_server(wait_until\u003d\u0027ACTIVE\u0027)"},{"line_number":107,"context_line":"        cls.server_id \u003d server[\u0027id\u0027]"},{"line_number":108,"context_line":"        cls.password \u003d server[\u0027adminPass\u0027]"},{"line_number":109,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAATH%2F%2Fm8w%3D","line":106,"updated":"2013-10-13 04:31:57.000000000","message":"ssh -tests will need extra args I can add it later.\n\nThe class should have have an extra_args dict.","commit_id":"91827397b2b7c7a6b4d8c2d01d4ca9b129fd88a2"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"735f5cd4b63d0ab1a17702f9bbe2260a20f28412","unresolved":false,"context_lines":[{"line_number":103,"context_line":"    def rebuild_servers(cls):"},{"line_number":104,"context_line":"        # Destroy any existing server and creates a new one"},{"line_number":105,"context_line":"        cls.clear_servers()"},{"line_number":106,"context_line":"        resp, server \u003d cls.create_server(wait_until\u003d\u0027ACTIVE\u0027)"},{"line_number":107,"context_line":"        cls.server_id \u003d server[\u0027id\u0027]"},{"line_number":108,"context_line":"        cls.password \u003d server[\u0027adminPass\u0027]"},{"line_number":109,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAATH%2F%2Fmns%3D","line":106,"in_reply_to":"AAAATH%2F%2Fm8w%3D","updated":"2013-10-13 13:01:52.000000000","message":"I will add kwargs to this method.","commit_id":"91827397b2b7c7a6b4d8c2d01d4ca9b129fd88a2"},{"author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"change_message_id":"159cfad94290454c83d788b8ebda116c85ec2acb","unresolved":false,"context_lines":[{"line_number":105,"context_line":"        try:"},{"line_number":106,"context_line":"            cls.servers_client.delete_server(cls.server_id)"},{"line_number":107,"context_line":"            cls.servers_client.wait_for_server_termination(cls.server_id)"},{"line_number":108,"context_line":"        except Exception:"},{"line_number":109,"context_line":"            pass"},{"line_number":110,"context_line":"        resp, server \u003d cls.create_server(wait_until\u003d\u0027ACTIVE\u0027, **kwargs)"},{"line_number":111,"context_line":"        cls.server_id \u003d server[\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAATH%2F%2Fl3s%3D","line":108,"updated":"2013-10-14 03:53:15.000000000","message":"LOG.exception(exc)","commit_id":"8a28ccf257049dff859834aa61cbbc4305afcb40"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"cdf99bb34c80e1b4895cc9fd7dec8756760b92c3","unresolved":false,"context_lines":[{"line_number":105,"context_line":"        try:"},{"line_number":106,"context_line":"            cls.servers_client.delete_server(cls.server_id)"},{"line_number":107,"context_line":"            cls.servers_client.wait_for_server_termination(cls.server_id)"},{"line_number":108,"context_line":"        except Exception:"},{"line_number":109,"context_line":"            pass"},{"line_number":110,"context_line":"        resp, server \u003d cls.create_server(wait_until\u003d\u0027ACTIVE\u0027, **kwargs)"},{"line_number":111,"context_line":"        cls.server_id \u003d server[\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAATH%2F%2FhuI%3D","line":108,"in_reply_to":"AAAATH%2F%2Fj9s%3D","updated":"2013-10-14 23:44:01.000000000","message":"thanks, I will fix here.","commit_id":"8a28ccf257049dff859834aa61cbbc4305afcb40"},{"author":{"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},"change_message_id":"c4be254be7dd442d94ed558e8c71156411c1f88f","unresolved":false,"context_lines":[{"line_number":105,"context_line":"        try:"},{"line_number":106,"context_line":"            cls.servers_client.delete_server(cls.server_id)"},{"line_number":107,"context_line":"            cls.servers_client.wait_for_server_termination(cls.server_id)"},{"line_number":108,"context_line":"        except Exception:"},{"line_number":109,"context_line":"            pass"},{"line_number":110,"context_line":"        resp, server \u003d cls.create_server(wait_until\u003d\u0027ACTIVE\u0027, **kwargs)"},{"line_number":111,"context_line":"        cls.server_id \u003d server[\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAATH%2F%2Fj9s%3D","line":108,"in_reply_to":"AAAATH%2F%2Fl3s%3D","updated":"2013-10-14 14:34:35.000000000","message":"agreed to afazekas, please refer to http://docs.openstack.org/developer/tempest/HACKING.html#exception-handling","commit_id":"8a28ccf257049dff859834aa61cbbc4305afcb40"}],"tempest/api/compute/servers/test_servers_negative.py":[{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"487cc6629975321d0206de09ae93a58040405a5f","unresolved":false,"context_lines":[{"line_number":47,"context_line":"    @classmethod"},{"line_number":48,"context_line":"    def rebuild_servers(cls):"},{"line_number":49,"context_line":"        # Destroy any existing server and creates a new one"},{"line_number":50,"context_line":"        cls.clear_servers()"},{"line_number":51,"context_line":"        resp, server \u003d cls.create_server(wait_until\u003d\u0027ACTIVE\u0027)"},{"line_number":52,"context_line":"        cls.server_id \u003d server[\u0027id\u0027]"},{"line_number":53,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATH%2F%2F2FU%3D","line":50,"updated":"2013-10-09 03:12:26.000000000","message":"I know this is in server_actions too but I\u0027m not sure this is really needed nor a good idea; let\u0027s see if others have opinions about it","commit_id":"2f8cf6ceceaa474d6721acdb5e4b151f353c23fc"},{"author":{"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},"change_message_id":"1371aab6ca4568ba0a7f7435a72c738e5bf23641","unresolved":false,"context_lines":[{"line_number":47,"context_line":"    @classmethod"},{"line_number":48,"context_line":"    def rebuild_servers(cls):"},{"line_number":49,"context_line":"        # Destroy any existing server and creates a new one"},{"line_number":50,"context_line":"        cls.clear_servers()"},{"line_number":51,"context_line":"        resp, server \u003d cls.create_server(wait_until\u003d\u0027ACTIVE\u0027)"},{"line_number":52,"context_line":"        cls.server_id \u003d server[\u0027id\u0027]"},{"line_number":53,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATH%2F%2F188%3D","line":50,"in_reply_to":"AAAATH%2F%2F19I%3D","updated":"2013-10-09 04:07:42.000000000","message":"Thanks Ken\u0027ichi, I see it. Please ignore my comment above.","commit_id":"2f8cf6ceceaa474d6721acdb5e4b151f353c23fc"},{"author":{"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},"change_message_id":"734309608322f180816d2be149a90e416595e15a","unresolved":false,"context_lines":[{"line_number":47,"context_line":"    @classmethod"},{"line_number":48,"context_line":"    def rebuild_servers(cls):"},{"line_number":49,"context_line":"        # Destroy any existing server and creates a new one"},{"line_number":50,"context_line":"        cls.clear_servers()"},{"line_number":51,"context_line":"        resp, server \u003d cls.create_server(wait_until\u003d\u0027ACTIVE\u0027)"},{"line_number":52,"context_line":"        cls.server_id \u003d server[\u0027id\u0027]"},{"line_number":53,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATH%2F%2F19I%3D","line":50,"in_reply_to":"AAAATH%2F%2F2BE%3D","updated":"2013-10-09 04:05:34.000000000","message":"@Giulio: As you said above, if we create one server in setUpClass in the testr environment, the server may be deleted by other test class, am I right?","commit_id":"2f8cf6ceceaa474d6721acdb5e4b151f353c23fc"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"39cf04cf7521c2902d2e69fd6751b7e0c021df5e","unresolved":false,"context_lines":[{"line_number":47,"context_line":"    @classmethod"},{"line_number":48,"context_line":"    def rebuild_servers(cls):"},{"line_number":49,"context_line":"        # Destroy any existing server and creates a new one"},{"line_number":50,"context_line":"        cls.clear_servers()"},{"line_number":51,"context_line":"        resp, server \u003d cls.create_server(wait_until\u003d\u0027ACTIVE\u0027)"},{"line_number":52,"context_line":"        cls.server_id \u003d server[\u0027id\u0027]"},{"line_number":53,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATH%2F%2F1%2Bw%3D","line":50,"in_reply_to":"AAAATH%2F%2F2BE%3D","updated":"2013-10-09 03:59:29.000000000","message":"My previous comment is wrong, sorry.\nclear_servers() deletes only servers which are created by create_server(). So current behavior is not wrong.\n\nI agree with you for creating just one server in setUpClass.","commit_id":"2f8cf6ceceaa474d6721acdb5e4b151f353c23fc"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"792bfe145c6a221c9d94d230adc07c81208148e0","unresolved":false,"context_lines":[{"line_number":47,"context_line":"    @classmethod"},{"line_number":48,"context_line":"    def rebuild_servers(cls):"},{"line_number":49,"context_line":"        # Destroy any existing server and creates a new one"},{"line_number":50,"context_line":"        cls.clear_servers()"},{"line_number":51,"context_line":"        resp, server \u003d cls.create_server(wait_until\u003d\u0027ACTIVE\u0027)"},{"line_number":52,"context_line":"        cls.server_id \u003d server[\u0027id\u0027]"},{"line_number":53,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATH%2F%2F2BE%3D","line":50,"in_reply_to":"AAAATH%2F%2F2DU%3D","updated":"2013-10-09 03:39:54.000000000","message":"well actually I just wasn\u0027t sure about being aggressive and remove all servers but again there are a few points for not changing it yet:\n\n- testr should be parallelizing per class so this shouldn\u0027t be a problem anyway\n- if you figure it is possible to create just one server in setUpClass, this won\u0027t be left here anyway","commit_id":"2f8cf6ceceaa474d6721acdb5e4b151f353c23fc"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"e0f164ac7f2c6168037380530ff92ce4c17af1bb","unresolved":false,"context_lines":[{"line_number":47,"context_line":"    @classmethod"},{"line_number":48,"context_line":"    def rebuild_servers(cls):"},{"line_number":49,"context_line":"        # Destroy any existing server and creates a new one"},{"line_number":50,"context_line":"        cls.clear_servers()"},{"line_number":51,"context_line":"        resp, server \u003d cls.create_server(wait_until\u003d\u0027ACTIVE\u0027)"},{"line_number":52,"context_line":"        cls.server_id \u003d server[\u0027id\u0027]"},{"line_number":53,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATH%2F%2F2DU%3D","line":50,"in_reply_to":"AAAATH%2F%2F2FU%3D","updated":"2013-10-09 03:30:44.000000000","message":"I guess you mean the following instead of clear_servers(), right?\n\n try:\n     cls.servers_client.delete_server(cls.server_id)\n except Exception:\n     pass\n\nI think the idea is nice because we can avoid unnecessary vm removals.","commit_id":"2f8cf6ceceaa474d6721acdb5e4b151f353c23fc"}]}