)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"662e3d55837dd0fe7e4f1c3e94a3ed61553c0d8a","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The create_volume_type_extra_specs API in volume types_client actually"},{"line_number":10,"context_line":"contains both \u0027create\u0027 and \u0027update\u0027 function for extra specs of a volume"},{"line_number":11,"context_line":"type. The \u0027update\u0027 function not only can update volume type\u0027s existed"},{"line_number":12,"context_line":"extra specs, but also can add new extra specs to the volume type. This"},{"line_number":13,"context_line":"patch adds test for this \u0027update\u0027 function."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5f2577a7_8e7b6079","line":11,"range":{"start_line":11,"start_character":62,"end_line":11,"end_character":69},"updated":"2017-09-18 03:20:01.000000000","message":"existing","commit_id":"e03a7c6ed34d49d7ab46623e9750b4ec777c687b"},{"author":{"_account_id":23081,"name":"Jeremy Zhang","email":"zhangjun_inspur@163.com","username":"jeremy.zhang"},"change_message_id":"9d2fb58fa1769dcbf197a405fa54fb18d980ec04","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The create_volume_type_extra_specs API in volume types_client actually"},{"line_number":10,"context_line":"contains both \u0027create\u0027 and \u0027update\u0027 function for extra specs of a volume"},{"line_number":11,"context_line":"type. The \u0027update\u0027 function not only can update volume type\u0027s existed"},{"line_number":12,"context_line":"extra specs, but also can add new extra specs to the volume type. This"},{"line_number":13,"context_line":"patch adds test for this \u0027update\u0027 function."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5f2577a7_919ca50e","line":11,"range":{"start_line":11,"start_character":62,"end_line":11,"end_character":69},"in_reply_to":"5f2577a7_8e7b6079","updated":"2017-09-18 05:48:10.000000000","message":"Done","commit_id":"e03a7c6ed34d49d7ab46623e9750b4ec777c687b"}],"tempest/api/volume/admin/test_volume_types_extra_specs.py":[{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"662e3d55837dd0fe7e4f1c3e94a3ed61553c0d8a","unresolved":false,"context_lines":[{"line_number":58,"context_line":"        self.assertEqual(extra_spec[spec_key], body[spec_key],"},{"line_number":59,"context_line":"                         \"Volume type extra spec incorrectly updated\")"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"        # Update an existed extra spec and a new extra spec"},{"line_number":62,"context_line":"        extra_specs \u003d {spec_key: \"val3\", \"spec4\": \"val4\"}"},{"line_number":63,"context_line":"        body \u003d self.admin_volume_types_client.create_volume_type_extra_specs("},{"line_number":64,"context_line":"            self.volume_type[\u0027id\u0027], extra_specs)[\u0027extra_specs\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f2577a7_ee442449","line":61,"range":{"start_line":61,"start_character":20,"end_line":61,"end_character":27},"updated":"2017-09-18 03:20:01.000000000","message":"existing","commit_id":"e03a7c6ed34d49d7ab46623e9750b4ec777c687b"},{"author":{"_account_id":23081,"name":"Jeremy Zhang","email":"zhangjun_inspur@163.com","username":"jeremy.zhang"},"change_message_id":"9d2fb58fa1769dcbf197a405fa54fb18d980ec04","unresolved":false,"context_lines":[{"line_number":58,"context_line":"        self.assertEqual(extra_spec[spec_key], body[spec_key],"},{"line_number":59,"context_line":"                         \"Volume type extra spec incorrectly updated\")"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"        # Update an existed extra spec and a new extra spec"},{"line_number":62,"context_line":"        extra_specs \u003d {spec_key: \"val3\", \"spec4\": \"val4\"}"},{"line_number":63,"context_line":"        body \u003d self.admin_volume_types_client.create_volume_type_extra_specs("},{"line_number":64,"context_line":"            self.volume_type[\u0027id\u0027], extra_specs)[\u0027extra_specs\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f2577a7_71ec998e","line":61,"range":{"start_line":61,"start_character":20,"end_line":61,"end_character":27},"in_reply_to":"5f2577a7_ee442449","updated":"2017-09-18 05:48:10.000000000","message":"Done","commit_id":"e03a7c6ed34d49d7ab46623e9750b4ec777c687b"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"662e3d55837dd0fe7e4f1c3e94a3ed61553c0d8a","unresolved":false,"context_lines":[{"line_number":60,"context_line":""},{"line_number":61,"context_line":"        # Update an existed extra spec and a new extra spec"},{"line_number":62,"context_line":"        extra_specs \u003d {spec_key: \"val3\", \"spec4\": \"val4\"}"},{"line_number":63,"context_line":"        body \u003d self.admin_volume_types_client.create_volume_type_extra_specs("},{"line_number":64,"context_line":"            self.volume_type[\u0027id\u0027], extra_specs)[\u0027extra_specs\u0027]"},{"line_number":65,"context_line":"        self.assertEqual(extra_specs, body)"},{"line_number":66,"context_line":"        body \u003d self.admin_volume_types_client.list_volume_types_extra_specs("}],"source_content_type":"text/x-python","patch_set":1,"id":"5f2577a7_ae8a9c66","line":63,"updated":"2017-09-18 03:20:01.000000000","message":"After this is called, do the original extra specs stay in addition to the new ones? Test below just checks whether new ones were added.","commit_id":"e03a7c6ed34d49d7ab46623e9750b4ec777c687b"},{"author":{"_account_id":23081,"name":"Jeremy Zhang","email":"zhangjun_inspur@163.com","username":"jeremy.zhang"},"change_message_id":"9d2fb58fa1769dcbf197a405fa54fb18d980ec04","unresolved":false,"context_lines":[{"line_number":60,"context_line":""},{"line_number":61,"context_line":"        # Update an existed extra spec and a new extra spec"},{"line_number":62,"context_line":"        extra_specs \u003d {spec_key: \"val3\", \"spec4\": \"val4\"}"},{"line_number":63,"context_line":"        body \u003d self.admin_volume_types_client.create_volume_type_extra_specs("},{"line_number":64,"context_line":"            self.volume_type[\u0027id\u0027], extra_specs)[\u0027extra_specs\u0027]"},{"line_number":65,"context_line":"        self.assertEqual(extra_specs, body)"},{"line_number":66,"context_line":"        body \u003d self.admin_volume_types_client.list_volume_types_extra_specs("}],"source_content_type":"text/x-python","patch_set":1,"id":"5f2577a7_91e705ad","line":63,"in_reply_to":"5f2577a7_ae8a9c66","updated":"2017-09-18 05:48:10.000000000","message":"The spec_key \u0027spec2\u0027 is the original extra spec key, and its value will be changed from \u0027val2\u0027 to \u0027val3\u0027, which is tested in L68-70","commit_id":"e03a7c6ed34d49d7ab46623e9750b4ec777c687b"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"464da05b47ad9af7ded9e63c2f05d254a66ab3bd","unresolved":false,"context_lines":[{"line_number":58,"context_line":"        self.assertEqual(extra_spec[spec_key], body[spec_key],"},{"line_number":59,"context_line":"                         \"Volume type extra spec incorrectly updated\")"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"        # Update an existing extra spec and a new extra spec"},{"line_number":62,"context_line":"        extra_specs \u003d {spec_key: \"val3\", \"spec4\": \"val4\"}"},{"line_number":63,"context_line":"        body \u003d self.admin_volume_types_client.create_volume_type_extra_specs("},{"line_number":64,"context_line":"            self.volume_type[\u0027id\u0027], extra_specs)[\u0027extra_specs\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f5c4f37_7005667a","line":61,"updated":"2017-09-21 01:45:44.000000000","message":"create","commit_id":"607294767d9e638f1b1b5d263814249b2359f840"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"dd010f2febd19177bfc3fa4cf06f54c4a842d841","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        self.assertEqual(extra_specs, body,"},{"line_number":48,"context_line":"                         \"Volume type extra spec incorrectly created\")"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"        # Only update a extra spec"},{"line_number":51,"context_line":"        spec_key \u003d \"spec2\""},{"line_number":52,"context_line":"        extra_spec \u003d {spec_key: \"val2\"}"},{"line_number":53,"context_line":"        body \u003d self.admin_volume_types_client.update_volume_type_extra_specs("}],"source_content_type":"text/x-python","patch_set":4,"id":"3f4b6375_b1591736","line":50,"range":{"start_line":50,"start_character":22,"end_line":50,"end_character":23},"updated":"2017-10-24 04:00:29.000000000","message":"an","commit_id":"37541d221ab9a707f328bc34de2c26787f1ec58c"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"dd010f2febd19177bfc3fa4cf06f54c4a842d841","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        extra_spec \u003d {spec_key: \"val2\"}"},{"line_number":53,"context_line":"        body \u003d self.admin_volume_types_client.update_volume_type_extra_specs("},{"line_number":54,"context_line":"            self.volume_type[\u0027id\u0027], spec_key, extra_spec)"},{"line_number":55,"context_line":"        self.assertEqual(extra_spec[spec_key], body[spec_key])"},{"line_number":56,"context_line":"        body \u003d self.admin_volume_types_client.show_volume_type_extra_specs("},{"line_number":57,"context_line":"            self.volume_type[\u0027id\u0027], spec_key)"},{"line_number":58,"context_line":"        self.assertEqual(extra_spec[spec_key], body[spec_key],"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f4b6375_b1dfd738","line":55,"range":{"start_line":55,"start_character":8,"end_line":55,"end_character":62},"updated":"2017-10-24 04:00:29.000000000","message":"self.assertEqual(extra_spec, body)\nbecause spec_key may not exist in body","commit_id":"37541d221ab9a707f328bc34de2c26787f1ec58c"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"dd010f2febd19177bfc3fa4cf06f54c4a842d841","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        self.assertEqual(extra_spec[spec_key], body[spec_key])"},{"line_number":56,"context_line":"        body \u003d self.admin_volume_types_client.show_volume_type_extra_specs("},{"line_number":57,"context_line":"            self.volume_type[\u0027id\u0027], spec_key)"},{"line_number":58,"context_line":"        self.assertEqual(extra_spec[spec_key], body[spec_key],"},{"line_number":59,"context_line":"                         \"Volume type extra spec incorrectly updated\")"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"        # Update an existing extra spec and a new extra spec"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f4b6375_31ebe7dc","line":58,"range":{"start_line":58,"start_character":8,"end_line":58,"end_character":62},"updated":"2017-10-24 04:00:29.000000000","message":"ditto","commit_id":"37541d221ab9a707f328bc34de2c26787f1ec58c"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"dd010f2febd19177bfc3fa4cf06f54c4a842d841","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        self.assertEqual(extra_specs, body)"},{"line_number":66,"context_line":"        body \u003d self.admin_volume_types_client.list_volume_types_extra_specs("},{"line_number":67,"context_line":"            self.volume_type[\u0027id\u0027])[\u0027extra_specs\u0027]"},{"line_number":68,"context_line":"        for key in extra_specs:"},{"line_number":69,"context_line":"            self.assertEqual(extra_specs[key], body[key],"},{"line_number":70,"context_line":"                             \"Volume type extra spec incorrectly created\")"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    @decorators.idempotent_id(\u0027d4772798-601f-408a-b2a5-29e8a59d1220\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f4b6375_f1954f34","line":69,"range":{"start_line":68,"start_character":8,"end_line":69,"end_character":57},"updated":"2017-10-24 04:00:29.000000000","message":"self.assertTrue(set(extra_specs.items()).issubset(body.items()))\nfor the same reason","commit_id":"37541d221ab9a707f328bc34de2c26787f1ec58c"}]}