)]}'
{"tempest/api/volume/admin/test_groups.py":[{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"ceddcf7f866ed230f3914ae979d7be7300a00a92","unresolved":false,"context_lines":[{"line_number":106,"context_line":"        self.assertEqual(grp2_id, grp2[\u0027id\u0027])"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"        # Get all groups with detail"},{"line_number":109,"context_line":"        grps \u003d self.groups_client.list_groups("},{"line_number":110,"context_line":"            detail\u003dTrue)[\u0027groups\u0027]"},{"line_number":111,"context_line":"        for grp_id in [grp1_id, grp2_id]:"},{"line_number":112,"context_line":"            filtered_grps \u003d [g for g in grps if g[\u0027id\u0027] \u003d\u003d grp_id]"},{"line_number":113,"context_line":"            self.assertEqual(1, len(filtered_grps))"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f515b1d_dd466150","line":110,"range":{"start_line":109,"start_character":0,"end_line":110,"end_character":34},"updated":"2017-09-22 08:52:52.000000000","message":"nit: can be put in one line","commit_id":"5c4efa70eddacabc4b76d507455e833eb010a6ed"},{"author":{"_account_id":23081,"name":"Jeremy Zhang","email":"zhangjun_inspur@163.com","username":"jeremy.zhang"},"change_message_id":"d928df0a87ec7bd84bd6f3f29e2f376d7f9c4dc4","unresolved":false,"context_lines":[{"line_number":106,"context_line":"        self.assertEqual(grp2_id, grp2[\u0027id\u0027])"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"        # Get all groups with detail"},{"line_number":109,"context_line":"        grps \u003d self.groups_client.list_groups("},{"line_number":110,"context_line":"            detail\u003dTrue)[\u0027groups\u0027]"},{"line_number":111,"context_line":"        for grp_id in [grp1_id, grp2_id]:"},{"line_number":112,"context_line":"            filtered_grps \u003d [g for g in grps if g[\u0027id\u0027] \u003d\u003d grp_id]"},{"line_number":113,"context_line":"            self.assertEqual(1, len(filtered_grps))"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f515b1d_1d5cf949","line":110,"range":{"start_line":109,"start_character":0,"end_line":110,"end_character":34},"in_reply_to":"7f515b1d_dd466150","updated":"2017-09-22 09:18:39.000000000","message":"Will be fixed, thanks","commit_id":"5c4efa70eddacabc4b76d507455e833eb010a6ed"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"a2a526030e8ad98401a0ed2e40a6f855b6fb9de3","unresolved":false,"context_lines":[{"line_number":108,"context_line":"        # Get all groups with detail"},{"line_number":109,"context_line":"        grps \u003d self.groups_client.list_groups("},{"line_number":110,"context_line":"            detail\u003dTrue)[\u0027groups\u0027]"},{"line_number":111,"context_line":"        for grp_id in [grp1_id, grp2_id]:"},{"line_number":112,"context_line":"            filtered_grps \u003d [g for g in grps if g[\u0027id\u0027] \u003d\u003d grp_id]"},{"line_number":113,"context_line":"            self.assertEqual(1, len(filtered_grps))"},{"line_number":114,"context_line":"            self.assertEqual([volume_type[\u0027id\u0027]],"},{"line_number":115,"context_line":"                             filtered_grps[0][\u0027volume_types\u0027])"},{"line_number":116,"context_line":"            self.assertEqual([group_type[\u0027id\u0027]],"},{"line_number":117,"context_line":"                             filtered_grps[0][\u0027group_type\u0027])"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"        filtered_vols \u003d self.volumes_client.list_volumes("},{"line_number":120,"context_line":"            detail\u003dTrue, **{\"group_id\": grp1_id})[\u0027volumes\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"bf57530f_2312015a","line":117,"range":{"start_line":111,"start_character":0,"end_line":117,"end_character":60},"updated":"2017-09-20 08:18:39.000000000","message":"what\u0027s the reason for this change? seems the original code is ok","commit_id":"5c4efa70eddacabc4b76d507455e833eb010a6ed"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"c5d1c88e3b487334d4a0afbf9710dc8317132b60","unresolved":false,"context_lines":[{"line_number":108,"context_line":"        # Get all groups with detail"},{"line_number":109,"context_line":"        grps \u003d self.groups_client.list_groups("},{"line_number":110,"context_line":"            detail\u003dTrue)[\u0027groups\u0027]"},{"line_number":111,"context_line":"        for grp_id in [grp1_id, grp2_id]:"},{"line_number":112,"context_line":"            filtered_grps \u003d [g for g in grps if g[\u0027id\u0027] \u003d\u003d grp_id]"},{"line_number":113,"context_line":"            self.assertEqual(1, len(filtered_grps))"},{"line_number":114,"context_line":"            self.assertEqual([volume_type[\u0027id\u0027]],"},{"line_number":115,"context_line":"                             filtered_grps[0][\u0027volume_types\u0027])"},{"line_number":116,"context_line":"            self.assertEqual([group_type[\u0027id\u0027]],"},{"line_number":117,"context_line":"                             filtered_grps[0][\u0027group_type\u0027])"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"        filtered_vols \u003d self.volumes_client.list_volumes("},{"line_number":120,"context_line":"            detail\u003dTrue, **{\"group_id\": grp1_id})[\u0027volumes\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f515b1d_48d06d51","line":117,"range":{"start_line":111,"start_character":0,"end_line":117,"end_character":60},"in_reply_to":"7f515b1d_5d4a7180","updated":"2017-09-22 09:35:09.000000000","message":"heh then I\u0027m ok with this most strict check:)","commit_id":"5c4efa70eddacabc4b76d507455e833eb010a6ed"},{"author":{"_account_id":23081,"name":"Jeremy Zhang","email":"zhangjun_inspur@163.com","username":"jeremy.zhang"},"change_message_id":"d928df0a87ec7bd84bd6f3f29e2f376d7f9c4dc4","unresolved":false,"context_lines":[{"line_number":108,"context_line":"        # Get all groups with detail"},{"line_number":109,"context_line":"        grps \u003d self.groups_client.list_groups("},{"line_number":110,"context_line":"            detail\u003dTrue)[\u0027groups\u0027]"},{"line_number":111,"context_line":"        for grp_id in [grp1_id, grp2_id]:"},{"line_number":112,"context_line":"            filtered_grps \u003d [g for g in grps if g[\u0027id\u0027] \u003d\u003d grp_id]"},{"line_number":113,"context_line":"            self.assertEqual(1, len(filtered_grps))"},{"line_number":114,"context_line":"            self.assertEqual([volume_type[\u0027id\u0027]],"},{"line_number":115,"context_line":"                             filtered_grps[0][\u0027volume_types\u0027])"},{"line_number":116,"context_line":"            self.assertEqual([group_type[\u0027id\u0027]],"},{"line_number":117,"context_line":"                             filtered_grps[0][\u0027group_type\u0027])"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"        filtered_vols \u003d self.volumes_client.list_volumes("},{"line_number":120,"context_line":"            detail\u003dTrue, **{\"group_id\": grp1_id})[\u0027volumes\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f515b1d_5d4a7180","line":117,"range":{"start_line":111,"start_character":0,"end_line":117,"end_character":60},"in_reply_to":"7f515b1d_5d74b199","updated":"2017-09-22 09:18:39.000000000","message":"I think in this test, the group list should only have one grp1_id and one grp2_id. so the \u0027filtered_grps\u0027 obtained should only have two elements, one grp1_id and one grp2_id. If the \u0027filtered_grps\u0027 is [\u0027grp1_id\u0027, \u0027grp2_id\u0027, \u0027grp2_id\u0027], then len(set(filtered_grps)) also equals 2. So using the \u0027set\u0027 method maybe also not a certained way, :), looking forward your suggestions.","commit_id":"5c4efa70eddacabc4b76d507455e833eb010a6ed"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"ceddcf7f866ed230f3914ae979d7be7300a00a92","unresolved":false,"context_lines":[{"line_number":108,"context_line":"        # Get all groups with detail"},{"line_number":109,"context_line":"        grps \u003d self.groups_client.list_groups("},{"line_number":110,"context_line":"            detail\u003dTrue)[\u0027groups\u0027]"},{"line_number":111,"context_line":"        for grp_id in [grp1_id, grp2_id]:"},{"line_number":112,"context_line":"            filtered_grps \u003d [g for g in grps if g[\u0027id\u0027] \u003d\u003d grp_id]"},{"line_number":113,"context_line":"            self.assertEqual(1, len(filtered_grps))"},{"line_number":114,"context_line":"            self.assertEqual([volume_type[\u0027id\u0027]],"},{"line_number":115,"context_line":"                             filtered_grps[0][\u0027volume_types\u0027])"},{"line_number":116,"context_line":"            self.assertEqual([group_type[\u0027id\u0027]],"},{"line_number":117,"context_line":"                             filtered_grps[0][\u0027group_type\u0027])"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"        filtered_vols \u003d self.volumes_client.list_volumes("},{"line_number":120,"context_line":"            detail\u003dTrue, **{\"group_id\": grp1_id})[\u0027volumes\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f515b1d_5d74b199","line":117,"range":{"start_line":111,"start_character":0,"end_line":117,"end_character":60},"in_reply_to":"9f5c4f37_fbdb777a","updated":"2017-09-22 08:52:52.000000000","message":"oh, I see. or maybe \"self.assertEqual(2, len(set(filtered_grps)))\" can also work?","commit_id":"5c4efa70eddacabc4b76d507455e833eb010a6ed"},{"author":{"_account_id":23081,"name":"Jeremy Zhang","email":"zhangjun_inspur@163.com","username":"jeremy.zhang"},"change_message_id":"bbaba15120345cc99028e39adbad073cc19e5d2c","unresolved":false,"context_lines":[{"line_number":108,"context_line":"        # Get all groups with detail"},{"line_number":109,"context_line":"        grps \u003d self.groups_client.list_groups("},{"line_number":110,"context_line":"            detail\u003dTrue)[\u0027groups\u0027]"},{"line_number":111,"context_line":"        for grp_id in [grp1_id, grp2_id]:"},{"line_number":112,"context_line":"            filtered_grps \u003d [g for g in grps if g[\u0027id\u0027] \u003d\u003d grp_id]"},{"line_number":113,"context_line":"            self.assertEqual(1, len(filtered_grps))"},{"line_number":114,"context_line":"            self.assertEqual([volume_type[\u0027id\u0027]],"},{"line_number":115,"context_line":"                             filtered_grps[0][\u0027volume_types\u0027])"},{"line_number":116,"context_line":"            self.assertEqual([group_type[\u0027id\u0027]],"},{"line_number":117,"context_line":"                             filtered_grps[0][\u0027group_type\u0027])"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"        filtered_vols \u003d self.volumes_client.list_volumes("},{"line_number":120,"context_line":"            detail\u003dTrue, **{\"group_id\": grp1_id})[\u0027volumes\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f5c4f37_fbdb777a","line":117,"range":{"start_line":111,"start_character":0,"end_line":117,"end_character":60},"in_reply_to":"bf57530f_2312015a","updated":"2017-09-21 02:09:57.000000000","message":"If use: filtered_grps \u003d [g for g in grps if g[\u0027id\u0027] in [grp1_id, grp2_id]]\n\nthe \u0027filtered_grps\u0027 cannot be certain to contain both grp1_id and grp2_id, the \u0027grps\u0027 maybe only contain two \u0027grp1_id\u0027. And here we need to verify the \u0027filtered_grps\u0027 has two different items.","commit_id":"5c4efa70eddacabc4b76d507455e833eb010a6ed"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"a2a526030e8ad98401a0ed2e40a6f855b6fb9de3","unresolved":false,"context_lines":[{"line_number":116,"context_line":"            self.assertEqual([group_type[\u0027id\u0027]],"},{"line_number":117,"context_line":"                             filtered_grps[0][\u0027group_type\u0027])"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"        filtered_vols \u003d self.volumes_client.list_volumes("},{"line_number":120,"context_line":"            detail\u003dTrue, **{\"group_id\": grp1_id})[\u0027volumes\u0027]"},{"line_number":121,"context_line":"        self.assertEqual(1, len(filtered_vols))"},{"line_number":122,"context_line":"        self.assertEqual(vol1_id, filtered_vols[0][\u0027id\u0027])"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"        # Delete group"},{"line_number":125,"context_line":"        # grp1 has a volume so delete_volumes flag is set to True by default"}],"source_content_type":"text/x-python","patch_set":2,"id":"bf57530f_e334e9e0","line":122,"range":{"start_line":119,"start_character":0,"end_line":122,"end_character":57},"updated":"2017-09-20 08:18:39.000000000","message":"is this duplicated with line 297-300?\nand maybe the check in line 122 can be added after line 300?","commit_id":"5c4efa70eddacabc4b76d507455e833eb010a6ed"},{"author":{"_account_id":23081,"name":"Jeremy Zhang","email":"zhangjun_inspur@163.com","username":"jeremy.zhang"},"change_message_id":"bbaba15120345cc99028e39adbad073cc19e5d2c","unresolved":false,"context_lines":[{"line_number":116,"context_line":"            self.assertEqual([group_type[\u0027id\u0027]],"},{"line_number":117,"context_line":"                             filtered_grps[0][\u0027group_type\u0027])"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"        filtered_vols \u003d self.volumes_client.list_volumes("},{"line_number":120,"context_line":"            detail\u003dTrue, **{\"group_id\": grp1_id})[\u0027volumes\u0027]"},{"line_number":121,"context_line":"        self.assertEqual(1, len(filtered_vols))"},{"line_number":122,"context_line":"        self.assertEqual(vol1_id, filtered_vols[0][\u0027id\u0027])"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"        # Delete group"},{"line_number":125,"context_line":"        # grp1 has a volume so delete_volumes flag is set to True by default"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f5c4f37_f075d6cd","line":122,"range":{"start_line":119,"start_character":0,"end_line":122,"end_character":57},"in_reply_to":"bf57530f_e334e9e0","updated":"2017-09-21 02:09:57.000000000","message":"Yes, it maybe a duplicate, but I\u0027m ok with it, :)","commit_id":"5c4efa70eddacabc4b76d507455e833eb010a6ed"}]}