)]}'
{"doc/source/write_tests.rst":[{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"a90524c13db148890bec6609ec0c5056468ce5d9","unresolved":false,"context_lines":[{"line_number":67,"context_line":"of these would be:"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":".. code-block:: python"},{"line_number":70,"context_line":"  "},{"line_number":71,"context_line":"  from tempest.common import waiters"},{"line_number":72,"context_line":"  from tempest import config"},{"line_number":73,"context_line":"  from tempest.lib.common.utils import test_utils"}],"source_content_type":"text/x-rst","patch_set":1,"id":"bf57530f_7300ae35","line":70,"range":{"start_line":70,"start_character":0,"end_line":70,"end_character":2},"updated":"2017-09-20 19:56:12.000000000","message":"White space that can cleaned up too.","commit_id":"2b1f0488e135475def05df1364a8db93586c73bd"}],"tempest/api/volume/test_volumes_get.py":[{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"6cb2ceda4b05a7782d1fb2cf3bb372ef4d08b4d6","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"class VolumesGetTest(base.BaseVolumeTest):"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    def _volume_create_get_update_delete(self, **kwargs):"},{"line_number":33,"context_line":"        # Create a volume, Get it\u0027s details and Delete the volume"},{"line_number":34,"context_line":"        v_name \u003d data_utils.rand_name(self.__class__.__name__ + \u0027-Volume\u0027)"},{"line_number":35,"context_line":"        metadata \u003d {\u0027Type\u0027: \u0027Test\u0027}"}],"source_content_type":"text/x-python","patch_set":5,"id":"5f4e5783_a30bd627","line":32,"range":{"start_line":32,"start_character":8,"end_line":32,"end_character":40},"updated":"2017-10-17 01:56:18.000000000","message":"after adding the new lines, _volume_create_get_update_delete will become too long for a single helper, so better to split it","commit_id":"fa3e946175035afa642b4ef2a7c752e916b654b3"},{"author":{"_account_id":25456,"name":"junboli","email":"junbo85.li@gmail.com","username":"junboli"},"change_message_id":"1bd33e8ca635b6154efb0c956a511ed936144ca2","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"class VolumesGetTest(base.BaseVolumeTest):"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    def _volume_create_get_update_delete(self, **kwargs):"},{"line_number":33,"context_line":"        # Create a volume, Get it\u0027s details and Delete the volume"},{"line_number":34,"context_line":"        v_name \u003d data_utils.rand_name(self.__class__.__name__ + \u0027-Volume\u0027)"},{"line_number":35,"context_line":"        metadata \u003d {\u0027Type\u0027: \u0027Test\u0027}"}],"source_content_type":"text/x-python","patch_set":5,"id":"5f4e5783_898c74d7","line":32,"range":{"start_line":32,"start_character":8,"end_line":32,"end_character":40},"in_reply_to":"5f4e5783_a30bd627","updated":"2017-10-17 08:42:25.000000000","message":"OK, Thanks.","commit_id":"fa3e946175035afa642b4ef2a7c752e916b654b3"},{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"b7b7f843f27cc8c330942d1978714f5dfc65b13d","unresolved":false,"context_lines":[{"line_number":117,"context_line":"            self.assertEqual(\u0027false\u0027, updated_volume[\u0027bootable\u0027])"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"        # test unicode symbols supported for volume name and description"},{"line_number":120,"context_line":"        params \u003d {\u0027name\u0027: \u0027ффф-name\u0027,"},{"line_number":121,"context_line":"                  \u0027description\u0027: \u0027ффф-desc\u0027}"},{"line_number":122,"context_line":"        volume \u003d self.volumes_client.create_volume(**params)[\u0027volume\u0027]"},{"line_number":123,"context_line":"        self.assertIn(\u0027id\u0027, volume)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f91af0f_e97c4473","line":120,"updated":"2018-01-10 07:08:15.000000000","message":"This doesn\u0027t work? Why do you remove this change in your latest patch?","commit_id":"fa3e946175035afa642b4ef2a7c752e916b654b3"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"6cb2ceda4b05a7782d1fb2cf3bb372ef4d08b4d6","unresolved":false,"context_lines":[{"line_number":117,"context_line":"            self.assertEqual(\u0027false\u0027, updated_volume[\u0027bootable\u0027])"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"        # test unicode symbols supported for volume name and description"},{"line_number":120,"context_line":"        params \u003d {\u0027name\u0027: \u0027ффф-name\u0027,"},{"line_number":121,"context_line":"                  \u0027description\u0027: \u0027ффф-desc\u0027}"},{"line_number":122,"context_line":"        volume \u003d self.volumes_client.create_volume(**params)[\u0027volume\u0027]"},{"line_number":123,"context_line":"        self.assertIn(\u0027id\u0027, volume)"}],"source_content_type":"text/x-python","patch_set":5,"id":"5f4e5783_433422fc","line":120,"range":{"start_line":120,"start_character":26,"end_line":120,"end_character":35},"updated":"2017-10-17 01:56:18.000000000","message":"maybe you can refer to test_update_server_name for the unicode name prefix, which is something like \n\"prefix_name \u003d u\u0027\\u00CD\\u00F1st\\u00E1\\u00F1c\\u00E9\u0027\"","commit_id":"fa3e946175035afa642b4ef2a7c752e916b654b3"},{"author":{"_account_id":25456,"name":"junboli","email":"junbo85.li@gmail.com","username":"junboli"},"change_message_id":"1bd33e8ca635b6154efb0c956a511ed936144ca2","unresolved":false,"context_lines":[{"line_number":117,"context_line":"            self.assertEqual(\u0027false\u0027, updated_volume[\u0027bootable\u0027])"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"        # test unicode symbols supported for volume name and description"},{"line_number":120,"context_line":"        params \u003d {\u0027name\u0027: \u0027ффф-name\u0027,"},{"line_number":121,"context_line":"                  \u0027description\u0027: \u0027ффф-desc\u0027}"},{"line_number":122,"context_line":"        volume \u003d self.volumes_client.create_volume(**params)[\u0027volume\u0027]"},{"line_number":123,"context_line":"        self.assertIn(\u0027id\u0027, volume)"}],"source_content_type":"text/x-python","patch_set":5,"id":"5f4e5783_299ea006","line":120,"range":{"start_line":120,"start_character":26,"end_line":120,"end_character":35},"in_reply_to":"5f4e5783_433422fc","updated":"2017-10-17 08:42:25.000000000","message":"Thanks for your suggestion, let me take a try.","commit_id":"fa3e946175035afa642b4ef2a7c752e916b654b3"},{"author":{"_account_id":25456,"name":"junboli","email":"junbo85.li@gmail.com","username":"junboli"},"change_message_id":"6097dca919d6ecf3148891cafaa304b53f123183","unresolved":false,"context_lines":[{"line_number":117,"context_line":"            self.assertEqual(\u0027false\u0027, updated_volume[\u0027bootable\u0027])"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"        # test unicode symbols supported for volume name and description"},{"line_number":120,"context_line":"        params \u003d {\u0027name\u0027: \u0027ффф-name\u0027,"},{"line_number":121,"context_line":"                  \u0027description\u0027: \u0027ффф-desc\u0027}"},{"line_number":122,"context_line":"        volume \u003d self.volumes_client.create_volume(**params)[\u0027volume\u0027]"},{"line_number":123,"context_line":"        self.assertIn(\u0027id\u0027, volume)"}],"source_content_type":"text/x-python","patch_set":5,"id":"7f96bb07_2f7ae623","line":120,"in_reply_to":"9f91af0f_e97c4473","updated":"2018-01-11 02:40:37.000000000","message":"Yes, the latest patch does not work, because:\n1. define a unicode in the laest patch is not correct, should use prefix u in the unicode.\n2. upd_volume \u003d self.volumes_client.update_volume(volume[\u0027id\u0027], **kwargs)\n   this is not correct, it should be:\n   upd_volume \u003d self.volumes_client.update_volume(\n       volume[\u0027id\u0027], **kwargs)[\u0027volume\u0027]","commit_id":"fa3e946175035afa642b4ef2a7c752e916b654b3"}]}