)]}'
{"tempest/api/volume/admin/test_volume_quotas.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"69749e72d3bc4637c313c7162445c960f856e1b6","unresolved":false,"context_lines":[{"line_number":26,"context_line":"class BaseVolumeQuotasAdminTestJSON(base.BaseVolumeAdminTest):"},{"line_number":27,"context_line":"    force_tenant_isolation \u003d True"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    credentials \u003d [\u0027primary\u0027, \u0027alt\u0027, \u0027admin\u0027, \u0027system\u0027]"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    def setUp(self):"},{"line_number":32,"context_line":"        # NOTE(jeremy.zhang): Avoid conflicts with volume quota class tests."}],"source_content_type":"text/x-python","patch_set":8,"id":"3f4b6375_5d1c9b69","line":29,"range":{"start_line":29,"start_character":37,"end_line":29,"end_character":45},"updated":"2017-10-20 03:25:52.000000000","message":"this is now kind of unused used for volume tests as they switched all policy rule to is_admin_project. can you remove this?\n\n\n\n- https://github.com/openstack/cinder/blob/master/cinder/policies/base.py","commit_id":"2e5bd4e5a66589102913d851be599a2185211fa8"}],"tempest/api/volume/base.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"69749e72d3bc4637c313c7162445c960f856e1b6","unresolved":false,"context_lines":[{"line_number":252,"context_line":"    def setup_clients(cls):"},{"line_number":253,"context_line":"        super(BaseVolumeAdminTest, cls).setup_clients()"},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"        cls.admin_volume_qos_client \u003d cls.os_system.volume_qos_v2_client"},{"line_number":256,"context_line":"        cls.admin_volume_services_client \u003d \\"},{"line_number":257,"context_line":"            cls.os_system.volume_services_v2_client"},{"line_number":258,"context_line":"        cls.admin_volume_types_client \u003d cls.os_system.volume_types_v2_client"}],"source_content_type":"text/x-python","patch_set":8,"id":"3f4b6375_dd6f6bc3","line":255,"range":{"start_line":255,"start_character":12,"end_line":255,"end_character":35},"updated":"2017-10-20 03:25:52.000000000","message":"we can change those to cls.system_* later or those are ok as it is also as cinder changed all policy to is_admin\n_project so admin there is system only.","commit_id":"2e5bd4e5a66589102913d851be599a2185211fa8"}],"tempest/lib/common/dynamic_creds.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"69749e72d3bc4637c313c7162445c960f856e1b6","unresolved":false,"context_lines":[{"line_number":177,"context_line":"        \"\"\""},{"line_number":178,"context_line":"        root \u003d self.name"},{"line_number":179,"context_line":"        username \u003d data_utils.rand_name(root, prefix\u003dself.resource_prefix)"},{"line_number":180,"context_line":"        use_admin_project \u003d system and self.system_project_id"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"        # for compatibility we assume we are only using the admin_project if"},{"line_number":183,"context_line":"        # the id was provided to config, otherwise we use the traditional"}],"source_content_type":"text/x-python","patch_set":8,"id":"3f4b6375_863bcd36","line":180,"range":{"start_line":180,"start_character":8,"end_line":180,"end_character":61},"updated":"2017-10-20 03:25:52.000000000","message":"also how about considering the system flag only. and evaluation of correct config like when system cred are requested then system_project_id/name etc are properly configured or not can be done in early stage like in get_credential() @L356","commit_id":"2e5bd4e5a66589102913d851be599a2185211fa8"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"69749e72d3bc4637c313c7162445c960f856e1b6","unresolved":false,"context_lines":[{"line_number":177,"context_line":"        \"\"\""},{"line_number":178,"context_line":"        root \u003d self.name"},{"line_number":179,"context_line":"        username \u003d data_utils.rand_name(root, prefix\u003dself.resource_prefix)"},{"line_number":180,"context_line":"        use_admin_project \u003d system and self.system_project_id"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"        # for compatibility we assume we are only using the admin_project if"},{"line_number":183,"context_line":"        # the id was provided to config, otherwise we use the traditional"}],"source_content_type":"text/x-python","patch_set":8,"id":"3f4b6375_c6d0a553","line":180,"range":{"start_line":180,"start_character":28,"end_line":180,"end_character":61},"updated":"2017-10-20 03:25:52.000000000","message":"how about considering the system_project_name also? \ni mean if system_project_name and domain name can be used to authenticate successfully, then we should consider this as\nuse_admin_project \u003d system and (self.system_project_id or self.system_project_name and self.system_domain_name(what ever domain we need))","commit_id":"2e5bd4e5a66589102913d851be599a2185211fa8"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"69749e72d3bc4637c313c7162445c960f856e1b6","unresolved":false,"context_lines":[{"line_number":183,"context_line":"        # the id was provided to config, otherwise we use the traditional"},{"line_number":184,"context_line":"        # admin role on any project concept"},{"line_number":185,"context_line":"        if use_admin_project:"},{"line_number":186,"context_line":"            # i don\u0027t think that name is validated or really used here."},{"line_number":187,"context_line":"            project \u003d {\u0027id\u0027: self.system_project_id,"},{"line_number":188,"context_line":"                       \u0027name\u0027: self.system_project_name}"},{"line_number":189,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":8,"id":"3f4b6375_8694ed8c","line":186,"range":{"start_line":186,"start_character":12,"end_line":186,"end_character":71},"updated":"2017-10-20 03:25:52.000000000","message":"this is used during auth if no project id. for v3 it is expected with domain name. \n\ntwo points here\n1. If no system_project_id is mentioned only system_project_name \u0026 system domain name (next question) are mentioned then also we should be able to authenticate successfully right.\n\n2. for v3, if project_name is mentioned then domain_name is mandatory so should not we add system_domain_name also in conf/param ? I am not sure domain for system project will be same or different from admin(current admin). if same then we can use admin_domain_name here.","commit_id":"2e5bd4e5a66589102913d851be599a2185211fa8"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"69749e72d3bc4637c313c7162445c960f856e1b6","unresolved":false,"context_lines":[{"line_number":211,"context_line":"        if use_admin_project:"},{"line_number":212,"context_line":"            # we should be able to define non-admin in system, but this isn\u0027t"},{"line_number":213,"context_line":"            # really used yet."},{"line_number":214,"context_line":"            self.creds_client.assign_user_role(user, project, self.admin_role)"},{"line_number":215,"context_line":"            role_assigned \u003d True"},{"line_number":216,"context_line":"        # Add roles specified in config file"},{"line_number":217,"context_line":"        for conf_role in self.extra_roles:"}],"source_content_type":"text/x-python","patch_set":8,"id":"3f4b6375_86474d1e","line":214,"range":{"start_line":214,"start_character":12,"end_line":214,"end_character":78},"updated":"2017-10-20 03:25:52.000000000","message":"this is not much clear to me. do we need to assign admin role to system?","commit_id":"2e5bd4e5a66589102913d851be599a2185211fa8"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"09f4f82329da714e5c92db82a59931cc2e8e4c58","unresolved":false,"context_lines":[{"line_number":211,"context_line":"        if use_admin_project:"},{"line_number":212,"context_line":"            # we should be able to define non-admin in system, but this isn\u0027t"},{"line_number":213,"context_line":"            # really used yet."},{"line_number":214,"context_line":"            self.creds_client.assign_user_role(user, project, self.admin_role)"},{"line_number":215,"context_line":"            role_assigned \u003d True"},{"line_number":216,"context_line":"        # Add roles specified in config file"},{"line_number":217,"context_line":"        for conf_role in self.extra_roles:"}],"source_content_type":"text/x-python","patch_set":8,"id":"3f79a3b5_83e513a7","line":214,"range":{"start_line":214,"start_character":12,"end_line":214,"end_character":78},"in_reply_to":"3f4b6375_86474d1e","updated":"2018-09-24 15:46:07.000000000","message":"we should have at least one user with this by bootstrapping keystone https://review.openstack.org/#/c/530410/","commit_id":"2e5bd4e5a66589102913d851be599a2185211fa8"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"69749e72d3bc4637c313c7162445c960f856e1b6","unresolved":false,"context_lines":[{"line_number":353,"context_line":"        if self._creds.get(str(credential_type)):"},{"line_number":354,"context_line":"            credentials \u003d self._creds[str(credential_type)]"},{"line_number":355,"context_line":"        else:"},{"line_number":356,"context_line":"            if credential_type \u003d\u003d \u0027system\u0027 and not self.system_project_id:"},{"line_number":357,"context_line":"                # if we\u0027re not using admin_projects then a system credential is"},{"line_number":358,"context_line":"                # just a regular old admin credential"},{"line_number":359,"context_line":"                return self.get_credentials(\u0027admin\u0027)"},{"line_number":360,"context_line":"            elif credential_type in [\u0027primary\u0027, \u0027alt\u0027, \u0027admin\u0027, \u0027system\u0027]:"},{"line_number":361,"context_line":"                is_admin \u003d (credential_type \u003d\u003d \u0027admin\u0027)"},{"line_number":362,"context_line":"                is_system \u003d (credential_type \u003d\u003d \u0027system\u0027)"}],"source_content_type":"text/x-python","patch_set":8,"id":"3f4b6375_6677b13c","line":359,"range":{"start_line":356,"start_character":0,"end_line":359,"end_character":52},"updated":"2017-10-20 03:25:52.000000000","message":"we should raise invalid credential exception here. If keystone has admin_project and people forget to mention it in tempest conf then going with regular admin cred will fail policy on project side. \n\nIf no admin_project on keystone (i think this is what you assumed in here), then people can set regular admin project in system_project_id/name etc so that tests required system cred can proceed with regular admin cred.","commit_id":"2e5bd4e5a66589102913d851be599a2185211fa8"}],"tempest/scenario/manager.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"69749e72d3bc4637c313c7162445c960f856e1b6","unresolved":false,"context_lines":[{"line_number":1246,"context_line":"class EncryptionScenarioTest(ScenarioTest):"},{"line_number":1247,"context_line":"    \"\"\"Base class for encryption scenario tests\"\"\""},{"line_number":1248,"context_line":""},{"line_number":1249,"context_line":"    credentials \u003d [\u0027primary\u0027, \u0027admin\u0027, \u0027system\u0027]"},{"line_number":1250,"context_line":""},{"line_number":1251,"context_line":"    @classmethod"},{"line_number":1252,"context_line":"    def setup_clients(cls):"}],"source_content_type":"text/x-python","patch_set":8,"id":"3f4b6375_0b65a8b5","line":1249,"range":{"start_line":1249,"start_character":31,"end_line":1249,"end_character":36},"updated":"2017-10-20 03:25:52.000000000","message":"ditto","commit_id":"2e5bd4e5a66589102913d851be599a2185211fa8"}]}