)]}'
{"tempest/common/compute.py":[{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"90c5efbed8ade287d7dc95a6bf07262fc0311bac","unresolved":false,"context_lines":[{"line_number":289,"context_line":"    url \u003d urlparse.urlparse(url)"},{"line_number":290,"context_line":"    for res in socket.getaddrinfo(url.hostname, url.port,"},{"line_number":291,"context_line":"                                  socket.AF_UNSPEC, socket.SOCK_STREAM):"},{"line_number":292,"context_line":"        af, socktype, proto, canonname, sa \u003d res"},{"line_number":293,"context_line":"        client_socket \u003d socket.socket(af, socktype, proto)"},{"line_number":294,"context_line":"        if url.scheme \u003d\u003d \u0027https\u0027:"},{"line_number":295,"context_line":"            client_socket \u003d ssl.wrap_socket(client_socket)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f4e5783_aed3d75f","line":292,"updated":"2017-10-16 05:06:53.000000000","message":"The `canonname` isn\u0027t used in this code, so that we can make this `_`.","commit_id":"aa2a8e2618e8b387196f8424d7e65f4a4a981d78"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"f415806a02180b921785c479098311d05cafb12c","unresolved":false,"context_lines":[{"line_number":289,"context_line":"    url \u003d urlparse.urlparse(url)"},{"line_number":290,"context_line":"    for res in socket.getaddrinfo(url.hostname, url.port,"},{"line_number":291,"context_line":"                                  socket.AF_UNSPEC, socket.SOCK_STREAM):"},{"line_number":292,"context_line":"        af, socktype, proto, canonname, sa \u003d res"},{"line_number":293,"context_line":"        client_socket \u003d socket.socket(af, socktype, proto)"},{"line_number":294,"context_line":"        if url.scheme \u003d\u003d \u0027https\u0027:"},{"line_number":295,"context_line":"            client_socket \u003d ssl.wrap_socket(client_socket)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f4b6375_c10e213a","line":292,"in_reply_to":"5f4e5783_aed3d75f","updated":"2017-10-23 08:46:29.000000000","message":"Done","commit_id":"aa2a8e2618e8b387196f8424d7e65f4a4a981d78"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"9e83683ea3e26fcb4a24cc299bc4e05216a582c3","unresolved":false,"context_lines":[{"line_number":299,"context_line":"        except socket.error:"},{"line_number":300,"context_line":"            client_socket.close()"},{"line_number":301,"context_line":"            continue"},{"line_number":302,"context_line":"        break"},{"line_number":303,"context_line":"    # Turn the Socket into a WebSocket to do the communication"},{"line_number":304,"context_line":"    return _WebSocket(client_socket, url)"},{"line_number":305,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ff82abbf_aec11ce7","line":302,"updated":"2017-11-30 19:07:35.000000000","message":"The overview seems good for me, one thing is that we need to add an exception check for the end of \"for\" loop instead of returning _WebSocket() like\n\n       break\n + else:\n +     raise SomeException(..)\n\n # Turn the Socket into a WebSocket to do the communication\n return _WebSocket(client_socket, url)","commit_id":"92d1150d4c2d29738497e19742268d0b928a18a8"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"4d8fd15197f21c7aa2e873a7a3e5ec0cf180a30f","unresolved":false,"context_lines":[{"line_number":299,"context_line":"        except socket.error:"},{"line_number":300,"context_line":"            client_socket.close()"},{"line_number":301,"context_line":"            continue"},{"line_number":302,"context_line":"        break"},{"line_number":303,"context_line":"    # Turn the Socket into a WebSocket to do the communication"},{"line_number":304,"context_line":"    return _WebSocket(client_socket, url)"},{"line_number":305,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ff82abbf_f6e4da3e","line":302,"in_reply_to":"ff82abbf_aec11ce7","updated":"2017-11-30 20:29:34.000000000","message":"Done","commit_id":"92d1150d4c2d29738497e19742268d0b928a18a8"}]}
