)]}'
{"tempest/api/volume/admin/test_group_snapshots.py":[{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"fbc1d4ff1e2932d7eef17f640d7065e84d5e46cd","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"class BaseGroupSnapshotsTest(base.BaseVolumeAdminTest):"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    def _create_group(self, group_type, volume_type, grp_name\u003dNone):"},{"line_number":27,"context_line":"        if not grp_name:"},{"line_number":28,"context_line":"            grp_name \u003d data_utils.rand_name(\u0027Group\u0027)"},{"line_number":29,"context_line":"        grp \u003d self.groups_client.create_group("}],"source_content_type":"text/x-python","patch_set":3,"id":"7f515b1d_794c9dc7","line":26,"range":{"start_line":26,"start_character":8,"end_line":26,"end_character":21},"updated":"2017-10-09 09:42:02.000000000","message":"how about add create_group and delete_group in base.BaseVolumeAdminTest?","commit_id":"5741e562cd40b0d57a8dd4fda21e4d363e4e1ae4"},{"author":{"_account_id":23081,"name":"Jeremy Zhang","email":"zhangjun_inspur@163.com","username":"jeremy.zhang"},"change_message_id":"06be735105aafd43baeaa1cb9d3d7ff729f9e5d1","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"class BaseGroupSnapshotsTest(base.BaseVolumeAdminTest):"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    def _create_group(self, group_type, volume_type, grp_name\u003dNone):"},{"line_number":27,"context_line":"        if not grp_name:"},{"line_number":28,"context_line":"            grp_name \u003d data_utils.rand_name(\u0027Group\u0027)"},{"line_number":29,"context_line":"        grp \u003d self.groups_client.create_group("}],"source_content_type":"text/x-python","patch_set":3,"id":"5f4e5783_c7aa1518","line":26,"range":{"start_line":26,"start_character":8,"end_line":26,"end_character":21},"in_reply_to":"7f515b1d_794c9dc7","updated":"2017-10-10 09:11:26.000000000","message":"Done, I think put \u0027create_group\u0027 and \u0027delete_group\u0027 in base.BaseVolumeTest maybe more suitable, :)","commit_id":"5741e562cd40b0d57a8dd4fda21e4d363e4e1ae4"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"fbc1d4ff1e2932d7eef17f640d7065e84d5e46cd","unresolved":false,"context_lines":[{"line_number":81,"context_line":"                                 group_id\u003dgrp[\u0027id\u0027])"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"        # Create group snapshot"},{"line_number":84,"context_line":"        group_snapshot_name \u003d data_utils.rand_name(\u0027group_snapshot\u0027)"},{"line_number":85,"context_line":"        group_snapshot \u003d ("},{"line_number":86,"context_line":"            self.group_snapshots_client.create_group_snapshot("},{"line_number":87,"context_line":"                group_id\u003dgrp[\u0027id\u0027],"},{"line_number":88,"context_line":"                name\u003dgroup_snapshot_name)[\u0027group_snapshot\u0027])"},{"line_number":89,"context_line":"        self.addCleanup(test_utils.call_and_ignore_notfound_exc,"},{"line_number":90,"context_line":"                        self._delete_group_snapshot,"},{"line_number":91,"context_line":"                        group_snapshot[\u0027id\u0027], grp[\u0027id\u0027])"},{"line_number":92,"context_line":"        snapshots \u003d self.snapshots_client.list_snapshots("},{"line_number":93,"context_line":"            detail\u003dTrue)[\u0027snapshots\u0027]"},{"line_number":94,"context_line":"        for snap in snapshots:"}],"source_content_type":"text/x-python","patch_set":3,"id":"7f515b1d_995d1949","line":91,"range":{"start_line":84,"start_character":0,"end_line":91,"end_character":56},"updated":"2017-10-09 09:42:02.000000000","message":"how about add _create_group_snapshot in BaseGroupSnapshotsTest to replace this?","commit_id":"5741e562cd40b0d57a8dd4fda21e4d363e4e1ae4"},{"author":{"_account_id":23081,"name":"Jeremy Zhang","email":"zhangjun_inspur@163.com","username":"jeremy.zhang"},"change_message_id":"06be735105aafd43baeaa1cb9d3d7ff729f9e5d1","unresolved":false,"context_lines":[{"line_number":81,"context_line":"                                 group_id\u003dgrp[\u0027id\u0027])"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"        # Create group snapshot"},{"line_number":84,"context_line":"        group_snapshot_name \u003d data_utils.rand_name(\u0027group_snapshot\u0027)"},{"line_number":85,"context_line":"        group_snapshot \u003d ("},{"line_number":86,"context_line":"            self.group_snapshots_client.create_group_snapshot("},{"line_number":87,"context_line":"                group_id\u003dgrp[\u0027id\u0027],"},{"line_number":88,"context_line":"                name\u003dgroup_snapshot_name)[\u0027group_snapshot\u0027])"},{"line_number":89,"context_line":"        self.addCleanup(test_utils.call_and_ignore_notfound_exc,"},{"line_number":90,"context_line":"                        self._delete_group_snapshot,"},{"line_number":91,"context_line":"                        group_snapshot[\u0027id\u0027], grp[\u0027id\u0027])"},{"line_number":92,"context_line":"        snapshots \u003d self.snapshots_client.list_snapshots("},{"line_number":93,"context_line":"            detail\u003dTrue)[\u0027snapshots\u0027]"},{"line_number":94,"context_line":"        for snap in snapshots:"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f4e5783_6208ef27","line":91,"range":{"start_line":84,"start_character":0,"end_line":91,"end_character":56},"in_reply_to":"7f515b1d_995d1949","updated":"2017-10-10 09:11:26.000000000","message":"Done, looking forward your suggestions.","commit_id":"5741e562cd40b0d57a8dd4fda21e4d363e4e1ae4"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"479759d8ba72791ad852bde86597be9756b1e0e1","unresolved":false,"context_lines":[{"line_number":137,"context_line":"        grp_name2 \u003d data_utils.rand_name(\u0027Group_from_snap\u0027)"},{"line_number":138,"context_line":"        grp2 \u003d self.groups_client.create_group_from_source("},{"line_number":139,"context_line":"            group_snapshot_id\u003dgroup_snapshot[\u0027id\u0027], name\u003dgrp_name2)[\u0027group\u0027]"},{"line_number":140,"context_line":"        self.addCleanup(self._delete_group, grp2[\u0027id\u0027])"},{"line_number":141,"context_line":"        self.assertEqual(grp_name2, grp2[\u0027name\u0027])"},{"line_number":142,"context_line":"        vols \u003d self.volumes_client.list_volumes(detail\u003dTrue)[\u0027volumes\u0027]"},{"line_number":143,"context_line":"        for vol in vols:"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f4e5783_82664b51","line":140,"range":{"start_line":140,"start_character":29,"end_line":140,"end_character":42},"updated":"2017-10-10 09:36:39.000000000","message":"delete_group?","commit_id":"0a24dec6cb785a88ee8a46e6867d4d5936cf8710"},{"author":{"_account_id":23081,"name":"Jeremy Zhang","email":"zhangjun_inspur@163.com","username":"jeremy.zhang"},"change_message_id":"d36db7dabcdb5ca99198795feaae4b30bca47c83","unresolved":false,"context_lines":[{"line_number":137,"context_line":"        grp_name2 \u003d data_utils.rand_name(\u0027Group_from_snap\u0027)"},{"line_number":138,"context_line":"        grp2 \u003d self.groups_client.create_group_from_source("},{"line_number":139,"context_line":"            group_snapshot_id\u003dgroup_snapshot[\u0027id\u0027], name\u003dgrp_name2)[\u0027group\u0027]"},{"line_number":140,"context_line":"        self.addCleanup(self._delete_group, grp2[\u0027id\u0027])"},{"line_number":141,"context_line":"        self.assertEqual(grp_name2, grp2[\u0027name\u0027])"},{"line_number":142,"context_line":"        vols \u003d self.volumes_client.list_volumes(detail\u003dTrue)[\u0027volumes\u0027]"},{"line_number":143,"context_line":"        for vol in vols:"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f4e5783_5db156e1","line":140,"range":{"start_line":140,"start_character":29,"end_line":140,"end_character":42},"in_reply_to":"5f4e5783_82664b51","updated":"2017-10-10 09:59:24.000000000","message":"Oops!","commit_id":"0a24dec6cb785a88ee8a46e6867d4d5936cf8710"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"bc8565b8493e3b9eb5a56930461c37f80e99358f","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"        group_snapshot \u003d self.group_snapshots_client.create_group_snapshot("},{"line_number":32,"context_line":"            **kwargs)[\u0027group_snapshot\u0027]"},{"line_number":33,"context_line":"        group_snapshot[\u0027group_id\u0027] \u003d kwargs[\u0027group_id\u0027]"},{"line_number":34,"context_line":"        self.addCleanup(test_utils.call_and_ignore_notfound_exc,"},{"line_number":35,"context_line":"                        self._delete_group_snapshot, group_snapshot)"},{"line_number":36,"context_line":"        waiters.wait_for_volume_resource_status("}],"source_content_type":"text/x-python","patch_set":7,"id":"5f4e5783_400b868d","line":33,"range":{"start_line":33,"start_character":8,"end_line":33,"end_character":55},"updated":"2017-10-11 08:45:21.000000000","message":"I wonder why this?","commit_id":"1dac3b876822c983f3292571feab3b77dc5210e6"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"2a082af5afabee427373db7cb89db82701c7a0c2","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"        group_snapshot \u003d self.group_snapshots_client.create_group_snapshot("},{"line_number":32,"context_line":"            **kwargs)[\u0027group_snapshot\u0027]"},{"line_number":33,"context_line":"        group_snapshot[\u0027group_id\u0027] \u003d kwargs[\u0027group_id\u0027]"},{"line_number":34,"context_line":"        self.addCleanup(test_utils.call_and_ignore_notfound_exc,"},{"line_number":35,"context_line":"                        self._delete_group_snapshot, group_snapshot)"},{"line_number":36,"context_line":"        waiters.wait_for_volume_resource_status("}],"source_content_type":"text/x-python","patch_set":7,"id":"5f4e5783_c26a677f","line":33,"range":{"start_line":33,"start_character":8,"end_line":33,"end_character":55},"in_reply_to":"5f4e5783_316434b9","updated":"2017-10-16 08:26:41.000000000","message":"then there is inconsistency between code and doc?","commit_id":"1dac3b876822c983f3292571feab3b77dc5210e6"},{"author":{"_account_id":23081,"name":"Jeremy Zhang","email":"zhangjun_inspur@163.com","username":"jeremy.zhang"},"change_message_id":"704681afb9e8ba0fc2ef501615013bae7bc6a40f","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"        group_snapshot \u003d self.group_snapshots_client.create_group_snapshot("},{"line_number":32,"context_line":"            **kwargs)[\u0027group_snapshot\u0027]"},{"line_number":33,"context_line":"        group_snapshot[\u0027group_id\u0027] \u003d kwargs[\u0027group_id\u0027]"},{"line_number":34,"context_line":"        self.addCleanup(test_utils.call_and_ignore_notfound_exc,"},{"line_number":35,"context_line":"                        self._delete_group_snapshot, group_snapshot)"},{"line_number":36,"context_line":"        waiters.wait_for_volume_resource_status("}],"source_content_type":"text/x-python","patch_set":7,"id":"5f4e5783_94ae5b2c","line":33,"range":{"start_line":33,"start_character":8,"end_line":33,"end_character":55},"in_reply_to":"5f4e5783_400b868d","updated":"2017-10-11 13:56:41.000000000","message":"\u0027group_id\u0027 is a required parameter for creating group snapshot, but the response body don\u0027t contain \u0027group_id\u0027.\nIt will be needed in the new _delete_group_snapshot() function.\n\nThe original _delete_group_snapshot function needs two parmas: group_snapshot_id and group_id, the new _delete_group_snapshot use one group_snapshot object to contain these two params (no need to verify the group_snapshot_id and the group_id whether belongs to the same group_snapshot).\n\nLooking forward your suggestions, :)","commit_id":"1dac3b876822c983f3292571feab3b77dc5210e6"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"54f5dcb531646bc37e4ec00b912fe5febcdfdc88","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"        group_snapshot \u003d self.group_snapshots_client.create_group_snapshot("},{"line_number":32,"context_line":"            **kwargs)[\u0027group_snapshot\u0027]"},{"line_number":33,"context_line":"        group_snapshot[\u0027group_id\u0027] \u003d kwargs[\u0027group_id\u0027]"},{"line_number":34,"context_line":"        self.addCleanup(test_utils.call_and_ignore_notfound_exc,"},{"line_number":35,"context_line":"                        self._delete_group_snapshot, group_snapshot)"},{"line_number":36,"context_line":"        waiters.wait_for_volume_resource_status("}],"source_content_type":"text/x-python","patch_set":7,"id":"5f4e5783_a0469f7b","line":33,"range":{"start_line":33,"start_character":8,"end_line":33,"end_character":55},"in_reply_to":"5f4e5783_94ae5b2c","updated":"2017-10-12 01:36:41.000000000","message":"oh, I wonder why group_id is not present in the result of create-group-snapshot?\nhttps://developer.openstack.org/api-ref/block-storage/v3/#create-group-snapshot shows that group_id is optional, \nso I thought if group_id was present in request body then it would be present in response body, isn\u0027t that true?","commit_id":"1dac3b876822c983f3292571feab3b77dc5210e6"},{"author":{"_account_id":23081,"name":"Jeremy Zhang","email":"zhangjun_inspur@163.com","username":"jeremy.zhang"},"change_message_id":"4f36bfbcfb2f5541bb9074c776fde404498c7cec","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"        group_snapshot \u003d self.group_snapshots_client.create_group_snapshot("},{"line_number":32,"context_line":"            **kwargs)[\u0027group_snapshot\u0027]"},{"line_number":33,"context_line":"        group_snapshot[\u0027group_id\u0027] \u003d kwargs[\u0027group_id\u0027]"},{"line_number":34,"context_line":"        self.addCleanup(test_utils.call_and_ignore_notfound_exc,"},{"line_number":35,"context_line":"                        self._delete_group_snapshot, group_snapshot)"},{"line_number":36,"context_line":"        waiters.wait_for_volume_resource_status("}],"source_content_type":"text/x-python","patch_set":7,"id":"5f4e5783_316434b9","line":33,"range":{"start_line":33,"start_character":8,"end_line":33,"end_character":55},"in_reply_to":"5f4e5783_a0469f7b","updated":"2017-10-12 14:19:11.000000000","message":"From the source code, we will find that the response body of creating group snapshot don\u0027t contain \u0027group_id\u0027, see [1][2]:\n\n[1] https://github.com/openstack/cinder/blob/master/cinder/api/v3/group_snapshots.py#L181\n\n[2] https://github.com/openstack/cinder/blob/master/cinder/api/v3/views/group_snapshots.py#L36","commit_id":"1dac3b876822c983f3292571feab3b77dc5210e6"},{"author":{"_account_id":23081,"name":"Jeremy Zhang","email":"zhangjun_inspur@163.com","username":"jeremy.zhang"},"change_message_id":"862930849af75cbe5e7a856e3e9eb76b386513fa","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"        group_snapshot \u003d self.group_snapshots_client.create_group_snapshot("},{"line_number":32,"context_line":"            **kwargs)[\u0027group_snapshot\u0027]"},{"line_number":33,"context_line":"        group_snapshot[\u0027group_id\u0027] \u003d kwargs[\u0027group_id\u0027]"},{"line_number":34,"context_line":"        self.addCleanup(test_utils.call_and_ignore_notfound_exc,"},{"line_number":35,"context_line":"                        self._delete_group_snapshot, group_snapshot)"},{"line_number":36,"context_line":"        waiters.wait_for_volume_resource_status("}],"source_content_type":"text/x-python","patch_set":7,"id":"5f4e5783_2c248aae","line":33,"range":{"start_line":33,"start_character":8,"end_line":33,"end_character":55},"in_reply_to":"5f4e5783_c26a677f","updated":"2017-10-16 10:47:10.000000000","message":"Yeah, it is.\nFrom the source code: Newton [1], Ocata [2], Pike [3] and master [4] branch, the \u0027summary\u0027 function of v3 group_snapshot views doesn\u0027t contain the \u0027group_id\u0027.\n\n[1] https://github.com/openstack/cinder/blob/stable/newton/cinder/api/v3/views/group_snapshots.py\n\n[2] https://github.com/openstack/cinder/blob/stable/ocata/cinder/api/v3/views/group_snapshots.py\n\n[3] https://github.com/openstack/cinder/blob/stable/pike/cinder/api/v3/views/group_snapshots.py\n\n[4] https://github.com/openstack/cinder/blob/master/cinder/api/v3/views/group_snapshots.py","commit_id":"1dac3b876822c983f3292571feab3b77dc5210e6"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"bc8565b8493e3b9eb5a56930461c37f80e99358f","unresolved":false,"context_lines":[{"line_number":102,"context_line":""},{"line_number":103,"context_line":"        # Delete group snapshot"},{"line_number":104,"context_line":"        self._delete_group_snapshot(group_snapshot)"},{"line_number":105,"context_line":"        group_snapshots \u003d (self.group_snapshots_client.list_group_snapshots()"},{"line_number":106,"context_line":"                           [\u0027group_snapshots\u0027])"},{"line_number":107,"context_line":"        self.assertEmpty(group_snapshots)"},{"line_number":108,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"5f4e5783_a04fdabb","line":105,"range":{"start_line":105,"start_character":26,"end_line":105,"end_character":27},"updated":"2017-10-11 08:45:21.000000000","message":"bracket is not recommended","commit_id":"1dac3b876822c983f3292571feab3b77dc5210e6"},{"author":{"_account_id":23081,"name":"Jeremy Zhang","email":"zhangjun_inspur@163.com","username":"jeremy.zhang"},"change_message_id":"704681afb9e8ba0fc2ef501615013bae7bc6a40f","unresolved":false,"context_lines":[{"line_number":102,"context_line":""},{"line_number":103,"context_line":"        # Delete group snapshot"},{"line_number":104,"context_line":"        self._delete_group_snapshot(group_snapshot)"},{"line_number":105,"context_line":"        group_snapshots \u003d (self.group_snapshots_client.list_group_snapshots()"},{"line_number":106,"context_line":"                           [\u0027group_snapshots\u0027])"},{"line_number":107,"context_line":"        self.assertEmpty(group_snapshots)"},{"line_number":108,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"5f4e5783_3479e7fb","line":105,"range":{"start_line":105,"start_character":26,"end_line":105,"end_character":27},"in_reply_to":"5f4e5783_a04fdabb","updated":"2017-10-11 13:56:41.000000000","message":"Done","commit_id":"1dac3b876822c983f3292571feab3b77dc5210e6"}],"tempest/api/volume/admin/test_groups.py":[{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"bc8565b8493e3b9eb5a56930461c37f80e99358f","unresolved":false,"context_lines":[{"line_number":22,"context_line":"CONF \u003d config.CONF"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"class GroupsTest(base.BaseVolumeAdminTest):"},{"line_number":26,"context_line":"    _api_version \u003d 3"},{"line_number":27,"context_line":"    min_microversion \u003d \u00273.13\u0027"},{"line_number":28,"context_line":"    max_microversion \u003d \u0027latest\u0027"}],"source_content_type":"text/x-python","patch_set":7,"id":"5f4e5783_00d10e55","line":25,"range":{"start_line":25,"start_character":17,"end_line":25,"end_character":41},"updated":"2017-10-11 08:45:21.000000000","message":"seems no admin credentials is used in GroupsTest?","commit_id":"1dac3b876822c983f3292571feab3b77dc5210e6"},{"author":{"_account_id":23081,"name":"Jeremy Zhang","email":"zhangjun_inspur@163.com","username":"jeremy.zhang"},"change_message_id":"704681afb9e8ba0fc2ef501615013bae7bc6a40f","unresolved":false,"context_lines":[{"line_number":22,"context_line":"CONF \u003d config.CONF"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"class GroupsTest(base.BaseVolumeAdminTest):"},{"line_number":26,"context_line":"    _api_version \u003d 3"},{"line_number":27,"context_line":"    min_microversion \u003d \u00273.13\u0027"},{"line_number":28,"context_line":"    max_microversion \u003d \u0027latest\u0027"}],"source_content_type":"text/x-python","patch_set":7,"id":"5f4e5783_344d6772","line":25,"range":{"start_line":25,"start_character":17,"end_line":25,"end_character":41},"in_reply_to":"5f4e5783_00d10e55","updated":"2017-10-11 13:56:41.000000000","message":"In GroupsTest, it needs admin credential to create new volume type.","commit_id":"1dac3b876822c983f3292571feab3b77dc5210e6"}],"tempest/api/volume/base.py":[{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"bc8565b8493e3b9eb5a56930461c37f80e99358f","unresolved":false,"context_lines":[{"line_number":257,"context_line":"    def delete_group(self, group_id, delete_volumes\u003dTrue):"},{"line_number":258,"context_line":"        self.groups_client.delete_group(group_id, delete_volumes)"},{"line_number":259,"context_line":"        vols \u003d self.volumes_client.list_volumes(detail\u003dTrue)[\u0027volumes\u0027]"},{"line_number":260,"context_line":"        for vol in vols:"},{"line_number":261,"context_line":"            if vol[\u0027group_id\u0027] \u003d\u003d group_id:"},{"line_number":262,"context_line":"                self.volumes_client.wait_for_resource_deletion(vol[\u0027id\u0027])"},{"line_number":263,"context_line":"        self.groups_client.wait_for_resource_deletion(group_id)"},{"line_number":264,"context_line":""},{"line_number":265,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"5f4e5783_808e1e76","line":262,"range":{"start_line":260,"start_character":0,"end_line":262,"end_character":73},"updated":"2017-10-11 08:45:21.000000000","message":"if delete_volumes is False, is this block needed?","commit_id":"1dac3b876822c983f3292571feab3b77dc5210e6"},{"author":{"_account_id":23081,"name":"Jeremy Zhang","email":"zhangjun_inspur@163.com","username":"jeremy.zhang"},"change_message_id":"704681afb9e8ba0fc2ef501615013bae7bc6a40f","unresolved":false,"context_lines":[{"line_number":257,"context_line":"    def delete_group(self, group_id, delete_volumes\u003dTrue):"},{"line_number":258,"context_line":"        self.groups_client.delete_group(group_id, delete_volumes)"},{"line_number":259,"context_line":"        vols \u003d self.volumes_client.list_volumes(detail\u003dTrue)[\u0027volumes\u0027]"},{"line_number":260,"context_line":"        for vol in vols:"},{"line_number":261,"context_line":"            if vol[\u0027group_id\u0027] \u003d\u003d group_id:"},{"line_number":262,"context_line":"                self.volumes_client.wait_for_resource_deletion(vol[\u0027id\u0027])"},{"line_number":263,"context_line":"        self.groups_client.wait_for_resource_deletion(group_id)"},{"line_number":264,"context_line":""},{"line_number":265,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"5f4e5783_6f3546da","line":262,"range":{"start_line":260,"start_character":0,"end_line":262,"end_character":73},"in_reply_to":"5f4e5783_808e1e76","updated":"2017-10-11 13:56:41.000000000","message":"Yes, when \u0027delete_volumes\u0027 is False, there\u0027s no need to wait for volume deletion.","commit_id":"1dac3b876822c983f3292571feab3b77dc5210e6"}]}