)]}'
{".zuul.yaml":[{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"5e0978f3421fe5dd38b971ea083f8dbf8e8e051a","unresolved":false,"context_lines":[{"line_number":10,"context_line":"    vars:"},{"line_number":11,"context_line":"      devstack_services:"},{"line_number":12,"context_line":"        tempest: True"},{"line_number":13,"context_line":"    run: playbooks/devstack-tempest"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"- project:"},{"line_number":16,"context_line":"    name: openstack/tempest"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"3f4b6375_590cdeea","line":13,"updated":"2017-11-07 22:46:54.000000000","message":"You should add the .yaml extension (zuul developers said that they will remove the support for automagically adding the extension)","commit_id":"5db62e5babfb3a93d0bd08e51c41e496ac1fac37"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"85acbd1f937fefbea0df4b37c243f08c695275f0","unresolved":false,"context_lines":[{"line_number":10,"context_line":"    vars:"},{"line_number":11,"context_line":"      devstack_services:"},{"line_number":12,"context_line":"        tempest: True"},{"line_number":13,"context_line":"    run: playbooks/devstack-tempest"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"- project:"},{"line_number":16,"context_line":"    name: openstack/tempest"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"3f4b6375_197f8615","line":13,"in_reply_to":"3f4b6375_590cdeea","updated":"2017-11-07 22:58:54.000000000","message":"Thanks! Done","commit_id":"5db62e5babfb3a93d0bd08e51c41e496ac1fac37"}],"playbooks/devstack-tempest.yaml":[{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"67689f78d9adb10b309b0f6919149dc3d08a6247","unresolved":false,"context_lines":[{"line_number":5,"context_line":"  roles:"},{"line_number":6,"context_line":"    - run-devstack"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"# NOTE(andreaf) For now run on all, since we don\u0027t have anything in the"},{"line_number":9,"context_line":"# inventory to select a test runner."},{"line_number":10,"context_line":"- hosts: all"},{"line_number":11,"context_line":"  roles:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3f4b6375_25f4e8f1","line":8,"updated":"2017-10-22 21:55:50.000000000","message":"devstack is a multinode job, even if it is used as single-node by default, and its default nodeset (openstack-single-node) defines a tempest group whose only member is \u0027controller\u0027 right now. Also the two-node version (openstack-two-nodes) defines that group.\nSo I think that everything could be done there (hosts: tempest).","commit_id":"5b252716b6de7b8ffd935202a1cab01ccd4dd63b"},{"author":{"_account_id":22406,"name":"Kien Nguyen","email":"kiennt2609@gmail.com","username":"kiennt"},"change_message_id":"f520d1346214646384a7fad4e83de53294ad81a7","unresolved":false,"context_lines":[{"line_number":5,"context_line":"  roles:"},{"line_number":6,"context_line":"    - run-devstack"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"# NOTE(andreaf) For now run on all, since we don\u0027t have anything in the"},{"line_number":9,"context_line":"# inventory to select a test runner."},{"line_number":10,"context_line":"- hosts: all"},{"line_number":11,"context_line":"  roles:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3f4b6375_85ca554b","line":8,"in_reply_to":"3f4b6375_25f4e8f1","updated":"2017-10-24 07:54:48.000000000","message":"+1\n\nThe definition is here [1].\n\n[1] https://github.com/openstack-dev/devstack/blob/master/.zuul.yaml#L19","commit_id":"5b252716b6de7b8ffd935202a1cab01ccd4dd63b"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"47feae1994ce8c5857441afabe5cd5b6f234ba0a","unresolved":false,"context_lines":[{"line_number":5,"context_line":"  roles:"},{"line_number":6,"context_line":"    - run-devstack"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"# NOTE(andreaf) For now run on all, since we don\u0027t have anything in the"},{"line_number":9,"context_line":"# inventory to select a test runner."},{"line_number":10,"context_line":"- hosts: all"},{"line_number":11,"context_line":"  roles:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3f4b6375_673df3db","line":8,"in_reply_to":"3f4b6375_85ca554b","updated":"2017-10-25 13:22:12.000000000","message":"Done","commit_id":"5b252716b6de7b8ffd935202a1cab01ccd4dd63b"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"58c2b5bcf96c0dd225e44293580accace43f7536","unresolved":false,"context_lines":[{"line_number":5,"context_line":"  roles:"},{"line_number":6,"context_line":"    - run-devstack"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"# We run tests only one one node, regardless how many nodes are in the system"},{"line_number":9,"context_line":"- hosts: tempest"},{"line_number":10,"context_line":"  roles:"},{"line_number":11,"context_line":"    - setup-tempest-run-dir"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3f4b6375_28e9f87e","line":8,"range":{"start_line":8,"start_character":20,"end_line":8,"end_character":23},"updated":"2017-10-26 03:40:01.000000000","message":"s/one/on","commit_id":"9f3991df2bb658a1cf2f29b4e771018df6122418"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"71665d2f9c5573d92e2f1e927665ea718558aff1","unresolved":false,"context_lines":[{"line_number":11,"context_line":"    - setup-tempest-run-dir"},{"line_number":12,"context_line":"    - setup-tempest-data-dir"},{"line_number":13,"context_line":"    - acl-devstack-files"},{"line_number":14,"context_line":"    - run-tempest"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"1f485f77_07eebb21","line":14,"updated":"2017-11-13 13:51:53.000000000","message":"Running tempest test is the main part of the job and other stuffs (run-devstack to acl-devstack-files) are preparations for the job.\nHow about defining L.1-13 to the pre-run phase. pre-run phase does not override pre-run of the parent job, so I think it is better.\n\nIn addition, if we have this in as pre-run phase, when someone extends devstack-tempest job itself, only run-tempest can be overridden by changing the run phase. (The run phase playbook is replaced when inheriting a parent job.)","commit_id":"7d5445dae2b9f95d435d06dc8cd22750ff831362"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"19145e4010bed3298d7ce5b9b119229d2d600c5f","unresolved":false,"context_lines":[{"line_number":11,"context_line":"    - setup-tempest-run-dir"},{"line_number":12,"context_line":"    - setup-tempest-data-dir"},{"line_number":13,"context_line":"    - acl-devstack-files"},{"line_number":14,"context_line":"    - run-tempest"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"1f485f77_3498bebe","line":14,"in_reply_to":"1f485f77_07eebb21","updated":"2017-11-13 16:25:32.000000000","message":"These are all good points. The reason why I made the run the way it is, is that zuul will retry a job automatically if there is a failure during pre, and I don\u0027t think we should retry to run devstack, since a failure in devstack is likely to be a legitimate\none.\n\nThis is just an initial version of the job, the idea I have is to make the run-tempest flexible enough via ansible variables so that there is no actual need in most cases to extend it. In extreme cases where one does need to extend it, it should be fine to duplicate the run playbook and change it as needed.\n\nStill I think you make a good point and we should discuss with the infra folks if there is an alternative way to overcome this. \n\nI would prefer though to start merging this patch in the meantime, and evolve it incrementally.","commit_id":"7d5445dae2b9f95d435d06dc8cd22750ff831362"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"a8e54a9c33de0b0544b3c6d63b72bbe392db7a3c","unresolved":false,"context_lines":[{"line_number":11,"context_line":"    - setup-tempest-run-dir"},{"line_number":12,"context_line":"    - setup-tempest-data-dir"},{"line_number":13,"context_line":"    - acl-devstack-files"},{"line_number":14,"context_line":"    - run-tempest"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"1f485f77_b4c70e13","line":14,"in_reply_to":"1f485f77_3498bebe","updated":"2017-11-13 16:41:49.000000000","message":"whether we should retry or not is an important point too. After reading your comment on \u0027retry\u0027, I am leaning to an option to have run-devstack in the run phase at the moment.","commit_id":"7d5445dae2b9f95d435d06dc8cd22750ff831362"}],"roles/run-tempest/README.rst":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"71665d2f9c5573d92e2f1e927665ea718558aff1","unresolved":false,"context_lines":[{"line_number":8,"context_line":"   The devstack base directory."},{"line_number":9,"context_line":""},{"line_number":10,"context_line":".. zuul:rolevar:: tempest_concurrency"},{"line_number":11,"context_line":"   :default: 0"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"   The number of parallel test processes."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-rst","patch_set":11,"id":"1f485f77_67bfaffb","line":11,"range":{"start_line":11,"start_character":3,"end_line":11,"end_character":14},"updated":"2017-11-13 13:51:53.000000000","message":"The default value itself is actually not defined.\nIsn\u0027t the default value \"undefined\" (means concurrency is determined automatically) ?","commit_id":"7d5445dae2b9f95d435d06dc8cd22750ff831362"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"19145e4010bed3298d7ce5b9b119229d2d600c5f","unresolved":false,"context_lines":[{"line_number":8,"context_line":"   The devstack base directory."},{"line_number":9,"context_line":""},{"line_number":10,"context_line":".. zuul:rolevar:: tempest_concurrency"},{"line_number":11,"context_line":"   :default: 0"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"   The number of parallel test processes."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-rst","patch_set":11,"id":"1f485f77_34f9dec7","line":11,"range":{"start_line":11,"start_character":3,"end_line":11,"end_character":14},"in_reply_to":"1f485f77_67bfaffb","updated":"2017-11-13 16:25:32.000000000","message":"Yeah good point, I need to fix this. Since it\u0027s documentation, can I fix it in a follow up patch?","commit_id":"7d5445dae2b9f95d435d06dc8cd22750ff831362"}],"roles/run-tempest/tasks/main.yaml":[{"author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"change_message_id":"361a8082ef33c355be132a8e019800e0e4bfe742","unresolved":false,"context_lines":[{"line_number":11,"context_line":"    default_concurrency: \"{{ansible_processor_vcpus|default(sysctl_hw_logicalcpu.stdout)|int}}\""},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"- name: Limit max concurrency when more than 3 vcpus are available"},{"line_number":14,"context_line":"  set_fact:"},{"line_number":15,"context_line":"    default_concurrency: \"{{default_concurrency|int // 2}}\""},{"line_number":16,"context_line":"  when: default_concurrency|int \u003e 3"},{"line_number":17,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3f4b6375_6d584989","line":14,"updated":"2017-11-03 06:21:39.000000000","message":"I am not sure is it wise idea to override a fact in ansible, can you make it a single expression ?","commit_id":"9f3991df2bb658a1cf2f29b4e771018df6122418"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"5f640a8f09a6a39960ffb7452c54ec23f1602c7a","unresolved":false,"context_lines":[{"line_number":9,"context_line":"- name: Limit max concurrency when more than 3 vcpus are available"},{"line_number":10,"context_line":"  set_fact:"},{"line_number":11,"context_line":"    default_concurrency: \"{{ansible_processor_vcpus|default(sysctl_hw_logicalcpu.stdout)|int // 2}}\""},{"line_number":12,"context_line":"  when: ansible_processor_vcpus|default(sysctl_hw_logicalcpu.stdout)|int \u003e 3"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"- name: Run Tempest"},{"line_number":15,"context_line":"  command: tox -e {{tox_venvlist}} -- --concurrency\u003d{{tempest_concurrency|default(default_concurrency)}}"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"3f4b6375_884d5e9b","line":12,"updated":"2017-11-08 06:13:05.000000000","message":"IIUC this will not set default_concurrency when we have less than 4 CPUs, causing the next command to fail.\n\nWill not be seen in testing where nodes always have 8 CPUs, but I think it would be good to verify things working with 1 or 2 CPUs, too.","commit_id":"d2512ee73fe866d8cd8bf4640d02750caaa669a1"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"c0b18ee0455d59de79eb44d1325c653a0ec0ffec","unresolved":false,"context_lines":[{"line_number":9,"context_line":"- name: Limit max concurrency when more than 3 vcpus are available"},{"line_number":10,"context_line":"  set_fact:"},{"line_number":11,"context_line":"    default_concurrency: \"{{ansible_processor_vcpus|default(sysctl_hw_logicalcpu.stdout)|int // 2}}\""},{"line_number":12,"context_line":"  when: ansible_processor_vcpus|default(sysctl_hw_logicalcpu.stdout)|int \u003e 3"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"- name: Run Tempest"},{"line_number":15,"context_line":"  command: tox -e {{tox_venvlist}} -- --concurrency\u003d{{tempest_concurrency|default(default_concurrency)}}"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"3f4b6375_c33217f2","line":12,"in_reply_to":"3f4b6375_884d5e9b","updated":"2017-11-08 06:27:08.000000000","message":"meh... nice catch, thank you!","commit_id":"d2512ee73fe866d8cd8bf4640d02750caaa669a1"}]}