)]}'
{"tempest/api/identity/admin/v3/test_domains.py":[{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"31b5bd549c71c9bb6550fa706126c64bdb7eba69","unresolved":false,"context_lines":[{"line_number":34,"context_line":"            cls.addClassResourceCleanup(cls._delete_domain, domain[\u0027id\u0027])"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    @classmethod"},{"line_number":37,"context_line":"    def _delete_domain(cls, domain_id):"},{"line_number":38,"context_line":"        # It is necessary to disable the domain before deleting,"},{"line_number":39,"context_line":"        # or else it would result in unauthorized error"},{"line_number":40,"context_line":"        cls.domains_client.update_domain(domain_id, enabled\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f515b1d_e64ee5bf","line":37,"range":{"start_line":37,"start_character":8,"end_line":37,"end_character":22},"updated":"2017-10-05 23:35:32.000000000","message":"This is replica of identity base delete_domain except that this is classmethod and the base one is instance-level method.","commit_id":"43cd4d776f3bb89fcdf97b731397e93f3fba5bcf"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"0d9777c5abc3c1ec336e1c0ada79e85c2fdf5f7b","unresolved":false,"context_lines":[{"line_number":31,"context_line":"        # One of those domains will be disabled"},{"line_number":32,"context_line":"        cls.setup_domains \u003d list()"},{"line_number":33,"context_line":"        for i in range(3):"},{"line_number":34,"context_line":"            domain \u003d cls.create_domain(enabled\u003di \u003c 2)"},{"line_number":35,"context_line":"            cls.setup_domains.append(domain)"},{"line_number":36,"context_line":"            cls.addClassResourceCleanup(cls._delete_domain, domain[\u0027id\u0027])"},{"line_number":37,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7f515b1d_24be00b4","line":34,"range":{"start_line":34,"start_character":25,"end_line":34,"end_character":38},"updated":"2017-10-09 02:53:22.000000000","message":"I am considering whether we can:\n1. remove base.setup_test_domain.\n2. add cls.addClassResourceCleanup of cls._delete_domain in base.create_domain.\nBecause domain is not a heavy resource for the system(and seems no other resource will encounter deletion error\nbecause domain is not deleted yet?), so I think maybe it\u0027s no harm for the domain to be deleted in resource_cleanup.\nLet\u0027s just wait for other opinions.","commit_id":"9b53a2e5989c0f2f9eedb15c7a9f779520d18343"}]}
