)]}'
{"tempest/api/compute/admin/test_aggregates_negative.py":[{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"e2c42c286b20ca23e744724e8574eb71cddc1e05","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    def setup_clients(cls):"},{"line_number":28,"context_line":"        super(AggregatesAdminNegativeTestJSON, cls).setup_clients()"},{"line_number":29,"context_line":"        cls.client \u003d cls.os_admin.aggregates_client"},{"line_number":30,"context_line":"        cls.user_client \u003d cls.aggregates_client"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    @classmethod"},{"line_number":33,"context_line":"    def resource_setup(cls):"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f4e5783_5e1d620d","side":"PARENT","line":30,"range":{"start_line":30,"start_character":8,"end_line":30,"end_character":47},"updated":"2017-10-13 08:45:48.000000000","message":"@masayuki, good catch, the name \"user_client\" is really misleading.","commit_id":"6c562fbc01263eca890c4f83454a897d83f5bad3"},{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"565066b978e58d2865ad0050a7345b9a772b808b","unresolved":false,"context_lines":[{"line_number":26,"context_line":"    @classmethod"},{"line_number":27,"context_line":"    def setup_clients(cls):"},{"line_number":28,"context_line":"        super(AggregatesAdminNegativeTestJSON, cls).setup_clients()"},{"line_number":29,"context_line":"        cls.client \u003d cls.os_admin.aggregates_client"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    @classmethod"},{"line_number":32,"context_line":"    def resource_setup(cls):"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f4e5783_6205f310","line":29,"updated":"2017-10-16 06:33:46.000000000","message":"My though was if we can remove this code, we can remove this \u0027setup_clients()\u0027.","commit_id":"b61942db061dd234b5f1be6a086c9e6d0871f7c1"}],"tempest/api/compute/servers/test_server_personality.py":[{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"23445010aad2152f16b9c8a43e7fdf9c648941f0","unresolved":false,"context_lines":[{"line_number":43,"context_line":"    @classmethod"},{"line_number":44,"context_line":"    def setup_clients(cls):"},{"line_number":45,"context_line":"        super(ServerPersonalityTestJSON, cls).setup_clients()"},{"line_number":46,"context_line":"        cls.client \u003d cls.servers_client"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    @decorators.idempotent_id(\u00273cfe87fd-115b-4a02-b942-7dc36a337fdf\u0027)"},{"line_number":49,"context_line":"    def test_create_server_with_personality(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f4e5783_686f4492","line":46,"updated":"2017-10-13 07:45:16.000000000","message":"Why not change this too? It\u0027s too long for the name?","commit_id":"ec1b9af2719972a696efe5a75450bd92c6e36e95"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"f9ee4d85e16e4af0cec6d42f356eeb6cd04e229d","unresolved":false,"context_lines":[{"line_number":43,"context_line":"    @classmethod"},{"line_number":44,"context_line":"    def setup_clients(cls):"},{"line_number":45,"context_line":"        super(ServerPersonalityTestJSON, cls).setup_clients()"},{"line_number":46,"context_line":"        cls.client \u003d cls.servers_client"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    @decorators.idempotent_id(\u00273cfe87fd-115b-4a02-b942-7dc36a337fdf\u0027)"},{"line_number":49,"context_line":"    def test_create_server_with_personality(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f4e5783_cb83d2cb","line":46,"in_reply_to":"5f4e5783_686f4492","updated":"2017-10-13 08:32:35.000000000","message":"Because there are many other similar situations, so I do not want to change only one occurrence in this patch:)\n\n[root@opencos_sbcj3 compute]# grep -rn \"cls\\.client \u003d \" .\n./volumes/test_volumes_list.py:45:        cls.client \u003d cls.volumes_extensions_client\n./volumes/test_volumes_negative.py:42:        cls.client \u003d cls.volumes_extensions_client\n./floating_ips/test_list_floating_ips.py:37:        cls.client \u003d cls.floating_ips_client\n./floating_ips/test_list_floating_ips_negative.py:39:        cls.client \u003d cls.floating_ips_client\n./floating_ips/test_floating_ips_actions.py:41:        cls.client \u003d cls.floating_ips_client\n./floating_ips/test_floating_ips_actions_negative.py:41:        cls.client \u003d cls.floating_ips_client\n./admin/test_servers.py:27:        cls.client \u003d cls.os_admin.servers_client\n./admin/test_availability_zone.py:26:        cls.client \u003d cls.availability_zone_admin_client\n./admin/test_servers_negative.py:34:        cls.client \u003d cls.os_admin.servers_client\n./admin/test_aggregates_negative.py:29:        cls.client \u003d cls.os_admin.aggregates_client\n./admin/test_simple_tenant_usage_negative.py:29:        cls.client \u003d cls.os_primary.tenant_usages_client\n./admin/test_aggregates.py:34:        cls.client \u003d cls.os_admin.aggregates_client\n./admin/test_fixed_ips_negative.py:38:        cls.client \u003d cls.os_admin.fixed_ips_client\n./admin/test_keypairs_v210.py:28:        cls.client \u003d cls.os_admin.keypairs_client\n./admin/test_hypervisor.py:26:        cls.client \u003d cls.os_admin.hypervisor_client\n./admin/test_hosts.py:26:        cls.client \u003d cls.os_admin.hosts_client\n./admin/test_migrations.py:32:        cls.client \u003d cls.os_admin.migrations_client\n./admin/test_simple_tenant_usage.py:34:        cls.client \u003d cls.os_primary.tenant_usages_client\n./admin/test_floating_ips_bulk.py:38:        cls.client \u003d cls.os_admin.floating_ips_bulk_client\n./admin/test_security_groups.py:28:        cls.client \u003d cls.security_groups_client\n./admin/test_hosts_negative.py:26:        cls.client \u003d cls.os_admin.hosts_client\n./admin/test_quotas_negative.py:31:        cls.client \u003d cls.os_primary.quotas_client\n./admin/test_create_server.py:38:        cls.client \u003d cls.servers_client\n./admin/test_server_diagnostics_negative.py:27:        cls.client \u003d cls.servers_client\n./admin/test_fixed_ips.py:38:        cls.client \u003d cls.os_admin.fixed_ips_client\n./admin/test_agents.py:26:        cls.client \u003d cls.os_admin.agents_client\n./admin/test_hypervisor_negative.py:28:        cls.client \u003d cls.os_admin.hypervisor_client\n./admin/test_networks.py:33:        cls.client \u003d cls.os_admin.compute_networks_client\n./admin/test_services_negative.py:26:        cls.client \u003d cls.os_admin.services_client\n./admin/test_server_diagnostics.py:28:        cls.client \u003d cls.os_admin.servers_client\n./admin/test_server_diagnostics.py:50:        cls.client \u003d cls.os_admin.servers_client\n./admin/test_services.py:27:        cls.client \u003d cls.os_admin.services_client\n./test_tenant_networks.py:25:        cls.client \u003d cls.os_primary.tenant_networks_client\n./keypairs/base.py:26:        cls.client \u003d cls.keypairs_client\n./test_quotas.py:39:        cls.client \u003d cls.quotas_client\n./images/test_images_negative.py:41:        cls.client \u003d cls.compute_images_client\n./images/test_images_oneserver_negative.py:72:        cls.client \u003d cls.compute_images_client\n./images/test_images.py:41:        cls.client \u003d cls.compute_images_client\n./images/test_list_images.py:35:        cls.client \u003d cls.compute_images_client\n./images/test_image_metadata_negative.py:27:        cls.client \u003d cls.compute_images_client\n./images/test_images_oneserver.py:47:        cls.client \u003d cls.compute_images_client\n./images/test_image_metadata.py:53:        cls.client \u003d cls.compute_images_client\n./images/test_list_image_filters.py:45:        cls.client \u003d cls.compute_images_client\n./images/test_list_image_filters_negative.py:36:        cls.client \u003d cls.compute_images_client\n./limits/test_absolute_limits.py:25:        cls.client \u003d cls.limits_client\n./limits/test_absolute_limits_negative.py:32:        cls.client \u003d cls.limits_client\n./test_networks.py:32:        cls.client \u003d cls.os_primary.compute_networks_client\n./security_groups/test_security_group_rules.py:25:        cls.client \u003d cls.security_group_rules_client\n./security_groups/test_security_groups.py:28:        cls.client \u003d cls.security_groups_client\n./security_groups/test_security_groups_negative.py:32:        cls.client \u003d cls.security_groups_client\n./servers/test_list_server_filters.py:38:        cls.client \u003d cls.servers_client\n./servers/test_virtual_interfaces.py:39:        cls.client \u003d cls.servers_client\n./servers/test_servers.py:33:        cls.client \u003d cls.servers_client\n./servers/test_server_metadata.py:25:        cls.client \u003d cls.servers_client\n./servers/test_server_group.py:43:        cls.client \u003d cls.server_groups_client\n./servers/test_availability_zone.py:26:        cls.client \u003d cls.availability_zone_client\n./servers/test_server_metadata_negative.py:27:        cls.client \u003d cls.servers_client\n./servers/test_servers_negative.py:49:        cls.client \u003d cls.servers_client\n./servers/test_instance_actions_negative.py:27:        cls.client \u003d cls.servers_client\n./servers/test_server_password.py:26:        cls.client \u003d cls.servers_client\n./servers/test_list_servers_negative.py:27:        cls.client \u003d cls.servers_client\n./servers/test_server_actions.py:73:        cls.client \u003d cls.servers_client\n./servers/test_server_addresses.py:32:        cls.client \u003d cls.servers_client\n./servers/test_create_server_multi_nic.py:37:        cls.client \u003d cls.servers_client\n./servers/test_delete_server.py:36:        cls.client \u003d cls.servers_client\n./servers/test_disk_config.py:38:        cls.client \u003d cls.os_primary.servers_client\n./servers/test_virtual_interfaces_negative.py:34:        cls.client \u003d cls.servers_client\n./servers/test_server_tags.py:39:        cls.client \u003d cls.servers_client\n./servers/test_create_server.py:41:        cls.client \u003d cls.servers_client\n./servers/test_server_addresses_negative.py:32:        cls.client \u003d cls.servers_client\n./servers/test_novnc.py:55:        cls.client \u003d cls.servers_client\n./servers/test_instance_actions.py:26:        cls.client \u003d cls.servers_client\n./servers/test_instance_actions.py:64:        cls.client \u003d cls.servers_client\n./servers/test_server_personality.py:46:        cls.client \u003d cls.servers_client","commit_id":"ec1b9af2719972a696efe5a75450bd92c6e36e95"},{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"565066b978e58d2865ad0050a7345b9a772b808b","unresolved":false,"context_lines":[{"line_number":43,"context_line":"    @classmethod"},{"line_number":44,"context_line":"    def setup_clients(cls):"},{"line_number":45,"context_line":"        super(ServerPersonalityTestJSON, cls).setup_clients()"},{"line_number":46,"context_line":"        cls.client \u003d cls.servers_client"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    @decorators.idempotent_id(\u00273cfe87fd-115b-4a02-b942-7dc36a337fdf\u0027)"},{"line_number":49,"context_line":"    def test_create_server_with_personality(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f4e5783_4206771e","line":46,"updated":"2017-10-16 06:33:46.000000000","message":"same here. But I think it\u0027s not a big problem.","commit_id":"b61942db061dd234b5f1be6a086c9e6d0871f7c1"}]}