)]}'
{"tempest/cli/simple_read_only/test_glance.py":[{"author":{"_account_id":7872,"name":"Marc Koderer","email":"marc@koderer.com","username":"mkoderer"},"change_message_id":"ec47063611b0d71a1563cea7c2856404d5d95de5","unresolved":false,"context_lines":[{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    def test_glance_member_list(self):"},{"line_number":53,"context_line":"        self.glance(\u0027member-list\u0027,"},{"line_number":54,"context_line":"                    params\u003d\u0027--tenant-id %s\u0027 % self.identity.admin_tenant_name)"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    def test_glance_help(self):"},{"line_number":57,"context_line":"        help_text \u003d self.glance(\u0027help\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATH%2F%2FoHE%3D","line":54,"updated":"2013-10-12 06:32:40.000000000","message":"We need here some output validation, too.","commit_id":"60e6c0bcc91e588eb3669453087bcb736aaee870"},{"author":{"_account_id":8021,"name":"wingwj","email":"wingwj@gmail.com","username":"wingwj"},"change_message_id":"51aef559490efa196838d1e52446609cc1aa9b76","unresolved":false,"context_lines":[{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    def test_glance_member_list(self):"},{"line_number":53,"context_line":"        self.glance(\u0027member-list\u0027,"},{"line_number":54,"context_line":"                    params\u003d\u0027--tenant-id %s\u0027 % self.identity.admin_tenant_name)"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    def test_glance_help(self):"},{"line_number":57,"context_line":"        help_text \u003d self.glance(\u0027help\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATH%2F%2FoBE%3D","line":54,"in_reply_to":"AAAATH%2F%2FoHE%3D","updated":"2013-10-12 09:39:33.000000000","message":"Done","commit_id":"60e6c0bcc91e588eb3669453087bcb736aaee870"},{"author":{"_account_id":7872,"name":"Marc Koderer","email":"marc@koderer.com","username":"mkoderer"},"change_message_id":"ec47063611b0d71a1563cea7c2856404d5d95de5","unresolved":false,"context_lines":[{"line_number":78,"context_line":"    def test_glance_version(self):"},{"line_number":79,"context_line":"        self.glance(\u0027\u0027, flags\u003d\u0027--version\u0027)"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    def test_glance_debug_list(self):"},{"line_number":82,"context_line":"        self.glance(\u0027image-list\u0027, flags\u003d\u0027--debug\u0027)"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    def test_glance_timeout(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATH%2F%2FoGg%3D","line":81,"updated":"2013-10-12 06:32:40.000000000","message":"This file should contain \"basic\" cli testing of glance. Why do we need to test these special parameters?","commit_id":"60e6c0bcc91e588eb3669453087bcb736aaee870"},{"author":{"_account_id":8021,"name":"wingwj","email":"wingwj@gmail.com","username":"wingwj"},"change_message_id":"51aef559490efa196838d1e52446609cc1aa9b76","unresolved":false,"context_lines":[{"line_number":78,"context_line":"    def test_glance_version(self):"},{"line_number":79,"context_line":"        self.glance(\u0027\u0027, flags\u003d\u0027--version\u0027)"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    def test_glance_debug_list(self):"},{"line_number":82,"context_line":"        self.glance(\u0027image-list\u0027, flags\u003d\u0027--debug\u0027)"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    def test_glance_timeout(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATH%2F%2Fn4k%3D","line":81,"in_reply_to":"AAAATH%2F%2FoGg%3D","updated":"2013-10-12 09:39:33.000000000","message":"In my opinion, this\u0027s also a \u0027basic\u0027 cli usage.\n\nAdding a \u0027--debug\u0027 tag, the operator or admin may easily find  mistakes and wrong configs through cli, no need to always check the log-files.\n\nMoreover, \u0027--debug\u0027 test has already involved in tempest of Nova/Cinder/Neutron/Keystone, only except Glance..\nI just want to complete it. :-)","commit_id":"60e6c0bcc91e588eb3669453087bcb736aaee870"},{"author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"change_message_id":"2acfb4a83ab5b9364be0f773b70ba11f7e6bd2e6","unresolved":false,"context_lines":[{"line_number":79,"context_line":"        self.glance(\u0027\u0027, flags\u003d\u0027--version\u0027)"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    def test_glance_debug_list(self):"},{"line_number":82,"context_line":"        self.glance(\u0027image-list\u0027, flags\u003d\u0027--debug\u0027)"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    def test_glance_timeout(self):"},{"line_number":85,"context_line":"        self.glance(\u0027image-list\u0027, flags\u003d\u0027--timeout %d\u0027 % CONF.cli.timeout)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATH%2F%2FpV0%3D","line":82,"updated":"2013-10-11 19:37:06.000000000","message":"And here","commit_id":"60e6c0bcc91e588eb3669453087bcb736aaee870"},{"author":{"_account_id":8021,"name":"wingwj","email":"wingwj@gmail.com","username":"wingwj"},"change_message_id":"51aef559490efa196838d1e52446609cc1aa9b76","unresolved":false,"context_lines":[{"line_number":79,"context_line":"        self.glance(\u0027\u0027, flags\u003d\u0027--version\u0027)"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    def test_glance_debug_list(self):"},{"line_number":82,"context_line":"        self.glance(\u0027image-list\u0027, flags\u003d\u0027--debug\u0027)"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    def test_glance_timeout(self):"},{"line_number":85,"context_line":"        self.glance(\u0027image-list\u0027, flags\u003d\u0027--timeout %d\u0027 % CONF.cli.timeout)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATH%2F%2Fn5g%3D","line":82,"in_reply_to":"AAAATH%2F%2FpV0%3D","updated":"2013-10-12 09:39:33.000000000","message":"Hi Joe,\nI got the result of \u0027glance --debug image-list\u0027,\n  it\u0027s the same with \u0027glance image-list\u0027.\nIt relates to the glance_cli defined in tempest/cli/__init__.py.\n\nSo I didn\u0027t validate it more.","commit_id":"60e6c0bcc91e588eb3669453087bcb736aaee870"},{"author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"change_message_id":"2acfb4a83ab5b9364be0f773b70ba11f7e6bd2e6","unresolved":false,"context_lines":[{"line_number":85,"context_line":"        self.glance(\u0027image-list\u0027, flags\u003d\u0027--timeout %d\u0027 % CONF.cli.timeout)"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    def test_glance_get_schema(self):"},{"line_number":88,"context_line":"        self.glance(\u0027image-list\u0027, flags\u003d\u0027--get-schema\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATH%2F%2FpWM%3D","line":88,"updated":"2013-10-11 19:37:06.000000000","message":"Can we validate the output here as well?","commit_id":"60e6c0bcc91e588eb3669453087bcb736aaee870"},{"author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"change_message_id":"6c22a3cbd16f1b6240a5e2522f3dfd159775b7ef","unresolved":false,"context_lines":[{"line_number":89,"context_line":"        self.glance(\u0027image-list\u0027, flags\u003d\u0027--timeout %d\u0027 % CONF.cli.timeout)"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    def test_glance_get_schema(self):"},{"line_number":92,"context_line":"        self.glance(\u0027image-list\u0027, flags\u003d\u0027--get-schema\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATH%2F%2Fi5k%3D","line":92,"updated":"2013-10-14 18:05:31.000000000","message":"I am little unclear on what this command is supposed to do.  Also as this only does something for v2 API, perhaps we need some logic about that here?   Also are we using v2 glance API in devstack yet (that question is out of the scope of this patch but just wondering -- in devstack it appears I am not using it)","commit_id":"4ff5557f0f2de0a43523e49ddd2158ea2a4a2ec3"},{"author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"change_message_id":"786da1052e7164dfc25bef83f73f874272dddd71","unresolved":false,"context_lines":[{"line_number":89,"context_line":"        self.glance(\u0027image-list\u0027, flags\u003d\u0027--timeout %d\u0027 % CONF.cli.timeout)"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    def test_glance_get_schema(self):"},{"line_number":92,"context_line":"        self.glance(\u0027image-list\u0027, flags\u003d\u0027--get-schema\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATX%2F%2F%2BnU%3D","line":92,"in_reply_to":"AAAATH%2F%2FOY8%3D","updated":"2013-10-23 12:04:28.000000000","message":"so does this command return anything in V2?\n\nCan you add a comment saying that this is a v2 only feature, so if someone comes along later and makes these tests more exhaustive and check the output of the commands instead of just making sure they don\u0027t cause glance client to error out, they will know.","commit_id":"4ff5557f0f2de0a43523e49ddd2158ea2a4a2ec3"},{"author":{"_account_id":8021,"name":"wingwj","email":"wingwj@gmail.com","username":"wingwj"},"change_message_id":"50fa90518cea76a23b23fb6f147ca7a6e818550c","unresolved":false,"context_lines":[{"line_number":89,"context_line":"        self.glance(\u0027image-list\u0027, flags\u003d\u0027--timeout %d\u0027 % CONF.cli.timeout)"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    def test_glance_get_schema(self):"},{"line_number":92,"context_line":"        self.glance(\u0027image-list\u0027, flags\u003d\u0027--get-schema\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATH%2F%2FOY8%3D","line":92,"in_reply_to":"AAAATH%2F%2Fi5k%3D","updated":"2013-10-21 02:38:13.000000000","message":"Hi Joe,\n\nHonestly speaking, I\u0027m also confused about its using in glance v1.. I checked it via API, \u0027schema\u0027 is only available in v2 api with \u0027/v2/schemas/images\u0027. But I saw it\u0027s involved in the glance cli, so I added it here. (Is it necessary?)\n\nAnd about glance v2 api, they\u0027re available in devstack, I\u0027m testing them now. :-)","commit_id":"4ff5557f0f2de0a43523e49ddd2158ea2a4a2ec3"},{"author":{"_account_id":8021,"name":"wingwj","email":"wingwj@gmail.com","username":"wingwj"},"change_message_id":"71132dd0c9e614f1069cb9938aa54892271fb7bd","unresolved":false,"context_lines":[{"line_number":89,"context_line":"        self.glance(\u0027image-list\u0027, flags\u003d\u0027--timeout %d\u0027 % CONF.cli.timeout)"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    def test_glance_get_schema(self):"},{"line_number":92,"context_line":"        self.glance(\u0027image-list\u0027, flags\u003d\u0027--get-schema\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F%2F%2B08%3D","line":92,"in_reply_to":"AAAATX%2F%2F%2BnU%3D","updated":"2013-10-24 09:47:09.000000000","message":"Hi Joe,\n\nThe return of \u0027--get-schema\u0027 doesn\u0027t return none.\n\nNo matter \u0027--get-schema\u0027 is specified in glance-cli, the result equals to the output of \u0027image-list\u0027 based on each version. \n\nAnd if you use it via API \u0027GET /v2/schemas/images\u0027, you\u0027ll get a structure dict.\n\nPlease see more details from here:\nhttp://paste.openstack.org/show/49436/\n\n---------------\n\nI\u0027ll comment it in the patch for v2. Thanks for your reviewing~","commit_id":"4ff5557f0f2de0a43523e49ddd2158ea2a4a2ec3"},{"author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"change_message_id":"5976c0e96c80a234ac7be3a0f45e23e13f740e83","unresolved":false,"context_lines":[{"line_number":89,"context_line":"        self.glance(\u0027image-list\u0027, flags\u003d\u0027--timeout %d\u0027 % CONF.cli.timeout)"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    def test_glance_get_schema(self):"},{"line_number":92,"context_line":"        self.glance(\u0027image-list\u0027, flags\u003d\u0027--get-schema\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F%2F%2Bnk%3D","line":92,"in_reply_to":"AAAATn%2F%2F%2B08%3D","updated":"2013-10-24 11:24:46.000000000","message":"wingwj,  it sounds like you found a bug to me, a flag shouldn\u0027t do nothing.  Can you file a bug with glanceclient for this.","commit_id":"4ff5557f0f2de0a43523e49ddd2158ea2a4a2ec3"},{"author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"change_message_id":"0afe8ec3c50449913684a7b62bba2ed0c01586d0","unresolved":false,"context_lines":[{"line_number":91,"context_line":"    def test_glance_get_schema(self):"},{"line_number":92,"context_line":"        # Note(wingwj): This\u0027s a v2 only feature, but won\u0027t be error out in v1"},{"line_number":93,"context_line":"        # No matter the param is specified,"},{"line_number":94,"context_line":"        # the result equals to output of \u0027image-list\u0027 based on each version"},{"line_number":95,"context_line":"        self.glance(\u0027image-list\u0027, flags\u003d\u0027--get-schema\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F%2F%2BnM%3D","line":94,"updated":"2013-10-24 11:26:12.000000000","message":"While this looks good to me, I think you found a bug and we should get some clarity from the glanceclient team on this before merging.","commit_id":"96692aed733430b1b862cdc255592178fe7b2aac"},{"author":{"_account_id":8021,"name":"wingwj","email":"wingwj@gmail.com","username":"wingwj"},"change_message_id":"2fa3ba518c9bddc2d347f1a83cc9bc6483ab8a2d","unresolved":false,"context_lines":[{"line_number":91,"context_line":"    def test_glance_get_schema(self):"},{"line_number":92,"context_line":"        # Note(wingwj): This\u0027s a v2 only feature, but won\u0027t be error out in v1"},{"line_number":93,"context_line":"        # No matter the param is specified,"},{"line_number":94,"context_line":"        # the result equals to output of \u0027image-list\u0027 based on each version"},{"line_number":95,"context_line":"        self.glance(\u0027image-list\u0027, flags\u003d\u0027--get-schema\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F%2F%2BgI%3D","line":94,"in_reply_to":"AAAATn%2F%2F%2BnM%3D","updated":"2013-10-24 12:02:37.000000000","message":"Done","commit_id":"96692aed733430b1b862cdc255592178fe7b2aac"}]}