)]}'
{"tempest/scenario/manager.py":[{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"dc112922f4119107242278b30853aceca3224be6","unresolved":false,"context_lines":[{"line_number":89,"context_line":"    # The create_[resource] functions only return body and discard the"},{"line_number":90,"context_line":"    # resp part which is not used in scenario tests"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    def create_port(self, network_id, client\u003dNone, **kwargs):"},{"line_number":93,"context_line":"        if not client:"},{"line_number":94,"context_line":"            client \u003d self.ports_client"},{"line_number":95,"context_line":"        name \u003d data_utils.rand_name(self.__class__.__name__)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f4e5783_1121d49f","line":92,"updated":"2017-10-17 02:59:37.000000000","message":"I\u0027m fine to remove the namestart. I guess this \u0027namestart\u0027 is used for debug purpose, like if the port is remaining after the tempest run, we can find the cause. But I think it\u0027s not so important anymore. Because we already added the addCleanup() just after.","commit_id":"3f8d9862f4f245e5aa9e6c1c6e9830c149b3e23f"},{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"dc112922f4119107242278b30853aceca3224be6","unresolved":false,"context_lines":[{"line_number":97,"context_line":"            name\u003dname,"},{"line_number":98,"context_line":"            network_id\u003dnetwork_id,"},{"line_number":99,"context_line":"            **kwargs)"},{"line_number":100,"context_line":"        self.assertIsNotNone(result, \u0027Unable to allocate port\u0027)"},{"line_number":101,"context_line":"        port \u003d result[\u0027port\u0027]"},{"line_number":102,"context_line":"        self.addCleanup(test_utils.call_and_ignore_notfound_exc,"},{"line_number":103,"context_line":"                        client.delete_port, port[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f4e5783_f123d8a5","line":100,"updated":"2017-10-17 02:59:37.000000000","message":"I think this assertion is not necessary. Because if the response is None, an AttributionError occurs, IIUC. http://git.openstack.org/cgit/openstack/tempest/tree/tempest/lib/services/network/base.py#n66","commit_id":"3f8d9862f4f245e5aa9e6c1c6e9830c149b3e23f"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"10d12e1d5abb4f91731e6f0bf7e7f34eff644d8a","unresolved":false,"context_lines":[{"line_number":97,"context_line":"            name\u003dname,"},{"line_number":98,"context_line":"            network_id\u003dnetwork_id,"},{"line_number":99,"context_line":"            **kwargs)"},{"line_number":100,"context_line":"        self.assertIsNotNone(result, \u0027Unable to allocate port\u0027)"},{"line_number":101,"context_line":"        port \u003d result[\u0027port\u0027]"},{"line_number":102,"context_line":"        self.addCleanup(test_utils.call_and_ignore_notfound_exc,"},{"line_number":103,"context_line":"                        client.delete_port, port[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f4e5783_11cb14a5","line":100,"in_reply_to":"5f4e5783_f123d8a5","updated":"2017-10-17 03:11:02.000000000","message":"oh yes it can be removed, because expect_empty_body is False","commit_id":"3f8d9862f4f245e5aa9e6c1c6e9830c149b3e23f"}]}