)]}'
{"tempest/api/network/test_security_groups_negative.py":[{"author":{"_account_id":2976,"name":"Adalberto Medeiros","email":"adalbas@gmail.com","username":"adalbas"},"change_message_id":"5d8c8341ae5de9350a01555170470b5a121c9825","unresolved":false,"context_lines":[{"line_number":53,"context_line":"        self.assertEqual(\u0027201\u0027, resp[\u0027status\u0027])"},{"line_number":54,"context_line":"        self.addCleanup(self._delete_security_group,"},{"line_number":55,"context_line":"                        group_create_body[\u0027security_group\u0027][\u0027id\u0027])"},{"line_number":56,"context_line":"        self.assertEqual(group_create_body[\u0027security_group\u0027][\u0027name\u0027], name)"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"        #Create rule with bad protocol name"},{"line_number":59,"context_line":"        pname \u003d \u0027bad_protocol_name\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FdyI%3D","line":56,"updated":"2013-10-15 20:32:10.000000000","message":"You could create a private function to have this piece of code and call it whithin the test methods","commit_id":"08e414b5844a62b53db4a75e1230ed16d99e6b1d"},{"author":{"_account_id":8576,"name":"Yair Fried","email":"yfried@redhat.com","username":"yfried"},"change_message_id":"cac755c61042274050ece6ede0aa3969070e2424","unresolved":false,"context_lines":[{"line_number":53,"context_line":"        self.assertEqual(\u0027201\u0027, resp[\u0027status\u0027])"},{"line_number":54,"context_line":"        self.addCleanup(self._delete_security_group,"},{"line_number":55,"context_line":"                        group_create_body[\u0027security_group\u0027][\u0027id\u0027])"},{"line_number":56,"context_line":"        self.assertEqual(group_create_body[\u0027security_group\u0027][\u0027name\u0027], name)"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"        #Create rule with bad protocol name"},{"line_number":59,"context_line":"        pname \u003d \u0027bad_protocol_name\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FcUU%3D","line":56,"in_reply_to":"AAAATH%2F%2FdyI%3D","updated":"2013-10-16 04:22:49.000000000","message":"This is better resolved in next commit: https://review.openstack.org/#/c/51590/","commit_id":"08e414b5844a62b53db4a75e1230ed16d99e6b1d"},{"author":{"_account_id":2976,"name":"Adalberto Medeiros","email":"adalbas@gmail.com","username":"adalbas"},"change_message_id":"5d8c8341ae5de9350a01555170470b5a121c9825","unresolved":false,"context_lines":[{"line_number":70,"context_line":"        self.assertEqual(\u0027201\u0027, resp[\u0027status\u0027])"},{"line_number":71,"context_line":"        self.addCleanup(self._delete_security_group,"},{"line_number":72,"context_line":"                        group_create_body[\u0027security_group\u0027][\u0027id\u0027])"},{"line_number":73,"context_line":"        self.assertEqual(group_create_body[\u0027security_group\u0027][\u0027name\u0027], name)"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"        #Create rule with invalid ports"},{"line_number":76,"context_line":"        states \u003d [(-16, 80, \u0027Invalid value for port -16\u0027),"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2Fdx8%3D","line":73,"updated":"2013-10-15 20:32:10.000000000","message":"Same as above","commit_id":"08e414b5844a62b53db4a75e1230ed16d99e6b1d"},{"author":{"_account_id":8576,"name":"Yair Fried","email":"yfried@redhat.com","username":"yfried"},"change_message_id":"cac755c61042274050ece6ede0aa3969070e2424","unresolved":false,"context_lines":[{"line_number":70,"context_line":"        self.assertEqual(\u0027201\u0027, resp[\u0027status\u0027])"},{"line_number":71,"context_line":"        self.addCleanup(self._delete_security_group,"},{"line_number":72,"context_line":"                        group_create_body[\u0027security_group\u0027][\u0027id\u0027])"},{"line_number":73,"context_line":"        self.assertEqual(group_create_body[\u0027security_group\u0027][\u0027name\u0027], name)"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"        #Create rule with invalid ports"},{"line_number":76,"context_line":"        states \u003d [(-16, 80, \u0027Invalid value for port -16\u0027),"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FcUQ%3D","line":73,"in_reply_to":"AAAATH%2F%2Fdx8%3D","updated":"2013-10-16 04:22:49.000000000","message":"This is better resolved in next commit: https://review.openstack.org/#/c/51590/","commit_id":"08e414b5844a62b53db4a75e1230ed16d99e6b1d"},{"author":{"_account_id":8625,"name":"Anju Tiwari","username":"Anju5","inactive":true},"change_message_id":"72b3a103b85f24e023ffa26e4d3ab59c7dcc5f50","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    @attr(type\u003d[\u0027negative\u0027, \u0027smoke\u0027])"},{"line_number":41,"context_line":"    def test_delete_non_existent_security_group(self):"},{"line_number":42,"context_line":"        non_exist_id \u003d \u0027fictional-id\u0027"},{"line_number":43,"context_line":"        self.assertRaises(exceptions.NotFound,"},{"line_number":44,"context_line":"                          self.client.delete_security_group,"},{"line_number":45,"context_line":"                          non_exist_id"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAATH%2F%2FZlg%3D","line":42,"updated":"2013-10-16 17:16:33.000000000","message":"why you are not using a rand value here also?","commit_id":"74d9bf373fbd5887977bc47abca75a98ec68965a"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"69ed886763a3369a132562dba3e1fcf2f69502b6","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        self.assertRaises(exceptions.NotFound,"},{"line_number":44,"context_line":"                          self.client.delete_security_group,"},{"line_number":45,"context_line":"                          non_exist_id"},{"line_number":46,"context_line":"                          )"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    @attr(type\u003d[\u0027negative\u0027, \u0027smoke\u0027])"},{"line_number":49,"context_line":"    def test_create_security_group_rule_with_bad_protocol(self):"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATH%2F%2FWws%3D","line":46,"updated":"2013-10-17 10:09:15.000000000","message":"this parenthesis feels a little alone here....","commit_id":"8a83bd923ef1c599b478d996da1a4db7a047301a"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"69ed886763a3369a132562dba3e1fcf2f69502b6","unresolved":false,"context_lines":[{"line_number":75,"context_line":"        #Create rule with invalid ports"},{"line_number":76,"context_line":"        states \u003d [(-16, 80, \u0027Invalid value for port -16\u0027),"},{"line_number":77,"context_line":"                  (80, 79, \u0027port_range_min must be \u003c\u003d port_range_max\u0027),"},{"line_number":78,"context_line":"                  (80, 65536, \u0027Invalid value for port 65536\u0027)]"},{"line_number":79,"context_line":"        for pmin, pmax, msg in states:"},{"line_number":80,"context_line":"            ex \u003d self.assertRaises(exceptions.BadRequest,"},{"line_number":81,"context_line":"                                   self.client.create_security_group_rule,"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATH%2F%2FWw4%3D","line":78,"updated":"2013-10-17 10:09:15.000000000","message":"just for pedantry, add a check with both min and max out of range","commit_id":"8a83bd923ef1c599b478d996da1a4db7a047301a"}]}