)]}'
{"tempest/client_lib/keystone/base.py":[{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"81dab0190af67fb5dfb48e9ce1958eb1a2c9125a","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    def _get_identity_client_v3(self, username\u003dNone, password\u003dNone,"},{"line_number":30,"context_line":"                                tenant_name\u003dNone, endpoint\u003dNone,"},{"line_number":31,"context_line":"                                trust_id\u003dNone):"},{"line_number":32,"context_line":"        \"\"\""},{"line_number":33,"context_line":"        Returns a v3 keystoneclient Client, authenticated with"},{"line_number":34,"context_line":"        admin credentials unless credentials specified."}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATH%2F%2FIn8%3D","line":31,"updated":"2013-10-22 17:27:01.000000000","message":"(mostly a NIT): should this really be a private method?  It might be useful in other contexts.  Also, this is not really congruent with the new client work being done to do auto-discovery.  I would prefer you allow for requesting other versions of the client via a .get_identity_client method (we will move beyond v3.0 some day), but defaulting to v3.0 is sane.","commit_id":"623dc60f5663f0cbbcd1e9320b5a2fea24a351d4"}],"tempest/client_lib/keystone/test_v3_auth.py":[{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"21f50dde458a4f07b28e9c88f1f5ceae7566ec2e","unresolved":false,"context_lines":[{"line_number":17,"context_line":"from tempest.scenario import manager"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"class ClientV3AuthTest(manager.OfficialClientTest):"},{"line_number":21,"context_line":"    \"\"\""},{"line_number":22,"context_line":"    Base-class for tests using keystoneclient v3 interfaces."},{"line_number":23,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAATH%2F%2FTd8%3D","line":20,"updated":"2013-10-18 02:33:29.000000000","message":"I get that there are only  a couple tests here but to be consistent with the other types of testing in tempest you should probably make a base.py file that has the base test class definitions.","commit_id":"d5f107d590754e9972bce1bb9cdc04409b026c53"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"81dab0190af67fb5dfb48e9ce1958eb1a2c9125a","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        self.assertIsNotNone(client.auth_token)"},{"line_number":44,"context_line":"        auth_token \u003d client.auth_token"},{"line_number":45,"context_line":"        token_client \u003d kc_v3.Client(token\u003dauth_token,"},{"line_number":46,"context_line":"                                    auth_url\u003dself.auth_url)"},{"line_number":47,"context_line":"        self.assertEqual(token_client.auth_token, auth_token)"},{"line_number":48,"context_line":"        self.assertTrue(token_client.authenticate())"},{"line_number":49,"context_line":"        self.assertIsNotNone(token_client.auth_token)"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATH%2F%2FIoM%3D","line":46,"updated":"2013-10-22 17:27:01.000000000","message":"More of a NIT than anything else, but this is inconsistent.  Either you should make a method on the BaseV3Auth that lets you pass in username, password, etc _or_ token for auth or you should instantiate the client directly above in test_pw_auth.  I would prefer the former, and I could see a use case to have the base class able to do token-based-auth in future tests without needing to instantiate a client to explicitly do it.","commit_id":"623dc60f5663f0cbbcd1e9320b5a2fea24a351d4"}]}