)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"b657c59cc22b72c7eadfb4250180bc85fc0e2a8f","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The name of APIs below in volume v2 types client don\u0027t describe their"},{"line_number":10,"context_line":"actual functions clearly or fully. This patch deprecates the original"},{"line_number":11,"context_line":"names of these APIs and renames them to the new ones."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"1. show_volume_type_extra_specs -\u003e show_volume_type_extra_specs_item"},{"line_number":14,"context_line":"2. create_volume_type_extra_specs -\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1f485f77_e677093a","line":11,"updated":"2017-11-14 08:50:31.000000000","message":"Could you describe more details or put links of these APIs? I\u0027d like to understand of this change meaning.","commit_id":"1706592502b6da3b4ddcc72f24767c54d79e02ff"}],"tempest/lib/services/volume/v2/types_client.py":[{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"dc67b438b9b6a9a58d8558432a27ca298d6109c8","unresolved":false,"context_lines":[{"line_number":124,"context_line":"                                                 extra_specs):"},{"line_number":125,"context_line":"        \"\"\"Creates or updates extra specs for a volume type."},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"        volume_type_id: Id of volume_type."},{"line_number":128,"context_line":"        extra_specs: A dictionary of values to be used as extra_specs."},{"line_number":129,"context_line":"        \"\"\""},{"line_number":130,"context_line":"        url \u003d \"types/%s/extra_specs\" % volume_type_id"}],"source_content_type":"text/x-python","patch_set":3,"id":"ff82abbf_889f7bb3","line":127,"updated":"2017-11-20 04:36:25.000000000","message":"Unrelated to PS, but just noticed none of these starts with :param","commit_id":"1706592502b6da3b4ddcc72f24767c54d79e02ff"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"dc67b438b9b6a9a58d8558432a27ca298d6109c8","unresolved":false,"context_lines":[{"line_number":169,"context_line":"                                            extra_spec_name, extra_specs):"},{"line_number":170,"context_line":"        \"\"\"Update a volume_type extra spec."},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"        volume_type_id: Id of volume_type."},{"line_number":173,"context_line":"        extra_spec_name: Name of the extra spec to be updated."},{"line_number":174,"context_line":"        extra_spec: A dictionary of with key as extra_spec_name and the"},{"line_number":175,"context_line":"                     updated value."}],"source_content_type":"text/x-python","patch_set":3,"id":"ff82abbf_28a42f08","line":172,"updated":"2017-11-20 04:36:25.000000000","message":"Ditto","commit_id":"1706592502b6da3b4ddcc72f24767c54d79e02ff"}],"tempest/lib/services/volume/v3/types_client.py":[{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"69eaa1ef5dc0c314f2591b5e01f4d8e08597df5b","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"class TypesClient(rest_client.RestClient):"},{"line_number":25,"context_line":"    \"\"\"Client class to send CRUD Volume API requests\"\"\""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    def is_resource_deleted(self, id):"},{"line_number":28,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":8,"id":"5f7c97a3_ab82fdc5","line":25,"range":{"start_line":25,"start_character":28,"end_line":25,"end_character":39},"updated":"2018-06-21 00:46:09.000000000","message":"Unrelated, but this should be CRUD Volume Type","commit_id":"c2a35d3f41b09069c144e5791808ff5ed2446f82"},{"author":{"_account_id":23081,"name":"Jeremy Zhang","email":"zhangjun_inspur@163.com","username":"jeremy.zhang"},"change_message_id":"5854d2a088bacb3c8cf8353a11d98709025fc842","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"class TypesClient(rest_client.RestClient):"},{"line_number":25,"context_line":"    \"\"\"Client class to send CRUD Volume API requests\"\"\""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    def is_resource_deleted(self, id):"},{"line_number":28,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":8,"id":"5f7c97a3_346e4e2c","line":25,"range":{"start_line":25,"start_character":28,"end_line":25,"end_character":39},"in_reply_to":"5f7c97a3_ab82fdc5","updated":"2018-06-21 05:20:09.000000000","message":"It will be fixed in patch https://review.openstack.org/#/c/577043/, :)","commit_id":"c2a35d3f41b09069c144e5791808ff5ed2446f82"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"186a7c91259755ecf522cf4316f7de78854040e0","unresolved":false,"context_lines":[{"line_number":105,"context_line":"        self.expected_success(200, resp.status)"},{"line_number":106,"context_line":"        return rest_client.ResponseBody(resp, body)"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"    def show_volume_type_extra_specs_item(self, volume_type_id,"},{"line_number":109,"context_line":"                                          extra_specs_name):"},{"line_number":110,"context_line":"        \"\"\"Returns the details of a single volume_type extra spec.\"\"\""},{"line_number":111,"context_line":"        url \u003d \"types/%s/extra_specs/%s\" % (volume_type_id, extra_specs_name)"}],"source_content_type":"text/x-python","patch_set":8,"id":"5f7c97a3_bd08fa7f","line":108,"range":{"start_line":108,"start_character":7,"end_line":108,"end_character":42},"updated":"2018-06-21 12:15:26.000000000","message":"i do not find any issue on original name also. Doc string of this function describe it well that this method is to show single extra specs.","commit_id":"c2a35d3f41b09069c144e5791808ff5ed2446f82"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"186a7c91259755ecf522cf4316f7de78854040e0","unresolved":false,"context_lines":[{"line_number":119,"context_line":"        \u0027show_volume_type_extra_specs\u0027, __name__,"},{"line_number":120,"context_line":"        version\u003d\u0027Rocky\u0027, removal_version\u003d\u0027?\u0027)"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"    def create_or_update_volume_type_extra_specs(self, volume_type_id,"},{"line_number":123,"context_line":"                                                 extra_specs):"},{"line_number":124,"context_line":"        \"\"\"Creates or updates extra specs for a volume type."},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"        volume_type_id: Id of volume_type."},{"line_number":127,"context_line":"        extra_specs: A dictionary of values to be used as extra_specs."}],"source_content_type":"text/x-python","patch_set":8,"id":"5f7c97a3_7d26e218","line":124,"range":{"start_line":122,"start_character":0,"end_line":124,"end_character":60},"updated":"2018-06-21 12:15:26.000000000","message":"ditto","commit_id":"c2a35d3f41b09069c144e5791808ff5ed2446f82"},{"author":{"_account_id":23081,"name":"Jeremy Zhang","email":"zhangjun_inspur@163.com","username":"jeremy.zhang"},"change_message_id":"cce961551953dacec27fcd462756e8fea726a6ed","unresolved":false,"context_lines":[{"line_number":119,"context_line":"        \u0027show_volume_type_extra_specs\u0027, __name__,"},{"line_number":120,"context_line":"        version\u003d\u0027Rocky\u0027, removal_version\u003d\u0027?\u0027)"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"    def create_or_update_volume_type_extra_specs(self, volume_type_id,"},{"line_number":123,"context_line":"                                                 extra_specs):"},{"line_number":124,"context_line":"        \"\"\"Creates or updates extra specs for a volume type."},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"        volume_type_id: Id of volume_type."},{"line_number":127,"context_line":"        extra_specs: A dictionary of values to be used as extra_specs."}],"source_content_type":"text/x-python","patch_set":8,"id":"5f7c97a3_1d500e32","line":124,"range":{"start_line":122,"start_character":0,"end_line":124,"end_character":60},"in_reply_to":"5f7c97a3_7d26e218","updated":"2018-06-21 12:24:31.000000000","message":"this method may be a little different, it not only create new volume type extra specs, but also can update old one. see:\nhttps://developer.openstack.org/api-ref/block-storage/v3/index.html#create-or-update-extra-specs-for-volume-type","commit_id":"c2a35d3f41b09069c144e5791808ff5ed2446f82"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"186a7c91259755ecf522cf4316f7de78854040e0","unresolved":false,"context_lines":[{"line_number":138,"context_line":"        \u0027create_volume_type_extra_specs\u0027, __name__,"},{"line_number":139,"context_line":"        version\u003d\u0027Rocky\u0027, removal_version\u003d\u0027?\u0027)"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"    def delete_volume_type_extra_specs_item(self, volume_type_id,"},{"line_number":142,"context_line":"                                            extra_spec_name):"},{"line_number":143,"context_line":"        \"\"\"Deletes the Specified Volume_type extra spec.\"\"\""},{"line_number":144,"context_line":"        resp, body \u003d self.delete(\"types/%s/extra_specs/%s\" % ("}],"source_content_type":"text/x-python","patch_set":8,"id":"5f7c97a3_9d689e21","line":141,"range":{"start_line":141,"start_character":8,"end_line":141,"end_character":43},"updated":"2018-06-21 12:15:26.000000000","message":"ditto. there is no API who can delete all the extra specs so this API is obvious to delete single extra spec only. That is what method doc string is telling.","commit_id":"c2a35d3f41b09069c144e5791808ff5ed2446f82"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"186a7c91259755ecf522cf4316f7de78854040e0","unresolved":false,"context_lines":[{"line_number":164,"context_line":"        self.expected_success(200, resp.status)"},{"line_number":165,"context_line":"        return rest_client.ResponseBody(resp, body)"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"    def update_volume_type_extra_specs_item(self, volume_type_id,"},{"line_number":168,"context_line":"                                            extra_spec_name, extra_specs):"},{"line_number":169,"context_line":"        \"\"\"Update a volume_type extra spec."},{"line_number":170,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"5f7c97a3_3d714a0e","line":167,"range":{"start_line":167,"start_character":8,"end_line":167,"end_character":43},"updated":"2018-06-21 12:15:26.000000000","message":"ditto","commit_id":"c2a35d3f41b09069c144e5791808ff5ed2446f82"}]}